| <?xml version="1.0" encoding="UTF-8"?> |
| <pmd version="4.2.2" timestamp="2009-03-07T11:35:27.445"> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\codec\Base64InputStream.java"> |
| <violation beginline="68" endline="74" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="84" endline="84" begincolumn="17" endcolumn="27" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="100" endline="100" begincolumn="13" endcolumn="21" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="117" endline="117" begincolumn="13" endcolumn="21" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="130" endline="130" begincolumn="13" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" variable="index" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'index' (lines '130'-'130'). |
| </violation> |
| <violation beginline="130" endline="130" begincolumn="13" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" variable="n" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'n' (lines '130'-'130'). |
| </violation> |
| <violation beginline="130" endline="130" begincolumn="13" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" variable="sextets" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'sextets' (lines '130'-'130'). |
| </violation> |
| <violation beginline="144" endline="144" begincolumn="13" endcolumn="54" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="148" endline="187" begincolumn="17" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" variable="data" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'data' (lines '148'-'187'). |
| </violation> |
| <violation beginline="148" endline="226" begincolumn="13" endcolumn="20" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" variable="data" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'data' (lines '148'-'226'). |
| </violation> |
| <violation beginline="149" endline="188" begincolumn="17" endcolumn="25" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" variable="sextets" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'sextets' (lines '149'-'188'). |
| </violation> |
| <violation beginline="164" endline="164" begincolumn="21" endcolumn="62" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="180" endline="180" begincolumn="21" endcolumn="40" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="191" endline="188" begincolumn="17" endcolumn="25" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" variable="sextets" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'sextets' (lines '191'-'188'). |
| </violation> |
| <violation beginline="191" endline="226" begincolumn="21" endcolumn="31" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" variable="sextets" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'sextets' (lines '191'-'226'). |
| </violation> |
| <violation beginline="217" endline="217" begincolumn="25" endcolumn="41" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64InputStream" method="read0" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\codec\Base64OutputStream.java"> |
| <violation beginline="48" endline="53" begincolumn="5" endcolumn="43" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="Base64OutputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\codec\CodecUtil.java"> |
| <violation beginline="31" endline="31" begincolumn="5" endcolumn="57" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="CodecUtil" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="40" endline="40" begincolumn="9" endcolumn="68" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="CodecUtil" method="copy" variable="buffer" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="42" endline="42" begincolumn="16" endcolumn="52" rule="AssignmentInOperand" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="CodecUtil" method="copy" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AssignmentInOperand" priority="3"> |
| Avoid assignments in operands |
| </violation> |
| <violation beginline="42" endline="45" begincolumn="16" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="CodecUtil" method="copy" variable="inputLength" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'inputLength' (lines '42'-'45'). |
| </violation> |
| <violation beginline="70" endline="70" begincolumn="9" endcolumn="110" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="CodecUtil" method="encodeQuotedPrintable" variable="encoder" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\codec\DecoderUtil.java"> |
| <violation beginline="52" endline="53" begincolumn="20" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeBaseQuotedPrintable" variable="b" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'b' (lines '52'-'53'). |
| </violation> |
| <violation beginline="53" endline="53" begincolumn="20" endcolumn="40" rule="AssignmentInOperand" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeBaseQuotedPrintable" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AssignmentInOperand" priority="3"> |
| Avoid assignments in operands |
| </violation> |
| <violation beginline="53" endline="64" begincolumn="20" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeBaseQuotedPrintable" variable="b" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'b' (lines '53'-'64'). |
| </violation> |
| <violation beginline="81" endline="82" begincolumn="20" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeBase64" variable="b" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'b' (lines '81'-'82'). |
| </violation> |
| <violation beginline="82" endline="82" begincolumn="20" endcolumn="40" rule="AssignmentInOperand" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeBase64" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AssignmentInOperand" priority="3"> |
| Avoid assignments in operands |
| </violation> |
| <violation beginline="82" endline="93" begincolumn="20" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeBase64" variable="b" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'b' (lines '82'-'93'). |
| </violation> |
| <violation beginline="150" endline="183" begincolumn="13" endcolumn="27" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWords" variable="previousEnd" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'previousEnd' (lines '150'-'183'). |
| </violation> |
| <violation beginline="151" endline="181" begincolumn="13" endcolumn="48" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWords" variable="previousWasEncoded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'previousWasEncoded' (lines '151'-'181'). |
| </violation> |
| <violation beginline="151" endline="183" begincolumn="17" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWords" variable="previousWasEncoded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'previousWasEncoded' (lines '151'-'183'). |
| </violation> |
| <violation beginline="153" endline="183" begincolumn="23" endcolumn="46" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWords" variable="sb" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'sb' (lines '153'-'183'). |
| </violation> |
| <violation beginline="160" endline="160" begincolumn="21" endcolumn="32" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWords" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="180" endline="183" begincolumn="13" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWords" variable="previousEnd" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'previousEnd' (lines '180'-'183'). |
| </violation> |
| <violation beginline="181" endline="181" begincolumn="13" endcolumn="48" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWords" variable="previousWasEncoded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'previousWasEncoded' (lines '181'-'181'). |
| </violation> |
| <violation beginline="181" endline="183" begincolumn="13" endcolumn="48" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWords" variable="previousWasEncoded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'previousWasEncoded' (lines '181'-'183'). |
| </violation> |
| <violation beginline="189" endline="189" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="193" endline="193" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="196" endline="251" begincolumn="16" endcolumn="54" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" variable="encoding" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'encoding' (lines '196'-'251'). |
| </violation> |
| <violation beginline="197" endline="251" begincolumn="16" endcolumn="61" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" variable="encodedText" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'encodedText' (lines '197'-'251'). |
| </violation> |
| <violation beginline="206" endline="206" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="214" endline="214" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="222" endline="222" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="227" endline="227" begincolumn="17" endcolumn="65" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="229" endline="229" begincolumn="17" endcolumn="65" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="235" endline="235" begincolumn="17" endcolumn="28" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="243" endline="243" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="DecoderUtil" method="decodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\codec\EncoderUtil.java"> |
| <violation beginline="111" endline="111" begincolumn="13" endcolumn="31" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeAddressDisplayName" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="113" endline="113" begincolumn="13" endcolumn="69" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeAddressDisplayName" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="135" endline="135" begincolumn="13" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeAddressLocalPart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="157" endline="157" begincolumn="13" endcolumn="38" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeHeaderParameter" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="180" endline="180" begincolumn="13" endcolumn="66" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeIfNecessary" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="205" endline="210" begincolumn="17" endcolumn="38" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="hasToBeEncoded" variable="nonWhiteSpaceCount" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'nonWhiteSpaceCount' (lines '205'-'210'). |
| </violation> |
| <violation beginline="205" endline="212" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="hasToBeEncoded" variable="nonWhiteSpaceCount" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'nonWhiteSpaceCount' (lines '205'-'212'). |
| </violation> |
| <violation beginline="205" endline="229" begincolumn="13" endcolumn="47" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="hasToBeEncoded" variable="nonWhiteSpaceCount" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'nonWhiteSpaceCount' (lines '205'-'229'). |
| </violation> |
| <violation beginline="210" endline="210" begincolumn="17" endcolumn="38" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="hasToBeEncoded" variable="nonWhiteSpaceCount" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'nonWhiteSpaceCount' (lines '210'-'210'). |
| </violation> |
| <violation beginline="210" endline="212" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="hasToBeEncoded" variable="nonWhiteSpaceCount" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'nonWhiteSpaceCount' (lines '210'-'212'). |
| </violation> |
| <violation beginline="210" endline="229" begincolumn="17" endcolumn="38" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="hasToBeEncoded" variable="nonWhiteSpaceCount" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'nonWhiteSpaceCount' (lines '210'-'229'). |
| </violation> |
| <violation beginline="218" endline="218" begincolumn="21" endcolumn="32" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="hasToBeEncoded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="223" endline="223" begincolumn="21" endcolumn="32" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="hasToBeEncoded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="326" endline="326" begincolumn="13" endcolumn="73" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeEncodedWord" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="345" endline="345" begincolumn="9" endcolumn="36" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeB" variable="end" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="385" endline="405" begincolumn="16" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeQ" variable="qChars" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'qChars' (lines '385'-'405'). |
| </violation> |
| <violation beginline="390" endline="390" begincolumn="9" endcolumn="36" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeQ" variable="end" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="422" endline="422" begincolumn="9" endcolumn="39" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isToken" variable="length" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="424" endline="424" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isToken" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="429" endline="429" begincolumn="17" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isToken" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="438" endline="444" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isAtomPhrase" variable="containsAText" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'containsAText' (lines '438'-'444'). |
| </violation> |
| <violation beginline="438" endline="451" begincolumn="17" endcolumn="37" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isAtomPhrase" variable="containsAText" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'containsAText' (lines '438'-'451'). |
| </violation> |
| <violation beginline="440" endline="440" begincolumn="9" endcolumn="39" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isAtomPhrase" variable="length" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="444" endline="444" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isAtomPhrase" variable="containsAText" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'containsAText' (lines '444'-'444'). |
| </violation> |
| <violation beginline="444" endline="451" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isAtomPhrase" variable="containsAText" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'containsAText' (lines '444'-'451'). |
| </violation> |
| <violation beginline="446" endline="446" begincolumn="17" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isAtomPhrase" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="459" endline="476" begincolumn="13" endcolumn="21" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isDotAtomText" variable="prev" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'prev' (lines '459'-'476'). |
| </violation> |
| <violation beginline="459" endline="480" begincolumn="14" endcolumn="23" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isDotAtomText" variable="prev" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'prev' (lines '459'-'480'). |
| </violation> |
| <violation beginline="461" endline="461" begincolumn="9" endcolumn="39" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isDotAtomText" variable="length" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="463" endline="463" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isDotAtomText" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="470" endline="470" begincolumn="21" endcolumn="33" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isDotAtomText" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="473" endline="473" begincolumn="21" endcolumn="33" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isDotAtomText" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="476" endline="476" begincolumn="13" endcolumn="21" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isDotAtomText" variable="prev" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'prev' (lines '476'-'476'). |
| </violation> |
| <violation beginline="476" endline="480" begincolumn="13" endcolumn="21" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="isDotAtomText" variable="prev" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'prev' (lines '476'-'480'). |
| </violation> |
| <violation beginline="502" endline="502" begincolumn="13" endcolumn="61" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeB" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="528" endline="528" begincolumn="13" endcolumn="68" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="encodeQ" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="544" endline="561" begincolumn="16" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="qEncodedLength" variable="qChars" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'qChars' (lines '544'-'561'). |
| </violation> |
| <violation beginline="547" endline="552" begincolumn="17" endcolumn="23" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="qEncodedLength" variable="count" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'count' (lines '547'-'552'). |
| </violation> |
| <violation beginline="547" endline="556" begincolumn="17" endcolumn="23" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="qEncodedLength" variable="count" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'count' (lines '547'-'556'). |
| </violation> |
| <violation beginline="552" endline="552" begincolumn="17" endcolumn="23" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="qEncodedLength" variable="count" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'count' (lines '552'-'552'). |
| </violation> |
| <violation beginline="552" endline="556" begincolumn="17" endcolumn="23" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="qEncodedLength" variable="count" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'count' (lines '552'-'556'). |
| </violation> |
| <violation beginline="556" endline="552" begincolumn="17" endcolumn="23" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="qEncodedLength" variable="count" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'count' (lines '556'-'552'). |
| </violation> |
| <violation beginline="556" endline="556" begincolumn="17" endcolumn="23" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="qEncodedLength" variable="count" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'count' (lines '556'-'556'). |
| </violation> |
| <violation beginline="573" endline="581" begincolumn="17" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineCharset" variable="ascii" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'ascii' (lines '573'-'581'). |
| </violation> |
| <violation beginline="573" endline="585" begincolumn="17" endcolumn="28" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineCharset" variable="ascii" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'ascii' (lines '573'-'585'). |
| </violation> |
| <violation beginline="574" endline="574" begincolumn="9" endcolumn="37" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineCharset" variable="len" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="578" endline="578" begincolumn="17" endcolumn="41" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="581" endline="581" begincolumn="17" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineCharset" variable="ascii" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'ascii' (lines '581'-'581'). |
| </violation> |
| <violation beginline="581" endline="585" begincolumn="17" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineCharset" variable="ascii" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'ascii' (lines '581'-'585'). |
| </violation> |
| <violation beginline="589" endline="589" begincolumn="13" endcolumn="30" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineEncoding" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="591" endline="604" begincolumn="16" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineEncoding" variable="qChars" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'qChars' (lines '591'-'604'). |
| </violation> |
| <violation beginline="594" endline="598" begincolumn="17" endcolumn="26" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineEncoding" variable="qEncoded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'qEncoded' (lines '594'-'598'). |
| </violation> |
| <violation beginline="598" endline="598" begincolumn="17" endcolumn="26" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="EncoderUtil" method="determineEncoding" variable="qEncoded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'qEncoded' (lines '598'-'598'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\codec\QuotedPrintableEncoder.java"> |
| <violation beginline="54" endline="54" begincolumn="15" endcolumn="18" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableEncoder" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="61" endline="67" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableEncoder" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="69" endline="73" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableEncoder" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="75" endline="78" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableEncoder" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="83" endline="83" begincolumn="15" endcolumn="52" rule="AssignmentInOperand" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableEncoder" method="encode" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AssignmentInOperand" priority="3"> |
| Avoid assignments in operands |
| </violation> |
| <violation beginline="83" endline="87" begincolumn="15" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableEncoder" method="encode" variable="inputLength" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'inputLength' (lines '83'-'87'). |
| </violation> |
| <violation beginline="198" endline="205" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableEncoder" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\codec\QuotedPrintableInputStream.java"> |
| <violation beginline="35" endline="35" begincolumn="5" endcolumn="38" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="36" endline="36" begincolumn="5" endcolumn="42" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="40" endline="42" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="62" endline="62" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="66" endline="66" begincolumn="17" endcolumn="27" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="85" endline="85" begincolumn="13" endcolumn="19" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="populatePushbackQueue" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="93" endline="93" begincolumn="21" endcolumn="27" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="populatePushbackQueue" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="102" endline="102" begincolumn="21" endcolumn="27" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="populatePushbackQueue" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="119" endline="144" begincolumn="25" endcolumn="35" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="fillBuffer" variable="msdChar" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'msdChar' (lines '119'-'144'). |
| </violation> |
| <violation beginline="119" endline="206" begincolumn="14" endcolumn="24" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="fillBuffer" variable="msdChar" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'msdChar' (lines '119'-'206'). |
| </violation> |
| <violation beginline="144" endline="206" begincolumn="25" endcolumn="35" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="fillBuffer" variable="msdChar" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'msdChar' (lines '144'-'206'). |
| </violation> |
| <violation beginline="215" endline="215" begincolumn="13" endcolumn="35" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="asciiCharToNumericValue" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="217" endline="217" begincolumn="13" endcolumn="43" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="QuotedPrintableInputStream" method="asciiCharToNumericValue" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\codec\UnboundedFifoByteBuffer.java"> |
| <violation beginline="88" endline="91" begincolumn="13" endcolumn="46" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="UnboundedFifoByteBuffer" method="size" variable="size" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'size' (lines '88'-'91'). |
| </violation> |
| <violation beginline="88" endline="93" begincolumn="13" endcolumn="30" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="UnboundedFifoByteBuffer" method="size" variable="size" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'size' (lines '88'-'93'). |
| </violation> |
| <violation beginline="117" endline="121" begincolumn="17" endcolumn="34" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="UnboundedFifoByteBuffer" method="add" variable="tmp" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'tmp' (lines '117'-'121'). |
| </violation> |
| <violation beginline="121" endline="121" begincolumn="17" endcolumn="34" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.codec" class="UnboundedFifoByteBuffer" method="add" variable="tmp" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'tmp' (lines '121'-'121'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\descriptor\DefaultBodyDescriptor.java"> |
| <violation beginline="96" endline="99" begincolumn="9" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="addField" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'name' (lines '96'-'99'). |
| </violation> |
| <violation beginline="97" endline="104" begincolumn="13" endcolumn="46" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="addField" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'value' (lines '97'-'104'). |
| </violation> |
| <violation beginline="97" endline="118" begincolumn="16" endcolumn="38" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="addField" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'value' (lines '97'-'118'). |
| </violation> |
| <violation beginline="126" endline="133" begincolumn="17" endcolumn="54" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="type" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'type' (lines '126'-'133'). |
| </violation> |
| <violation beginline="126" endline="143" begincolumn="17" endcolumn="27" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="type" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'type' (lines '126'-'143'). |
| </violation> |
| <violation beginline="126" endline="181" begincolumn="16" endcolumn="26" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="type" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'type' (lines '126'-'181'). |
| </violation> |
| <violation beginline="127" endline="134" begincolumn="17" endcolumn="58" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="subtype" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'subtype' (lines '127'-'134'). |
| </violation> |
| <violation beginline="127" endline="144" begincolumn="17" endcolumn="30" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="subtype" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'subtype' (lines '127'-'144'). |
| </violation> |
| <violation beginline="127" endline="181" begincolumn="16" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="subtype" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'subtype' (lines '127'-'181'). |
| </violation> |
| <violation beginline="131" endline="137" begincolumn="21" endcolumn="32" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="valid" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'valid' (lines '131'-'137'). |
| </violation> |
| <violation beginline="136" endline="142" begincolumn="17" endcolumn="27" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="main" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'main' (lines '136'-'142'). |
| </violation> |
| <violation beginline="142" endline="142" begincolumn="24" endcolumn="27" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="143" endline="143" begincolumn="24" endcolumn="27" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="143" endline="181" begincolumn="17" endcolumn="27" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="type" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'type' (lines '143'-'181'). |
| </violation> |
| <violation beginline="144" endline="144" begincolumn="27" endcolumn="30" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="144" endline="181" begincolumn="17" endcolumn="30" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" variable="subtype" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'subtype' (lines '144'-'181'). |
| </violation> |
| <violation beginline="163" endline="163" begincolumn="19" endcolumn="22" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="DefaultBodyDescriptor" method="parseContentType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\descriptor\MaximalBodyDescriptor.java"> |
| <violation beginline="82" endline="82" begincolumn="26" endcolumn="29" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="84" endline="84" begincolumn="35" endcolumn="38" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="86" endline="86" begincolumn="39" endcolumn="42" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="88" endline="88" begincolumn="51" endcolumn="54" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="89" endline="89" begincolumn="65" endcolumn="68" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="90" endline="90" begincolumn="47" endcolumn="50" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="91" endline="91" begincolumn="61" endcolumn="64" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="92" endline="92" begincolumn="43" endcolumn="46" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="93" endline="93" begincolumn="57" endcolumn="60" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="95" endline="95" begincolumn="53" endcolumn="56" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="97" endline="97" begincolumn="32" endcolumn="35" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="98" endline="98" begincolumn="46" endcolumn="49" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="100" endline="100" begincolumn="32" endcolumn="35" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="101" endline="101" begincolumn="46" endcolumn="49" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="103" endline="103" begincolumn="30" endcolumn="33" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="109" endline="111" begincolumn="9" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="addField" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'name' (lines '109'-'111'). |
| </violation> |
| <violation beginline="110" endline="129" begincolumn="16" endcolumn="38" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="addField" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'value' (lines '110'-'129'). |
| </violation> |
| <violation beginline="141" endline="141" begincolumn="13" endcolumn="69" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseLocation" variable="stringReader" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="142" endline="142" begincolumn="13" endcolumn="88" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseLocation" variable="parser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="156" endline="156" begincolumn="17" endcolumn="103" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseLanguage" variable="parser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="169" endline="170" begincolumn="9" endcolumn="80" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseContentDisposition" variable="contentDispositionModificationDate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="179" endline="180" begincolumn="9" endcolumn="76" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseContentDisposition" variable="contentDispositionCreationDate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="189" endline="190" begincolumn="9" endcolumn="72" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseContentDisposition" variable="contentDispositionReadDate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="199" endline="199" begincolumn="9" endcolumn="81" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseContentDisposition" variable="size" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="211" endline="211" begincolumn="9" endcolumn="64" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseDate" variable="stringReader" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="212" endline="212" begincolumn="9" endcolumn="70" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseDate" variable="parser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="236" endline="236" begincolumn="9" endcolumn="59" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseMimeVersion" variable="reader" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="237" endline="237" begincolumn="9" endcolumn="70" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseMimeVersion" variable="parser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="240" endline="240" begincolumn="13" endcolumn="54" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseMimeVersion" variable="major" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="244" endline="244" begincolumn="13" endcolumn="54" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.descriptor" class="MaximalBodyDescriptor" method="parseMimeVersion" variable="minor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\AbstractField.java"> |
| <violation beginline="155" endline="155" begincolumn="9" endcolumn="55" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="AbstractField" method="parse" variable="unfolded" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="160" endline="160" begincolumn="9" endcolumn="73" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="AbstractField" method="parse" variable="fieldMatcher" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="164" endline="164" begincolumn="9" endcolumn="49" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="AbstractField" method="parse" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\AddressListField.java"> |
| <violation beginline="73" endline="78" begincolumn="5" endcolumn="6" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="AddressListField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\ContentDispositionField.java"> |
| <violation beginline="243" endline="243" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentDispositionField" method="getSize" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="247" endline="247" begincolumn="13" endcolumn="40" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentDispositionField" method="getSize" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="259" endline="259" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentDispositionField" method="parseDate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="263" endline="264" begincolumn="13" endcolumn="31" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentDispositionField" method="parseDate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="270" endline="270" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentDispositionField" method="parseDate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="299" endline="299" begincolumn="9" endcolumn="66" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentDispositionField" method="parse" variable="dispositionType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="308" endline="308" begincolumn="17" endcolumn="79" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentDispositionField" method="parse" variable="len" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="320" endline="325" begincolumn="5" endcolumn="6" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentDispositionField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\ContentTransferEncodingField.java"> |
| <violation beginline="54" endline="54" begincolumn="13" endcolumn="35" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTransferEncodingField" method="getEncoding" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="59" endline="64" begincolumn="5" endcolumn="6" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTransferEncodingField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\ContentTypeField.java"> |
| <violation beginline="186" endline="186" begincolumn="17" endcolumn="43" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTypeField" method="getMimeType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="188" endline="188" begincolumn="17" endcolumn="39" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTypeField" method="getMimeType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="206" endline="206" begincolumn="17" endcolumn="31" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTypeField" method="getCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="230" endline="230" begincolumn="9" endcolumn="44" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTypeField" method="parse" variable="type" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="231" endline="231" begincolumn="9" endcolumn="50" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTypeField" method="parse" variable="subType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="240" endline="240" begincolumn="17" endcolumn="79" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTypeField" method="parse" variable="len" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="252" endline="257" begincolumn="5" endcolumn="6" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="ContentTypeField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\DateTimeField.java"> |
| <violation beginline="83" endline="88" begincolumn="5" endcolumn="6" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DateTimeField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\DefaultFieldParser.java"> |
| <violation beginline="24" endline="51" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DefaultFieldParser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="31" endline="31" begincolumn="9" endcolumn="63" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DefaultFieldParser" variable="dateTimeParser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="35" endline="35" begincolumn="9" endcolumn="69" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DefaultFieldParser" variable="mailboxListParser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="39" endline="39" begincolumn="9" endcolumn="61" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DefaultFieldParser" variable="mailboxParser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="43" endline="43" begincolumn="9" endcolumn="69" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DefaultFieldParser" variable="addressListParser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\DelegatingFieldParser.java"> |
| <violation beginline="42" endline="42" begincolumn="9" endcolumn="65" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DelegatingFieldParser" method="getParser" variable="field" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="44" endline="44" begincolumn="13" endcolumn="33" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DelegatingFieldParser" method="getParser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="50" endline="50" begincolumn="9" endcolumn="50" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="DelegatingFieldParser" method="parse" variable="parser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\Fields.java"> |
| <violation beginline="82" endline="83" begincolumn="13" endcolumn="30" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="Fields" method="contentType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="145" endline="146" begincolumn="13" endcolumn="68" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="Fields" method="contentDisposition" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="559" endline="559" begincolumn="9" endcolumn="68" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="Fields" method="date0" variable="formattedDate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="587" endline="587" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="Fields" method="isValidMimeType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="591" endline="591" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="Fields" method="isValidMimeType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="600" endline="600" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="Fields" method="isValidDispositionType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\MailboxField.java"> |
| <violation beginline="78" endline="83" begincolumn="5" endcolumn="6" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="MailboxField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\MailboxListField.java"> |
| <violation beginline="74" endline="79" begincolumn="5" endcolumn="6" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="MailboxListField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\UnstructuredField.java"> |
| <violation beginline="52" endline="57" begincolumn="5" endcolumn="6" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field" class="UnstructuredField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\address\Address.java"> |
| <violation beginline="42" endline="44" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Address" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\address\AddressList.java"> |
| <violation beginline="48" endline="54" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="AddressList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="78" endline="81" begincolumn="17" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="AddressList" method="flatten" variable="groupDetected" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'groupDetected' (lines '78'-'81'). |
| </violation> |
| <violation beginline="87" endline="88" begincolumn="13" endcolumn="69" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="AddressList" method="flatten" variable="mailboxes" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="89" endline="89" begincolumn="13" endcolumn="52" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="AddressList" method="flatten" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="129" endline="147" begincolumn="32" endcolumn="57" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="AddressList" method="main" variable="reader" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'reader' (lines '129'-'147'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\address\Builder.java"> |
| <violation beginline="68" endline="68" begincolumn="13" endcolumn="51" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAddress" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="70" endline="70" begincolumn="13" endcolumn="53" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAddress" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="72" endline="77" begincolumn="17" endcolumn="59" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAddress" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'name' (lines '72'-'77'). |
| </violation> |
| <violation beginline="72" endline="85" begincolumn="20" endcolumn="59" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAddress" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'name' (lines '72'-'85'). |
| </violation> |
| <violation beginline="75" endline="75" begincolumn="17" endcolumn="75" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAddress" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="88" endline="98" begincolumn="23" endcolumn="56" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildGroupBody" variable="results" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'results' (lines '88'-'98'). |
| </violation> |
| <violation beginline="104" endline="104" begincolumn="13" endcolumn="51" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildMailbox" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="106" endline="106" begincolumn="13" endcolumn="53" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildMailbox" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="119" endline="126" begincolumn="13" endcolumn="55" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildNameAddr" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'name' (lines '119'-'126'). |
| </violation> |
| <violation beginline="119" endline="131" begincolumn="13" endcolumn="52" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildNameAddr" variable="name" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'name' (lines '119'-'131'). |
| </violation> |
| <violation beginline="135" endline="138" begincolumn="13" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAngleAddr" variable="route" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'route' (lines '135'-'138'). |
| </violation> |
| <violation beginline="135" endline="150" begincolumn="20" endcolumn="31" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAngleAddr" variable="route" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'route' (lines '135'-'150'). |
| </violation> |
| <violation beginline="138" endline="150" begincolumn="13" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAngleAddr" variable="route" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'route' (lines '138'-'150'). |
| </violation> |
| <violation beginline="140" endline="142" begincolumn="47" endcolumn="9" rule="EmptyIfStmt" ruleset="Basic Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildAngleAddr" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyIfStmt" priority="3"> |
| Avoid empty if statements |
| </violation> |
| <violation beginline="153" endline="163" begincolumn="22" endcolumn="78" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Builder" method="buildRoute" variable="results" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'results' (lines '153'-'163'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\address\DomainList.java"> |
| <violation beginline="45" endline="50" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="DomainList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\address\Group.java"> |
| <violation beginline="65" endline="73" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Group" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="113" endline="128" begincolumn="17" endcolumn="28" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Group" method="getDisplayString" variable="first" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'first' (lines '113'-'128'). |
| </violation> |
| <violation beginline="116" endline="128" begincolumn="17" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Group" method="getDisplayString" variable="first" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'first' (lines '116'-'128'). |
| </violation> |
| <violation beginline="137" endline="152" begincolumn="17" endcolumn="28" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Group" method="getEncodedString" variable="first" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'first' (lines '137'-'152'). |
| </violation> |
| <violation beginline="140" endline="152" begincolumn="17" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Group" method="getEncodedString" variable="first" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'first' (lines '140'-'152'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\address\Mailbox.java"> |
| <violation beginline="100" endline="109" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Mailbox" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="105" endline="105" begincolumn="58" endcolumn="61" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Mailbox" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="108" endline="108" begincolumn="64" endcolumn="67" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Mailbox" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="177" endline="177" begincolumn="13" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Mailbox" method="getAddress" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="266" endline="266" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Mailbox" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="268" endline="268" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Mailbox" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="282" endline="282" begincolumn="13" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="Mailbox" method="getCanonicalizedAddress" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\address\MailboxList.java"> |
| <violation beginline="44" endline="50" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address" class="MailboxList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\address\parser\BaseNode.java"> |
| <violation beginline="23" endline="28" begincolumn="17" endcolumn="1" rule="AtLeastOneConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.address.parser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AtLeastOneConstructor" priority="3"> |
| Each class should declare at least one constructor |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\field\datetime\DateTime.java"> |
| <violation beginline="54" endline="54" begincolumn="21" endcolumn="39" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="convertToYear" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="56" endline="56" begincolumn="21" endcolumn="39" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="convertToYear" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="58" endline="58" begincolumn="17" endcolumn="35" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="convertToYear" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="120" endline="120" begincolumn="9" endcolumn="28" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="hashCode" variable="PRIME" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="121" endline="122" begincolumn="9" endcolumn="72" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="hashCode" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'result' (lines '121'-'122'). |
| </violation> |
| <violation beginline="136" endline="136" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="138" endline="138" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="140" endline="140" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="141" endline="141" begincolumn="9" endcolumn="45" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" variable="other" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="144" endline="144" begincolumn="17" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="146" endline="146" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="148" endline="148" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="150" endline="150" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="152" endline="152" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="154" endline="154" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="156" endline="156" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="158" endline="158" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="160" endline="160" begincolumn="13" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.field.datetime" class="DateTime" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\io\BufferedLineReaderInputStream.java"> |
| <violation beginline="96" endline="96" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="fillBuffer" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="115" endline="115" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="117" endline="119" begincolumn="13" endcolumn="33" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" variable="noRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'noRead' (lines '117'-'119'). |
| </violation> |
| <violation beginline="117" endline="125" begincolumn="13" endcolumn="22" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" variable="noRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'noRead' (lines '117'-'125'). |
| </violation> |
| <violation beginline="121" endline="121" begincolumn="17" endcolumn="26" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="130" endline="130" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="133" endline="133" begincolumn="13" endcolumn="21" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="135" endline="137" begincolumn="13" endcolumn="33" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" variable="noRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'noRead' (lines '135'-'137'). |
| </violation> |
| <violation beginline="135" endline="149" begincolumn="13" endcolumn="22" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" variable="noRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'noRead' (lines '135'-'149'). |
| </violation> |
| <violation beginline="139" endline="139" begincolumn="17" endcolumn="26" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="154" endline="154" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="157" endline="157" begincolumn="13" endcolumn="21" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="174" endline="174" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="readLine" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="176" endline="208" begincolumn="13" endcolumn="21" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="readLine" variable="total" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'total' (lines '176'-'208'). |
| </violation> |
| <violation beginline="178" endline="181" begincolumn="17" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="readLine" variable="bytesRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'bytesRead' (lines '178'-'181'). |
| </violation> |
| <violation beginline="178" endline="208" begincolumn="13" endcolumn="25" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="readLine" variable="bytesRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'bytesRead' (lines '178'-'208'). |
| </violation> |
| <violation beginline="189" endline="208" begincolumn="17" endcolumn="28" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="readLine" variable="found" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'found' (lines '189'-'208'). |
| </violation> |
| <violation beginline="204" endline="204" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="readLine" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="226" endline="226" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="indexOf" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="235" endline="235" begincolumn="13" endcolumn="46" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="indexOf" variable="shiftTable" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'shiftTable' (lines '235'-'235'). |
| </violation> |
| <violation beginline="235" endline="260" begincolumn="13" endcolumn="46" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="indexOf" variable="shiftTable" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'shiftTable' (lines '235'-'260'). |
| </violation> |
| <violation beginline="241" endline="244" begincolumn="21" endcolumn="33" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="indexOf" variable="match" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'match' (lines '241'-'244'). |
| </violation> |
| <violation beginline="249" endline="249" begincolumn="17" endcolumn="27" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="indexOf" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="280" endline="280" begincolumn="17" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="BufferedLineReaderInputStream" method="indexOf" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\io\EOLConvertingInputStream.java"> |
| <violation beginline="86" endline="86" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="EOLConvertingInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\io\LineReaderInputStreamAdaptor.java"> |
| <violation beginline="47" endline="47" begincolumn="24" endcolumn="27" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="LineReaderInputStreamAdaptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="87" endline="91" begincolumn="13" endcolumn="19" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="LineReaderInputStreamAdaptor" method="doReadLine" variable="total" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'total' (lines '87'-'91'). |
| </violation> |
| <violation beginline="89" endline="89" begincolumn="16" endcolumn="37" rule="AssignmentInOperand" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="LineReaderInputStreamAdaptor" method="doReadLine" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AssignmentInOperand" priority="3"> |
| Avoid assignments in operands |
| </violation> |
| <violation beginline="91" endline="91" begincolumn="13" endcolumn="19" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="LineReaderInputStreamAdaptor" method="doReadLine" variable="total" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'total' (lines '91'-'91'). |
| </violation> |
| <violation beginline="91" endline="104" begincolumn="13" endcolumn="19" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="LineReaderInputStreamAdaptor" method="doReadLine" variable="total" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'total' (lines '91'-'104'). |
| </violation> |
| <violation beginline="100" endline="100" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="LineReaderInputStreamAdaptor" method="doReadLine" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\io\MimeBoundaryInputStream.java"> |
| <violation beginline="101" endline="101" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="105" endline="105" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="109" endline="109" begincolumn="17" endcolumn="37" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="121" endline="121" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="125" endline="125" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="129" endline="129" begincolumn="13" endcolumn="37" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="read" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="141" endline="141" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="readLine" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="145" endline="145" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="readLine" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="150" endline="153" begincolumn="17" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="readLine" variable="bytesRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'bytesRead' (lines '150'-'153'). |
| </violation> |
| <violation beginline="153" endline="153" begincolumn="17" endcolumn="40" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="readLine" variable="bytesRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'bytesRead' (lines '153'-'153'). |
| </violation> |
| <violation beginline="153" endline="156" begincolumn="21" endcolumn="34" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="readLine" variable="bytesRead" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'bytesRead' (lines '153'-'156'). |
| </violation> |
| <violation beginline="176" endline="176" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="readLine" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="192" endline="192" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="fillBuffer" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="231" endline="234" begincolumn="13" endcolumn="13" rule="CollapsibleIfStatements" ruleset="Basic Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="calculateBoundaryLen" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements" priority="3"> |
| These nested if statements could be combined |
| </violation> |
| <violation beginline="237" endline="240" begincolumn="13" endcolumn="13" rule="CollapsibleIfStatements" ruleset="Basic Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="calculateBoundaryLen" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements" priority="3"> |
| These nested if statements could be combined |
| </violation> |
| <violation beginline="248" endline="280" begincolumn="21" endcolumn="43" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="skipBoundary" variable="checkForLastPart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'checkForLastPart' (lines '248'-'280'). |
| </violation> |
| <violation beginline="254" endline="259" begincolumn="43" endcolumn="21" rule="CollapsibleIfStatements" ruleset="Basic Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="skipBoundary" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#CollapsibleIfStatements" priority="3"> |
| These nested if statements could be combined |
| </violation> |
| <violation beginline="257" endline="280" begincolumn="25" endcolumn="48" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="skipBoundary" variable="checkForLastPart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'checkForLastPart' (lines '257'-'280'). |
| </violation> |
| <violation beginline="292" endline="292" begincolumn="9" endcolumn="92" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="MimeBoundaryInputStream" method="toString" variable="buffer" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\io\PositionInputStream.java"> |
| <violation beginline="77" endline="77" begincolumn="9" endcolumn="33" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="PositionInputStream" method="skip" variable="c" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="85" endline="85" begincolumn="9" endcolumn="42" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.io" class="PositionInputStream" method="read" variable="c" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\BinaryBody.java"> |
| <violation beginline="33" endline="34" begincolumn="15" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="BinaryBody" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\BodyCopier.java"> |
| <violation beginline="57" endline="57" begincolumn="13" endcolumn="47" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="BodyCopier" method="copy" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="60" endline="60" begincolumn="13" endcolumn="51" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="BodyCopier" method="copy" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\BodyFactory.java"> |
| <violation beginline="288" endline="288" begincolumn="13" endcolumn="36" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="BodyFactory" method="toJavaCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="296" endline="296" begincolumn="13" endcolumn="36" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="BodyFactory" method="toJavaCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="304" endline="304" begincolumn="13" endcolumn="36" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="BodyFactory" method="toJavaCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\BodyPart.java"> |
| <violation beginline="30" endline="31" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="BodyPart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\Entity.java"> |
| <violation beginline="146" endline="147" begincolumn="13" endcolumn="24" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" method="removeBody" variable="body" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'body' (lines '146'-'147'). |
| </violation> |
| <violation beginline="148" endline="148" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" method="removeBody" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="151" endline="151" begincolumn="21" endcolumn="24" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" method="removeBody" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="236" endline="239" begincolumn="13" endcolumn="73" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" method="setText" variable="parameters" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'parameters' (lines '236'-'239'). |
| </violation> |
| <violation beginline="343" endline="343" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" method="getDispositionType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="443" endline="443" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" method="getFilename" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="530" endline="535" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="547" endline="555" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="550" endline="550" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Entity" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\Header.java"> |
| <violation beginline="77" endline="77" begincolumn="9" endcolumn="62" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" variable="parser" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="130" endline="130" begincolumn="13" endcolumn="28" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="getField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="142" endline="142" begincolumn="9" endcolumn="55" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="getFields" variable="lowerCaseName" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="143" endline="143" begincolumn="9" endcolumn="57" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="getFields" variable="l" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="144" endline="144" begincolumn="9" endcolumn="33" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="getFields" variable="results" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="170" endline="170" begincolumn="9" endcolumn="55" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="removeFields" variable="lowerCaseName" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="173" endline="173" begincolumn="13" endcolumn="21" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="removeFields" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="197" endline="197" begincolumn="9" endcolumn="66" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="setField" variable="lowerCaseName" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="208" endline="209" begincolumn="80" endcolumn="86" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="setField" variable="index" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'index' (lines '208'-'209'). |
| </violation> |
| <violation beginline="208" endline="220" begincolumn="13" endcolumn="21" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="setField" variable="index" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'index' (lines '208'-'220'). |
| </violation> |
| <violation beginline="209" endline="209" begincolumn="80" endcolumn="86" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="setField" variable="index" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'index' (lines '209'-'209'). |
| </violation> |
| <violation beginline="209" endline="220" begincolumn="80" endcolumn="86" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Header" method="setField" variable="index" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'index' (lines '209'-'220'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\Message.java"> |
| <violation beginline="63" endline="64" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="135" endline="145" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="170" endline="170" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Message" method="getMessageId" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="199" endline="199" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Message" method="getSubject" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="233" endline="233" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Message" method="getDate" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="533" endline="533" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Message" method="getMailbox" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="551" endline="551" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Message" method="getMailboxList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="579" endline="579" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Message" method="getAddressList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\MessageBuilder.java"> |
| <violation beginline="121" endline="121" begincolumn="9" endcolumn="46" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageBuilder" method="startMultipart" variable="e" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="122" endline="122" begincolumn="9" endcolumn="46" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageBuilder" method="startMultipart" variable="subType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="123" endline="123" begincolumn="9" endcolumn="58" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageBuilder" method="startMultipart" variable="multiPart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="134" endline="134" begincolumn="9" endcolumn="51" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageBuilder" method="body" variable="enc" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="136" endline="136" begincolumn="9" endcolumn="23" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageBuilder" method="body" variable="body" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="138" endline="138" begincolumn="9" endcolumn="39" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageBuilder" method="body" variable="decodedStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="213" endline="213" begincolumn="16" endcolumn="36" rule="AssignmentInOperand" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageBuilder" method="loadStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AssignmentInOperand" priority="3"> |
| Avoid assignments in operands |
| </violation> |
| <violation beginline="213" endline="218" begincolumn="16" endcolumn="36" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageBuilder" method="loadStream" variable="b" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'b' (lines '213'-'218'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\MessageWriter.java"> |
| <violation beginline="93" endline="93" begincolumn="9" endcolumn="48" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageWriter" method="writeEntity" variable="header" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="99" endline="99" begincolumn="9" endcolumn="42" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageWriter" method="writeEntity" variable="body" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="174" endline="174" begincolumn="13" endcolumn="45" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageWriter" method="encodeStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="176" endline="176" begincolumn="13" endcolumn="66" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="MessageWriter" method="encodeStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\Multipart.java"> |
| <violation beginline="242" endline="244" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Multipart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="246" endline="249" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Multipart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="248" endline="248" begincolumn="33" endcolumn="36" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Multipart" method="setPreambleRaw" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="275" endline="277" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Multipart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="279" endline="282" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Multipart" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="281" endline="281" begincolumn="33" endcolumn="36" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="Multipart" method="setEpilogueRaw" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\SimpleContentHandler.java"> |
| <violation beginline="90" endline="90" begincolumn="22" endcolumn="25" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="SimpleContentHandler" method="endHeader" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\StorageBinaryBody.java"> |
| <violation beginline="37" endline="39" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="StorageBinaryBody" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="71" endline="71" begincolumn="23" endcolumn="26" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="StorageBinaryBody" method="dispose" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\StorageTextBody.java"> |
| <violation beginline="41" endline="44" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="StorageTextBody" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="81" endline="81" begincolumn="23" endcolumn="26" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="StorageTextBody" method="dispose" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\StringTextBody.java"> |
| <violation beginline="40" endline="43" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="StringTextBody" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="63" endline="74" begincolumn="14" endcolumn="38" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="StringTextBody" method="writeTo" variable="buffer" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'buffer' (lines '63'-'74'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\message\TextBody.java"> |
| <violation beginline="33" endline="34" begincolumn="15" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.message" class="TextBody" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\parser\AbstractEntity.java"> |
| <violation beginline="108" endline="108" begincolumn="9" endcolumn="42" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="newBodyDescriptor" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="129" endline="172" begincolumn="13" endcolumn="47" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="fillFieldBuffer" variable="maxLineLen" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'maxLineLen' (lines '129'-'172'). |
| </violation> |
| <violation beginline="130" endline="172" begincolumn="31" endcolumn="56" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="fillFieldBuffer" variable="instream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'instream' (lines '130'-'172'). |
| </violation> |
| <violation beginline="175" endline="218" begincolumn="13" endcolumn="55" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="parseField" variable="maxHeaderLimit" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'maxHeaderLimit' (lines '175'-'218'). |
| </violation> |
| <violation beginline="178" endline="178" begincolumn="17" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="parseField" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="197" endline="202" begincolumn="17" endcolumn="29" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="parseField" variable="valid" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'valid' (lines '197'-'202'). |
| </violation> |
| <violation beginline="197" endline="207" begincolumn="25" endcolumn="37" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="parseField" variable="valid" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'valid' (lines '197'-'207'). |
| </violation> |
| <violation beginline="284" endline="284" begincolumn="9" endcolumn="28" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="message" variable="message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="293" endline="293" begincolumn="13" endcolumn="27" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="message" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="332" endline="332" begincolumn="9" endcolumn="27" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="AbstractEntity" method="stateToString" variable="result" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\parser\Event.java"> |
| <violation beginline="56" endline="56" begincolumn="26" endcolumn="38" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="Event" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="57" endline="57" begincolumn="26" endcolumn="37" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="Event" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="60" endline="60" begincolumn="13" endcolumn="47" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="Event" method="equals" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\parser\MimeEntity.java"> |
| <violation beginline="106" endline="106" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="getLineNumber" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="133" endline="199" begincolumn="20" endcolumn="48" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="advance" variable="mimeType" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'mimeType' (lines '133'-'199'). |
| </violation> |
| <violation beginline="142" endline="142" begincolumn="17" endcolumn="37" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="advance" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="165" endline="165" begincolumn="17" endcolumn="40" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="advance" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="177" endline="177" begincolumn="21" endcolumn="44" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="advance" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="229" endline="229" begincolumn="22" endcolumn="25" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="clearMimeStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="241" endline="242" begincolumn="48" endcolumn="13" rule="EmptyWhileStmt" ruleset="Basic Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="advanceToBoundary" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyWhileStmt" priority="3"> |
| Avoid empty while statements |
| </violation> |
| <violation beginline="261" endline="261" begincolumn="13" endcolumn="27" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="nextMessage" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="281" endline="281" begincolumn="13" endcolumn="27" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="nextMimeEntity" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="302" endline="302" begincolumn="13" endcolumn="71" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeEntity" method="getLimitedContentStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\parser\MimeStreamParser.java"> |
| <violation beginline="144" endline="91" begincolumn="17" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeStreamParser" method="parse" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '144'-'91'). |
| </violation> |
| <violation beginline="144" endline="146" begincolumn="13" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeStreamParser" method="parse" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'state' (lines '144'-'146'). |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\parser\MimeTokenStream.java"> |
| <violation beginline="153" endline="156" begincolumn="13" endcolumn="34" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="doParse" variable="lineSource" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'lineSource' (lines '153'-'156'). |
| </violation> |
| <violation beginline="153" endline="189" begincolumn="26" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="doParse" variable="lineSource" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'lineSource' (lines '153'-'189'). |
| </violation> |
| <violation beginline="156" endline="189" begincolumn="13" endcolumn="34" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="doParse" variable="lineSource" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'lineSource' (lines '156'-'189'). |
| </violation> |
| <violation beginline="282" endline="284" begincolumn="13" endcolumn="58" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="getDecodedInputStream" variable="dataStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'dataStream' (lines '282'-'284'). |
| </violation> |
| <violation beginline="282" endline="286" begincolumn="13" endcolumn="67" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="getDecodedInputStream" variable="dataStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'dataStream' (lines '282'-'286'). |
| </violation> |
| <violation beginline="309" endline="309" begincolumn="9" endcolumn="65" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="getReader" variable="bodyDescriptor" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="310" endline="310" begincolumn="9" endcolumn="62" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="getReader" variable="mimeCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="311" endline="311" begincolumn="9" endcolumn="29" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="getReader" variable="charset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="317" endline="317" begincolumn="9" endcolumn="60" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="getReader" variable="instream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="363" endline="363" begincolumn="17" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="next" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="367" endline="367" begincolumn="39" endcolumn="42" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.parser" class="MimeTokenStream" method="next" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\storage\CipherStorageProvider.java"> |
| <violation beginline="74" endline="85" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="CipherStorageProvider" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="106" endline="120" begincolumn="16" endcolumn="9" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="CipherStorageProvider$CipherStorageOutputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="157" endline="157" begincolumn="29" endcolumn="32" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="CipherStorageProvider$CipherStorage" method="delete" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\storage\DefaultStorageProvider.java"> |
| <violation beginline="46" endline="46" begincolumn="29" endcolumn="60" rule="AvoidUsingVolatile" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="DefaultStorageProvider" variable="instance" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidUsingVolatile" priority="2"> |
| Use of modifier volatile is not recommended. |
| </violation> |
| <violation beginline="96" endline="99" begincolumn="5" endcolumn="5" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="DefaultStorageProvider" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="97" endline="97" begincolumn="20" endcolumn="23" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="DefaultStorageProvider" method="reset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\storage\MemoryStorageProvider.java"> |
| <violation beginline="43" endline="44" begincolumn="12" endcolumn="5" rule="UnnecessaryConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="MemoryStorageProvider" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#UnnecessaryConstructor" priority="3"> |
| Avoid unnecessary constructors - the compiler will generate these for you |
| </violation> |
| <violation beginline="43" endline="44" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="MemoryStorageProvider" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="52" endline="52" begincolumn="9" endcolumn="56" rule="DefaultPackage" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="MemoryStorageProvider$MemoryStorageOutputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DefaultPackage" priority="3"> |
| Use explicit scoping instead of the default package private level |
| </violation> |
| <violation beginline="83" endline="83" begincolumn="20" endcolumn="23" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="MemoryStorageProvider$MemoryStorage" method="delete" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\storage\StorageOutputStream.java"> |
| <violation beginline="47" endline="48" begincolumn="15" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="StorageOutputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\storage\TempFileStorageProvider.java"> |
| <violation beginline="90" endline="101" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="TempFileStorageProvider" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="115" endline="118" begincolumn="16" endcolumn="9" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="TempFileStorageProvider$TempFileStorageOutputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="161" endline="161" begincolumn="28" endcolumn="31" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="TempFileStorageProvider$TempFileStorage" method="delete" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\storage\ThresholdStorageProvider.java"> |
| <violation beginline="67" endline="75" begincolumn="12" endcolumn="5" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="ThresholdStorageProvider" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="87" endline="90" begincolumn="16" endcolumn="9" rule="CallSuperInConstructor" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="ThresholdStorageProvider$ThresholdStorageOutputStream" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#CallSuperInConstructor" priority="3"> |
| It is a good practice to call super() in a constructor |
| </violation> |
| <violation beginline="88" endline="88" begincolumn="13" endcolumn="64" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="ThresholdStorageProvider$ThresholdStorageOutputStream" variable="bufferSize" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="122" endline="123" begincolumn="17" endcolumn="39" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="ThresholdStorageProvider$ThresholdStorageOutputStream" method="toStorage0" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="145" endline="145" begincolumn="24" endcolumn="27" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="ThresholdStorageProvider$ThresholdStorage" method="delete" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="147" endline="147" begincolumn="24" endcolumn="27" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.storage" class="ThresholdStorageProvider$ThresholdStorage" method="delete" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\util\ByteArrayBuffer.java"> |
| <violation beginline="67" endline="67" begincolumn="13" endcolumn="19" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="ByteArrayBuffer" method="append" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="136" endline="136" begincolumn="13" endcolumn="22" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="ByteArrayBuffer" method="indexOf" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="140" endline="140" begincolumn="17" endcolumn="25" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="ByteArrayBuffer" method="indexOf" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\util\CharsetUtil.java"> |
| <violation beginline="1024" endline="1025" begincolumn="15" endcolumn="13" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3"> |
| Avoid empty catch blocks |
| </violation> |
| <violation beginline="1025" endline="1026" begincolumn="15" endcolumn="13" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3"> |
| Avoid empty catch blocks |
| </violation> |
| <violation beginline="1030" endline="1031" begincolumn="15" endcolumn="13" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3"> |
| Avoid empty catch blocks |
| </violation> |
| <violation beginline="1031" endline="1032" begincolumn="15" endcolumn="13" rule="EmptyCatchBlock" ruleset="Basic Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" externalInfoUrl="http://pmd.sourceforge.net/rules/basic.html#EmptyCatchBlock" priority="3"> |
| Avoid empty catch blocks |
| </violation> |
| <violation beginline="1108" endline="1108" begincolumn="9" endcolumn="34" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="isASCII" variable="len" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="1111" endline="1111" begincolumn="17" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="isASCII" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="1143" endline="1143" begincolumn="9" endcolumn="34" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="isWhitespace" variable="len" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="1146" endline="1146" begincolumn="17" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="isWhitespace" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="1192" endline="1192" begincolumn="13" endcolumn="26" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="toMimeCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="1211" endline="1211" begincolumn="13" endcolumn="31" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="toJavaCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="1217" endline="1234" begincolumn="16" endcolumn="44" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="getCharset" variable="defaultCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'defaultCharset' (lines '1,217'-'1,234'). |
| </violation> |
| <violation beginline="1223" endline="1223" begincolumn="13" endcolumn="65" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="getCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="1227" endline="1227" begincolumn="13" endcolumn="68" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="CharsetUtil" method="getCharset" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\util\ContentUtil.java"> |
| <violation beginline="125" endline="125" begincolumn="13" endcolumn="65" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="ContentUtil" method="decode" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\util\MimeUtil.java"> |
| <violation beginline="176" endline="176" begincolumn="19" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" variable="ERROR" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'ERROR' (lines '176'-'176'). |
| </violation> |
| <violation beginline="176" endline="176" begincolumn="19" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" variable="IN_NAME" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'IN_NAME' (lines '176'-'176'). |
| </violation> |
| <violation beginline="176" endline="176" begincolumn="19" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" variable="IN_QUOTED_VALUE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'IN_QUOTED_VALUE' (lines '176'-'176'). |
| </violation> |
| <violation beginline="176" endline="176" begincolumn="19" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" variable="IN_VALUE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'IN_VALUE' (lines '176'-'176'). |
| </violation> |
| <violation beginline="176" endline="176" begincolumn="19" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" variable="READY_FOR_NAME" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'READY_FOR_NAME' (lines '176'-'176'). |
| </violation> |
| <violation beginline="176" endline="176" begincolumn="19" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" variable="READY_FOR_VALUE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'READY_FOR_VALUE' (lines '176'-'176'). |
| </violation> |
| <violation beginline="176" endline="176" begincolumn="19" endcolumn="5" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" variable="VALUE_DONE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'UR'-anomaly for variable 'VALUE_DONE' (lines '176'-'176'). |
| </violation> |
| <violation beginline="188" endline="188" begincolumn="20" endcolumn="23" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="197" endline="343" begincolumn="27" endcolumn="59" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="paramName" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'paramName' (lines '197'-'343'). |
| </violation> |
| <violation beginline="198" endline="343" begincolumn="27" endcolumn="60" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="paramValue" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'paramValue' (lines '198'-'343'). |
| </violation> |
| <violation beginline="200" endline="200" begincolumn="13" endcolumn="41" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="READY_FOR_NAME" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="201" endline="201" begincolumn="13" endcolumn="34" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="IN_NAME" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="201" endline="343" begincolumn="24" endcolumn="34" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="IN_NAME" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'IN_NAME' (lines '201'-'343'). |
| </violation> |
| <violation beginline="202" endline="202" begincolumn="13" endcolumn="42" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="READY_FOR_VALUE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="202" endline="343" begincolumn="24" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="READY_FOR_VALUE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'READY_FOR_VALUE' (lines '202'-'343'). |
| </violation> |
| <violation beginline="203" endline="203" begincolumn="13" endcolumn="35" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="IN_VALUE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="204" endline="204" begincolumn="13" endcolumn="42" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="IN_QUOTED_VALUE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="204" endline="343" begincolumn="24" endcolumn="42" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="IN_QUOTED_VALUE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'IN_QUOTED_VALUE' (lines '204'-'343'). |
| </violation> |
| <violation beginline="205" endline="205" begincolumn="13" endcolumn="37" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="VALUE_DONE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="205" endline="343" begincolumn="24" endcolumn="37" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="VALUE_DONE" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'VALUE_DONE' (lines '205'-'343'). |
| </violation> |
| <violation beginline="206" endline="206" begincolumn="13" endcolumn="33" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="ERROR" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="206" endline="343" begincolumn="24" endcolumn="33" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="ERROR" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'ERROR' (lines '206'-'343'). |
| </violation> |
| <violation beginline="209" endline="343" begincolumn="21" endcolumn="35" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="escaped" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'escaped' (lines '209'-'343'). |
| </violation> |
| <violation beginline="227" endline="233" begincolumn="33" endcolumn="45" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '227'-'233'). |
| </violation> |
| <violation beginline="227" endline="235" begincolumn="33" endcolumn="55" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '227'-'235'). |
| </violation> |
| <violation beginline="244" endline="256" begincolumn="33" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="fallThrough" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'fallThrough' (lines '244'-'256'). |
| </violation> |
| <violation beginline="251" endline="273" begincolumn="33" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '251'-'273'). |
| </violation> |
| <violation beginline="251" endline="286" begincolumn="33" endcolumn="54" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '251'-'286'). |
| </violation> |
| <violation beginline="251" endline="294" begincolumn="33" endcolumn="45" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '251'-'294'). |
| </violation> |
| <violation beginline="255" endline="273" begincolumn="33" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '255'-'273'). |
| </violation> |
| <violation beginline="255" endline="286" begincolumn="33" endcolumn="54" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '255'-'286'). |
| </violation> |
| <violation beginline="255" endline="294" begincolumn="33" endcolumn="45" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '255'-'294'). |
| </violation> |
| <violation beginline="265" endline="274" begincolumn="33" endcolumn="50" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="fallThrough" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'fallThrough' (lines '265'-'274'). |
| </violation> |
| <violation beginline="273" endline="286" begincolumn="33" endcolumn="54" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '273'-'286'). |
| </violation> |
| <violation beginline="273" endline="294" begincolumn="33" endcolumn="45" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="state" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DD'-anomaly for variable 'state' (lines '273'-'294'). |
| </violation> |
| <violation beginline="309" endline="343" begincolumn="37" endcolumn="51" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="escaped" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'escaped' (lines '309'-'343'). |
| </violation> |
| <violation beginline="318" endline="318" begincolumn="43" endcolumn="50" rule="BooleanInversion" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#BooleanInversion" priority="3"> |
| Use bitwise inversion to invert boolean values |
| </violation> |
| <violation beginline="325" endline="343" begincolumn="33" endcolumn="47" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="getHeaderParams" variable="escaped" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'escaped' (lines '325'-'343'). |
| </violation> |
| <violation beginline="431" endline="431" begincolumn="9" endcolumn="36" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="fold" variable="maxCharacters" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="433" endline="433" begincolumn="9" endcolumn="37" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="fold" variable="length" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="435" endline="435" begincolumn="13" endcolumn="21" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="fold" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="437" endline="457" begincolumn="23" endcolumn="46" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="fold" variable="sb" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'sb' (lines '437'-'457'). |
| </violation> |
| <violation beginline="439" endline="457" begincolumn="13" endcolumn="43" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="fold" variable="lastLineBreak" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'lastLineBreak' (lines '439'-'457'). |
| </violation> |
| <violation beginline="440" endline="457" begincolumn="13" endcolumn="37" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="fold" variable="wspIdx" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'wspIdx' (lines '440'-'457'). |
| </violation> |
| <violation beginline="452" endline="457" begincolumn="17" endcolumn="38" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="fold" variable="lastLineBreak" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'lastLineBreak' (lines '452'-'457'). |
| </violation> |
| <violation beginline="455" endline="457" begincolumn="13" endcolumn="31" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="fold" variable="wspIdx" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'wspIdx' (lines '455'-'457'). |
| </violation> |
| <violation beginline="467" endline="467" begincolumn="9" endcolumn="37" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="unfold" variable="length" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="471" endline="471" begincolumn="17" endcolumn="39" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="unfold" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="479" endline="479" begincolumn="9" endcolumn="37" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="unfold0" variable="length" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="497" endline="497" begincolumn="9" endcolumn="34" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="indexOfWsp" variable="len" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="501" endline="501" begincolumn="17" endcolumn="29" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="MimeUtil" method="indexOfWsp" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| </file> |
| <file name="c:\data\src\apache.org\james\apache-mime4j-0.6\src\main\java\org\apache\james\mime4j\util\StringArrayMap.java"> |
| <violation beginline="60" endline="60" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asString" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="63" endline="63" begincolumn="13" endcolumn="35" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asString" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="66" endline="66" begincolumn="13" endcolumn="42" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asString" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="84" endline="84" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringArray" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="87" endline="87" begincolumn="13" endcolumn="49" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringArray" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="90" endline="90" begincolumn="13" endcolumn="37" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringArray" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="93" endline="93" begincolumn="13" endcolumn="46" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringArray" variable="l" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="109" endline="109" begincolumn="13" endcolumn="24" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="112" endline="125" begincolumn="13" endcolumn="14" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="121" endline="121" begincolumn="21" endcolumn="51" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="nextElement" variable="s" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="122" endline="122" begincolumn="29" endcolumn="32" rule="NullAssignment" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="nextElement" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#NullAssignment" priority="3"> |
| Assigning an Object to null is a code smell. Consider refactoring. |
| </violation> |
| <violation beginline="128" endline="128" begincolumn="13" endcolumn="53" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" variable="values" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="128" endline="148" begincolumn="28" endcolumn="53" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" variable="values" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'values' (lines '128'-'148'). |
| </violation> |
| <violation beginline="128" endline="148" begincolumn="28" endcolumn="53" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" variable="values" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'values' (lines '128'-'148'). |
| </violation> |
| <violation beginline="128" endline="148" begincolumn="28" endcolumn="53" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" variable="values" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'values' (lines '128'-'148'). |
| </violation> |
| <violation beginline="128" endline="148" begincolumn="28" endcolumn="53" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" variable="values" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'values' (lines '128'-'148'). |
| </violation> |
| <violation beginline="128" endline="148" begincolumn="28" endcolumn="53" rule="DataflowAnomalyAnalysis" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" variable="values" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#DataflowAnomalyAnalysis" priority="5"> |
| Found 'DU'-anomaly for variable 'values' (lines '128'-'148'). |
| </violation> |
| <violation beginline="129" endline="140" begincolumn="13" endcolumn="14" rule="OnlyOneReturn" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#OnlyOneReturn" priority="3"> |
| A method should have only one exit point, and that should be the last statement in the method |
| </violation> |
| <violation beginline="143" endline="144" begincolumn="13" endcolumn="65" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asStringEnum" variable="stringList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="157" endline="157" begincolumn="13" endcolumn="66" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="asMap" variable="value" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="171" endline="171" begincolumn="13" endcolumn="61" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="addMapValue" variable="list" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="176" endline="177" begincolumn="13" endcolumn="60" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="addMapValue" variable="stringList" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="180" endline="180" begincolumn="13" endcolumn="61" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="addMapValue" variable="list" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="181" endline="181" begincolumn="13" endcolumn="45" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="addMapValue" variable="arr" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| <violation beginline="250" endline="250" begincolumn="9" endcolumn="49" rule="AvoidFinalLocalVariable" ruleset="Controversial Rules" package="org.apache.james.mime4j.util" class="StringArrayMap" method="getNameArray" variable="c" externalInfoUrl="http://pmd.sourceforge.net/rules/controversial.html#AvoidFinalLocalVariable" priority="3"> |
| Avoid using final local variables, turn them into fields |
| </violation> |
| </file> |
| </pmd> |
