update spotless version (#12345)
diff --git a/example/pulsar/src/main/java/org/apache/iotdb/pulsar/PulsarConsumerThread.java b/example/pulsar/src/main/java/org/apache/iotdb/pulsar/PulsarConsumerThread.java
index fce2baa..a504654 100644
--- a/example/pulsar/src/main/java/org/apache/iotdb/pulsar/PulsarConsumerThread.java
+++ b/example/pulsar/src/main/java/org/apache/iotdb/pulsar/PulsarConsumerThread.java
@@ -47,6 +47,7 @@
this.consumer = consumer;
Class.forName("org.apache.iotdb.jdbc.IoTDBDriver");
}
+
/** insert data to IoTDB */
private void insert(String data) throws IoTDBConnectionException, StatementExecutionException {
String[] dataArray = data.split(",");
diff --git a/example/session/src/main/java/org/apache/iotdb/DataMigrationExample.java b/example/session/src/main/java/org/apache/iotdb/DataMigrationExample.java
index 6743124..e19953b 100644
--- a/example/session/src/main/java/org/apache/iotdb/DataMigrationExample.java
+++ b/example/session/src/main/java/org/apache/iotdb/DataMigrationExample.java
@@ -59,7 +59,9 @@
private static final int CONCURRENCY = 5;
public static void main(String[] args)
- throws IoTDBConnectionException, StatementExecutionException, ExecutionException,
+ throws IoTDBConnectionException,
+ StatementExecutionException,
+ ExecutionException,
InterruptedException {
// the thread used for dataMigration must be smaller than session pool size
diff --git a/example/session/src/main/java/org/apache/iotdb/HybridTimeseriesSessionExample.java b/example/session/src/main/java/org/apache/iotdb/HybridTimeseriesSessionExample.java
index 79b6f89..2a1f5d8 100644
--- a/example/session/src/main/java/org/apache/iotdb/HybridTimeseriesSessionExample.java
+++ b/example/session/src/main/java/org/apache/iotdb/HybridTimeseriesSessionExample.java
@@ -73,6 +73,7 @@
dataSet.closeOperationHandle();
}
+
/** Method 1 for insert tablet with aligned timeseries */
private static void insertTabletWithAlignedTimeseriesMethod(int minTime, int maxTime)
throws IoTDBConnectionException, StatementExecutionException {
diff --git a/example/session/src/main/java/org/apache/iotdb/SyntaxConventionRelatedExample.java b/example/session/src/main/java/org/apache/iotdb/SyntaxConventionRelatedExample.java
index 5831eea..ada3646 100644
--- a/example/session/src/main/java/org/apache/iotdb/SyntaxConventionRelatedExample.java
+++ b/example/session/src/main/java/org/apache/iotdb/SyntaxConventionRelatedExample.java
@@ -47,6 +47,7 @@
private static Session session;
private static final String LOCAL_HOST = "127.0.0.1";
+
/**
* if you want to create a time series named root.sg1.select, a possible SQL statement would be
* like: create timeseries root.sg1.select with datatype=FLOAT, encoding=RLE As described before,
diff --git a/integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java b/integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java
index 5b64cb8..1a429f4 100644
--- a/integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java
+++ b/integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java
@@ -293,6 +293,7 @@
});
testJDBCConnection();
}
+
/**
* check whether all nodes' status match the provided predicate with RPC. after retryCount times,
* if the status of all nodes still not match the predicate, throw AssertionError.
diff --git a/integration-test/src/test/java/org/apache/iotdb/confignode/it/regionmigration/IoTDBRegionMigrateReliabilityITFramework.java b/integration-test/src/test/java/org/apache/iotdb/confignode/it/regionmigration/IoTDBRegionMigrateReliabilityITFramework.java
index 0994ddf..15d396f 100644
--- a/integration-test/src/test/java/org/apache/iotdb/confignode/it/regionmigration/IoTDBRegionMigrateReliabilityITFramework.java
+++ b/integration-test/src/test/java/org/apache/iotdb/confignode/it/regionmigration/IoTDBRegionMigrateReliabilityITFramework.java
@@ -103,10 +103,7 @@
public static Consumer<KillPointContext> actionOfRestartCluster =
context -> {
- context
- .getEnv()
- .getNodeWrapperList()
- .parallelStream()
+ context.getEnv().getNodeWrapperList().parallelStream()
.forEach(AbstractNodeWrapper::stopForcibly);
LOGGER.info("Cluster has been stopped");
context.getEnv().getNodeWrapperList().parallelStream().forEach(AbstractNodeWrapper::start);
@@ -307,8 +304,7 @@
}
private void restartDataNodes(List<DataNodeWrapper> dataNodeWrappers) {
- dataNodeWrappers
- .parallelStream()
+ dataNodeWrappers.parallelStream()
.forEach(
nodeWrapper -> {
nodeWrapper.stop();
diff --git a/integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/maxby/IoTDBMaxByIT.java b/integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/maxby/IoTDBMaxByIT.java
index 5b70672..bcc34fc 100644
--- a/integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/maxby/IoTDBMaxByIT.java
+++ b/integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/maxby/IoTDBMaxByIT.java
@@ -468,7 +468,9 @@
}
}
- /** @return yInput -> expectedHeader */
+ /**
+ * @return yInput -> expectedHeader
+ */
private Map<String, String[]> generateExpectedHeadersForMaxByTest(
String device, String[] xInput, String[] yInput) {
Map<String, String[]> res = new HashMap<>();
diff --git a/integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/minby/IoTDBMinByIT.java b/integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/minby/IoTDBMinByIT.java
index f332368..7b4d45d 100644
--- a/integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/minby/IoTDBMinByIT.java
+++ b/integration-test/src/test/java/org/apache/iotdb/db/it/aggregation/minby/IoTDBMinByIT.java
@@ -468,7 +468,9 @@
}
}
- /** @return yInput -> expectedHeader */
+ /**
+ * @return yInput -> expectedHeader
+ */
private Map<String, String[]> generateExpectedHeadersForMaxByTest(
String device, String[] xInput, String[] yInput) {
Map<String, String[]> res = new HashMap<>();
diff --git a/integration-test/src/test/java/org/apache/iotdb/db/it/schema/IoTDBCreateStorageGroupIT.java b/integration-test/src/test/java/org/apache/iotdb/db/it/schema/IoTDBCreateStorageGroupIT.java
index 5703bec..84dc7b7 100644
--- a/integration-test/src/test/java/org/apache/iotdb/db/it/schema/IoTDBCreateStorageGroupIT.java
+++ b/integration-test/src/test/java/org/apache/iotdb/db/it/schema/IoTDBCreateStorageGroupIT.java
@@ -69,6 +69,7 @@
public void tearDown() throws Exception {
clearSchema();
}
+
/** The test creates three databases */
@Test
public void testCreateStorageGroup() throws Exception {
diff --git a/integration-test/src/test/java/org/apache/iotdb/subscription/it/dual/IoTDBSubscriptionConsumerGroupIT.java b/integration-test/src/test/java/org/apache/iotdb/subscription/it/dual/IoTDBSubscriptionConsumerGroupIT.java
index bff5080..3175922 100644
--- a/integration-test/src/test/java/org/apache/iotdb/subscription/it/dual/IoTDBSubscriptionConsumerGroupIT.java
+++ b/integration-test/src/test/java/org/apache/iotdb/subscription/it/dual/IoTDBSubscriptionConsumerGroupIT.java
@@ -795,7 +795,9 @@
}
}
- /** @return false -> receiver crashed */
+ /**
+ * @return false -> receiver crashed
+ */
private boolean insertRowRecordEnrichedByConsumerGroupId(
final List<String> columnNameList, final RowRecord record, final String consumerGroupId)
throws Exception {
diff --git a/iotdb-api/udf-api/src/main/java/org/apache/iotdb/udf/api/State.java b/iotdb-api/udf-api/src/main/java/org/apache/iotdb/udf/api/State.java
index fd01f45..993cf30 100644
--- a/iotdb-api/udf-api/src/main/java/org/apache/iotdb/udf/api/State.java
+++ b/iotdb-api/udf-api/src/main/java/org/apache/iotdb/udf/api/State.java
@@ -36,5 +36,6 @@
void deserialize(byte[] bytes);
/** Destroy state. You may release previously binding resource in this method. */
- default void destroyState() {};
+ default void destroyState() {}
+ ;
}
diff --git a/iotdb-api/udf-api/src/main/java/org/apache/iotdb/udf/api/UDAF.java b/iotdb-api/udf-api/src/main/java/org/apache/iotdb/udf/api/UDAF.java
index 6cd71f8..56340de 100644
--- a/iotdb-api/udf-api/src/main/java/org/apache/iotdb/udf/api/UDAF.java
+++ b/iotdb-api/udf-api/src/main/java/org/apache/iotdb/udf/api/UDAF.java
@@ -68,5 +68,6 @@
*/
default void removeState(State state, State removed) {
throw new UnsupportedOperationException(getClass().getName());
- };
+ }
+ ;
}
diff --git a/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ExportTsFile.java b/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ExportTsFile.java
index 6949142..18ada25 100644
--- a/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ExportTsFile.java
+++ b/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ExportTsFile.java
@@ -313,7 +313,9 @@
"squid:S6541"
}) // Suppress high Cognitive Complexity warning, Suppress many task in one method warning
public static void writeTsFileFile(SessionDataSet sessionDataSet, String filePath)
- throws IOException, IoTDBConnectionException, StatementExecutionException,
+ throws IOException,
+ IoTDBConnectionException,
+ StatementExecutionException,
WriteProcessException {
List<String> columnNames = sessionDataSet.getColumnNames();
List<String> columnTypes = sessionDataSet.getColumnTypes();
diff --git a/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ImportData.java b/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ImportData.java
index 7695fd4..1fba1f6 100644
--- a/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ImportData.java
+++ b/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/ImportData.java
@@ -492,7 +492,8 @@
try {
writer.flush();
writer.close();
- } catch (IOException e) {;
+ } catch (IOException e) {
+ ;
}
}
}
diff --git a/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/ISession.java b/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/ISession.java
index 3324d5d..85a8c9c 100644
--- a/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/ISession.java
+++ b/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/ISession.java
@@ -72,17 +72,23 @@
void setTimeZoneOfSession(String zoneId);
- /** @deprecated Use {@link #createDatabase(String)} instead. */
+ /**
+ * @deprecated Use {@link #createDatabase(String)} instead.
+ */
@Deprecated
void setStorageGroup(String storageGroup)
throws IoTDBConnectionException, StatementExecutionException;
- /** @deprecated Use {@link #deleteDatabase(String)} instead. */
+ /**
+ * @deprecated Use {@link #deleteDatabase(String)} instead.
+ */
@Deprecated
void deleteStorageGroup(String storageGroup)
throws IoTDBConnectionException, StatementExecutionException;
- /** @deprecated Use {@link #deleteDatabases(List)} instead. */
+ /**
+ * @deprecated Use {@link #deleteDatabases(List)} instead.
+ */
@Deprecated
void deleteStorageGroups(List<String> storageGroups)
throws IoTDBConnectionException, StatementExecutionException;
@@ -509,34 +515,46 @@
long getQueryTimeout();
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default SystemStatus getSystemStatus() {
return SystemStatus.NORMAL;
}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default void createTimeseriesOfTemplateOnPath(String path)
throws IoTDBConnectionException, StatementExecutionException {}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default void deactivateTemplateOn(String templateName, String prefixPath)
throws IoTDBConnectionException, StatementExecutionException {}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default void operationSyncTransmit(ByteBuffer buffer)
throws IoTDBConnectionException, StatementExecutionException {}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default boolean isEnableCacheLeader() {
return true;
}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default void setEnableCacheLeader(boolean enableCacheLeader) {}
}
diff --git a/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/SessionConfig.java b/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/SessionConfig.java
index e43b771..a095b5e 100644
--- a/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/SessionConfig.java
+++ b/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/SessionConfig.java
@@ -37,6 +37,7 @@
public static final int RETRY_NUM = 3;
public static final long RETRY_INTERVAL_MS = 1000;
public static final long DEFAULT_QUERY_TIME_OUT = 60000;
+
/** thrift init buffer size, 1KB by default */
public static final int DEFAULT_INITIAL_BUFFER_CAPACITY = 1024;
diff --git a/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/pool/ISessionPool.java b/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/pool/ISessionPool.java
index 090fb8e..eeb6509 100644
--- a/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/pool/ISessionPool.java
+++ b/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/pool/ISessionPool.java
@@ -96,7 +96,9 @@
List<List<Object>> valuesList)
throws IoTDBConnectionException, StatementExecutionException;
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
void insertOneDeviceRecords(
String deviceId,
@@ -122,7 +124,9 @@
boolean haveSorted)
throws IoTDBConnectionException, StatementExecutionException;
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
void insertOneDeviceRecords(
String deviceId,
@@ -271,17 +275,23 @@
void deleteData(List<String> paths, long startTime, long endTime)
throws IoTDBConnectionException, StatementExecutionException;
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
void setStorageGroup(String storageGroupId)
throws IoTDBConnectionException, StatementExecutionException;
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
void deleteStorageGroup(String storageGroup)
throws IoTDBConnectionException, StatementExecutionException;
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
void deleteStorageGroups(List<String> storageGroup)
throws IoTDBConnectionException, StatementExecutionException;
@@ -319,7 +329,9 @@
List<String> measurementAliasList)
throws IoTDBConnectionException, StatementExecutionException;
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
@SuppressWarnings("squid:S107") // ignore Methods should not have too many parameters
void createAlignedTimeseries(
@@ -360,7 +372,9 @@
boolean isAligned)
throws IOException, IoTDBConnectionException, StatementExecutionException;
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
void createSchemaTemplate(
String name,
@@ -544,17 +558,23 @@
long getQueryTimeout();
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default void createTimeseriesOfTemplateOnPath(String path)
throws IoTDBConnectionException, StatementExecutionException {}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default void deactivateTempalte(String templateName, String prefixPath)
throws IoTDBConnectionException, StatementExecutionException {}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default SessionDataSetWrapper executeRawDataQuery(
List<String> paths, long startTime, long endTime)
@@ -562,20 +582,26 @@
return null;
}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default boolean operationSyncTransmit(ByteBuffer buffer)
throws IoTDBConnectionException, StatementExecutionException {
return false;
}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default SystemStatus getSystemStatus() throws IoTDBConnectionException {
return SystemStatus.NORMAL;
}
- /** @deprecated */
+ /**
+ * @deprecated
+ */
@Deprecated
default boolean isEnableCacheLeader() {
return false;
diff --git a/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/pool/SessionDataSetWrapper.java b/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/pool/SessionDataSetWrapper.java
index 77f347b..408b22f 100644
--- a/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/pool/SessionDataSetWrapper.java
+++ b/iotdb-client/isession/src/main/java/org/apache/iotdb/isession/pool/SessionDataSetWrapper.java
@@ -67,6 +67,7 @@
}
return next;
}
+
/**
* If there is an Exception, and you do not want to use the resultset anymore, you have to release
* the resultset manually by calling closeResultSet
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/AbstractIoTDBJDBCResultSet.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/AbstractIoTDBJDBCResultSet.java
index afda243..43c6ea9 100644
--- a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/AbstractIoTDBJDBCResultSet.java
+++ b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/AbstractIoTDBJDBCResultSet.java
@@ -725,7 +725,9 @@
return false;
}
- /** @return true means has results */
+ /**
+ * @return true means has results
+ */
abstract boolean fetchResults() throws SQLException;
abstract boolean hasCachedResults();
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/Config.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/Config.java
index adb0125..407f07e 100644
--- a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/Config.java
+++ b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/Config.java
@@ -35,6 +35,7 @@
public static final String IOTDB_ERROR_PREFIX = "Error";
static final String IOTDB_DEFAULT_HOST = "localhost";
+
/** If host is provided, without a port. */
static final int IOTDB_DEFAULT_PORT = 6667;
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java
index 9f8142f..3da9071 100644
--- a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java
+++ b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java
@@ -75,6 +75,7 @@
private boolean isClosed = true;
private SQLWarning warningChain = null;
private TTransport transport;
+
/**
* Timeout of query can be set by users. Unit: s If not set, default value 0 will be used, which
* will use server configuration.
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java
index e2db05d..49039e5 100644
--- a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java
+++ b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java
@@ -1483,6 +1483,7 @@
public int getMaxBinaryLiteralLength() {
return Integer.MAX_VALUE;
}
+
/** Although there is no limit, it is not recommended */
@Override
public int getMaxCatalogNameLength() {
@@ -1493,6 +1494,7 @@
public int getMaxCharLiteralLength() {
return Integer.MAX_VALUE;
}
+
/** Although there is no limit, it is not recommended */
@Override
public int getMaxColumnNameLength() {
@@ -1549,11 +1551,13 @@
public int getMaxProcedureNameLength() {
return 0;
}
+
/** maxrowsize unlimited */
@Override
public int getMaxRowSize() {
return 2147483639;
}
+
/** Although there is no limit, it is not recommended */
@Override
public int getMaxSchemaNameLength() {
@@ -1574,16 +1578,19 @@
public int getMaxStatements() {
return 0;
}
+
/** Although there is no limit, it is not recommended */
@Override
public int getMaxTableNameLength() {
return 1024;
}
+
/** Although there is no limit, it is not recommended */
@Override
public int getMaxTablesInSelect() {
return 1024;
}
+
/** Although there is no limit, it is not recommended */
@Override
public int getMaxUserNameLength() {
@@ -3367,7 +3374,9 @@
return false;
}
- /** @deprecated recommend using getMetadataInJson() instead of toString() */
+ /**
+ * @deprecated recommend using getMetadataInJson() instead of toString()
+ */
@SuppressWarnings("squid:S1133") // ignore Deprecated code should be removed
@Deprecated
@Override
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDriver.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDriver.java
index 82bcb4d..db6e9e7 100644
--- a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDriver.java
+++ b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDriver.java
@@ -36,6 +36,7 @@
public class IoTDBDriver implements Driver {
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(IoTDBDriver.class);
+
/** Is this driver JDBC compliant. */
private static final boolean TSFILE_JDBC_COMPLIANT = false;
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignJDBCResultSet.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignJDBCResultSet.java
index facfaed..5303520 100644
--- a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignJDBCResultSet.java
+++ b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignJDBCResultSet.java
@@ -54,6 +54,7 @@
private TSQueryNonAlignDataSet tsQueryNonAlignDataSet;
private byte[][] times; // used for disable align
private List<String> sgColumns = null;
+
// for disable align clause
@SuppressWarnings("squid:S107") // ignore Methods should not have too many parameters
IoTDBNonAlignJDBCResultSet(
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java
index 1c95abe..ab2e598 100644
--- a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java
+++ b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java
@@ -61,6 +61,7 @@
private List<String> batchSQLList;
private static final String NOT_SUPPORT_EXECUTE = "Not support execute";
private static final String NOT_SUPPORT_EXECUTE_UPDATE = "Not support executeUpdate";
+
/** Keep state so we can fail certain calls made after close(). */
private boolean isClosed = false;
diff --git a/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java b/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
index e91f3ca..5ee3a81 100644
--- a/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
+++ b/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
@@ -40,6 +40,7 @@
/** How big should the default read and write buffers be? Defaults to 1KB */
public static final int THRIFT_DEFAULT_BUF_CAPACITY = 1024;
+
/**
* It is used to prevent the size of the parsing package from being too large and allocating the
* buffer will cause oom. Therefore, the maximum length of the requested memory is limited when
diff --git a/iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java b/iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java
index 02be219..6c0a42e 100644
--- a/iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java
+++ b/iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java
@@ -126,6 +126,7 @@
protected boolean useSSL;
protected String trustStore;
protected String trustStorePwd;
+
/**
* Timeout of query can be set by users. A negative number means using the default configuration
* of server. And value 0 will disable the function of query timeout.
@@ -3539,7 +3540,9 @@
defaultSessionConnection.pruneSchemaTemplate(req);
}
- /** @return Amount of measurements in the template */
+ /**
+ * @return Amount of measurements in the template
+ */
@Override
public int countMeasurementsInTemplate(String name)
throws StatementExecutionException, IoTDBConnectionException {
@@ -3550,7 +3553,9 @@
return resp.getCount();
}
- /** @return If the node specified by the path is a measurement. */
+ /**
+ * @return If the node specified by the path is a measurement.
+ */
@Override
public boolean isMeasurementInTemplate(String templateName, String path)
throws StatementExecutionException, IoTDBConnectionException {
@@ -3562,7 +3567,9 @@
return resp.result;
}
- /** @return if there is a node correspond to the path in the template. */
+ /**
+ * @return if there is a node correspond to the path in the template.
+ */
@Override
public boolean isPathExistInTemplate(String templateName, String path)
throws StatementExecutionException, IoTDBConnectionException {
@@ -3574,7 +3581,9 @@
return resp.result;
}
- /** @return All paths of measurements in the template. */
+ /**
+ * @return All paths of measurements in the template.
+ */
@Override
public List<String> showMeasurementsInTemplate(String templateName)
throws StatementExecutionException, IoTDBConnectionException {
@@ -3586,7 +3595,9 @@
return resp.getMeasurements();
}
- /** @return All paths of measurements under the pattern in the template. */
+ /**
+ * @return All paths of measurements under the pattern in the template.
+ */
@Override
public List<String> showMeasurementsInTemplate(String templateName, String pattern)
throws StatementExecutionException, IoTDBConnectionException {
@@ -3598,7 +3609,9 @@
return resp.getMeasurements();
}
- /** @return All template names. */
+ /**
+ * @return All template names.
+ */
@Override
public List<String> showAllTemplates()
throws StatementExecutionException, IoTDBConnectionException {
@@ -3609,7 +3622,9 @@
return resp.getMeasurements();
}
- /** @return All paths have been set to designated template. */
+ /**
+ * @return All paths have been set to designated template.
+ */
@Override
public List<String> showPathsTemplateSetOn(String templateName)
throws StatementExecutionException, IoTDBConnectionException {
@@ -3620,7 +3635,9 @@
return resp.getMeasurements();
}
- /** @return All paths are using designated template. */
+ /**
+ * @return All paths are using designated template.
+ */
@Override
public List<String> showPathsTemplateUsingOn(String templateName)
throws StatementExecutionException, IoTDBConnectionException {
diff --git a/iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java b/iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java
index 1f10b62..c51a6b2 100644
--- a/iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java
+++ b/iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java
@@ -2021,7 +2021,9 @@
}
}
- /** @deprecated Use {@link #createDatabase(String)} instead. */
+ /**
+ * @deprecated Use {@link #createDatabase(String)} instead.
+ */
@Deprecated
@Override
public void setStorageGroup(String storageGroupId)
@@ -2047,7 +2049,9 @@
}
}
- /** @deprecated Use {@link #deleteDatabase(String)} instead. */
+ /**
+ * @deprecated Use {@link #deleteDatabase(String)} instead.
+ */
@Deprecated
@Override
public void deleteStorageGroup(String storageGroup)
@@ -2073,7 +2077,9 @@
}
}
- /** @deprecated Use {@link #deleteDatabases(List)} instead. */
+ /**
+ * @deprecated Use {@link #deleteDatabases(List)} instead.
+ */
@Deprecated
@Override
public void deleteStorageGroups(List<String> storageGroup)
diff --git a/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFInputFormat.java b/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFInputFormat.java
index f38cc08..a943db9 100644
--- a/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFInputFormat.java
+++ b/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFInputFormat.java
@@ -47,16 +47,22 @@
/** key to configure whether reading time enable */
public static final String READ_TIME_ENABLE = "tsfile.read.time.enable";
+
/** key to configure whether reading deltaObjectId enable */
public static final String READ_DELTAOBJECT_ENABLE = "tsfile.read.deltaObjectId.enable";
+
/** key to configure the type of filter */
@Deprecated public static final String FILTER_TYPE = "tsfile.filter.type";
+
/** key to configure the filter */
@Deprecated public static final String FILTER_EXPRESSION = "tsfile.filter.expression";
+
/** key to configure whether filtering is enable */
public static final String FILTER_EXIST = "tsfile.filter.exist";
+
/** key to configure the reading deltaObjectIds */
public static final String READ_DELTAOBJECTS = "tsfile.read.deltaobject";
+
/** key to configure the reading measurementIds */
public static final String READ_MEASUREMENTID = "tsfile.read.measurement";
diff --git a/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFRecordReader.java b/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFRecordReader.java
index 49bcf86..ab21d06 100644
--- a/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFRecordReader.java
+++ b/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFRecordReader.java
@@ -55,6 +55,7 @@
/** all */
private List<QueryDataSet> dataSetList = new ArrayList<>();
+
/**
* List for name of devices. The order corresponds to the order of dataSetList. Means that
* deviceIdList[i] is the name of device for dataSetList[i].
@@ -62,6 +63,7 @@
private List<String> deviceIdList = new ArrayList<>();
private List<Field> fields = null;
+
/** The index of QueryDataSet that is currently processed */
private int currentIndex = 0;
diff --git a/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/record/HDFSTSRecord.java b/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/record/HDFSTSRecord.java
index 21173b5..8877041 100644
--- a/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/record/HDFSTSRecord.java
+++ b/iotdb-connector/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/record/HDFSTSRecord.java
@@ -43,8 +43,10 @@
/** timestamp of this TSRecord. */
private long time;
+
/** deviceId of this TSRecord. */
private String deviceId;
+
/** all value of this TSRecord. */
private List<DataPoint> dataPointList = new ArrayList<>();
diff --git a/iotdb-connector/hive-connector/src/main/java/org/apache/iotdb/hive/TSFHiveRecordReader.java b/iotdb-connector/hive-connector/src/main/java/org/apache/iotdb/hive/TSFHiveRecordReader.java
index b99869b..9603318 100644
--- a/iotdb-connector/hive-connector/src/main/java/org/apache/iotdb/hive/TSFHiveRecordReader.java
+++ b/iotdb-connector/hive-connector/src/main/java/org/apache/iotdb/hive/TSFHiveRecordReader.java
@@ -47,11 +47,13 @@
/** all datasets corresponding to one specific split */
private List<QueryDataSet> dataSetList = new ArrayList<>();
+
/**
* List for name of devices. The order corresponds to the order of dataSetList. Means that
* deviceIdList[i] is the name of device for dataSetList[i].
*/
private List<String> deviceIdList = new ArrayList<>();
+
/** The index of QueryDataSet that is currently processed */
private int currentIndex = 0;
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
index 387fe1a..241274b 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
@@ -601,21 +601,27 @@
"%s, There are no other DataNodes could be selected to perform the add peer process, "
+ "please check RegionGroup: %s by show regions sql command",
REGION_MIGRATE_PROCESS, regionGroupId);
- } else if (configManager.getPartitionManager()
- .getAllReplicaSets(originalDataNode.getDataNodeId()).stream()
+ } else if (configManager
+ .getPartitionManager()
+ .getAllReplicaSets(originalDataNode.getDataNodeId())
+ .stream()
.noneMatch(replicaSet -> replicaSet.getRegionId().equals(regionGroupId))) {
failMessage =
String.format(
"Submit RegionMigrateProcedure failed, because the original DataNode %s doesn't contain Region %s",
migrateRegionReq.getFromId(), migrateRegionReq.getRegionId());
- } else if (configManager.getPartitionManager().getAllReplicaSets(destDataNode.getDataNodeId())
+ } else if (configManager
+ .getPartitionManager()
+ .getAllReplicaSets(destDataNode.getDataNodeId())
.stream()
.anyMatch(replicaSet -> replicaSet.getRegionId().equals(regionGroupId))) {
failMessage =
String.format(
"Submit RegionMigrateProcedure failed, because the target DataNode %s already contains Region %s",
migrateRegionReq.getToId(), migrateRegionReq.getRegionId());
- } else if (!configManager.getNodeManager().filterDataNodeThroughStatus(NodeStatus.Running)
+ } else if (!configManager
+ .getNodeManager()
+ .filterDataNodeThroughStatus(NodeStatus.Running)
.stream()
.map(TDataNodeConfiguration::getLocation)
.map(TDataNodeLocation::getDataNodeId)
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/consensus/ConsensusManager.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/consensus/ConsensusManager.java
index be7e97e..e28aee7 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/consensus/ConsensusManager.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/consensus/ConsensusManager.java
@@ -69,6 +69,7 @@
private static final long MAX_WAIT_READY_TIME_MS =
CommonDescriptor.getInstance().getConfig().getConnectionTimeoutInMS() / 2;
private static final long RETRY_WAIT_TIME_MS = 100;
+
/** There is only one ConfigNodeGroup */
public static final ConsensusGroupId DEFAULT_CONSENSUS_GROUP_ID =
new ConfigRegionId(CONF.getConfigRegionId());
@@ -340,7 +341,9 @@
return consensusImpl.isLeaderReady(DEFAULT_CONSENSUS_GROUP_ID);
}
- /** @return ConfigNode-leader peer if leader exists, null otherwise. */
+ /**
+ * @return ConfigNode-leader peer if leader exists, null otherwise.
+ */
private Peer getLeaderPeer() {
for (int retry = 0; retry < 50; retry++) {
Peer leaderPeer = consensusImpl.getLeader(DEFAULT_CONSENSUS_GROUP_ID);
@@ -357,7 +360,9 @@
return null;
}
- /** @return ConfigNode-leader's location if leader exists, null otherwise. */
+ /**
+ * @return ConfigNode-leader's location if leader exists, null otherwise.
+ */
public TConfigNodeLocation getLeaderLocation() {
Peer leaderPeer = getLeaderPeer();
if (leaderPeer != null) {
@@ -369,7 +374,9 @@
return null;
}
- /** @return true if ConfigNode-leader is elected, false otherwise. */
+ /**
+ * @return true if ConfigNode-leader is elected, false otherwise.
+ */
public boolean isLeaderExist() {
return getLeaderPeer() != null;
}
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/RouteBalancer.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/RouteBalancer.java
index 79ca434..7356e42 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/RouteBalancer.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/RouteBalancer.java
@@ -331,7 +331,9 @@
}
}
- /** @return Map<RegionGroupId, RegionPriority> */
+ /**
+ * @return Map<RegionGroupId, RegionPriority>
+ */
public Map<TConsensusGroupId, TRegionReplicaSet> getRegionPriorityMap() {
priorityMapLock.readLock().lock();
try {
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/router/leader/MinCostFlowLeaderBalancer.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/router/leader/MinCostFlowLeaderBalancer.java
index daf1d15..8f9e8dd 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/router/leader/MinCostFlowLeaderBalancer.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/router/leader/MinCostFlowLeaderBalancer.java
@@ -43,6 +43,7 @@
/** Graph nodes */
// Super source node
private static final int S_NODE = 0;
+
// Super terminal node
private static final int T_NODE = 1;
// Maximum index of graph nodes
@@ -320,7 +321,9 @@
}
}
- /** @return Map<RegionGroupId, DataNodeId where the new leader locate> */
+ /**
+ * @return Map<RegionGroupId, DataNodeId where the new leader locate>
+ */
private Map<TConsensusGroupId, Integer> collectLeaderDistribution() {
Map<TConsensusGroupId, Integer> result = new ConcurrentHashMap<>();
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/node/BaseNodeCache.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/node/BaseNodeCache.java
index f51026e..4eeb963 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/node/BaseNodeCache.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/node/BaseNodeCache.java
@@ -50,12 +50,16 @@
return ((NodeStatistics) currentStatistics.get()).getLoadScore();
}
- /** @return The current status of the Node. */
+ /**
+ * @return The current status of the Node.
+ */
public NodeStatus getNodeStatus() {
return ((NodeStatistics) currentStatistics.get()).getStatus();
}
- /** @return The reason why lead to current NodeStatus. */
+ /**
+ * @return The reason why lead to current NodeStatus.
+ */
public String getNodeStatusWithReason() {
NodeStatistics statistics = (NodeStatistics) this.currentStatistics.get();
return statistics.getStatusReason() == null
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java
index 5daf89f..fcb354b 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java
@@ -137,6 +137,7 @@
/** Region cleaner. */
// Monitor for leadership change
private final Object scheduleMonitor = new Object();
+
// Try to delete Regions in every 10s
private static final int REGION_MAINTAINER_WORK_INTERVAL = 10;
private final ScheduledExecutorService regionMaintainer;
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtask.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtask.java
index 376548b..6785e45 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtask.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtask.java
@@ -52,6 +52,7 @@
// Pipe plugins for this subtask
private PipeExtractor extractor;
+
// TODO: currently unused
@SuppressWarnings("unused")
private PipeProcessor processor;
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtaskExecutor.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtaskExecutor.java
index 1a34ab4..9a82e72 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtaskExecutor.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/execution/PipeConfigNodeSubtaskExecutor.java
@@ -31,7 +31,9 @@
super(THREAD_NUM, ThreadName.PIPE_CONFIGNODE_EXECUTOR_POOL);
}
- /** @param ignored Used to distinguish this constructor from the default constructor. */
+ /**
+ * @param ignored Used to distinguish this constructor from the default constructor.
+ */
@TestOnly
public PipeConfigNodeSubtaskExecutor(Object ignored) {
super(THREAD_NUM, ThreadName.PIPE_CONFIGNODE_EXECUTOR_POOL);
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/executor/ConfigPlanExecutor.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/executor/ConfigPlanExecutor.java
index 8bce698..f476340 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/executor/ConfigPlanExecutor.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/executor/ConfigPlanExecutor.java
@@ -580,8 +580,7 @@
}
AtomicBoolean result = new AtomicBoolean(true);
- snapshotProcessorList
- .parallelStream()
+ snapshotProcessorList.parallelStream()
.forEach(
x -> {
try {
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/node/NodeInfo.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/node/NodeInfo.java
index 1ba65aa..155a381 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/node/NodeInfo.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/node/NodeInfo.java
@@ -277,7 +277,9 @@
return result;
}
- /** @return All registered DataNodes. */
+ /**
+ * @return All registered DataNodes.
+ */
public List<TDataNodeConfiguration> getRegisteredDataNodes() {
List<TDataNodeConfiguration> result;
dataNodeInfoReadWriteLock.readLock().lock();
@@ -289,7 +291,9 @@
return result;
}
- /** @return The specified registered DataNode. */
+ /**
+ * @return The specified registered DataNode.
+ */
public TDataNodeConfiguration getRegisteredDataNode(int dataNodeId) {
dataNodeInfoReadWriteLock.readLock().lock();
try {
@@ -299,7 +303,9 @@
}
}
- /** @return The specified registered DataNodes. */
+ /**
+ * @return The specified registered DataNodes.
+ */
public List<TDataNodeConfiguration> getRegisteredDataNodes(List<Integer> dataNodeIds) {
List<TDataNodeConfiguration> result = new ArrayList<>();
dataNodeInfoReadWriteLock.readLock().lock();
@@ -404,7 +410,9 @@
return new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode());
}
- /** @return All registered ConfigNodes. */
+ /**
+ * @return All registered ConfigNodes.
+ */
public List<TConfigNodeLocation> getRegisteredConfigNodes() {
List<TConfigNodeLocation> result;
configNodeInfoReadWriteLock.readLock().lock();
@@ -416,7 +424,9 @@
return result;
}
- /** @return The specified registered ConfigNode. */
+ /**
+ * @return The specified registered ConfigNode.
+ */
public List<TConfigNodeLocation> getRegisteredConfigNodes(List<Integer> configNodeIds) {
List<TConfigNodeLocation> result = new ArrayList<>();
configNodeInfoReadWriteLock.readLock().lock();
@@ -433,7 +443,9 @@
return result;
}
- /** @return all nodes buildInfo */
+ /**
+ * @return all nodes buildInfo
+ */
public Map<Integer, TNodeVersionInfo> getNodeVersionInfo() {
Map<Integer, TNodeVersionInfo> result = new HashMap<>(nodeVersionInfo.size());
versionInfoReadWriteLock.readLock().lock();
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/DatabasePartitionTable.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/DatabasePartitionTable.java
index 8ad66b1..1ff56a8 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/DatabasePartitionTable.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/DatabasePartitionTable.java
@@ -113,7 +113,9 @@
new RegionGroup(CommonDateTimeUtils.currentTime(), replicaSet)));
}
- /** @return Deep copy of all Regions' RegionReplicaSet within one StorageGroup */
+ /**
+ * @return Deep copy of all Regions' RegionReplicaSet within one StorageGroup
+ */
public Stream<TRegionReplicaSet> getAllReplicaSets() {
return regionGroupMap.values().stream().map(RegionGroup::getReplicaSet);
}
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/PartitionInfo.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/PartitionInfo.java
index 9fdf668..fe48dd5 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/PartitionInfo.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/PartitionInfo.java
@@ -119,6 +119,7 @@
/** For Cluster Partition. */
// For allocating Regions
private final AtomicInteger nextRegionGroupId;
+
// Map<DatabaseName, DatabasePartitionInfo>
private final Map<String, DatabasePartitionTable> databasePartitionTables;
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/RegionGroup.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/RegionGroup.java
index 048ccab..0b268e7 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/RegionGroup.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/RegionGroup.java
@@ -100,7 +100,9 @@
replicaSet.getDataNodeLocations().sort(TDataNodeLocation::compareTo);
}
- /** @param deltaMap Map<TSeriesPartitionSlot, Delta TTimePartitionSlot Count> */
+ /**
+ * @param deltaMap Map<TSeriesPartitionSlot, Delta TTimePartitionSlot Count>
+ */
public void updateSlotCountMap(Map<TSeriesPartitionSlot, AtomicLong> deltaMap) {
deltaMap.forEach(
((seriesPartitionSlot, delta) -> {
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java
index 55a3972..7d1d528 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java
@@ -274,7 +274,9 @@
}
}
- /** @return The number of matched Databases by the specified Database pattern */
+ /**
+ * @return The number of matched Databases by the specified Database pattern
+ */
public CountDatabaseResp countMatchedDatabases(CountDatabasePlan plan) {
CountDatabaseResp result = new CountDatabaseResp();
databaseReadWriteLock.readLock().lock();
@@ -293,7 +295,9 @@
return result;
}
- /** @return All DatabaseSchemas that matches to the specified Database pattern */
+ /**
+ * @return All DatabaseSchemas that matches to the specified Database pattern
+ */
public DatabaseSchemaResp getMatchedDatabaseSchemas(GetDatabasePlan plan) {
DatabaseSchemaResp result = new DatabaseSchemaResp();
databaseReadWriteLock.readLock().lock();
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java
index f0a6378..7566087 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java
@@ -587,7 +587,9 @@
// ==========================================================================
// runtime state - timeout related
// ==========================================================================
- /** @param timeout timeout interval in msec */
+ /**
+ * @param timeout timeout interval in msec
+ */
protected void setTimeout(long timeout) {
this.timeout = timeout;
}
@@ -596,7 +598,9 @@
return timeout != NO_TIMEOUT;
}
- /** @return the timeout in msec */
+ /**
+ * @return the timeout in msec
+ */
public long getTimeout() {
return timeout;
}
@@ -630,12 +634,16 @@
// ==========================================================================
// runtime state
// ==========================================================================
- /** @return the time elapsed between the last update and the start time of the procedure. */
+ /**
+ * @return the time elapsed between the last update and the start time of the procedure.
+ */
public long elapsedTime() {
return getLastUpdate() - getSubmittedTime();
}
- /** @return the serialized result if any, otherwise null */
+ /**
+ * @return the serialized result if any, otherwise null
+ */
public byte[] getResult() {
return result.get();
}
@@ -679,7 +687,9 @@
// just because the procedure can get scheduled on different executor threads on each step.
// ==============================================================================================
- /** @return true if the procedure is in a RUNNABLE state. */
+ /**
+ * @return true if the procedure is in a RUNNABLE state.
+ */
public synchronized boolean isRunnable() {
return state == ProcedureState.RUNNABLE;
}
@@ -688,12 +698,16 @@
return state == ProcedureState.INITIALIZING;
}
- /** @return true if the procedure has failed. It may or may not have rolled back. */
+ /**
+ * @return true if the procedure has failed. It may or may not have rolled back.
+ */
public synchronized boolean isFailed() {
return state == ProcedureState.FAILED || state == ProcedureState.ROLLEDBACK;
}
- /** @return true if the procedure is finished successfully. */
+ /**
+ * @return true if the procedure is finished successfully.
+ */
public synchronized boolean isSuccess() {
return state == ProcedureState.SUCCESS && !hasException();
}
@@ -706,7 +720,9 @@
return isSuccess() || state == ProcedureState.ROLLEDBACK;
}
- /** @return true if the procedure is waiting for a child to finish or for an external event. */
+ /**
+ * @return true if the procedure is waiting for a child to finish or for an external event.
+ */
public synchronized boolean isWaiting() {
switch (state) {
case WAITING:
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java
index 6719324..65dfe8c 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java
@@ -772,7 +772,9 @@
return getName() + "(pid=" + (p == null ? NO_PROC_ID : p.getProcId() + ")");
}
- /** @return the time since the current procedure is running */
+ /**
+ * @return the time since the current procedure is running
+ */
public long getCurrentRunTime() {
return System.currentTimeMillis() - startTime.get();
}
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/scheduler/ProcedureScheduler.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/scheduler/ProcedureScheduler.java
index 33ff7cf..a55fd0b 100644
--- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/scheduler/ProcedureScheduler.java
+++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/scheduler/ProcedureScheduler.java
@@ -75,7 +75,9 @@
*/
void yield(Procedure proc);
- /** @return true if there are procedures available to process, otherwise false. */
+ /**
+ * @return true if there are procedures available to process, otherwise false.
+ */
boolean hasRunnables();
/**
diff --git a/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/service/IoTConsensusRPCService.java b/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/service/IoTConsensusRPCService.java
index 7be6dbe..1be3b67 100644
--- a/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/service/IoTConsensusRPCService.java
+++ b/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/service/IoTConsensusRPCService.java
@@ -62,8 +62,11 @@
@Override
public void initTProcessor()
- throws ClassNotFoundException, IllegalAccessException, InstantiationException,
- NoSuchMethodException, InvocationTargetException {
+ throws ClassNotFoundException,
+ IllegalAccessException,
+ InstantiationException,
+ NoSuchMethodException,
+ InvocationTargetException {
processor = new IoTConsensusIService.AsyncProcessor<>(iotConsensusRPCServiceProcessor);
}
diff --git a/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/metrics/IoTDBMetricRegistry.java b/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/metrics/IoTDBMetricRegistry.java
index 8a1de5e..41619b2 100644
--- a/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/metrics/IoTDBMetricRegistry.java
+++ b/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/metrics/IoTDBMetricRegistry.java
@@ -44,26 +44,35 @@
private final Map<String, CounterProxy> counterCache = new ConcurrentHashMap<>();
private final Map<String, TimerProxy> timerCache = new ConcurrentHashMap<>();
private final Map<String, Boolean> gaugeCache = new ConcurrentHashMap<>();
+
/** Time taken to flush log. */
public static final String RAFT_LOG_FLUSH_TIME = "flushTime";
+
/** Size of SegmentedRaftLogCache::closedSegments in bytes. */
public static final String RAFT_LOG_CACHE_CLOSED_SEGMENTS_SIZE_IN_BYTES =
"closedSegmentsSizeInBytes";
+
/** Size of SegmentedRaftLogCache::openSegment in bytes. */
public static final String RAFT_LOG_CACHE_OPEN_SEGMENT_SIZE_IN_BYTES = "openSegmentSizeInBytes";
+
/** Total time taken to append a raft log entry. */
public static final String RAFT_LOG_APPEND_ENTRY_LATENCY = "appendEntryLatency";
+
/**
* Time taken for a Raft log operation to get into the queue after being requested. This is the
* time that it has to wait for the queue to be non-full.
*/
public static final String RAFT_LOG_TASK_ENQUEUE_DELAY = "queueingDelay";
+
/** Time spent by a Raft log operation in the queue. */
public static final String RAFT_LOG_TASK_QUEUE_TIME = "enqueuedTime";
+
/** Time taken for a Raft log operation to complete execution. */
public static final String RAFT_LOG_TASK_EXECUTION_TIME = "ExecutionTime";
+
/** Time taken for followers to append log entries. */
public static final String FOLLOWER_APPEND_ENTRIES_LATENCY = "follower_append_entry_latency";
+
/** Time taken to process write requests from client. */
public static final String RAFT_CLIENT_WRITE_REQUEST = "clientWriteRequest";
diff --git a/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/utils/RetryPolicy.java b/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/utils/RetryPolicy.java
index a8da79d..6320ef8 100644
--- a/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/utils/RetryPolicy.java
+++ b/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/utils/RetryPolicy.java
@@ -25,6 +25,7 @@
public class RetryPolicy<RESP> {
private final Function<RESP, Boolean> retryHandler;
+
/** -1 means retry indefinitely */
private final int maxAttempts;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBStartCheck.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBStartCheck.java
index 42995ff..c5d22f3 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBStartCheck.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBStartCheck.java
@@ -98,6 +98,7 @@
variableParamValueTable.put(
DATA_REGION_CONSENSUS_PORT, () -> String.valueOf(config.getDataRegionConsensusPort()));
}
+
// endregion
// region params don't need checking, determined by the system
private static final String IOTDB_VERSION_STRING = "iotdb_version";
@@ -108,6 +109,7 @@
// endregion
// region params of old versions
private static final String VIRTUAL_STORAGE_GROUP_NUM = "virtual_storage_group_num";
+
// endregion
public static IoTDBStartCheck getInstance() {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/rest/IoTDBRestServiceConfig.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/rest/IoTDBRestServiceConfig.java
index 4639ce4..50c6980 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/rest/IoTDBRestServiceConfig.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/rest/IoTDBRestServiceConfig.java
@@ -22,6 +22,7 @@
public class IoTDBRestServiceConfig {
static final String CONFIG_NAME = "iotdb-datanode.properties";
static final String OLD_CONFIG_NAME = "iotdb-common.properties";
+
/** If the enableRestService is true, we will start REST Service. */
private boolean enableRestService = false;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java
index b8ace00..327fe61 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java
@@ -381,15 +381,11 @@
dataRegionPipeTasks.parallelStream().forEach(PipeTask::drop);
// Stop schema region tasks
- pipeTaskManager
- .getPipeTasks(pipeMeta.getStaticMeta())
- .values()
- .parallelStream()
+ pipeTaskManager.getPipeTasks(pipeMeta.getStaticMeta()).values().parallelStream()
.forEach(PipeTask::stop);
// Re-create data region tasks
- dataRegionPipeTasks
- .parallelStream()
+ dataRegionPipeTasks.parallelStream()
.forEach(
pipeTask -> {
final PipeTask newPipeTask =
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/TsFileInsertionDataContainer.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/TsFileInsertionDataContainer.java
index 1c1f0d0..2081a540 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/TsFileInsertionDataContainer.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/TsFileInsertionDataContainer.java
@@ -196,7 +196,9 @@
return deviceIsAlignedResultMap;
}
- /** @return {@link TabletInsertionEvent} in a streaming way */
+ /**
+ * @return {@link TabletInsertionEvent} in a streaming way
+ */
public Iterable<TabletInsertionEvent> toTabletInsertionEvents() {
return () ->
new Iterator<TabletInsertionEvent>() {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/realtime/PipeRealtimeDataRegionExtractor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/realtime/PipeRealtimeDataRegionExtractor.java
index 2c37ca0..b8c5a71 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/realtime/PipeRealtimeDataRegionExtractor.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/realtime/PipeRealtimeDataRegionExtractor.java
@@ -232,7 +232,9 @@
});
}
- /** @param event the {@link Event} from the {@link StorageEngine} */
+ /**
+ * @param event the {@link Event} from the {@link StorageEngine}
+ */
public final void extract(PipeRealtimeEvent event) {
if (isDbNameCoveredByPattern) {
event.skipParsingPattern();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/downsampling/sdt/SwingingDoorTrendingFilter.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/downsampling/sdt/SwingingDoorTrendingFilter.java
index bb4825b..cdbae8f 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/downsampling/sdt/SwingingDoorTrendingFilter.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/downsampling/sdt/SwingingDoorTrendingFilter.java
@@ -30,6 +30,7 @@
* open up
*/
private double upperDoor;
+
/**
* The minimum curLowerSlope between the lastStoredPoint to the current point lowerDoor can only
* open downward
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/client/ConfigNodeInfo.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/client/ConfigNodeInfo.java
index 4726366..d9fe03d 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/client/ConfigNodeInfo.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/client/ConfigNodeInfo.java
@@ -80,6 +80,7 @@
}
}
}
+
// TODO: This needs removal of statics ...
public static void reinitializeStatics() {
ConfigNodeInfoHolder.INSTANCE = new ConfigNodeInfo();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/utils/InsertTabletSortDataUtils.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/utils/InsertTabletSortDataUtils.java
index d69e89c..e2e3d2f 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/utils/InsertTabletSortDataUtils.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/utils/InsertTabletSortDataUtils.java
@@ -49,6 +49,7 @@
}
return sortedValues;
}
+
/**
* Sort the input source list.
*
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/session/SessionManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/session/SessionManager.java
index edf0259..647a472 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/session/SessionManager.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/session/SessionManager.java
@@ -61,6 +61,7 @@
public class SessionManager implements SessionManagerMBean {
private static final Logger LOGGER = LoggerFactory.getLogger(SessionManager.class);
+
// When the client abnormally exits, we can still know who to disconnect
/** currSession can be only used in client-thread model services. */
private final ThreadLocal<IClientSession> currSession = new ThreadLocal<>();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/schematree/ClusterSchemaTree.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/schematree/ClusterSchemaTree.java
index 2af8693..1ffa382 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/schematree/ClusterSchemaTree.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/schematree/ClusterSchemaTree.java
@@ -70,6 +70,7 @@
/** a flag recording whether there is logical view in this schema tree. */
private boolean hasLogicalMeasurementPath = false;
+
/** used to judge schema tree type */
private boolean hasNormalTimeSeries = false;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/aggregation/timerangeiterator/ITimeRangeIterator.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/aggregation/timerangeiterator/ITimeRangeIterator.java
index 7433bbd..9dbd2ce 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/aggregation/timerangeiterator/ITimeRangeIterator.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/aggregation/timerangeiterator/ITimeRangeIterator.java
@@ -32,7 +32,9 @@
/** return the first time range by sorting order. */
TimeRange getFirstTimeRange();
- /** @return whether current iterator has next time range. */
+ /**
+ * @return whether current iterator has next time range.
+ */
boolean hasNextTimeRange();
/**
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/exchange/sink/SinkChannel.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/exchange/sink/SinkChannel.java
index 0920eef..b91001a 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/exchange/sink/SinkChannel.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/exchange/sink/SinkChannel.java
@@ -102,6 +102,7 @@
private volatile ListenableFuture<Void> blocked;
private int nextSequenceId = 0;
+
/** The actual buffered memory in bytes, including the amount of memory being reserved. */
private long bufferRetainedSizeInBytes;
@@ -449,6 +450,7 @@
public void setRetryIntervalInMs(long retryIntervalInMs) {
this.retryIntervalInMs = retryIntervalInMs;
}
+
// endregion
// region ============ inner class ============
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/exchange/source/LocalSourceHandle.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/exchange/source/LocalSourceHandle.java
index 8d3fc9d..e1d2438 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/exchange/source/LocalSourceHandle.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/exchange/source/LocalSourceHandle.java
@@ -60,6 +60,7 @@
private static final TsBlockSerde serde = new TsBlockSerde();
private static final DataExchangeCostMetricSet DATA_EXCHANGE_COST_METRIC_SET =
DataExchangeCostMetricSet.getInstance();
+
// For pipeline
public LocalSourceHandle(
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/fragment/FragmentInstanceContext.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/fragment/FragmentInstanceContext.java
index 36d9173..3d72278 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/fragment/FragmentInstanceContext.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/fragment/FragmentInstanceContext.java
@@ -66,10 +66,13 @@
private List<PartialPath> sourcePaths;
// Shared by all scan operators in this fragment instance to avoid memory problem
private QueryDataSource sharedQueryDataSource;
+
/** closed tsfile used in this fragment instance. */
private Set<TsFileResource> closedFilePaths;
+
/** unClosed tsfile used in this fragment instance. */
private Set<TsFileResource> unClosedFilePaths;
+
/** check if there is tmp file to be deleted. */
private boolean mayHaveTmpFile = false;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/memory/MemoryPool.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/memory/MemoryPool.java
index f319825..ca37d85 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/memory/MemoryPool.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/memory/MemoryPool.java
@@ -52,6 +52,7 @@
private final String fragmentInstanceId;
private final String planNodeId;
private final long bytesToReserve;
+
/**
* MemoryReservationFuture is created when SinkHandle or SourceHandle tries to reserve memory
* from pool. This field is max Bytes that SinkHandle or SourceHandle can reserve.
@@ -115,6 +116,7 @@
private final long maxBytesPerFragmentInstance;
private final AtomicLong remainingBytes;
+
/** queryId -> fragmentInstanceId -> planNodeId -> bytesReserved. */
private final Map<String, Map<String, Map<String, Long>>> queryMemoryReservations =
new ConcurrentHashMap<>();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/AbstractConsumeAllOperator.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/AbstractConsumeAllOperator.java
index c022f7b..636102a 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/AbstractConsumeAllOperator.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/AbstractConsumeAllOperator.java
@@ -37,6 +37,7 @@
implements ProcessOperator {
protected final List<Operator> children;
protected final int inputOperatorsCount;
+
/** TsBlock from child operator. Only one cache now. */
protected TsBlock[] inputTsBlocks;
@@ -155,7 +156,9 @@
return !isEmpty(currentChildIndex) || children.get(currentChildIndex) == null;
}
- /** @param currentInputIndex index of the input TsBlock */
+ /**
+ * @param currentInputIndex index of the input TsBlock
+ */
protected void processCurrentInputTsBlock(int currentInputIndex) {
// do nothing here, the subclass have its own implementation
}
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/LinearFillOperator.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/LinearFillOperator.java
index 7ecf222..024e1a6 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/LinearFillOperator.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/LinearFillOperator.java
@@ -54,6 +54,7 @@
* be called once in LinearFillOperator.next().
*/
private boolean canCallNext;
+
// indicate whether there is more TsBlock for child operator
private boolean noMoreTsBlock;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/MergeSortOperator.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/MergeSortOperator.java
index 8defe42..7aee14e 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/MergeSortOperator.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/MergeSortOperator.java
@@ -227,7 +227,9 @@
|| children.get(currentChildIndex) == null;
}
- /** @param currentInputIndex index of the input TsBlock */
+ /**
+ * @param currentInputIndex index of the input TsBlock
+ */
@Override
protected void processCurrentInputTsBlock(int currentInputIndex) {
mergeSortHeap.push(new MergeSortKey(inputTsBlocks[currentInputIndex], 0, currentInputIndex));
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/FullOuterTimeJoinOperator.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/FullOuterTimeJoinOperator.java
index 52f2fcf..1f1289b 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/FullOuterTimeJoinOperator.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/FullOuterTimeJoinOperator.java
@@ -290,7 +290,9 @@
|| children.get(currentChildIndex) == null;
}
- /** @param currentInputIndex index of the input TsBlock */
+ /**
+ * @param currentInputIndex index of the input TsBlock
+ */
@Override
protected void processCurrentInputTsBlock(int currentInputIndex) {
updateTimeSelector(currentInputIndex);
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/InnerTimeJoinOperator.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/InnerTimeJoinOperator.java
index 63cfb2e..4c826bc 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/InnerTimeJoinOperator.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/InnerTimeJoinOperator.java
@@ -54,6 +54,7 @@
private final List<Operator> children;
private final int inputOperatorsCount;
+
/** TsBlock from child operator. Only one cache now. */
private final TsBlock[] inputTsBlocks;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/DataExchangeCostMetricSet.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/DataExchangeCostMetricSet.java
index 9a0ef15..785ead4 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/DataExchangeCostMetricSet.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/DataExchangeCostMetricSet.java
@@ -245,6 +245,7 @@
});
});
}
+
// endregion
@Override
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/QueryExecutionMetricSet.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/QueryExecutionMetricSet.java
index ed493ab..27a238d 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/QueryExecutionMetricSet.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/metric/QueryExecutionMetricSet.java
@@ -68,6 +68,7 @@
metricService.remove(
MetricType.TIMER, Metric.DISPATCHER.toString(), Tag.STAGE.toString(), stage));
}
+
// endregion
// region query execution
@@ -136,6 +137,7 @@
Tag.STAGE.toString(),
stage));
}
+
// endregion
// region query aggregation
@@ -165,6 +167,7 @@
metricService.remove(
MetricType.TIMER, Metric.AGGREGATION.toString(), Tag.FROM.toString(), from));
}
+
// endregion
@Override
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeVisitor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeVisitor.java
index a5bf031..b23a5d4 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeVisitor.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeVisitor.java
@@ -3615,6 +3615,7 @@
analysis.setRespDatasetHeader(DatasetHeaderFactory.getShowLogicalViewHeader());
return analysis;
}
+
// endregion view
@Override
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/ExpressionUtils.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/ExpressionUtils.java
index ac5a199..04b348a 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/ExpressionUtils.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/ExpressionUtils.java
@@ -121,7 +121,8 @@
Expression resultExpression =
new CaseWhenThenExpression(
childExpressions // transform to List<WhenThenExpression>
- .subList(0, childExpressions.size() - 1).stream()
+ .subList(0, childExpressions.size() - 1)
+ .stream()
.map(WhenThenExpression.class::cast)
.collect(Collectors.toList()),
childExpressions.get(childExpressions.size() - 1));
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java
index 07a68fb..86b9b6d 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java
@@ -87,15 +87,19 @@
/** the size of partitionCache */
private final int cacheSize = config.getPartitionCacheSize();
+
/** the cache of database */
private final Set<String> storageGroupCache = Collections.synchronizedSet(new HashSet<>());
+
/** storage -> schemaPartitionTable */
private final Cache<String, SchemaPartitionTable> schemaPartitionCache;
+
/** storage -> dataPartitionTable */
private final Cache<String, DataPartitionTable> dataPartitionCache;
/** the latest time when groupIdToReplicaSetMap updated. */
private final AtomicLong latestUpdateTime = new AtomicLong(0);
+
/** TConsensusGroupId -> TRegionReplicaSet */
private final Map<TConsensusGroupId, TRegionReplicaSet> groupIdToReplicaSetMap = new HashMap<>();
@@ -611,6 +615,7 @@
schemaPartitionCacheLock.writeLock().unlock();
}
}
+
// endregion
// region data partition cache
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/StorageGroupCacheResult.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/StorageGroupCacheResult.java
index bc55571..53771fa 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/StorageGroupCacheResult.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/StorageGroupCacheResult.java
@@ -27,8 +27,10 @@
public abstract class StorageGroupCacheResult<V> {
/** the result */
private boolean success = true;
+
/** the list of devices that miss */
private List<String> missedDevices = new ArrayList<>();
+
/** result map, Notice: this map will be empty when failed */
protected Map<String, V> map = new HashMap<>();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/ISchemaComputation.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/ISchemaComputation.java
index 17ddded..c0934b2 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/ISchemaComputation.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/ISchemaComputation.java
@@ -37,7 +37,9 @@
String[] getMeasurements();
- /** @param isAligned whether the fetched device is aligned */
+ /**
+ * @param isAligned whether the fetched device is aligned
+ */
void computeDevice(boolean isAligned);
/**
@@ -69,7 +71,9 @@
*/
void recordRangeOfLogicalViewSchemaListNow();
- /** @return the recorded range of logical view schema list. */
+ /**
+ * @return the recorded range of logical view schema list.
+ */
Pair<Integer, Integer> getRangeOfLogicalViewSchemaListRecorded();
/**
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/IQueryExecution.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/IQueryExecution.java
index 914300e..b35123e 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/IQueryExecution.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/IQueryExecution.java
@@ -59,7 +59,9 @@
void recordExecutionTime(long executionTime);
- /** @return cost time in ns */
+ /**
+ * @return cost time in ns
+ */
long getTotalExecutionTime();
Optional<String> getExecuteSQL();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/QueryExecution.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/QueryExecution.java
index ea8a3d9..9724a95 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/QueryExecution.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/QueryExecution.java
@@ -482,7 +482,9 @@
return resultHandle.getSerializedTsBlock();
}
- /** @return true if there is more tsblocks, otherwise false */
+ /**
+ * @return true if there is more tsblocks, otherwise false
+ */
@Override
public boolean hasNextResult() {
return resultHandle != null && !resultHandle.isFinished();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/expression/visitor/TransformToViewExpressionVisitor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/expression/visitor/TransformToViewExpressionVisitor.java
index e29b8af..28e1a19 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/expression/visitor/TransformToViewExpressionVisitor.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/expression/visitor/TransformToViewExpressionVisitor.java
@@ -115,6 +115,7 @@
public ViewExpression visitTimeStampOperand(TimestampOperand timestampOperand, Void context) {
return new TimestampViewOperand();
}
+
// endregion
// region Unary Expressions
@@ -165,6 +166,7 @@
regularExpression.getPattern(),
regularExpression.isNot());
}
+
// endregion
// region Binary Expressions
@@ -215,6 +217,7 @@
this.getExpressionsForBinaryExpression(subtractionExpression);
return new SubtractionViewExpression(pair.left, pair.right);
}
+
// endregion
// region Binary: Compare Binary Expression
@@ -265,6 +268,7 @@
this.getExpressionsForBinaryExpression(nonEqualExpression);
return new NonEqualViewExpression(pair.left, pair.right);
}
+
// endregion
// region Binary : Logic Binary Expression
@@ -283,6 +287,7 @@
this.getExpressionsForBinaryExpression(logicOrExpression);
return new LogicOrViewExpression(pair.left, pair.right);
}
+
// endregion
// endregion
@@ -296,6 +301,7 @@
ViewExpression third = this.process(betweenExpression.getSecondExpression(), null);
return new BetweenViewExpression(first, second, third, betweenExpression.isNotBetween());
}
+
// endregion
// region FunctionExpression
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/metedata/write/view/CreateLogicalViewNode.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/metedata/write/view/CreateLogicalViewNode.java
index 9291b60..a2d8022 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/metedata/write/view/CreateLogicalViewNode.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/metedata/write/view/CreateLogicalViewNode.java
@@ -119,6 +119,7 @@
public <R, C> R accept(PlanVisitor<R, C> visitor, C schemaRegion) {
return visitor.visitCreateLogicalView(this, schemaRegion);
}
+
// endregion
// region Interfaces in WritePlanNode or PlanNode
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertNode.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertNode.java
index a53fe80..054770c 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertNode.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertNode.java
@@ -222,6 +222,7 @@
measurements[i] = measurementSchemas[i].getMeasurementId();
}
}
+
// endregion
public TRegionReplicaSet getRegionReplicaSet() {
@@ -268,6 +269,7 @@
}
return true;
}
+
// endregion
// region progress index
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java
index 4d7fd05..b684da4 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java
@@ -777,6 +777,7 @@
}
}
}
+
// endregion
@Override
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertTabletNode.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertTabletNode.java
index 9153336..eef602c 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertTabletNode.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertTabletNode.java
@@ -939,6 +939,7 @@
QueryDataSetUtils.readTabletValuesFromBuffer(buffer, dataTypes, measurementSize, rowCount);
isAligned = buffer.get() == 1;
}
+
// endregion
@Override
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/parameter/SeriesScanOptions.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/parameter/SeriesScanOptions.java
index 6f43ded..62b5d53 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/parameter/SeriesScanOptions.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/parameter/SeriesScanOptions.java
@@ -86,7 +86,9 @@
this.globalTimeFilter = updateFilterUsingTTL(globalTimeFilter, dataTTL);
}
- /** @return an updated filter concerning TTL */
+ /**
+ * @return an updated filter concerning TTL
+ */
public static Filter updateFilterUsingTTL(Filter filter, long dataTTL) {
if (dataTTL != Long.MAX_VALUE) {
if (filter != null) {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/FragmentInstanceDispatcherImpl.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/FragmentInstanceDispatcherImpl.java
index f671a87..d401a61 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/FragmentInstanceDispatcherImpl.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/FragmentInstanceDispatcherImpl.java
@@ -291,7 +291,9 @@
}
private void dispatchRemoteHelper(FragmentInstance instance, TEndPoint endPoint)
- throws FragmentInstanceDispatchException, TException, ClientManagerException,
+ throws FragmentInstanceDispatchException,
+ TException,
+ ClientManagerException,
RatisReadUnavailableException {
try (SyncDataNodeInternalServiceClient client =
syncInternalServiceClientManager.borrowClient(endPoint)) {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertBaseStatement.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertBaseStatement.java
index bb2d5f5..605f72f 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertBaseStatement.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertBaseStatement.java
@@ -275,6 +275,7 @@
this.cause = cause;
}
}
+
// endregion
// region functions used by analyzing logical views
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/view/AlterLogicalViewStatement.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/view/AlterLogicalViewStatement.java
index 51be103..0d2b5d3 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/view/AlterLogicalViewStatement.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/view/AlterLogicalViewStatement.java
@@ -146,6 +146,7 @@
this.targetPaths.setSuffixOfPathsGroup(suffixPaths);
this.targetPaths.generateFullPathsFromPathsGroup();
}
+
// endregion
@Override
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/row/ElasticSerializableRowRecordList.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/row/ElasticSerializableRowRecordList.java
index b6bb5c4..a5ddd5c 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/row/ElasticSerializableRowRecordList.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/row/ElasticSerializableRowRecordList.java
@@ -45,6 +45,7 @@
protected LRUCache cache;
protected List<SerializableRowRecordList> rowRecordLists;
+
/** Mark bitMaps of correct index when one row has at least one null field. */
protected List<BitMap> bitMaps;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/tv/ElasticSerializableTVList.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/tv/ElasticSerializableTVList.java
index 1fd51be..f1306e0 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/tv/ElasticSerializableTVList.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/datastructure/tv/ElasticSerializableTVList.java
@@ -54,6 +54,7 @@
protected LRUCache cache;
protected List<SerializableTVList> tvLists;
+
/**
* the bitmap used to indicate whether one value is null in the tvLists. The size of bitMap is the
* same as tvLists and the length of whole bits is the same as tvLists' length.
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/ISchemaRegion.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/ISchemaRegion.java
index 421f47e..95e3524 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/ISchemaRegion.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/ISchemaRegion.java
@@ -85,6 +85,7 @@
ISchemaRegionStatistics getSchemaRegionStatistics();
ISchemaRegionMetric getSchemaRegionMetric();
+
// endregion
// region Interfaces for schema region Info query and operation
@@ -98,6 +99,7 @@
boolean createSnapshot(File snapshotDir);
void loadSnapshot(File latestSnapshotRootDir);
+
// endregion
// region Interfaces for Timeseries operation
@@ -174,6 +176,7 @@
* @throws MetadataException
*/
void deleteTimeseriesInBlackList(PathPatternTree patternTree) throws MetadataException;
+
// endregion
// region Interfaces for Logical View
@@ -274,6 +277,7 @@
*/
void renameTagOrAttributeKey(String oldKey, String newKey, PartialPath fullPath)
throws MetadataException, IOException;
+
// endregion
// region Interfaces for Template operations
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionMemoryImpl.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionMemoryImpl.java
index 789908a..5e6cb55 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionMemoryImpl.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionMemoryImpl.java
@@ -874,7 +874,9 @@
measurementMNode.setPreDeleted(false);
}
- /** @param path full path from root to leaf node */
+ /**
+ * @param path full path from root to leaf node
+ */
private void deleteOneTimeseriesUpdateStatistics(PartialPath path)
throws MetadataException, IOException {
IMeasurementMNode<IMemMNode> measurementMNode = mtree.deleteTimeseries(path);
@@ -885,6 +887,7 @@
regionStatistics.deleteMeasurement(1L);
}
}
+
// endregion
// region Interfaces for get and auto create device
@@ -910,6 +913,7 @@
throw new MetadataException(e);
}
}
+
// endregion
// region Interfaces for metadata info Query
@@ -1130,6 +1134,7 @@
private void removeFromTagInvertedIndex(IMeasurementMNode<IMemMNode> node) throws IOException {
tagManager.removeFromTagInvertedIndex(node);
}
+
// endregion
// region Interfaces and Implementation for Template operations
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionPBTreeImpl.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionPBTreeImpl.java
index 6c12d31..070594d 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionPBTreeImpl.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionPBTreeImpl.java
@@ -948,7 +948,9 @@
mtree.rollbackSchemaBlackList(path);
}
- /** @param path full path from root to leaf node */
+ /**
+ * @param path full path from root to leaf node
+ */
private void deleteOneTimeseriesUpdateStatistics(PartialPath path)
throws MetadataException, IOException {
IMeasurementMNode<ICachedMNode> measurementMNode = mtree.deleteTimeseries(path);
@@ -959,6 +961,7 @@
regionStatistics.deleteMeasurement(1L);
}
}
+
// endregion
// region Interfaces for get and auto create device
@@ -985,6 +988,7 @@
throw new MetadataException(e);
}
}
+
// endregion
// region Interfaces for metadata info Query
@@ -1240,6 +1244,7 @@
private void removeFromTagInvertedIndex(IMeasurementMNode<ICachedMNode> node) throws IOException {
tagManager.removeFromTagInvertedIndex(node);
}
+
// endregion
// region Interfaces and Implementation for Template operations
@@ -1349,6 +1354,7 @@
throws MetadataException {
return mtree.getNodeReader(showNodesPlan);
}
+
// endregion
private static class RecoverOperationResult {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/MTreeBelowSGMemoryImpl.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/MTreeBelowSGMemoryImpl.java
index 7229511..e76c393 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/MTreeBelowSGMemoryImpl.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/MTreeBelowSGMemoryImpl.java
@@ -1141,6 +1141,7 @@
}
};
}
+
// endregion
// region interfaces for logical view
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/info/LogicalViewInfo.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/info/LogicalViewInfo.java
index 8ab10fa..69cf2eb 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/info/LogicalViewInfo.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/info/LogicalViewInfo.java
@@ -40,6 +40,7 @@
/** tag/attribute's start offset in tag file */
private long offset = -1;
+
/** whether this measurement is pre deleted and considered in black list */
private boolean preDeleted = false;
@@ -59,7 +60,9 @@
return false;
}
- /** @return return the path of alias series if this view is alias series; else return null. */
+ /**
+ * @return return the path of alias series if this view is alias series; else return null.
+ */
public PartialPath getAliasSeriesPath() {
if (this.isAliasSeries()) {
if (this.getExpression().getExpressionType() == ViewExpressionType.TIMESERIES) {
@@ -81,6 +84,7 @@
public void setExpression(ViewExpression expression) {
this.schema.setExpression(expression);
}
+
// endregion
// region IMeasurementInfo interfaces
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/info/MeasurementInfo.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/info/MeasurementInfo.java
index c43cd9a..19d1855 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/info/MeasurementInfo.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/info/MeasurementInfo.java
@@ -28,10 +28,13 @@
/** alias name of this measurement */
protected String alias;
+
/** tag/attribute's start offset in tag file */
private long offset = -1;
+
/** measurement's Schema for one timeseries represented by current leaf node */
private IMeasurementSchema schema;
+
/** whether this measurement is pre deleted and considered in black list */
private boolean preDeleted = false;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/MTreeBelowSGCachedImpl.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/MTreeBelowSGCachedImpl.java
index d803bc1..d2ef703 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/MTreeBelowSGCachedImpl.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/MTreeBelowSGCachedImpl.java
@@ -933,6 +933,7 @@
path.getFullPath(), SchemaConstant.MEASUREMENT_MNODE_TYPE);
}
}
+
// endregion
// region Interfaces and Implementation for Logical View
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/flush/Scheduler.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/flush/Scheduler.java
index 5a22b23..b467b47 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/flush/Scheduler.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/flush/Scheduler.java
@@ -52,6 +52,7 @@
/** data structure */
private final Map<Integer, CachedMTreeStore> regionToStore;
+
// flushingRegionSet is used to avoid flush the same region concurrently, update will be
// guaranteed by synchronized
private final Set<Integer> flushingRegionSet;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/SchemaFile.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/SchemaFile.java
index babad02..892a93a 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/SchemaFile.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/SchemaFile.java
@@ -323,6 +323,7 @@
pageManager.inspect(pw);
return String.format("SchemaFile[%s] had been inspected.", this.filePath);
}
+
// endregion
// region File Operations
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/SegmentedPage.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/SegmentedPage.java
index f5709e4..fa0c31f 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/SegmentedPage.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/SegmentedPage.java
@@ -343,6 +343,7 @@
return this.pageBuffer.slice();
}
}
+
// endregion
// region Segment Getters
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/pagemgr/BTreePageManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/pagemgr/BTreePageManager.java
index d6b8743..b069f97 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/pagemgr/BTreePageManager.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/pagemgr/BTreePageManager.java
@@ -157,7 +157,9 @@
.getRecordByAlias(alias);
}
- /** @return top page to insert index */
+ /**
+ * @return top page to insert index
+ */
private ISchemaPage insertAliasIndexEntry(
ISchemaPage topPage, String alias, String name, SchemaPageContext cxt)
throws MetadataException, IOException {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/pagemgr/PageManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/pagemgr/PageManager.java
index 4f0cc02..06d8c27 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/pagemgr/PageManager.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/schemafile/pagemgr/PageManager.java
@@ -180,7 +180,9 @@
String alias;
// TODO: reserve order of insert in container may be better
for (Map.Entry<String, ICachedMNode> entry :
- ICachedMNodeContainer.getCachedMNodeContainer(node).getNewChildFlushingBuffer().entrySet()
+ ICachedMNodeContainer.getCachedMNodeContainer(node)
+ .getNewChildFlushingBuffer()
+ .entrySet()
.stream()
.sorted(Map.Entry.comparingByKey())
.collect(Collectors.toList())) {
@@ -488,6 +490,7 @@
cxt.lastLeafPage = page.getAsSegmentedPage();
}
+
// endregion
// region General Interfaces
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/read/resp/reader/impl/TimeseriesReaderWithViewFetch.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/read/resp/reader/impl/TimeseriesReaderWithViewFetch.java
index 4a6e064..0c66153 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/read/resp/reader/impl/TimeseriesReaderWithViewFetch.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/read/resp/reader/impl/TimeseriesReaderWithViewFetch.java
@@ -61,6 +61,7 @@
private ITimeSeriesSchemaInfo next = null;
private boolean consumeView = false;
private final SchemaFilter schemaFilter;
+
/**
* There is no need to pull the original sequence information from the view if needFetch is false.
* The default is false if not filtered by DataType.
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/utils/ResourceByPathUtils.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/utils/ResourceByPathUtils.java
index 14ff80d..36ba50e 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/utils/ResourceByPathUtils.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/utils/ResourceByPathUtils.java
@@ -382,6 +382,7 @@
partialPath.getMeasurementSchema().getProps(),
deletionList);
}
+
/**
* construct a deletion list from a memtable.
*
@@ -404,6 +405,7 @@
}
return TimeRange.sortAndMerge(deletionList);
}
+
/** get modifications from a memtable. */
@Override
protected List<Modification> getModificationsForMemtable(
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/view/visitor/TransformToExpressionVisitor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/view/visitor/TransformToExpressionVisitor.java
index fdfeea2..7ad1de7 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/view/visitor/TransformToExpressionVisitor.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/view/visitor/TransformToExpressionVisitor.java
@@ -125,6 +125,7 @@
public Expression visitTimeStampOperand(TimestampViewOperand timestampOperand, Void context) {
return new TimestampOperand();
}
+
// endregion
// region Unary Expressions
@@ -180,6 +181,7 @@
regularExpression.getPattern(),
regularExpression.isNot());
}
+
// endregion
@Override
@@ -231,6 +233,7 @@
this.getExpressionsForBinaryExpression(subtractionExpression);
return new SubtractionExpression(pair.left, pair.right);
}
+
// endregion
// region Binary: Compare Binary Expression
@@ -275,6 +278,7 @@
Pair<Expression, Expression> pair = this.getExpressionsForBinaryExpression(nonEqualExpression);
return new NonEqualExpression(pair.left, pair.right);
}
+
// endregion
// region Binary : Logic Binary Expression
@@ -293,6 +297,7 @@
Pair<Expression, Expression> pair = this.getExpressionsForBinaryExpression(logicOrExpression);
return new LogicOrExpression(pair.left, pair.right);
}
+
// endregion
// endregion
@@ -311,6 +316,7 @@
return new org.apache.iotdb.db.queryengine.plan.expression.ternary.BetweenExpression(
first, second, third, betweenViewExpression.isNotBetween());
}
+
// endregion
// region FunctionExpression
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/write/req/view/ICreateLogicalViewPlan.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/write/req/view/ICreateLogicalViewPlan.java
index 7f58564..3c94851 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/write/req/view/ICreateLogicalViewPlan.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/write/req/view/ICreateLogicalViewPlan.java
@@ -46,10 +46,14 @@
*/
int getViewSize();
- /** @return return a map, from view path (the targets) to source expression. */
+ /**
+ * @return return a map, from view path (the targets) to source expression.
+ */
Map<PartialPath, ViewExpression> getViewPathToSourceExpressionMap();
- /** @return return a list of target paths (paths of views). */
+ /**
+ * @return return a list of target paths (paths of views).
+ */
List<PartialPath> getViewPathList();
/**
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNodeServerCommandLine.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNodeServerCommandLine.java
index be231d2..d676011 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNodeServerCommandLine.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNodeServerCommandLine.java
@@ -167,8 +167,11 @@
continue;
}
List<TDataNodeLocation> nodeLocationResult =
- client.getDataNodeConfiguration(Integer.parseInt(id)).getDataNodeConfigurationMap()
- .values().stream()
+ client
+ .getDataNodeConfiguration(Integer.parseInt(id))
+ .getDataNodeConfigurationMap()
+ .values()
+ .stream()
.map(TDataNodeConfiguration::getLocation)
.collect(Collectors.toList());
if (nodeLocationResult.isEmpty()) {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java
index 05a3603..05c7b2c 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java
@@ -89,9 +89,7 @@
.getConfig()
.getDataRegionConsensusProtocolClass()
.equals(ConsensusFactory.RATIS_CONSENSUS)) {
- DataRegionConsensusImpl.getInstance()
- .getAllConsensusGroupIds()
- .parallelStream()
+ DataRegionConsensusImpl.getInstance().getAllConsensusGroupIds().parallelStream()
.forEach(
id -> {
try {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/RPCService.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/RPCService.java
index 0ddd868..3a03226 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/RPCService.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/RPCService.java
@@ -45,8 +45,11 @@
@Override
public void initTProcessor()
- throws ClassNotFoundException, IllegalAccessException, InstantiationException,
- NoSuchMethodException, InvocationTargetException {
+ throws ClassNotFoundException,
+ IllegalAccessException,
+ InstantiationException,
+ NoSuchMethodException,
+ InvocationTargetException {
impl =
(IClientRPCServiceWithHandler)
Class.forName(IoTDBDescriptor.getInstance().getConfig().getRpcImplClassName())
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/CompactionMetrics.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/CompactionMetrics.java
index 102a237..79b7938 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/CompactionMetrics.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/CompactionMetrics.java
@@ -246,6 +246,7 @@
}
totalCompactionReadInfoCounter.inc(byteNum);
}
+
// endregion
// region compaction summary info
@@ -292,6 +293,7 @@
totalDeserializedChunkCounter.inc(summary.getDeserializeChunkCount());
totalMergedChunkCounter.inc(summary.getMergedChunkNum());
}
+
// endregion
// region task info
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
index 50d29b3..d193c9f 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
@@ -201,18 +201,24 @@
* partitionLatestFlushedTimeForEachDevice)
*/
private final ReadWriteLock insertLock = new ReentrantReadWriteLock();
+
/** Condition to safely delete data region. */
private final Condition deletedCondition = insertLock.writeLock().newCondition();
+
/** Data region has been deleted or not. */
private volatile boolean deleted = false;
+
/** closeStorageGroupCondition is used to wait for all currently closing TsFiles to be done. */
private final Object closeStorageGroupCondition = new Object();
+
/**
* Avoid some tsfileResource is changed (e.g., from unsealed to sealed) when a read is executed.
*/
private final ReadWriteLock closeQueryLock = new ReentrantReadWriteLock();
+
/** time partition id in the database -> {@link TsFileProcessor} for this time partition. */
private final TreeMap<Long, TsFileProcessor> workSequenceTsFileProcessors = new TreeMap<>();
+
/** time partition id in the database -> {@link TsFileProcessor} for this time partition. */
private final TreeMap<Long, TsFileProcessor> workUnsequenceTsFileProcessors = new TreeMap<>();
@@ -225,10 +231,13 @@
/** data region id. */
private final String dataRegionId;
+
/** database name. */
private final String databaseName;
+
/** database system directory. */
private File storageGroupSysDir;
+
/** manage seqFileList and unSeqFileList. */
private final TsFileManager tsFileManager;
@@ -242,15 +251,19 @@
*/
private final HashMap<Long, VersionController> timePartitionIdVersionControllerMap =
new HashMap<>();
+
/**
* When the data in a database is older than dataTTL, it is considered invalid and will be
* eventually removed.
*/
private long dataTTL = Long.MAX_VALUE;
+
/** File system factory (local or hdfs). */
private final FSFactory fsFactory = FSFactoryProducer.getFSFactory();
+
/** File flush policy. */
private TsFileFlushPolicy fileFlushPolicy;
+
/**
* The max file versions in each partition. By recording this, if several IoTDB instances have the
* same policy of closing file and their ingestion is identical, then files of the same version in
@@ -258,12 +271,16 @@
* across different instances. partition number -> max version number
*/
private Map<Long, Long> partitionMaxFileVersions = new ConcurrentHashMap<>();
+
/** database info for mem control. */
private final DataRegionInfo dataRegionInfo = new DataRegionInfo(this);
+
/** whether it's ready from recovery. */
private boolean isReady = false;
+
/** close file listeners. */
private List<CloseFileListener> customCloseFileListeners = Collections.emptyList();
+
/** flush listeners. */
private List<FlushListener> customFlushListeners = Collections.emptyList();
@@ -378,6 +395,7 @@
/** number of already recovered files. */
private long recoveredFilesNum;
+
/** last recovery log time. */
private long lastLogTime;
@@ -3281,7 +3299,9 @@
}
}
- /** @return the disk space occupied by this data region, unit is MB */
+ /**
+ * @return the disk space occupied by this data region, unit is MB
+ */
public long countRegionDiskSize() {
AtomicLong diskSize = new AtomicLong(0);
TierManager.getInstance()
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/ILastFlushTimeMap.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/ILastFlushTimeMap.java
index 19ff2c2..e809730 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/ILastFlushTimeMap.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/ILastFlushTimeMap.java
@@ -39,6 +39,7 @@
/** Update both partitionLatestFlushedTime and globalLatestFlushedTimeForEachDevice. */
void updateLatestFlushTime(long partitionId, Map<IDeviceID, Long> updateMap);
+
// endregion
// region ensure
@@ -50,12 +51,14 @@
long getFlushedTime(long timePartitionId, IDeviceID deviceId);
long getGlobalFlushedTime(IDeviceID path);
+
// endregion
// region clear
void clearFlushedTime();
void clearGlobalFlushedTime();
+
// endregion
void degradeLastFlushTime(long partitionId);
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/performer/impl/ReadChunkCompactionPerformer.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/performer/impl/ReadChunkCompactionPerformer.java
index 512d6c1..b13aca3 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/performer/impl/ReadChunkCompactionPerformer.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/performer/impl/ReadChunkCompactionPerformer.java
@@ -66,7 +66,10 @@
@Override
public void perform()
- throws IOException, MetadataException, InterruptedException, StorageEngineException,
+ throws IOException,
+ MetadataException,
+ InterruptedException,
+ StorageEngineException,
PageException {
// size for file writer is 5% of per compaction task memory budget
long sizeForFileWriter =
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/estimator/FileInfo.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/estimator/FileInfo.java
index 7ff1ae9..09282cc 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/estimator/FileInfo.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/estimator/FileInfo.java
@@ -27,6 +27,7 @@
// max aligned series num in one device. If there is no aligned series in this file, then it
// turns to be -1.
int maxAlignedSeriesNumInDevice = -1;
+
// max chunk num of one device in this tsfile
@SuppressWarnings("squid:S1068")
int maxDeviceChunkNum = 0;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tool/ListTimeRangeImpl.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tool/ListTimeRangeImpl.java
index bca7f72..5651de0 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tool/ListTimeRangeImpl.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tool/ListTimeRangeImpl.java
@@ -26,6 +26,7 @@
public class ListTimeRangeImpl implements ITimeRange {
List<Interval> intervalList = new LinkedList<>();
+
// 0-10， 20-30， 50-70
// 25-60
// 0-10. 20-70
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractMemTable.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractMemTable.java
index 97f9aaf..7c7e46e 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractMemTable.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractMemTable.java
@@ -73,8 +73,10 @@
private volatile FlushStatus flushStatus = FlushStatus.WORKING;
private final int avgSeriesPointNumThreshold =
IoTDBDescriptor.getInstance().getConfig().getAvgSeriesPointNumberThreshold();
+
/** Memory size of data points, including TEXT values. */
private long memSize = 0;
+
/**
* Memory usage of all TVLists memory usage regardless of whether these TVLists are full,
* including TEXT values.
@@ -97,6 +99,7 @@
/** this time is updated by the timed flush, same as createdTime when the feature is disabled. */
private long updateTime = createdTime;
+
/**
* check whether this memTable has been updated since last timed flush check, update updateTime
* when changed
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/DeviceIDFactory.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/DeviceIDFactory.java
index cb20d9b..15a609c 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/DeviceIDFactory.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/DeviceIDFactory.java
@@ -54,6 +54,7 @@
private DeviceIDFactory() {
getDeviceIDFunction = PlainDeviceID::new;
}
+
// endregion
/**
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IMemTable.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IMemTable.java
index 33fb0e9..8a43573 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IMemTable.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IMemTable.java
@@ -61,10 +61,14 @@
long insertTime,
Object[] objectValue);
- /** @return the number of points */
+ /**
+ * @return the number of points
+ */
long size();
- /** @return memory usage */
+ /**
+ * @return memory usage
+ */
long memSize();
/** only used when mem control enabled */
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IWritableMemChunk.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IWritableMemChunk.java
index 8e83b60..eac0648 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IWritableMemChunk.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IWritableMemChunk.java
@@ -129,7 +129,9 @@
return Long.MAX_VALUE;
}
- /** @return how many points are deleted */
+ /**
+ * @return how many points are deleted
+ */
int delete(long lowerBound, long upperBound);
IChunkWriter createIChunkWriter();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
index 2c0e4d0..8cbca98 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
@@ -112,6 +112,7 @@
/** Database info for mem control. */
private final DataRegionInfo dataRegionInfo;
+
/** Tsfile processor info for mem control. */
private TsFileProcessorInfo tsFileProcessorInfo;
@@ -129,6 +130,7 @@
/** Time range index to indicate this processor belongs to which time range */
private long timeRangeId;
+
/**
* Whether the processor is in the queue of the FlushManager or being flushed by a flush thread.
*/
@@ -136,6 +138,7 @@
/** A lock to mutual exclude read and read */
private final ReadWriteLock flushQueryLock = new ReentrantReadWriteLock();
+
/**
* It is set by the StorageGroupProcessor and checked by flush threads. (If shouldClose == true
* and its flushingMemTables are all flushed, then the flush thread will close this file.)
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/read/control/FileReaderManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/read/control/FileReaderManager.java
index 951291c..d01b16f 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/read/control/FileReaderManager.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/read/control/FileReaderManager.java
@@ -58,6 +58,7 @@
* corresponding reader.
*/
private Map<String, TsFileSequenceReader> closedFileReaderMap;
+
/**
* the key of unclosedFileReaderMap is the file path and the value of unclosedFileReaderMap is the
* corresponding reader.
@@ -69,6 +70,7 @@
* file's reference count.
*/
private Map<String, AtomicInteger> closedReferenceMap;
+
/**
* the key of unclosedFileReaderMap is the file path and the value of unclosedFileReaderMap is the
* file's reference count.
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/TsFileResource.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/TsFileResource.java
index d23c64b..3439673 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/TsFileResource.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/TsFileResource.java
@@ -697,7 +697,9 @@
return timeIndex.checkDeviceIdExist(deviceId);
}
- /** @return true if the device is contained in the TsFile and it lives beyond TTL */
+ /**
+ * @return true if the device is contained in the TsFile and it lives beyond TTL
+ */
public boolean isSatisfied(
IDeviceID deviceId, Filter globalTimeFilter, boolean isSeq, long ttl, boolean debug) {
if (deviceId == null) {
@@ -736,7 +738,9 @@
return true;
}
- /** @return true if the TsFile lives beyond TTL */
+ /**
+ * @return true if the TsFile lives beyond TTL
+ */
private boolean isSatisfied(Filter timeFilter, boolean isSeq, long ttl, boolean debug) {
long startTime = getFileStartTime();
long endTime = isClosed() || !isSeq ? getFileEndTime() : Long.MAX_VALUE;
@@ -768,7 +772,9 @@
return true;
}
- /** @return true if the device is contained in the TsFile */
+ /**
+ * @return true if the device is contained in the TsFile
+ */
public boolean isSatisfied(IDeviceID deviceId, Filter timeFilter, boolean isSeq, boolean debug) {
if (definitelyNotContains(deviceId)) {
if (debug) {
@@ -802,7 +808,9 @@
return true;
}
- /** @return whether the given time falls in ttl */
+ /**
+ * @return whether the given time falls in ttl
+ */
private boolean isAlive(long time, long dataTTL) {
return dataTTL == Long.MAX_VALUE || (CommonDateTimeUtils.currentTime() - time) <= dataTTL;
}
@@ -856,7 +864,9 @@
}
}
- /** @return resource map size */
+ /**
+ * @return resource map size
+ */
public long calculateRamSize() {
if (ramSize == 0) {
ramSize = INSTANCE_SIZE + timeIndex.calculateRamSize();
@@ -1110,7 +1120,9 @@
}
}
- /** @return is this tsfile resource in a TsFileResourceList */
+ /**
+ * @return is this tsfile resource in a TsFileResourceList
+ */
public boolean isFileInList() {
return prev != null || next != null;
}
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/generator/SimpleFileVersionController.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/generator/SimpleFileVersionController.java
index b97c4b8..3ee0bd7 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/generator/SimpleFileVersionController.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/generator/SimpleFileVersionController.java
@@ -35,12 +35,14 @@
private static final Logger logger = LoggerFactory.getLogger(SimpleFileVersionController.class);
public static final String FILE_PREFIX = "Version-";
public static final String UPGRADE_DIR = "upgrade";
+
/**
* Every time currVersion - prevVersion >= saveInterval, currVersion is persisted and prevVersion
* is set to currVersion. When recovering from file, the version number is automatically increased
* by saveInterval to avoid conflicts.
*/
private static long saveInterval = 100;
+
/** time partition id to dividing time series into different database */
private long timePartitionId;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/timeindex/ITimeIndex.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/timeindex/ITimeIndex.java
index ccfa926..3426fdc 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/timeindex/ITimeIndex.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/timeindex/ITimeIndex.java
@@ -71,7 +71,9 @@
*/
Set<IDeviceID> getDevices(String tsFilePath, TsFileResource tsFileResource);
- /** @return whether end time is empty (Long.MIN_VALUE) */
+ /**
+ * @return whether end time is empty (Long.MIN_VALUE)
+ */
boolean endTimeEmpty();
/**
@@ -80,7 +82,9 @@
*/
boolean stillLives(long ttlLowerBound);
- /** @return Calculate file index ram size */
+ /**
+ * @return Calculate file index ram size
+ */
long calculateRamSize();
/**
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/ElasticStrategy.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/ElasticStrategy.java
index 9cb7e55..99007ed 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/ElasticStrategy.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/ElasticStrategy.java
@@ -46,6 +46,7 @@
private final Map<String, WALNode> uniqueId2Nodes = new HashMap<>();
// each wal node has a unique long value identifier
private int nodeIdCounter = -1;
+
// endregion
public ElasticStrategy() {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/FirstCreateStrategy.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/FirstCreateStrategy.java
index 203a6e0..75b3cb8 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/FirstCreateStrategy.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/FirstCreateStrategy.java
@@ -42,6 +42,7 @@
// region these variables should be protected by nodesLock
// wal nodes
private final Map<String, WALNode> identifier2Nodes = new HashMap<>();
+
// endregion
// it's safe to not close WALNode here, we use clear method to close all WALNodes.
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/RoundRobinStrategy.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/RoundRobinStrategy.java
index 1334295..ddb40fb 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/RoundRobinStrategy.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/RoundRobinStrategy.java
@@ -43,6 +43,7 @@
private int nodeCursor = -1;
// each wal node has a unique int value identifier
private int nodeIdCounter = -1;
+
// endregion
public RoundRobinStrategy(int maxWalNodeNum) {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java
index 1b4b673..7bf33a9 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java
@@ -90,20 +90,24 @@
private final Condition idleBufferReadyCondition = buffersLock.newCondition();
// last writer position when fsync is called, help record each entry's position
private long lastFsyncPosition;
+
// region these variables should be protected by buffersLock
/** two buffers switch between three statuses (there is always 1 buffer working). */
// buffer in working status, only updated by serializeThread
// it's safe to use volatile here to make this reference thread-safe.
@SuppressWarnings("squid:S3077")
private volatile ByteBuffer workingBuffer;
+
// buffer in idle status
// it's safe to use volatile here to make this reference thread-safe.
@SuppressWarnings("squid:S3077")
private volatile ByteBuffer idleBuffer;
+
// buffer in syncing status, serializeThread makes sure no more writes to syncingBuffer
// it's safe to use volatile here to make this reference thread-safe.
@SuppressWarnings("squid:S3077")
private volatile ByteBuffer syncingBuffer;
+
// endregion
// file status of working buffer, updating file writer's status when syncing
protected volatile WALFileStatus currentFileStatus;
@@ -475,6 +479,7 @@
buffersLock.unlock();
}
}
+
// endregion
// region Task of syncBufferThread
@@ -640,6 +645,7 @@
buffersLock.unlock();
}
}
+
// endregion
@Override
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/checkpoint/CheckpointManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/checkpoint/CheckpointManager.java
index 3a7017a..8359330 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/checkpoint/CheckpointManager.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/checkpoint/CheckpointManager.java
@@ -63,16 +63,19 @@
// region these variables should be protected by infoLock
// memTable id -> memTable info
private final Map<Long, MemTableInfo> memTableId2Info = new ConcurrentHashMap<>();
+
// cache the biggest byte buffer to serialize checkpoint
// it's safe to use volatile here to make this reference thread-safe.
@SuppressWarnings("squid:S3077")
private volatile ByteBuffer cachedByteBuffer;
+
// max memTable id
private long maxMemTableId = 0;
// current checkpoint file version id, only updated by fsyncAndDeleteThread
private long currentCheckPointFileVersion = 0;
// current checkpoint file log writer, only updated by fsyncAndDeleteThread
private ILogWriter currentLogWriter;
+
// endregion
public CheckpointManager(String identifier, String logDirectory) throws FileNotFoundException {
@@ -255,6 +258,7 @@
currentLogWriter = new CheckpointWriter(nextLogFile);
return true;
}
+
// endregion
// region methods for pipe
@@ -314,6 +318,7 @@
infoLock.unlock();
}
}
+
// endregion
/** Get MemTableInfo of oldest unpinned MemTable, whose first version id is smallest. */
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java
index 72806f5..e4a497d 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java
@@ -213,6 +213,7 @@
public void unpinMemTable(long memTableId) throws MemTablePinException {
checkpointManager.unpinMemTable(memTableId);
}
+
// endregion
// region Task to delete outdated .wal files
@@ -602,6 +603,7 @@
&& !isContainsActiveOrPinnedMemTable(versionId);
}
}
+
// endregion
// region Search interfaces for consensus group
@@ -619,16 +621,22 @@
private class PlanNodeIterator implements ReqIterator {
/** search index of next element */
private long nextSearchIndex;
+
/** files to search */
private File[] filesToSearch = null;
+
/** index of current searching file in the filesToSearch */
private int currentFileIndex = -1;
+
/** true means filesToSearch and currentFileIndex are outdated, call updateFilesToSearch */
private boolean needUpdatingFilesToSearch = true;
+
/** batch store insert nodes */
private final LinkedList<IndexedConsensusRequest> insertNodes = new LinkedList<>();
+
/** iterator of insertNodes */
private ListIterator<IndexedConsensusRequest> itr = null;
+
/** last broken wal file's version id */
private long brokenFileId = -1;
@@ -927,6 +935,7 @@
public long getTotalSize() {
return WALManager.getInstance().getTotalDiskUsage();
}
+
// endregion
@Override
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/WALRecoverManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/WALRecoverManager.java
index c3a0902..463681d 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/WALRecoverManager.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/WALRecoverManager.java
@@ -57,9 +57,11 @@
// true when the recover procedure has started
private volatile boolean hasStarted = false;
+
// start recovery after all data regions have submitted unsealed zero-level TsFiles
@SuppressWarnings("squid:S3077")
private volatile ExceptionalCountDownLatch allDataRegionScannedLatch;
+
// threads to recover wal nodes
private ExecutorService recoverThreadPool;
// stores all UnsealedTsFileRecoverPerformer submitted by data region processors
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/utils/listener/AbstractResultListener.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/utils/listener/AbstractResultListener.java
index 9acea2b..2d8432a 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/utils/listener/AbstractResultListener.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/utils/listener/AbstractResultListener.java
@@ -30,6 +30,7 @@
protected final boolean wait;
protected volatile Status status;
+
// it's safe to use volatile here to make this reference thread-safe.
@SuppressWarnings("squid:S3077")
protected volatile Exception cause;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/TierManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/TierManager.java
index 5a97a12..ef2921b 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/TierManager.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/TierManager.java
@@ -53,19 +53,24 @@
private static final Logger logger = LoggerFactory.getLogger(TierManager.class);
private static final IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig();
private DirectoryStrategyType directoryStrategyType = DirectoryStrategyType.SEQUENCE_STRATEGY;
+
/**
* seq folder manager of each storage tier, managing both data directories and multi-dir strategy
*/
private final List<FolderManager> seqTiers = new ArrayList<>();
+
/**
* unSeq folder manager of each storage tier, managing both data directories and multi-dir
* strategy
*/
private final List<FolderManager> unSeqTiers = new ArrayList<>();
+
/** seq file folder's rawFsPath path -> tier level */
private final Map<String, Integer> seqDir2TierLevel = new HashMap<>();
+
/** unSeq file folder's rawFsPath path -> tier level */
private final Map<String, Integer> unSeqDir2TierLevel = new HashMap<>();
+
/** total space of each tier, Long.MAX_VALUE when one tier contains remote storage */
private long[] tierDiskTotalSpace;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/agent/SubscriptionBrokerAgent.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/agent/SubscriptionBrokerAgent.java
index 7b75a8d..6fa5bf1 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/agent/SubscriptionBrokerAgent.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/agent/SubscriptionBrokerAgent.java
@@ -80,7 +80,9 @@
consumerGroupIdToSubscriptionBroker.put(consumerGroupId, broker);
}
- /** @return true -> if drop broker success */
+ /**
+ * @return true -> if drop broker success
+ */
public synchronized boolean dropBroker(String consumerGroupId) {
SubscriptionBroker broker = consumerGroupIdToSubscriptionBroker.get(consumerGroupId);
if (Objects.isNull(broker)) {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SerializedEnrichedEvent.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SerializedEnrichedEvent.java
index 095981a..26c65c1 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SerializedEnrichedEvent.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SerializedEnrichedEvent.java
@@ -60,7 +60,9 @@
return enrichedTablets;
}
- /** @return true -> byte buffer is not null */
+ /**
+ * @return true -> byte buffer is not null
+ */
public boolean serialize() {
if (Objects.isNull(byteBuffer)) {
try {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/WalChecker.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/WalChecker.java
index dc40b54..cbf2ead 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/WalChecker.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/WalChecker.java
@@ -113,7 +113,9 @@
}
}
- /** @param args walRootDirectory */
+ /**
+ * @param args walRootDirectory
+ */
public static void main(String[] args) throws WALException {
if (args.length < 1) {
logger.error("No enough args: require the walRootDirectory");
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/settle/TsFileAndModSettleTool.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/settle/TsFileAndModSettleTool.java
index d523580..904bc32 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/settle/TsFileAndModSettleTool.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/settle/TsFileAndModSettleTool.java
@@ -53,6 +53,7 @@
@SuppressWarnings("squid:S6548")
public class TsFileAndModSettleTool {
private static final Logger logger = LoggerFactory.getLogger(TsFileAndModSettleTool.class);
+
// TsFilePath -> SettleCheckStatus
@SuppressWarnings("squid:S1104")
public Map<String, Integer> recoverSettleFileMap = new HashMap<>();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/MathUtils.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/MathUtils.java
index 46a7d15..7aa6818 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/MathUtils.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/MathUtils.java
@@ -28,6 +28,7 @@
private MathUtils() {
throw new IllegalStateException("Utility class");
}
+
/**
* @param data data should be less than Long.MAX_VALUE. otherwise Math.round() will return wrong
* value.
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/MetaUtilsTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/MetaUtilsTest.java
index c95b219..986fdf9 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/MetaUtilsTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/MetaUtilsTest.java
@@ -44,7 +44,8 @@
public class MetaUtilsTest {
private final IMNodeFactory<IMemMNode> nodeFactory =
- MNodeFactoryLoader.getInstance().getMemMNodeIMNodeFactory();;
+ MNodeFactoryLoader.getInstance().getMemMNodeIMNodeFactory();
+ ;
@Test
public void testGetMultiFullPaths() {
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/schemaRegion/SchemaRegionAliasAndTagTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/schemaRegion/SchemaRegionAliasAndTagTest.java
index 56a7479..eed9691 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/schemaRegion/SchemaRegionAliasAndTagTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/schemaRegion/SchemaRegionAliasAndTagTest.java
@@ -56,6 +56,7 @@
super.setUp();
schemaRegion = getSchemaRegion("root.sg", 0);
}
+
/**
* Prepare timeseries
*
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/AlignedSeriesAggregationScanOperatorTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/AlignedSeriesAggregationScanOperatorTest.java
index c9d7225..041621f 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/AlignedSeriesAggregationScanOperatorTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/AlignedSeriesAggregationScanOperatorTest.java
@@ -84,7 +84,8 @@
private static final List<TsFileResource> unSeqResources = new ArrayList<>();
private ExecutorService instanceNotificationExecutor =
- IoTDBThreadPoolFactory.newFixedThreadPool(1, "test-instance-notification");;
+ IoTDBThreadPoolFactory.newFixedThreadPool(1, "test-instance-notification");
+ ;
private static final double DELTA = 0.000001;
@BeforeClass
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/RawDataAggregationOperatorTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/RawDataAggregationOperatorTest.java
index 7fac9a6..46cfc59 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/RawDataAggregationOperatorTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/RawDataAggregationOperatorTest.java
@@ -727,6 +727,7 @@
assertEquals(6, count);
}
+
/** 0 - 199 200 - 259 260 - 299 300 - 379 380 - 399 400 - 499 */
@Test
public void groupByEventRawDataTest4() throws Exception {
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/schedule/DefaultDriverSchedulerTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/schedule/DefaultDriverSchedulerTest.java
index d59175a..0cc0e5e 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/schedule/DefaultDriverSchedulerTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/schedule/DefaultDriverSchedulerTest.java
@@ -56,7 +56,8 @@
private final DriverScheduler manager = DriverScheduler.getInstance();
private ExecutorService instanceNotificationExecutor =
- IoTDBThreadPoolFactory.newFixedThreadPool(1, "test");;
+ IoTDBThreadPoolFactory.newFixedThreadPool(1, "test");
+ ;
@After
public void tearDown() throws IOException {
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/DataRegionTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/DataRegionTest.java
index 3ad8c77..492e66f 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/DataRegionTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/DataRegionTest.java
@@ -318,7 +318,9 @@
@Test
public void testIoTDBTabletWriteAndDeleteDataRegion()
- throws QueryProcessException, IllegalPathException, WriteProcessException,
+ throws QueryProcessException,
+ IllegalPathException,
+ WriteProcessException,
TsFileProcessorException {
String[] measurements = new String[2];
measurements[0] = "s0";
@@ -949,8 +951,11 @@
@Test
public void testInsertUnSequenceRows()
- throws IllegalPathException, WriteProcessRejectException, QueryProcessException,
- DataRegionException, TsFileProcessorException {
+ throws IllegalPathException,
+ WriteProcessRejectException,
+ QueryProcessException,
+ DataRegionException,
+ TsFileProcessorException {
int defaultAvgSeriesPointNumberThreshold = config.getAvgSeriesPointNumberThreshold();
config.setAvgSeriesPointNumberThreshold(2);
DataRegion dataRegion1 = new DummyDataRegion(systemDir, "root.Rows");
@@ -984,8 +989,12 @@
@Test
public void testSmallReportProportionInsertRow()
- throws WriteProcessException, QueryProcessException, IllegalPathException, IOException,
- DataRegionException, TsFileProcessorException {
+ throws WriteProcessException,
+ QueryProcessException,
+ IllegalPathException,
+ IOException,
+ DataRegionException,
+ TsFileProcessorException {
double defaultValue = config.getWriteMemoryVariationReportProportion();
config.setWriteMemoryVariationReportProportion(0);
DataRegion dataRegion1 = new DummyDataRegion(systemDir, "root.ln22");
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/TTLTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/TTLTest.java
index 93f8992..95098ed 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/TTLTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/TTLTest.java
@@ -247,7 +247,9 @@
@Test
public void testTTLRemoval()
- throws StorageEngineException, WriteProcessException, QueryProcessException,
+ throws StorageEngineException,
+ WriteProcessException,
+ QueryProcessException,
IllegalPathException {
prepareData();
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerTest.java
index 79974cc..41ad4be 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerTest.java
@@ -548,6 +548,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=true
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=100
@@ -769,6 +770,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=false
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=100
@@ -870,6 +872,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=false enable_unseq_space_compaction=false
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=100
@@ -957,6 +960,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=true
* compaction_concurrent_thread=50 max_compaction_candidate_file_num=2
@@ -1057,6 +1061,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=false enable_unseq_space_compaction=true
* compaction_concurrent_thread=50 max_compaction_candidate_file_num=2
@@ -1167,6 +1172,7 @@
.setEnableCrossSpaceCompaction(prevEnableCrossCompaction);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=false
* compaction_concurrent_thread=50 max_compaction_candidate_file_num=2
@@ -1489,6 +1495,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=false
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=2
@@ -1606,6 +1613,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=false enable_unseq_space_compaction=false
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=2
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerWithFastPerformerTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerWithFastPerformerTest.java
index 653c225..b2c80ce 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerWithFastPerformerTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerWithFastPerformerTest.java
@@ -549,6 +549,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=true
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=100
@@ -770,6 +771,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=false
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=100
@@ -871,6 +873,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=false enable_unseq_space_compaction=false
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=100
@@ -958,6 +961,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=true
* compaction_concurrent_thread=50 max_compaction_candidate_file_num=2
@@ -1058,6 +1062,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=false enable_unseq_space_compaction=true
* compaction_concurrent_thread=50 max_compaction_candidate_file_num=2
@@ -1168,6 +1173,7 @@
.setEnableCrossSpaceCompaction(prevEnableCrossCompaction);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=false
* compaction_concurrent_thread=50 max_compaction_candidate_file_num=2
@@ -1487,6 +1493,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=true enable_unseq_space_compaction=false
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=2
@@ -1604,6 +1611,7 @@
.setFileLimitPerInnerTask(prevMaxCompactionCandidateFileNum);
}
}
+
/**
* enable_seq_space_compaction=false enable_unseq_space_compaction=false
* compaction_concurrent_thread=1 max_compaction_candidate_file_num=2
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/TsFileValidationCorrectnessTests.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/TsFileValidationCorrectnessTests.java
index a99f78e..28a8628 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/TsFileValidationCorrectnessTests.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/TsFileValidationCorrectnessTests.java
@@ -63,6 +63,7 @@
FileUtils.forceDelete(new File(dir));
}
+
// 1. empty tsfile
@Test
public void testTsFileHasNoData() throws IOException {
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/CrossSpaceCompactionSelectorTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/CrossSpaceCompactionSelectorTest.java
index 78b71ea..3f86a18 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/CrossSpaceCompactionSelectorTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/CrossSpaceCompactionSelectorTest.java
@@ -185,7 +185,10 @@
@Test
public void testSelectWithTooManySourceFiles()
- throws IOException, MetadataException, WriteProcessException, InterruptedException,
+ throws IOException,
+ MetadataException,
+ WriteProcessException,
+ InterruptedException,
ExecutionException {
int oldMaxFileNumForCompaction = SystemInfo.getInstance().getTotalFileLimitForCompaction();
SystemInfo.getInstance().setTotalFileLimitForCompactionTask(1);
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/CrossSpaceCompactionWithReadPointPerformerValidationTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/CrossSpaceCompactionWithReadPointPerformerValidationTest.java
index d342615..f4b7118 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/CrossSpaceCompactionWithReadPointPerformerValidationTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/CrossSpaceCompactionWithReadPointPerformerValidationTest.java
@@ -2086,8 +2086,12 @@
*/
@Test
public void testSelectingFilesWhenSomeFilesBeingDeleted()
- throws MetadataException, IOException, WriteProcessException, StorageEngineException,
- InterruptedException, MergeException {
+ throws MetadataException,
+ IOException,
+ WriteProcessException,
+ StorageEngineException,
+ InterruptedException,
+ MergeException {
registerTimeseriesInMManger(5, 10, true);
createFiles(5, 10, 5, 1000, 0, 0, 100, 100, false, true);
createFiles(1, 5, 10, 4500, 500, 500, 0, 100, false, false);
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/RewriteCompactionFileSelectorTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/RewriteCompactionFileSelectorTest.java
index 42078ab..49f8c0c 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/RewriteCompactionFileSelectorTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/RewriteCompactionFileSelectorTest.java
@@ -134,7 +134,10 @@
*/
@Test
public void testFileOpenSelection()
- throws MergeException, IOException, WriteProcessException, NoSuchFieldException,
+ throws MergeException,
+ IOException,
+ WriteProcessException,
+ NoSuchFieldException,
IllegalAccessException {
File file =
new File(
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/inner/NewReadChunkCompactionPerformerWithAlignedSeriesTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/inner/NewReadChunkCompactionPerformerWithAlignedSeriesTest.java
index 1932a5c..455674c 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/inner/NewReadChunkCompactionPerformerWithAlignedSeriesTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/inner/NewReadChunkCompactionPerformerWithAlignedSeriesTest.java
@@ -85,7 +85,10 @@
@Test
public void testSimpleCompactionByFlushChunk()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -131,7 +134,10 @@
@Test
public void testSimpleCompactionWithNullColumnByFlushChunk()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -177,7 +183,10 @@
@Test
public void testSimpleCompactionWithAllDeletedColumnByFlushChunk()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -228,7 +237,10 @@
@Test
public void testSimpleCompactionWithNotExistColumnByFlushChunk()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -279,7 +291,10 @@
@Test
public void testSimpleCompactionWithNullColumn()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 = createEmptyFileAndResource(true);
try (CompactionTestFileWriter writer = new CompactionTestFileWriter(seqResource1)) {
@@ -332,7 +347,10 @@
@Test
public void testSimpleCompactionWithPartialDeletedColumnByFlushChunk()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -434,7 +452,10 @@
@Test
public void testSimpleCompactionWithPartialDeletedPageByWritePoint()
- throws IOException, MetadataException, StorageEngineException, InterruptedException,
+ throws IOException,
+ MetadataException,
+ StorageEngineException,
+ InterruptedException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -486,7 +507,10 @@
@Test
public void testSimpleCompactionByFlushPage()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -532,7 +556,10 @@
@Test
public void testSimpleCompactionByWritePoint()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -578,7 +605,10 @@
@Test
public void testCompactionWithDifferentCompressionTypeOrEncoding()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
TsFileResource seqResource1 =
generateSingleAlignedSeriesFile(
@@ -635,7 +665,10 @@
@Test
public void testFlushChunkMetadataToTempFile()
- throws IOException, StorageEngineException, InterruptedException, MetadataException,
+ throws IOException,
+ StorageEngineException,
+ InterruptedException,
+ MetadataException,
PageException {
List<String> devices = new ArrayList<>();
for (int i = 0; i < 1000; i++) {
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/utils/MultiTsFileDeviceIteratorTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/utils/MultiTsFileDeviceIteratorTest.java
index 0e9c3cb..540ba10 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/utils/MultiTsFileDeviceIteratorTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/utils/MultiTsFileDeviceIteratorTest.java
@@ -402,7 +402,10 @@
*/
@Test
public void getDeletedDevicesWithSameNameFromSeqFilesByReadChunkPerformer()
- throws MetadataException, IOException, WriteProcessException, StorageEngineException,
+ throws MetadataException,
+ IOException,
+ WriteProcessException,
+ StorageEngineException,
InterruptedException {
TSFileDescriptor.getInstance().getConfig().setMaxDegreeOfIndexNode(3);
int oldAlignedDeviceOffset = TsFileGeneratorUtils.alignDeviceOffset;
@@ -548,7 +551,10 @@
*/
@Test
public void getDeletedDevicesWithSameNameFromSeqFilesByReadChunkPerformer2()
- throws MetadataException, IOException, WriteProcessException, StorageEngineException,
+ throws MetadataException,
+ IOException,
+ WriteProcessException,
+ StorageEngineException,
InterruptedException {
TSFileDescriptor.getInstance().getConfig().setMaxDegreeOfIndexNode(3);
int oldAlignedDeviceOffset = TsFileGeneratorUtils.alignDeviceOffset;
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/file/UnsealedTsFileRecoverPerformerTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/file/UnsealedTsFileRecoverPerformerTest.java
index 9d5ef2f..472cf96 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/file/UnsealedTsFileRecoverPerformerTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/file/UnsealedTsFileRecoverPerformerTest.java
@@ -331,7 +331,10 @@
@Test
public void testRecoverDuplicate()
- throws IllegalPathException, IOException, WriteProcessException, DataRegionException,
+ throws IllegalPathException,
+ IOException,
+ WriteProcessException,
+ DataRegionException,
WALRecoverException {
// generate crashed .tsfile
File file = new File(FILE_NAME);
diff --git a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/utils/SerializeUtilsTest.java b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/utils/SerializeUtilsTest.java
index 8badb6e..c854c23 100644
--- a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/utils/SerializeUtilsTest.java
+++ b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/utils/SerializeUtilsTest.java
@@ -322,6 +322,7 @@
batchDataSerializableTest(1000);
batchDataSerializableTest(1500);
}
+
// In DescReadWriteBatchData, read has the same order with descending write
private void descReadWriteBatchDataSerializableTest(int dataSize) {
double E = 0.00001;
@@ -569,6 +570,7 @@
}
Assert.assertFalse(fullMsg, data2.hasCurrent());
}
+
// In DescReadBatchData, read has a reverse order with ascending write
private void descReadBatchDataSerializableTest(int dataSize) {
double E = 0.00001;
@@ -815,6 +817,7 @@
}
Assert.assertFalse(fullMsg, data2.hasCurrent());
}
+
// In BatchData, read has a reverse order with ascending write
private void batchDataSerializableTest(int dataSize) {
double E = 0.00001;
diff --git a/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java b/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java
index 5e0616b..f5197dc 100644
--- a/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java
+++ b/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java
@@ -51,6 +51,7 @@
/** The clock which is used in Metric system */
private final Clock clock = Clock.SYSTEM;
+
/** The histogram config which is used to create IoTDBTimer and IoTDBHistogram */
private final DistributionStatisticConfig IoTDBDistributionStatisticConfig;
diff --git a/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/reporter/IoTDBJmxReporter.java b/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/reporter/IoTDBJmxReporter.java
index 2534086..9a00273 100644
--- a/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/reporter/IoTDBJmxReporter.java
+++ b/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/reporter/IoTDBJmxReporter.java
@@ -44,14 +44,19 @@
public class IoTDBJmxReporter implements JmxReporter {
private static final Logger LOGGER = LoggerFactory.getLogger(IoTDBJmxReporter.class);
+
/** Domain name of IoTDB Metrics */
private static final String DOMAIN = "org.apache.iotdb.metrics";
+
/** The metricManager of IoTDB */
private final AbstractMetricManager metricManager;
+
/** The objectNameFactory used to create objectName for metrics */
private final ObjectNameFactory objectNameFactory;
+
/** The map that stores all registered metrics */
private final Map<ObjectName, ObjectName> registered;
+
/** The JMX MBeanServer */
private final MBeanServer mBeanServer;
diff --git a/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/uitls/IoTDBCachedGauge.java b/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/uitls/IoTDBCachedGauge.java
index c287170..9c1dd71 100644
--- a/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/uitls/IoTDBCachedGauge.java
+++ b/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/uitls/IoTDBCachedGauge.java
@@ -40,14 +40,19 @@
implements AutoGauge, IoTDBCachedGaugeMBean {
/** The timer of metric system */
private final Clock clock;
+
/** The time to reload cache */
private final AtomicLong reloadAt;
+
/** The timeout duration */
private final long timeoutNS;
+
/** The cache's value */
private final AtomicReference<Double> value;
+
/** The reference object of gauge */
private final WeakReference<T> refObj;
+
/** The calculate function of gauge */
private final ToDoubleFunction<T> mapper;
diff --git a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricManager.java b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricManager.java
index 0699aa7..0d531a0 100644
--- a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricManager.java
+++ b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricManager.java
@@ -50,10 +50,13 @@
protected static final MetricConfig METRIC_CONFIG =
MetricConfigDescriptor.getInstance().getMetricConfig();
private static final String ALREADY_EXISTS = " is already used for a different type of name";
+
/** The map from metric name to metric metaInfo. */
protected Map<String, MetricInfo.MetaInfo> nameToMetaInfo;
+
/** The map from metricInfo to metric. */
protected Map<MetricInfo, IMetric> metrics;
+
/** The bind IoTDBJmxReporter */
protected JmxReporter bindJmxReporter = null;
diff --git a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricService.java b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricService.java
index 2caf1f0..02ce273 100644
--- a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricService.java
+++ b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricService.java
@@ -52,15 +52,20 @@
/** MetricService is the entry to get all metric features. */
public abstract class AbstractMetricService {
private static final Logger LOGGER = LoggerFactory.getLogger(AbstractMetricService.class);
+
/** The config of metric service. */
protected static final MetricConfig METRIC_CONFIG =
MetricConfigDescriptor.getInstance().getMetricConfig();
+
/** The metric manager of metric service. */
protected AbstractMetricManager metricManager = new DoNothingMetricManager();
+
/** The metric reporter of metric service. */
protected CompositeReporter compositeReporter = new CompositeReporter();
+
/** The internal reporter of metric service. */
protected IoTDBInternalReporter internalReporter = new IoTDBInternalMemoryReporter();
+
/** The list of metric sets. */
protected Set<IMetricSet> metricSets = new HashSet<>();
diff --git a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/config/MetricConfig.java b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/config/MetricConfig.java
index aaa3fe4..a2b1a58 100644
--- a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/config/MetricConfig.java
+++ b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/config/MetricConfig.java
@@ -36,6 +36,7 @@
public class MetricConfig {
private static final Logger LOGGER = LoggerFactory.getLogger(MetricConfig.class);
+
/** The list of reporters provide metrics for external tool. */
private List<ReporterType> metricReporterList = Collections.emptyList();
@@ -56,12 +57,16 @@
/** The pid of iotdb instance. */
private String pid = "";
+
/** The running system of iotdb instance. */
private final SystemType systemType = SystemType.getSystemType();
+
/** The type of monitored node. */
private NodeType nodeType = NodeType.CONFIGNODE;
+
/** The name of iotdb cluster. */
private String clusterName = "defaultCluster";
+
/** The id of iotdb node. */
private int nodeId = 0;
@@ -205,16 +210,22 @@
public static class IoTDBReporterConfig {
/** The host of iotdb that store metric value. */
private String host = "127.0.0.1";
+
/** The port of iotdb that store metric value. */
private Integer port = 6667;
+
/** The username of iotdb. */
private String username = "root";
+
/** The password of iotdb. */
private String password = "root";
+
/** The max number of connection. */
private Integer maxConnectionNumber = 3;
+
/** The location of iotdb metrics. */
private String location = "metric";
+
/** The period of data pushed by the reporter to the remote monitoring system. */
private Integer pushPeriodInSecond = 15;
diff --git a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/reporter/iotdb/IoTDBSessionReporter.java b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/reporter/iotdb/IoTDBSessionReporter.java
index 09c3b50..c5d431d 100644
--- a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/reporter/iotdb/IoTDBSessionReporter.java
+++ b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/reporter/iotdb/IoTDBSessionReporter.java
@@ -56,6 +56,7 @@
/** The manager of metrics. */
protected AbstractMetricManager metricManager;
+
/** The session pool to write metrics. */
protected SessionPool sessionPool;
diff --git a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/utils/MetricInfo.java b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/utils/MetricInfo.java
index fdbf74a..e223aac 100644
--- a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/utils/MetricInfo.java
+++ b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/utils/MetricInfo.java
@@ -34,10 +34,13 @@
private static final Logger logger = LoggerFactory.getLogger(MetricInfo.class);
private static final Integer PAIR_SIZE = 2;
+
/** The name of metric. */
private final String name;
+
/** The tags of metric. */
private final Map<String, String> tags = new LinkedHashMap<>();
+
/** The metaInfo of metric. */
private final MetaInfo metaInfo;
@@ -134,6 +137,7 @@
public static class MetaInfo {
/** The type of metric. */
private final MetricType type;
+
/** The tag keys of metric. */
private final Set<String> tagNames;
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/entity/Role.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/entity/Role.java
index 017d6d0..581df28 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/entity/Role.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/entity/Role.java
@@ -179,6 +179,7 @@
public boolean checkSysPriGrantOpt(int privilegeId) {
return sysPrivilegeSet.contains(privilegeId) && sysPriGrantOpt.contains(privilegeId);
}
+
/** ----------- misc --------------------* */
@Override
public boolean equals(Object o) {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/BasicUserManager.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/BasicUserManager.java
index b644501..bf7d3a6 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/BasicUserManager.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/BasicUserManager.java
@@ -69,6 +69,7 @@
public boolean preVersion() {
return this.preVersion;
}
+
// FOR PRE VERSION DONE ------
/**
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/LocalFileUserAccessor.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/LocalFileUserAccessor.java
index f140a78..03a0759 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/LocalFileUserAccessor.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/LocalFileUserAccessor.java
@@ -86,6 +86,7 @@
public static final String ROLE_SUFFIX = "_role";
private final String userDirPath;
+
/**
* Reused buffer for primitive types encoding/decoding, which aim to reduce memory fragments. Use
* ThreadLocal for thread safety.
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/property/ThriftClientProperty.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/property/ThriftClientProperty.java
index 824eb64..f8fe161 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/property/ThriftClientProperty.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/property/ThriftClientProperty.java
@@ -64,8 +64,10 @@
/** whether to use thrift compression. */
private boolean rpcThriftCompressionEnabled = DefaultProperty.RPC_THRIFT_COMPRESSED_ENABLED;
+
/** socket timeout for thrift client. */
private int connectionTimeoutMs = DefaultProperty.CONNECTION_TIMEOUT_MS;
+
/** number of selector threads for asynchronous thrift client in a clientManager. */
private int selectorNumOfAsyncClientManager =
DefaultProperty.SELECTOR_NUM_OF_ASYNC_CLIENT_MANAGER;
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/ProgressIndex.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/ProgressIndex.java
index ad82065..7bbcedf 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/ProgressIndex.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/ProgressIndex.java
@@ -116,7 +116,9 @@
public abstract ProgressIndex updateToMinimumEqualOrIsAfterProgressIndex(
ProgressIndex progressIndex);
- /** @return the type of this {@link ProgressIndex} */
+ /**
+ * @return the type of this {@link ProgressIndex}
+ */
public abstract ProgressIndexType getType();
/**
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/impl/TimeWindowStateProgressIndex.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/impl/TimeWindowStateProgressIndex.java
index da7fc35..ea5469b 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/impl/TimeWindowStateProgressIndex.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/consensus/index/impl/TimeWindowStateProgressIndex.java
@@ -131,7 +131,9 @@
final TimeWindowStateProgressIndex thisTimeWindowStateProgressIndex = this;
final TimeWindowStateProgressIndex thatTimeWindowStateProgressIndex =
(TimeWindowStateProgressIndex) progressIndex;
- return thatTimeWindowStateProgressIndex.timeSeries2TimestampWindowBufferPairMap.entrySet()
+ return thatTimeWindowStateProgressIndex
+ .timeSeries2TimestampWindowBufferPairMap
+ .entrySet()
.stream()
.noneMatch(
entry ->
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/IoTDBException.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/IoTDBException.java
index 5101abf..0a93d80 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/IoTDBException.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/IoTDBException.java
@@ -24,6 +24,7 @@
private static final long serialVersionUID = 8480450962311247736L;
protected int errorCode;
+
/**
* This kind of exception is caused by users' wrong sql, and there is no need for server to print
* the full stack of the exception
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/executable/ExecutableManager.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/executable/ExecutableManager.java
index 57f77e2..8dc39bd 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/executable/ExecutableManager.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/executable/ExecutableManager.java
@@ -103,6 +103,7 @@
getFileByFullPath(libRoot),
false);
}
+
// endregion
// ======================================================
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PartialPath.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PartialPath.java
index 2ffeca5..5a530ce 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PartialPath.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PartialPath.java
@@ -94,7 +94,9 @@
this.fullPath = getFullPath();
}
- /** @param partialNodes nodes of a time series path */
+ /**
+ * @param partialNodes nodes of a time series path
+ */
public PartialPath(String[] partialNodes) {
nodes = partialNodes;
}
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PathPatternNode.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PathPatternNode.java
index 8ca7385..80e48f2 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PathPatternNode.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PathPatternNode.java
@@ -45,6 +45,7 @@
private final String name;
private final Map<String, PathPatternNode<V, VSerializer>> children;
private Set<V> valueSet;
+
/**
* Used only in PatternTreeMap to identify whether from root to the current node is a registered
* path pattern. In PatternTreeMap, it can be replaced by the size of the valueSet
@@ -112,7 +113,9 @@
return valueSet;
}
- /** @return true if from root to the current node is a registered path pattern. */
+ /**
+ * @return true if from root to the current node is a registered path pattern.
+ */
public boolean isPathPattern() {
return mark || isLeaf();
}
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PatternTreeMap.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PatternTreeMap.java
index 8b065fc..130c605 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PatternTreeMap.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/PatternTreeMap.java
@@ -36,6 +36,7 @@
private final BiConsumer<V, Set<V>> appendFunction;
private final BiConsumer<V, Set<V>> deleteFunction;
private final VSerializer serializer;
+
/**
* Create PatternTreeMap.
*
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IFAState.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IFAState.java
index a216340..e7be9e8 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IFAState.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IFAState.java
@@ -22,12 +22,18 @@
/** This interface defines the behaviour of a FA(Finite Automation)'s states. */
public interface IFAState {
- /** @return whether this state is the initial state of the belonged FA */
+ /**
+ * @return whether this state is the initial state of the belonged FA
+ */
boolean isInitial();
- /** @return whether this state is one of the final state of the belonged FA */
+ /**
+ * @return whether this state is one of the final state of the belonged FA
+ */
boolean isFinal();
- /** @return the index of this state, used for uniquely identifying states in FA */
+ /**
+ * @return the index of this state, used for uniquely identifying states in FA
+ */
int getIndex();
}
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IFATransition.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IFATransition.java
index 2663cb7..56a2ba5 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IFATransition.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IFATransition.java
@@ -22,7 +22,9 @@
/** This interface defines the behaviour of a FA(Finite Automation)'s transition. */
public interface IFATransition {
- /** @return the value of this transition, which is used to match the events */
+ /**
+ * @return the value of this transition, which is used to match the events
+ */
String getAcceptEvent();
/**
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IPatternFA.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IPatternFA.java
index 3016ab4..30249cd 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IPatternFA.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/IPatternFA.java
@@ -65,10 +65,14 @@
*/
IFAState getNextState(IFAState sourceState, IFATransition transition);
- /** @return the initial state of this FA */
+ /**
+ * @return the initial state of this FA
+ */
IFAState getInitialState();
- /** @return the size of states this FA has */
+ /**
+ * @return the size of states this FA has
+ */
int getStateSize();
/**
@@ -97,7 +101,9 @@
return this;
}
- /** @param patternTree the included PartialPath must be a prefix or a fullPath */
+ /**
+ * @param patternTree the included PartialPath must be a prefix or a fullPath
+ */
public Builder patternTree(PathPatternTree patternTree) {
this.patternTree = patternTree;
return this;
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/match/IStateMatchInfo.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/match/IStateMatchInfo.java
index da582c3..8295849 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/match/IStateMatchInfo.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/path/fa/match/IStateMatchInfo.java
@@ -30,7 +30,9 @@
*/
public interface IStateMatchInfo {
- /** @return whether current matched state has a final state */
+ /**
+ * @return whether current matched state has a final state
+ */
boolean hasFinalState();
/**
@@ -51,7 +53,9 @@
*/
boolean isSingleFuzzyMatchTransition();
- /** @return one of the matched state */
+ /**
+ * @return one of the matched state
+ */
IFAState getOneMatchedState();
void addMatchedState(IFAState state);
@@ -62,19 +66,29 @@
*/
IFAState getMatchedState(int stateOrdinal);
- /** @return size of current matched states */
+ /**
+ * @return size of current matched states
+ */
int getMatchedStateSize();
- /** @return the ordinal of the source state in matched order */
+ /**
+ * @return the ordinal of the source state in matched order
+ */
int getSourceStateOrdinal();
- /** @param sourceStateOrdinal the ordinal of the source state in matched order */
+ /**
+ * @param sourceStateOrdinal the ordinal of the source state in matched order
+ */
void setSourceStateOrdinal(int sourceStateOrdinal);
- /** @return the iterator of current checking source states' transition */
+ /**
+ * @return the iterator of current checking source states' transition
+ */
Iterator<IFATransition> getSourceTransitionIterator();
- /** @param sourceTransitionIterator the iterator of current checking source states' transition */
+ /**
+ * @param sourceTransitionIterator the iterator of current checking source states' transition
+ */
void setSourceTransitionIterator(Iterator<IFATransition> sourceTransitionIterator);
IFAState getScopeMatchedState();
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/task/subtask/PipeAbstractConnectorSubtask.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/task/subtask/PipeAbstractConnectorSubtask.java
index 4d0bae8..f5bfe36 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/task/subtask/PipeAbstractConnectorSubtask.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/task/subtask/PipeAbstractConnectorSubtask.java
@@ -113,7 +113,9 @@
: new PipeRuntimeConnectorCriticalException(throwable.getMessage()));
}
- /** @return {@code true} if the {@link PipeSubtask} should be stopped, {@code false} otherwise */
+ /**
+ * @return {@code true} if the {@link PipeSubtask} should be stopped, {@code false} otherwise
+ */
private boolean onPipeConnectionException(Throwable throwable) {
LOGGER.warn(
"PipeConnectionException occurred, {} retries to handshake with the target system.",
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/node/info/IDeviceInfo.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/node/info/IDeviceInfo.java
index 6e79544..456a517 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/node/info/IDeviceInfo.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/node/info/IDeviceInfo.java
@@ -46,10 +46,14 @@
void setSchemaTemplateId(int schemaTemplateId);
- /** @return the logic id of template set or activated on this node, id>=-1 */
+ /**
+ * @return the logic id of template set or activated on this node, id>=-1
+ */
int getSchemaTemplateId();
- /** @return the template id with current state, may be negative since unset or deactivation */
+ /**
+ * @return the template id with current state, may be negative since unset or deactivation
+ */
int getSchemaTemplateIdWithState();
boolean isPreDeactivateTemplate();
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/node/role/IDeviceMNode.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/node/role/IDeviceMNode.java
index 4e8c697..1df1c51 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/node/role/IDeviceMNode.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/node/role/IDeviceMNode.java
@@ -37,10 +37,14 @@
void setSchemaTemplateId(int schemaTemplateId);
- /** @return the logic id of template set or activated on this node, id>=-1 */
+ /**
+ * @return the logic id of template set or activated on this node, id>=-1
+ */
int getSchemaTemplateId();
- /** @return the template id with current state, may be negative since unset or deactivation */
+ /**
+ * @return the template id with current state, may be negative since unset or deactivation
+ */
int getSchemaTemplateIdWithState();
boolean isPreDeactivateTemplate();
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ViewExpression.java
index 2862acb..d995376 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ViewExpression.java
@@ -73,7 +73,9 @@
public abstract ViewExpressionType getExpressionType();
- /** @return if this view expression is a leaf node, return true; else return false. */
+ /**
+ * @return if this view expression is a leaf node, return true; else return false.
+ */
public final boolean isLeafOperand() {
return isLeafOperandInternal();
}
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/BinaryViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/BinaryViewExpression.java
index 642a904..3aaff86 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/BinaryViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/BinaryViewExpression.java
@@ -49,6 +49,7 @@
this.leftExpression = ViewExpression.deserialize(inputStream);
this.rightExpression = ViewExpression.deserialize(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
@@ -78,6 +79,7 @@
ViewExpression.serialize(leftExpression, stream);
ViewExpression.serialize(rightExpression, stream);
}
+
// endregion
public void setLeftExpression(ViewExpression leftExpression) {
this.leftExpression = leftExpression;
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/AdditionViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/AdditionViewExpression.java
index 328cc36..699ccc3 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/AdditionViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/AdditionViewExpression.java
@@ -40,6 +40,7 @@
public AdditionViewExpression(InputStream inputStream) {
super(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/ArithmeticBinaryViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/ArithmeticBinaryViewExpression.java
index f51d54e..ded0331 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/ArithmeticBinaryViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/ArithmeticBinaryViewExpression.java
@@ -41,6 +41,7 @@
protected ArithmeticBinaryViewExpression(InputStream inputStream) {
super(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/DivisionViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/DivisionViewExpression.java
index ce25023..86fe8c1 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/DivisionViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/DivisionViewExpression.java
@@ -40,6 +40,7 @@
public DivisionViewExpression(InputStream inputStream) {
super(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/ModuloViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/ModuloViewExpression.java
index ef09107..decbdc7 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/ModuloViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/ModuloViewExpression.java
@@ -40,6 +40,7 @@
public ModuloViewExpression(InputStream inputStream) {
super(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/MultiplicationViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/MultiplicationViewExpression.java
index ca0f479..869f908 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/MultiplicationViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/MultiplicationViewExpression.java
@@ -41,6 +41,7 @@
public MultiplicationViewExpression(InputStream inputStream) {
super(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/SubtractionViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/SubtractionViewExpression.java
index 56aaea3..9010578 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/SubtractionViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/arithmetic/SubtractionViewExpression.java
@@ -40,6 +40,7 @@
public SubtractionViewExpression(InputStream inputStream) {
super(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/compare/CompareBinaryViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/compare/CompareBinaryViewExpression.java
index 37efefc..e9c7d1f 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/compare/CompareBinaryViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/compare/CompareBinaryViewExpression.java
@@ -41,6 +41,7 @@
protected CompareBinaryViewExpression(InputStream inputStream) {
super(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/logic/LogicBinaryViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/logic/LogicBinaryViewExpression.java
index d293df6..46631b1 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/logic/LogicBinaryViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/binary/logic/LogicBinaryViewExpression.java
@@ -41,6 +41,7 @@
protected LogicBinaryViewExpression(InputStream inputStream) {
super(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/NullViewOperand.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/NullViewOperand.java
index c18b295..955e83e 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/NullViewOperand.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/NullViewOperand.java
@@ -29,7 +29,9 @@
public class NullViewOperand extends LeafViewOperand {
// region member variables and init functions
- public NullViewOperand() {};
+ public NullViewOperand() {}
+ ;
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/TimeSeriesViewOperand.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/TimeSeriesViewOperand.java
index d506f43..e530dee 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/TimeSeriesViewOperand.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/TimeSeriesViewOperand.java
@@ -50,6 +50,7 @@
throw new RuntimeException(e);
}
}
+
// endregion
// region common interfaces that have to be implemented
@@ -77,6 +78,7 @@
protected void serialize(OutputStream stream) throws IOException {
ReadWriteIOUtils.write(pathString, stream);
}
+
// endregion
public String getPathString() {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/TimestampViewOperand.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/TimestampViewOperand.java
index c23e49c..a64d720 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/TimestampViewOperand.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/leaf/TimestampViewOperand.java
@@ -31,7 +31,8 @@
// region member variables and init functions
public TimestampViewOperand() {
// do nothing
- };
+ }
+ ;
public TimestampViewOperand(ByteBuffer byteBuffer) {
// do nothing
@@ -40,6 +41,7 @@
public TimestampViewOperand(InputStream inputStream) {
// do nothing
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/multi/FunctionViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/multi/FunctionViewExpression.java
index ada4e01..eace434 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/multi/FunctionViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/multi/FunctionViewExpression.java
@@ -100,6 +100,7 @@
throw new RuntimeException(e);
}
}
+
// endregion
// region common interfaces that have to be implemented
@@ -178,6 +179,7 @@
ViewExpression.serialize(expression, stream);
}
}
+
// endregion
public String getFunctionName() {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ternary/BetweenViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ternary/BetweenViewExpression.java
index 128cad9..e4af291 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ternary/BetweenViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ternary/BetweenViewExpression.java
@@ -66,6 +66,7 @@
throw new RuntimeException(e);
}
}
+
// endregion
// region common interfaces that have to be implemented
@@ -104,6 +105,7 @@
super.serialize(stream);
ReadWriteIOUtils.write(isNotBetween, stream);
}
+
// endregion
public boolean isNotBetween() {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ternary/TernaryViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ternary/TernaryViewExpression.java
index f46e3bd..9ce3c7b 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ternary/TernaryViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/ternary/TernaryViewExpression.java
@@ -58,6 +58,7 @@
this.secondExpression = ViewExpression.deserialize(inputStream);
this.thirdExpression = ViewExpression.deserialize(inputStream);
}
+
// endregion
// region common interfaces that have to be implemented
@@ -89,6 +90,7 @@
ViewExpression.serialize(secondExpression, stream);
ViewExpression.serialize(thirdExpression, stream);
}
+
// endregion
public ViewExpression getFirstExpression() {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/InViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/InViewExpression.java
index d601739..50441bb 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/InViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/InViewExpression.java
@@ -60,6 +60,7 @@
throw new RuntimeException(e);
}
}
+
// endregion
// region common interfaces that have to be implemented
@@ -91,6 +92,7 @@
ReadWriteIOUtils.write(isNotIn, stream);
ReadWriteIOUtils.writeStringList(this.valueList, stream);
}
+
// endregion
public boolean isNotIn() {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/IsNullViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/IsNullViewExpression.java
index ea048da..655418c 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/IsNullViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/IsNullViewExpression.java
@@ -53,6 +53,7 @@
throw new RuntimeException(e);
}
}
+
// endregion
// region common interfaces that have to be implemented
@@ -82,6 +83,7 @@
super.serialize(stream);
ReadWriteIOUtils.write(isNot, stream);
}
+
// endregion
public boolean isNot() {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/LikeViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/LikeViewExpression.java
index bc3d37e..12cbc51 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/LikeViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/LikeViewExpression.java
@@ -71,6 +71,7 @@
throw new RuntimeException(e);
}
}
+
// endregion
// region common interfaces that have to be implemented
@@ -107,6 +108,7 @@
ReadWriteIOUtils.write(patternString, stream);
ReadWriteIOUtils.write(isNot, stream);
}
+
// endregion
public String getPatternString() {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/LogicNotViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/LogicNotViewExpression.java
index 89ef25f..b3eb592 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/LogicNotViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/LogicNotViewExpression.java
@@ -40,6 +40,7 @@
public LogicNotViewExpression(InputStream inputStream) {
super(ViewExpression.deserialize(inputStream));
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/NegationViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/NegationViewExpression.java
index 0e62d90..2d3e9aa 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/NegationViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/NegationViewExpression.java
@@ -40,6 +40,7 @@
public NegationViewExpression(InputStream inputStream) {
super(ViewExpression.deserialize(inputStream));
}
+
// endregion
// region common interfaces that have to be implemented
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/RegularViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/RegularViewExpression.java
index 0770161..ad0e4d8 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/RegularViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/RegularViewExpression.java
@@ -72,6 +72,7 @@
throw new RuntimeException(e);
}
}
+
// endregion
// region common interfaces that have to be implemented
@@ -108,6 +109,7 @@
ReadWriteIOUtils.write(patternString, stream);
ReadWriteIOUtils.write(isNot, stream);
}
+
// endregion
public String getPatternString() {
return patternString;
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/UnaryViewExpression.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/UnaryViewExpression.java
index de91883..be424a1 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/UnaryViewExpression.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/unary/UnaryViewExpression.java
@@ -65,6 +65,7 @@
protected void serialize(OutputStream stream) throws IOException {
ViewExpression.serialize(expression, stream);
}
+
// endregion
public final ViewExpression getExpression() {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/visitor/ViewExpressionVisitor.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/visitor/ViewExpressionVisitor.java
index 4014689..fdbd55d 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/visitor/ViewExpressionVisitor.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/view/viewExpression/visitor/ViewExpressionVisitor.java
@@ -88,6 +88,7 @@
public R visitTimeStampOperand(TimestampViewOperand timestampOperand, C context) {
return visitLeafOperand(timestampOperand, context);
}
+
// endregion
// region Unary Expressions
@@ -118,6 +119,7 @@
public R visitRegularExpression(RegularViewExpression regularExpression, C context) {
return visitUnaryExpression(regularExpression, context);
}
+
// endregion
// region Binary Expressions
@@ -151,6 +153,7 @@
public R visitSubtractionExpression(SubtractionViewExpression subtractionExpression, C context) {
return visitArithmeticBinaryExpression(subtractionExpression, context);
}
+
// endregion
// region Binary: Compare Binary Expression
@@ -183,6 +186,7 @@
public R visitNonEqualExpression(NonEqualViewExpression nonEqualExpression, C context) {
return visitCompareBinaryExpression(nonEqualExpression, context);
}
+
// endregion
// region Binary : Logic Binary Expression
@@ -197,6 +201,7 @@
public R visitLogicOrExpression(LogicOrViewExpression logicOrExpression, C context) {
return visitLogicBinaryExpression(logicOrExpression, context);
}
+
// endregion
// endregion
@@ -209,6 +214,7 @@
public R visitBetweenExpression(BetweenViewExpression betweenViewExpression, C context) {
return visitTernaryExpression(betweenViewExpression, context);
}
+
// endregion
// region FunctionExpression
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/StartupChecks.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/StartupChecks.java
index 6199c18..d9eb6fb 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/StartupChecks.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/StartupChecks.java
@@ -97,6 +97,7 @@
preChecks.add(this::checkJDK);
preChecks.add(this::checkJVM);
}
+
/** execute every pretest. */
protected void verify() throws StartupException {
for (StartupCheck check : preChecks) {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/ThriftService.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/ThriftService.java
index 9834190..e160e2d 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/ThriftService.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/ThriftService.java
@@ -88,8 +88,11 @@
}
public abstract void initTProcessor()
- throws ClassNotFoundException, IllegalAccessException, InstantiationException,
- NoSuchMethodException, InvocationTargetException;
+ throws ClassNotFoundException,
+ IllegalAccessException,
+ InstantiationException,
+ NoSuchMethodException,
+ InvocationTargetException;
public abstract void initThriftServiceThread()
throws IllegalAccessException, InstantiationException, ClassNotFoundException;
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/consumer/ConsumerGroupMeta.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/consumer/ConsumerGroupMeta.java
index 377a27e..d538682 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/consumer/ConsumerGroupMeta.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/consumer/ConsumerGroupMeta.java
@@ -136,7 +136,9 @@
}
}
- /** @return topics subscribed by no consumers in this group after this removal. */
+ /**
+ * @return topics subscribed by no consumers in this group after this removal.
+ */
public Set<String> removeSubscription(String consumerId, Set<String> topics) {
if (!consumerIdToConsumerMeta.containsKey(consumerId)) {
throw new SubscriptionException(
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/topic/TopicMeta.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/topic/TopicMeta.java
index 816d41a..2c9e699 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/topic/TopicMeta.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/topic/TopicMeta.java
@@ -80,7 +80,9 @@
return config;
}
- /** @return true if the consumer group did not already subscribe this topic */
+ /**
+ * @return true if the consumer group did not already subscribe this topic
+ */
public boolean addSubscribedConsumerGroup(String consumerGroupId) {
return subscribedConsumerGroupIds.add(consumerGroupId);
}
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/trigger/TriggerInformation.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/trigger/TriggerInformation.java
index 39d715f..5632dd2 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/trigger/TriggerInformation.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/trigger/TriggerInformation.java
@@ -54,10 +54,12 @@
/** indicate this Trigger is Stateful or Stateless */
private boolean isStateful;
+
/** only used for Stateful Trigger */
private TDataNodeLocation dataNodeLocation;
private FailureStrategy failureStrategy;
+
/** MD5 of the Jar File */
private String jarFileMD5;
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/trigger/TriggerTable.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/trigger/TriggerTable.java
index a10df79..1e5093c 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/trigger/TriggerTable.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/trigger/TriggerTable.java
@@ -49,6 +49,7 @@
public TriggerTable(Map<String, TriggerInformation> triggerTable) {
this.triggerTable = triggerTable;
}
+
// for createTrigger
public void addTriggerInformation(String triggerName, TriggerInformation triggerInformation) {
triggerTable.put(triggerName, triggerInformation);
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/BuiltinAggregationFunction.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/BuiltinAggregationFunction.java
index 72bd4ac..1c6b25e 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/BuiltinAggregationFunction.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/BuiltinAggregationFunction.java
@@ -68,7 +68,9 @@
return NATIVE_FUNCTION_NAMES;
}
- /** @return if the Aggregation can use statistics to optimize */
+ /**
+ * @return if the Aggregation can use statistics to optimize
+ */
public static boolean canUseStatistics(String name) {
final String functionName = name.toLowerCase();
switch (functionName) {
@@ -103,7 +105,9 @@
// TODO Maybe we can merge this method with canUseStatistics(),
// new method returns three level push-down: No push-down, DataRegion, SeriesScan
- /** @return if the Aggregation can split to multi phases */
+ /**
+ * @return if the Aggregation can split to multi phases
+ */
public static boolean canSplitToMultiPhases(String name) {
final String functionName = name.toLowerCase();
switch (functionName) {
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/UDTFJexl.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/UDTFJexl.java
index fb365e4..24b5d41 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/UDTFJexl.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/UDTFJexl.java
@@ -61,7 +61,8 @@
@Override
public void beforeStart(UDFParameters parameters, UDTFConfigurations configurations)
- throws UDFInputSeriesDataTypeNotValidException, UDFOutputSeriesDataTypeNotValidException,
+ throws UDFInputSeriesDataTypeNotValidException,
+ UDFOutputSeriesDataTypeNotValidException,
MetadataException {
String expr = parameters.getString("expr");
JexlEngine jexl = new JexlBuilder().create();
@@ -148,7 +149,8 @@
@Override
public void transform(Row row, PointCollector collector)
- throws IOException, UDFOutputSeriesDataTypeNotValidException,
+ throws IOException,
+ UDFOutputSeriesDataTypeNotValidException,
UDFInputSeriesDataTypeNotValidException {
switch (outputDataType) {
case DOUBLE:
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/AuthUtils.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/AuthUtils.java
index f4079b4..38f8c68 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/AuthUtils.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/AuthUtils.java
@@ -63,6 +63,7 @@
private AuthUtils() {
// Empty constructor
}
+
/**
* This filed only for pre version. When we do a major version upgrade, it can be removed
* directly.
@@ -320,6 +321,7 @@
}
return false;
}
+
/**
* Add privilege
*
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/IOUtils.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/IOUtils.java
index 48d0f95..f2d9e9d 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/IOUtils.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/IOUtils.java
@@ -122,6 +122,7 @@
}
return null;
}
+
/**
* To distinguish between permissions files of the new and old versions, in files generated by the
* new version, the length of the first string will be stored as a negative number.
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/NodeUrlUtils.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/NodeUrlUtils.java
index 818ee7a..e8190fd 100644
--- a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/NodeUrlUtils.java
+++ b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/NodeUrlUtils.java
@@ -43,6 +43,7 @@
public static final String WILD_CARD_ADDRESS = "0.0.0.0";
public static final String LOOPBACK_HOST_NAME = "localhost";
+
/**
* Convert TEndPoint to TEndPointUrl
*
diff --git a/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/MissDetector.java b/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/MissDetector.java
index 0141ae0..ab7f277 100644
--- a/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/MissDetector.java
+++ b/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/MissDetector.java
@@ -130,22 +130,30 @@
}
}
- /** @return the minLength */
+ /**
+ * @return the minLength
+ */
public int getMinLength() {
return minLength;
}
- /** @param minLength the minLength to set */
+ /**
+ * @param minLength the minLength to set
+ */
public void setMinLength(int minLength) {
this.minLength = minLength;
}
- /** @return the threshold */
+ /**
+ * @return the threshold
+ */
public double getThreshold() {
return threshold;
}
- /** @param threshold the threshold to set */
+ /**
+ * @param threshold the threshold to set
+ */
public void setThreshold(double threshold) {
this.threshold = threshold;
}
@@ -176,32 +184,44 @@
return end - start;
}
- /** @return the start */
+ /**
+ * @return the start
+ */
public int getStart() {
return start;
}
- /** @param start the start to set */
+ /**
+ * @param start the start to set
+ */
public void setStart(int start) {
this.start = start;
}
- /** @return the end */
+ /**
+ * @return the end
+ */
public int getEnd() {
return end;
}
- /** @param end the end to set */
+ /**
+ * @param end the end to set
+ */
public void setEnd(int end) {
this.end = end;
}
- /** @return the slope */
+ /**
+ * @return the slope
+ */
public double getSlope() {
return slope;
}
- /** @param slope the slope to set */
+ /**
+ * @param slope the slope to set
+ */
public void setSlope(double slope) {
this.slope = slope;
}
@@ -218,22 +238,30 @@
}
}
- /** @return the predictLabel */
+ /**
+ * @return the predictLabel
+ */
public IntArrayList getPredictLabel() {
return predictLabel;
}
- /** @return the len */
+ /**
+ * @return the len
+ */
public int getLen() {
return len;
}
- /** @return the time */
+ /**
+ * @return the time
+ */
public LongArrayList getTime() {
return time;
}
- /** @return the value */
+ /**
+ * @return the value
+ */
public DoubleArrayList getValue() {
return value;
}
diff --git a/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/StreamMissDetector.java b/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/StreamMissDetector.java
index ceadbb5..892541b 100644
--- a/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/StreamMissDetector.java
+++ b/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/StreamMissDetector.java
@@ -188,7 +188,9 @@
return minLength;
}
- /** @param minLength the minLength to set */
+ /**
+ * @param minLength the minLength to set
+ */
public void setMinLength(int minLength) {
this.minLength = minLength;
}
diff --git a/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/WindowDetect.java b/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/WindowDetect.java
index 475e4b0..0eeb69c 100644
--- a/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/WindowDetect.java
+++ b/library-udf/src/main/java/org/apache/iotdb/library/anomaly/util/WindowDetect.java
@@ -84,12 +84,16 @@
repaired = Util.toDoubleArray(repairedList);
}
- /** @return the time */
+ /**
+ * @return the time
+ */
public long[] getTime() {
return time;
}
- /** @return the repaired */
+ /**
+ * @return the repaired
+ */
public double[] getRepaired() {
return repaired;
}
diff --git a/library-udf/src/main/java/org/apache/iotdb/library/dquality/util/TimeSeriesQuality.java b/library-udf/src/main/java/org/apache/iotdb/library/dquality/util/TimeSeriesQuality.java
index 0c87ed6..4bab2e8 100644
--- a/library-udf/src/main/java/org/apache/iotdb/library/dquality/util/TimeSeriesQuality.java
+++ b/library-udf/src/main/java/org/apache/iotdb/library/dquality/util/TimeSeriesQuality.java
@@ -204,12 +204,16 @@
return 1 - (valueCnt + variationCnt + speedCnt + speedchangeCnt) * 0.25 / cnt;
}
- /** @return the downtime */
+ /**
+ * @return the downtime
+ */
public boolean isDowntime() {
return downtime;
}
- /** @param downtime the downtime to set */
+ /**
+ * @param downtime the downtime to set
+ */
public void setDowntime(boolean downtime) {
this.downtime = downtime;
}
diff --git a/library-udf/src/main/java/org/apache/iotdb/library/frequency/util/DWTUtil.java b/library-udf/src/main/java/org/apache/iotdb/library/frequency/util/DWTUtil.java
index 35d2863..e37c96d 100644
--- a/library-udf/src/main/java/org/apache/iotdb/library/frequency/util/DWTUtil.java
+++ b/library-udf/src/main/java/org/apache/iotdb/library/frequency/util/DWTUtil.java
@@ -26,8 +26,10 @@
public class DWTUtil {
/** The number of coefficients. */
private int ncof;
+
/** layers to decompose，When transforming, point numbers should be no less than ncof. */
private int layer;
+
/** Centering. */
private int ioff;
diff --git a/pom.xml b/pom.xml
index 3f9e2aa..83fdf0e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -81,7 +81,7 @@
<flink.version>1.17.1</flink.version>
<fusesource-mqtt-client.version>1.16</fusesource-mqtt-client.version>
<!-- JDK1.8 only support google java format 1.7-->
- <google.java.format.version>1.7</google.java.format.version>
+ <google.java.format.version>1.22.0</google.java.format.version>
<gson.version>2.10.1</gson.version>
<guava.version>32.1.2-jre</guava.version>
<hadoop.version>3.3.6</hadoop.version>
@@ -165,8 +165,7 @@
<spark-scala.2.12.version>3.5.0</spark-scala.2.12.version>
<!-- Override this to `true`, if you want to disable spotless -->
<spotless.skip>false</spotless.skip>
- <!-- This was the last version to support Java 8 -->
- <spotless.version>2.27.1</spotless.version>
+ <spotless.version>2.43.0</spotless.version>
<!-- This is the matching version of spring-boot for spring 5.3.30 -->
<spring-boot.version>2.7.18</spring-boot.version>
<!-- This is the last version to support the javax namespace -->
@@ -2517,18 +2516,17 @@
<maven.compiler.release>8</maven.compiler.release>
</properties>
</profile>
- <!-- Some APIs were removed in Java 11, so we need to add replacements -->
+ <!-- Current version of spotless cannot support JDK11 below -->
<profile>
- <id>.java-11-and-above</id>
+ <id>.java-11-below</id>
<activation>
- <jdk>[11,)</jdk>
+ <jdk>(,11]</jdk>
</activation>
<properties>
- <!--
- Change to 1.15.0 will modify many codes (all are javadocs), we change it to 1.15.0
- until: iotdb decides to do not support jdk8.
- -->
- <google.java.format.version>1.7</google.java.format.version>
+ <!-- This was the last version to support Java 8, Just for run -->
+ <spotless.version>2.27.1</spotless.version>
+ <!-- To avoid format conflicts -->
+ <spotless.skip>true</spotless.skip>
</properties>
</profile>
<!--
@@ -2557,16 +2555,6 @@
<argLine>--add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED</argLine>
</properties>
</profile>
- <!-- Current version of spotless cannot support JDK21 -->
- <profile>
- <id>.java-21-and-above</id>
- <activation>
- <jdk>[21,)</jdk>
- </activation>
- <properties>
- <spotless.skip>true</spotless.skip>
- </properties>
- </profile>
<!-- Little helper profile that will disable running the cmake tests when the maven tests are being skipped -->
<profile>
<id>.skipTests</id>
