Findbugs finds bugs
diff --git a/src/main/java/org/apache/jenkins/gitpubsub/ASFGitSCMFileSystem.java b/src/main/java/org/apache/jenkins/gitpubsub/ASFGitSCMFileSystem.java
index 11f8586..d564cea 100644
--- a/src/main/java/org/apache/jenkins/gitpubsub/ASFGitSCMFileSystem.java
+++ b/src/main/java/org/apache/jenkins/gitpubsub/ASFGitSCMFileSystem.java
@@ -173,7 +173,7 @@
@Override
public boolean changesSince(SCMRevision revision, @NonNull OutputStream changeLogStream)
throws UnsupportedOperationException, IOException, InterruptedException {
- if (getRevision() == null ? revision == null : getRevision().equals(revision)) {
+ if (revision == null ? getRevision() == null : revision.equals(getRevision())) {
// special case where somebody is asking one of two stupid questions:
// 1. what has changed between the latest and the latest
// 2. what has changed between the current revision and the current revision
diff --git a/src/main/java/org/apache/jenkins/gitpubsub/ASFGitSCMNavigator.java b/src/main/java/org/apache/jenkins/gitpubsub/ASFGitSCMNavigator.java
index aa7e7ea..5b561e4 100644
--- a/src/main/java/org/apache/jenkins/gitpubsub/ASFGitSCMNavigator.java
+++ b/src/main/java/org/apache/jenkins/gitpubsub/ASFGitSCMNavigator.java
@@ -30,6 +30,7 @@
import java.io.InputStreamReader;
import java.net.URL;
import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
@@ -168,7 +169,10 @@
.withTraits(traits)
.newRequest(this, observer);
BufferedReader reader = new BufferedReader(
- new InputStreamReader(new URL(server + "?a=project_index").openStream()))) {
+ new InputStreamReader(
+ new URL(server + "?a=project_index").openStream(),
+ StandardCharsets.UTF_8 // content is always US-ASCII but content type says UTF-8
+ ))) {
int count = 0;
String line;
observer.getListener().getLogger().format("%n Checking repositories...%n");
