Merge branch 'feature/SLIDER-531-registry-enhancements' into develop
diff --git a/slider-agent/src/main/python/agent/Registry.py b/slider-agent/src/main/python/agent/Registry.py
index ad84053..6d34956 100644
--- a/slider-agent/src/main/python/agent/Registry.py
+++ b/slider-agent/src/main/python/agent/Registry.py
@@ -24,7 +24,7 @@
logger = logging.getLogger()
-class Registry:
+class Registry(object):
def __init__(self, zk_quorum, zk_reg_path):
self.zk_quorum = zk_quorum
self.zk_reg_path = zk_reg_path
@@ -39,17 +39,18 @@
zk = KazooClient(hosts=self.zk_quorum, read_only=True)
zk.start()
data, stat = zk.get(self.zk_reg_path)
- data = data.lstrip("jsonservicerec")
logger.debug("Registry Data: %s" % (data.decode("utf-8")))
sliderRegistry = json.loads(data)
internalAttr = sliderRegistry["internal"]
for internal in internalAttr:
if internal["api"] == "org.apache.slider.agents.secure":
- amUrl = internal["addresses"][0][0]
+ address0 = internal["addresses"][0]
+ amUrl = address0["uri"]
amHost = amUrl.split("/")[2].split(":")[0]
amSecuredPort = amUrl.split(":")[2].split("/")[0]
if internal["api"] == "org.apache.slider.agents.oneway":
- amUnsecureUrl = internal["addresses"][0][0]
+ address0 = internal["addresses"][0]
+ amUnsecureUrl = address0["uri"]
amHost = amUnsecureUrl.split("/")[2].split(":")[0]
amUnsecuredPort = amUnsecureUrl.split(":")[2].split("/")[0]
@@ -62,7 +63,7 @@
(self.zk_reg_path, self.zk_quorum, str(e)))
pass
finally:
- if not zk == None:
+ if not zk is None:
zk.stop()
zk.close()
logger.info("AM Host = %s, AM Secured Port = %s, ping port = %s" % (amHost, amSecuredPort, amUnsecuredPort))
diff --git a/slider-core/src/main/java/org/apache/slider/core/registry/info/CustomRegistryConstants.java b/slider-core/src/main/java/org/apache/slider/core/registry/info/CustomRegistryConstants.java
index 67b9feb..0a3476c 100644
--- a/slider-core/src/main/java/org/apache/slider/core/registry/info/CustomRegistryConstants.java
+++ b/slider-core/src/main/java/org/apache/slider/core/registry/info/CustomRegistryConstants.java
@@ -24,31 +24,31 @@
public class CustomRegistryConstants {
public static final String MANAGEMENT_REST_API =
- "org.apache.slider.management";
+ "classpath:org.apache.slider.management";
public static final String REGISTRY_REST_API =
- "org.apache.slider.registry";
+ "classpath:org.apache.slider.registry";
public static final String PUBLISHER_REST_API =
- "org.apache.slider.publisher";
+ "classpath:org.apache.slider.publisher";
public static final String PUBLISHER_CONFIGURATIONS_API =
- "org.apache.slider.publisher.configurations";
+ "classpath:org.apache.slider.publisher.configurations";
public static final String PUBLISHER_EXPORTS_API =
- "org.apache.slider.publisher.exports";
+ "classpath:org.apache.slider.publisher.exports";
public static final String PUBLISHER_DOCUMENTS_API =
- "org.apache.slider.publisher.documents";
+ "classpath:org.apache.slider.publisher.documents";
public static final String AGENT_SECURE_REST_API =
- "org.apache.slider.agents.secure";
+ "classpath:org.apache.slider.agents.secure";
public static final String AGENT_ONEWAY_REST_API =
- "org.apache.slider.agents.oneway";
+ "classpath:org.apache.slider.agents.oneway";
public static final String AM_IPC_PROTOCOL =
- "org.apache.slider.appmaster";
+ "classpath:org.apache.slider.appmaster";
- public static final String WEB_UI = "org.apache.http.UI";
+ public static final String WEB_UI = "http://";
}
diff --git a/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java b/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
index f2ea00f..3bee4a4 100644
--- a/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
+++ b/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
@@ -1060,8 +1060,7 @@
serviceRecord.addExternalEndpoint(
RegistryTypeUtils.ipcEndpoint(
CustomRegistryConstants.AM_IPC_PROTOCOL,
- true,
- RegistryTypeUtils.marshall(rpcServiceAddress)));
+ rpcServiceAddress));
// internal services
sliderAMProvider.applyInitialRegistryDefinitions(amWebURI,
diff --git a/slider-core/src/test/groovy/org/apache/slider/server/appmaster/web/rest/registry/PathEntryMarshalling.groovy b/slider-core/src/test/groovy/org/apache/slider/server/appmaster/web/rest/registry/PathEntryMarshalling.groovy
index 937bebf..5f987c2 100644
--- a/slider-core/src/test/groovy/org/apache/slider/server/appmaster/web/rest/registry/PathEntryMarshalling.groovy
+++ b/slider-core/src/test/groovy/org/apache/slider/server/appmaster/web/rest/registry/PathEntryMarshalling.groovy
@@ -23,6 +23,6 @@
class PathEntryMarshalling
extends JsonSerDeser<PathEntryResource> {
public PathEntryMarshalling() {
- super(PathEntryResource.class, new byte[0]);
+ super(PathEntryResource.class);
}
}
\ No newline at end of file
diff --git a/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AgentRegistryIT.groovy b/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AgentRegistryIT.groovy
index 5b8b3cd..ee9ef61 100644
--- a/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AgentRegistryIT.groovy
+++ b/slider-funtest/src/test/groovy/org/apache/slider/funtest/lifecycle/AgentRegistryIT.groovy
@@ -50,7 +50,7 @@
@Before
public void prepareCluster() {
setupCluster(CLUSTER)
- }
+ }
@After
public void destroyCluster() {