commit e629995ac8d90e23a7ca3610808c10905b18d3da
author Colin P. Mccabe <cmccabe@apache.org> Tue Apr 19 11:09:35 2016 -0700
committer Colin P. Mccabe <cmccabe@apache.org> Tue Apr 19 11:09:35 2016 -0700
tree 3a3186db45e19ca5d3129fab431b5e3dd51d6c90
parent 23e2dce78ebbc1d1501399ff681c2bf7ddc36b71

HTRACE-360. Missing space in Sampler.java "Cannot find a constructor" error log message (Mike Drob via cmccabe)

htrace-core4/src/main/java/org/apache/htrace/core/Sampler.java

diff --git a/htrace-core4/src/main/java/org/apache/htrace/core/Sampler.java b/htrace-core4/src/main/java/org/apache/htrace/core/Sampler.java
index 7ae2bcf..ff326c4 100644
--- a/htrace-core4/src/main/java/org/apache/htrace/core/Sampler.java
+++ b/htrace-core4/src/main/java/org/apache/htrace/core/Sampler.java
@@ -107,7 +107,7 @@
         ctor = cls.getConstructor(HTraceConfiguration.class);
       } catch (NoSuchMethodException e) {
         throwError("Cannot find a constructor for class " +
-            str + "which takes an HTraceConfiguration.");
+            str + " which takes an HTraceConfiguration.");
       }
       Sampler sampler = null;
       try {

htrace-core4/src/test/java/org/apache/htrace/core/TestSampler.java

diff --git a/htrace-core4/src/test/java/org/apache/htrace/core/TestSampler.java b/htrace-core4/src/test/java/org/apache/htrace/core/TestSampler.java
index 2305d9f..92943b5 100644
--- a/htrace-core4/src/test/java/org/apache/htrace/core/TestSampler.java
+++ b/htrace-core4/src/test/java/org/apache/htrace/core/TestSampler.java
@@ -81,6 +81,10 @@
     samplers = getSamplersFromConf(HTraceConfiguration.
         fromKeyValuePairs("sampler.classes", "NonExistentSampler"));
     Assert.assertEquals(0, samplers.length);
+    
+    samplers = getSamplersFromConf(HTraceConfiguration.
+        fromKeyValuePairs("sampler.classes", "java.lang.String"));
+    Assert.assertEquals(0, samplers.length);
 
     samplers = getSamplersFromConf(HTraceConfiguration.EMPTY);
     Assert.assertEquals(0, samplers.length);