HTRACE-127. fix ./build/htrace dumpAll (cmccabe)
diff --git a/htrace-core/src/go/src/org/apache/htrace/htrace/cmd.go b/htrace-core/src/go/src/org/apache/htrace/htrace/cmd.go
index ef7b43f..a38e314 100644
--- a/htrace-core/src/go/src/org/apache/htrace/htrace/cmd.go
+++ b/htrace-core/src/go/src/org/apache/htrace/htrace/cmd.go
@@ -263,8 +263,10 @@
if err != nil {
return err
}
+ w := bufio.NewWriter(file)
defer func() {
if file != nil {
+ w.Flush()
file.Close()
}
}()
@@ -280,15 +282,15 @@
if !channelOpen {
break
}
- if err != nil {
- _, err = fmt.Fprintf(file, "%s\n", span.ToJson())
+ if err == nil {
+ _, err = fmt.Fprintf(w, "%s\n", span.ToJson())
}
if *verbose {
numSpans++
now := time.Now()
if !now.Before(nextLogTime) {
nextLogTime = now.Add(time.Second * 5)
- fmt.Printf("wrote %d span(s)...\n", numSpans)
+ fmt.Printf("received %d span(s)...\n", numSpans)
}
}
}
@@ -298,6 +300,10 @@
if dumpErr != nil {
return errors.New(fmt.Sprintf("Dump error %s", dumpErr.Error()))
}
+ err = w.Flush()
+ if err != nil {
+ return err
+ }
err = file.Close()
file = nil
if err != nil {
