commit 40510547528e123a20000f6e21164093e5da24a9
author Masatake Iwasaki <iwasakims@apache.org> Wed Jun 03 12:53:04 2015 +0900
committer Masatake Iwasaki <iwasakims@apache.org> Wed Jun 03 12:53:04 2015 +0900
tree a3096c1a95b24f8f77f9204e52c9744880794e10
parent 07d428de3b2e5a9f46bdf60157737e72417939e6

HTRACE-176. Expose ZipkinSpanReceiver configuration keys externally (Daniel Lee via iwasakims)

htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java

diff --git a/htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java b/htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java
index d75c504..f39b753 100644
--- a/htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java
+++ b/htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java
@@ -66,11 +66,19 @@
    * Default hostname to fall back on.
    */
   private static final String DEFAULT_COLLECTOR_HOSTNAME = "localhost";
+  public static final String HOSTNAME_KEY = "zipkin.collector-hostname";
 
   /**
    * Default collector port.
    */
   private static final int DEFAULT_COLLECTOR_PORT = 9410; // trace collector default port.
+  public static final String PORT_KEY = "zipkin.collector-port";
+
+  /**
+   * Default number of threads to use.
+   */
+  private static final int DEFAULT_NUM_THREAD = 1;
+  public static final String NUM_THREAD_KEY = "zipkin.num-threads";
 
   /**
    * this is used to tell scribe that the entries are for zipkin..
@@ -153,15 +161,13 @@
   private void configure(HTraceConfiguration conf) {
     this.conf = conf;
 
-    this.collectorHostname = conf.get("zipkin.collector-hostname",
-        DEFAULT_COLLECTOR_HOSTNAME);
-    this.collectorPort = conf.getInt("zipkin.collector-port",
-        DEFAULT_COLLECTOR_PORT);
+    this.collectorHostname = conf.get(HOSTNAME_KEY, DEFAULT_COLLECTOR_HOSTNAME);
+    this.collectorPort = conf.getInt(PORT_KEY, DEFAULT_COLLECTOR_PORT);
 
     // initialize the endpoint. This endpoint is used while writing the Span.
     initConverter();
 
-    int numThreads = conf.getInt("zipkin.num-threads", 1);
+    int numThreads = conf.getInt(NUM_THREAD_KEY, DEFAULT_NUM_THREAD);
 
     // If there are already threads runnnig tear them down.
     if (this.service != null) {