making the variable private
diff --git a/leader-common/src/main/kotlin/org/apache/amaterasu/leader/common/execution/JobManager.kt b/leader-common/src/main/kotlin/org/apache/amaterasu/leader/common/execution/JobManager.kt
index 943dd67..d4a317b 100644
--- a/leader-common/src/main/kotlin/org/apache/amaterasu/leader/common/execution/JobManager.kt
+++ b/leader-common/src/main/kotlin/org/apache/amaterasu/leader/common/execution/JobManager.kt
@@ -31,9 +31,9 @@
lateinit var head: Action
- // TODO: this is not private due to tests, fix this!!!
+ // TODO: this is not private due to tests, fix this!!! <---- Eran is correct!
val registeredActions = HashMap<String, Action>()
- val frameworks = HashMap<String, HashSet<String>>()
+ private val frameworks = HashMap<String, HashSet<String>>()
operator fun set(groupId : String , typeId : String) = frameworks.getOrPut(groupId){HashSet()}.add(typeId)
@@ -63,7 +63,7 @@
val nextAction: ActionData? = executionQueue.poll()
if (nextAction != null) {
- registeredActions[nextAction.id]!!.announceStart()
+ registeredActions[nextAction.id]?.announceStart()
}
return nextAction
@@ -71,8 +71,8 @@
fun reQueueAction(actionId: String) {
- val action = registeredActions[actionId]
- executionQueue.put(action!!.data)
+ val action : Action = registeredActions[actionId] ?: throw IllegalAccessException()
+ executionQueue.put(action.data)
registeredActions[actionId]!!.announceQueued()
}
