commit 5ba3f7248b59b5434ae87e3c84445679b018b1b6
author Yoo-Youngjae <44061214+Yoo-Youngjae@users.noreply.github.com> Thu Jan 16 22:35:19 2020 +0900
committer WooYeon Lee <wylee@apache.org> Thu Jan 16 22:35:19 2020 +0900
tree e1030fa83f957808f9feb91bd7796dc604dce5aa
parent b9de05d62f112ae419d9f2b6c15fb131bc38003f

[NEMO-429] SWPP TEAM 9 code smell fix (#259)

* switch statement -> if statement

* transient added

Co-authored-by: manhair <43872798+manhair@users.noreply.github.com>
Co-authored-by: WooYeon Lee <wylee@apache.org>

client/src/main/java/org/apache/nemo/client/ClientUtils.java

diff --git a/client/src/main/java/org/apache/nemo/client/ClientUtils.java b/client/src/main/java/org/apache/nemo/client/ClientUtils.java
index a200a2e..afe9097 100644
--- a/client/src/main/java/org/apache/nemo/client/ClientUtils.java
+++ b/client/src/main/java/org/apache/nemo/client/ClientUtils.java
@@ -47,20 +47,16 @@
    */
   static void handleOptimizationType(final ControlMessage.DriverToClientMessage message,
                                      final DriverRPCServer driverRPCServer) {
-    switch (message.getOptimizationType()) {
-      case XGBoost:
-        new Thread(() ->
-          driverRPCServer.send(ControlMessage.ClientToDriverMessage.newBuilder()
-            .setType(ControlMessage.ClientToDriverMessageType.Notification)
-            .setMessage(ControlMessage.NotificationMessage.newBuilder()
-              .setOptimizationType(ControlMessage.OptimizationType.XGBoost)
-              .setData(ClientUtils.launchXGBoostScript(message.getDataCollected().getData()))
-              .build())
-            .build()))
-          .start();
-        break;
-      default:
-        break;
+    if (message.getOptimizationType().equals(ControlMessage.OptimizationType.XGBoost)) {
+      new Thread(() ->
+        driverRPCServer.send(ControlMessage.ClientToDriverMessage.newBuilder()
+          .setType(ControlMessage.ClientToDriverMessageType.Notification)
+          .setMessage(ControlMessage.NotificationMessage.newBuilder()
+            .setOptimizationType(ControlMessage.OptimizationType.XGBoost)
+            .setData(ClientUtils.launchXGBoostScript(message.getDataCollected().getData()))
+            .build())
+          .build()))
+        .start();
     }
   }
 

examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java

diff --git a/examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java b/examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java
index 79f2bba..3efbd72 100644
--- a/examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java
+++ b/examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java
@@ -58,7 +58,7 @@
     private Map<Integer, List<Double>> model;
 
     // TODO #274: Use bundles properly in Beam MultinomialLogisticRegression
-    private ProcessContext savedContextHack;
+    private transient ProcessContext savedContextHack;
 
     /**
      * Constructor for CalculateGradient DoFn class.