commit 2da1647454eec500162a1649115897c4277e1779
author JooHyung Kim <14wnrkim@gmail.com> Fri Jan 17 14:00:27 2020 +0900
committer Jangho Seo <jangho@jangho.io> Fri Jan 17 14:00:27 2020 +0900
tree 653eeeabcd0aadb87434f2ddb5c4a622c9cf453b
parent 5ba3f7248b59b5434ae87e3c84445679b018b1b6

[NEMO-429] SWPP TEAM16 Code Smell Fix (#278)

JIRA: [NEMO-429: Team16](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-429)

**Major changes:**
- Fixed code smells (SWPP Code Smell session)

Co-authored-by: mss8087 <46183183+mss8087@users.noreply.github.com>
Co-authored-by: Daewoong Kim <43679861+dkim94@users.noreply.github.com>
Co-authored-by: Jangho Seo <jangho@jangho.io>
Co-authored-by: WooYeon Lee <wylee@apache.org>

runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/block/FileBlock.java

diff --git a/runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/block/FileBlock.java b/runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/block/FileBlock.java
index a869e8d..05c310e 100644
--- a/runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/block/FileBlock.java
+++ b/runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/block/FileBlock.java
@@ -69,6 +69,7 @@
   private final String filePath;
   private final FileMetadata<K> metadata;
   private final MemoryPoolAssigner memoryPoolAssigner;
+  private static final String ALREADY_COMMITED = "The partition is already committed!";
 
   /**
    * Constructor.
@@ -128,7 +129,7 @@
   public void write(final K key,
                     final Object element) throws BlockWriteException {
     if (metadata.isCommitted()) {
-      throw new BlockWriteException(new Throwable("The partition is already committed!"));
+      throw new BlockWriteException(new Throwable(ALREADY_COMMITED));
     } else {
       try {
         SerializedPartition<K> partition = nonCommittedPartitionsMap.get(key);
@@ -154,7 +155,7 @@
   public void writePartitions(final Iterable<NonSerializedPartition<K>> partitions)
     throws BlockWriteException {
     if (metadata.isCommitted()) {
-      throw new BlockWriteException(new Throwable("The partition is already committed!"));
+      throw new BlockWriteException(new Throwable(ALREADY_COMMITED));
     } else {
       try {
         final Iterable<SerializedPartition<K>> convertedPartitions =
@@ -177,7 +178,7 @@
   public void writeSerializedPartitions(final Iterable<SerializedPartition<K>> partitions)
     throws BlockWriteException {
     if (metadata.isCommitted()) {
-      throw new BlockWriteException(new Throwable("The partition is already committed!"));
+      throw new BlockWriteException(new Throwable(ALREADY_COMMITED));
     } else {
       try {
         writeToFile(partitions);