commit deac513c43858a144f0e7171d9f2ff33196b1e1a
author Jermy Li <lizhangmei@baidu.com> Wed Apr 27 10:27:59 2022 +0800
committer GitHub <noreply@github.com> Wed Apr 27 10:27:59 2022 +0800
tree d95419379da8711f70598d3d83af13c1b7b2aa92
parent f2e838443de26d21619708f90988abcf332ef36e

improve Whitebox.setInternalState() (#99)

* add Whitebox.setInternalFinalState()

* delete Whitebox.setInternalFinalState() method since ineffective

hugegraph-common/src/main/java/com/baidu/hugegraph/testutil/Whitebox.java

diff --git a/hugegraph-common/src/main/java/com/baidu/hugegraph/testutil/Whitebox.java b/hugegraph-common/src/main/java/com/baidu/hugegraph/testutil/Whitebox.java
index 0d7c7c4..826ab01 100644
--- a/hugegraph-common/src/main/java/com/baidu/hugegraph/testutil/Whitebox.java
+++ b/hugegraph-common/src/main/java/com/baidu/hugegraph/testutil/Whitebox.java
@@ -32,13 +32,18 @@
 
     public static final char SEPARATOR = '.';
 
-    public static void setInternalState(Object target, String fieldName,
-                                        Object value) {
+    public static void setInternalState(Object target,
+                                        String fieldName, Object value) {
         assert target != null;
         assert fieldName != null;
         int sep = fieldName.lastIndexOf(SEPARATOR);
         if (sep > 0) {
-            target = getInternalState(target, fieldName.substring(0, sep));
+            String prefix = fieldName.substring(0, sep);
+            Object result = getInternalState(target, prefix);
+            E.checkArgument(result != null,
+                            "Can't set value on null field: `%s.%s`",
+                            target, prefix);
+            target = result;
             fieldName = fieldName.substring(sep + 1);
         }
 

hugegraph-common/src/test/java/com/baidu/hugegraph/testutil/WhiteboxTest.java

diff --git a/hugegraph-common/src/test/java/com/baidu/hugegraph/testutil/WhiteboxTest.java b/hugegraph-common/src/test/java/com/baidu/hugegraph/testutil/WhiteboxTest.java
index 92ab1af..6375c0d 100644
--- a/hugegraph-common/src/test/java/com/baidu/hugegraph/testutil/WhiteboxTest.java
+++ b/hugegraph-common/src/test/java/com/baidu/hugegraph/testutil/WhiteboxTest.java
@@ -56,7 +56,7 @@
         Test1 test1 = newTest();
         Assert.assertEquals(1, Whitebox.getInternalState(test1, "ivalue"));
         Assert.assertEquals(2f, Whitebox.getInternalState(test1,
-                                                          "test2.fvalue"));
+                                                          "test2.finalValue"));
         Assert.assertEquals("3",  Whitebox.getInternalState(test1,
                                                             "test2.test3.str"));
 
@@ -65,7 +65,7 @@
         });
 
         Assert.assertThrows(RuntimeException.class, () -> {
-            Whitebox.getInternalState(test1, "test2.fvalue2");
+            Whitebox.getInternalState(test1, "test2.valueNotExist");
         });
     }
 
@@ -75,10 +75,11 @@
 
         Whitebox.setInternalState(test1, "ivalue", 11);
         Assert.assertEquals(11, Whitebox.getInternalState(test1, "ivalue"));
+        Assert.assertEquals(11, test1.ivalue);
 
-        Whitebox.setInternalState(test1, "test2.fvalue", 22f);
+        Whitebox.setInternalState(test1, "test2.finalValue", 22f);
         Assert.assertEquals(22f, Whitebox.getInternalState(test1,
-                                                          "test2.fvalue"));
+                                                          "test2.finalValue"));
 
         Whitebox.setInternalState(test1, "test2.test3.str", "33");
         Assert.assertEquals("33",  Whitebox.getInternalState(test1,
@@ -89,12 +90,40 @@
         });
 
         Assert.assertThrows(RuntimeException.class, () -> {
-            Whitebox.setInternalState(test1, "test2.fvalue2", 22f);
+            Whitebox.setInternalState(test1, "test2.valueNotExist", 22f);
         });
 
         Assert.assertThrows(RuntimeException.class, () -> {
-            Whitebox.setInternalState(test1, "test2.fvalue", 22d);
+            Whitebox.setInternalState(test1, "test2.finalValue", 22d);
         });
+
+        Assert.assertThrows(RuntimeException.class, () -> {
+            test1.test2 = null;
+            Whitebox.setInternalState(test1, "test2.finalValue", 22f);
+        }, e -> {
+            Assert.assertContains("Can't set value on null field",
+                                  e.getMessage());
+        });
+    }
+
+    @Test
+    public void testSetInternalFinalState() {
+        Test1 test1 = newTest();
+        Assert.assertEquals(1, test1.finalValue);
+
+        Whitebox.setInternalState(test1, "finalValue", 2);
+        Assert.assertEquals(2, Whitebox.getInternalState(test1, "finalValue"));
+
+        Whitebox.setInternalState(test1, "finalValue", 3);
+        Assert.assertEquals(3, Whitebox.getInternalState(test1, "finalValue"));
+
+        Whitebox.setInternalState(test1, "test2.finalValue", 22f);
+        Assert.assertEquals(22f, Whitebox.getInternalState(test1,
+                                                           "test2.finalValue"));
+
+        // FIXME: seems don't take effect!!!
+        Assert.assertEquals(1, test1.finalValue);
+        Assert.assertEquals(2f, test1.test2.finalValue, 0f);
     }
 
     @Test
@@ -159,7 +188,10 @@
     private static class Test1 {
 
         private static int staticValue = 1;
+
         private int ivalue = 1;
+        private final int finalValue = 1;
+
         private Test2 test2;
         private TestSubClass test4;
 
@@ -196,11 +228,11 @@
     private static class Test2 {
 
         private static int staticValue = 2;
-        private final float fvalue = 2;
+        private final float finalValue = 2f;
         private Test3 test3;
 
         private float value() {
-            return this.fvalue;
+            return this.finalValue;
         }
 
         private <T> T value(T o) {