commit 9959965265df86104dc1c3bc72492354ded510af
author Maosong Fu <maosongfu@gmail.com> Fri May 05 14:15:13 2017 -0700
committer Runhang Li <rli@twitter.com> Fri May 05 14:16:04 2017 -0700
tree 36e912eb6b87ede741ebdde2d29a6e139a090409
parent 4284d01e17d076b9d607df3c44a25a572839ae77

Fail Heron-instance fast for errors (#1839)

heron/instance/src/java/com/twitter/heron/instance/HeronInstance.java

diff --git a/heron/instance/src/java/com/twitter/heron/instance/HeronInstance.java b/heron/instance/src/java/com/twitter/heron/instance/HeronInstance.java
index 09ccdb3..8004782 100644
--- a/heron/instance/src/java/com/twitter/heron/instance/HeronInstance.java
+++ b/heron/instance/src/java/com/twitter/heron/instance/HeronInstance.java
@@ -233,6 +233,15 @@
 
     // The actual uncaught exceptions handing logic
     private void handleException(Thread thread, Throwable exception) {
+      // We would fail fast when errors occur to avoid unexpected bad situations
+      if (exception instanceof Error) {
+        LOG.log(Level.SEVERE,
+            "Error caught in thread: " + thread.getName()
+                + " with thread id: " + thread.getId() + ". Process halting...",
+            exception);
+        Runtime.getRuntime().halt(1);
+      }
+
       LOG.log(Level.SEVERE,
           String.format("Exception caught in thread: %s with id: %d",
               thread.getName(), thread.getId()), exception);