Merge pull request #1805 from merico-dev/fix#1799
fix: handle empty primary key correctly
diff --git a/plugins/helper/batch_save.go b/plugins/helper/batch_save.go
index d78f466..1487064 100644
--- a/plugins/helper/batch_save.go
+++ b/plugins/helper/batch_save.go
@@ -47,18 +47,20 @@
}
// deduplication
key := getPrimaryKeyValue(slot)
- if index, ok := c.valueIndex[key]; ok {
- c.slots.Index(index).Set(reflect.ValueOf(slot))
- } else {
- // push into slot
- c.valueIndex[key] = c.current
- c.slots.Index(c.current).Set(reflect.ValueOf(slot))
- c.current++
- // flush out into database if max outed
- if c.current == c.size {
- return c.Flush()
+ if key != "" {
+ if index, ok := c.valueIndex[key]; !ok {
+ c.valueIndex[key] = c.current
+ } else {
+ c.slots.Index(index).Set(reflect.ValueOf(slot))
+ return nil
}
}
+ c.slots.Index(c.current).Set(reflect.ValueOf(slot))
+ c.current++
+ // flush out into database if max outed
+ if c.current == c.size {
+ return c.Flush()
+ }
return nil
}
