fix(plugins): fix wrong resp when testing connections, fix a typo in bitbucket
diff --git a/backend/plugins/opsgenie/api/connection.go b/backend/plugins/opsgenie/api/connection.go
index d53b8b0..8cc7340 100644
--- a/backend/plugins/opsgenie/api/connection.go
+++ b/backend/plugins/opsgenie/api/connection.go
@@ -51,7 +51,7 @@
return nil, errors.HttpStatus(http.StatusForbidden).New("API Key need 'Read' and 'Configuration access' Access rights")
}
- if response.StatusCode == http.StatusOK {
+ if response.StatusCode == http.StatusOK || response.StatusCode == http.StatusAccepted {
return &plugin.ApiResourceOutput{Body: nil, Status: http.StatusOK}, nil
}
@@ -79,7 +79,7 @@
if testConnectionErr != nil {
return nil, plugin.WrapTestConnectionErrResp(basicRes, testConnectionErr)
}
- return &plugin.ApiResourceOutput{Body: testConnectionResult, Status: http.StatusOK}, nil
+ return testConnectionResult, nil
}
// TestConnection test opsgenie connection
@@ -101,7 +101,7 @@
if testConnectionErr != nil {
return nil, plugin.WrapTestConnectionErrResp(basicRes, testConnectionErr)
}
- return &plugin.ApiResourceOutput{Body: testConnectionResult, Status: http.StatusOK}, nil
+ return testConnectionResult, nil
}
// @Summary create opsgenie connection
diff --git a/backend/plugins/pagerduty/api/connection.go b/backend/plugins/pagerduty/api/connection.go
index 0c29062..13be31f 100644
--- a/backend/plugins/pagerduty/api/connection.go
+++ b/backend/plugins/pagerduty/api/connection.go
@@ -69,7 +69,7 @@
if testConnectionErr != nil {
return nil, plugin.WrapTestConnectionErrResp(basicRes, testConnectionErr)
}
- return &plugin.ApiResourceOutput{Body: testConnectionResult, Status: http.StatusOK}, nil
+ return testConnectionResult, nil
}
// TestExistingConnection test pagerduty connection
@@ -93,7 +93,7 @@
if testConnectionErr != nil {
return nil, plugin.WrapTestConnectionErrResp(basicRes, testConnectionErr)
}
- return &plugin.ApiResourceOutput{Body: testConnectionResult, Status: http.StatusOK}, nil
+ return testConnectionResult, nil
}
// @Summary create pagerduty connection
diff --git a/backend/plugins/sonarqube/api/connection_api.go b/backend/plugins/sonarqube/api/connection_api.go
index 9058ce3..44d2c3b 100644
--- a/backend/plugins/sonarqube/api/connection_api.go
+++ b/backend/plugins/sonarqube/api/connection_api.go
@@ -100,7 +100,7 @@
errMsg := fmt.Sprintf("Test connection fail, unexpected status code: %d", testConnectionResult.Status)
return nil, plugin.WrapTestConnectionErrResp(basicRes, errors.Default.New(errMsg))
}
- return &plugin.ApiResourceOutput{Body: testConnectionResult, Status: http.StatusOK}, nil
+ return testConnectionResult, nil
}
// TestExistingConnection test sonarqube connection options
@@ -125,7 +125,7 @@
errMsg := fmt.Sprintf("Test connection fail, unexpected status code: %d", testConnectionResult.Status)
return nil, plugin.WrapTestConnectionErrResp(basicRes, errors.Default.New(errMsg))
}
- return &plugin.ApiResourceOutput{Body: testConnectionResult, Status: http.StatusOK}, nil
+ return testConnectionResult, nil
}
// PostConnections create sonarqube connection
