Tidy persistence TODO comments
diff --git a/core/src/main/java/brooklyn/management/internal/EntityChangeListener.java b/core/src/main/java/brooklyn/management/internal/EntityChangeListener.java
index 36a6324..d564074 100644
--- a/core/src/main/java/brooklyn/management/internal/EntityChangeListener.java
+++ b/core/src/main/java/brooklyn/management/internal/EntityChangeListener.java
@@ -30,7 +30,9 @@
void onChildrenChanged();
- void onPoliciesChanged(); // TODO
+ // FIXME Also want something to be notified when policy's state/config changes.
+ // Do we want a separate PolicyChangeListener instead? Or everything through EntityChangeListener?
+ void onPoliciesChanged();
void onEffectorStarting(Effector<?> effector);
diff --git a/core/src/main/java/brooklyn/management/internal/EntityManagementSupport.java b/core/src/main/java/brooklyn/management/internal/EntityManagementSupport.java
index 6d65648..6b9dcde 100644
--- a/core/src/main/java/brooklyn/management/internal/EntityManagementSupport.java
+++ b/core/src/main/java/brooklyn/management/internal/EntityManagementSupport.java
@@ -344,9 +344,10 @@
}
@Override
public void onAttributeChanged(AttributeSensor<?> attribute) {
- // if important persist, otherwiise ignore
+ // TODO Could make this more efficient by inspecting the attribute to decide if needs persisted
+ // immediately, or not important, or transient (e.g. do we really need to persist
+ // request-per-second count for rebind purposes?!)
getManagementContext().getRebindManager().getChangeListener().onChanged(entity);
- // getManagementContext().getRebindManager().getAttributeChangeListener().onChanged(entity, attribute);
}
@Override
public void onConfigChanged(ConfigKey<?> key) {
