commit 8f4251c0633c2cc04f1c612cf89c88b15c27259e
author Gerben <gerben@treora.com> Fri May 22 17:59:20 2020 +0200
committer Gerben <gerben@treora.com> Thu Jun 18 16:23:43 2020 +0200
tree 0cc34ad81726060122549671d8b4ec34f100b40c
parent 786cc22aba6618eb014486c24b1dc7eed89797c9

Fix failing test case

Our iterator would include text outside the scope’s range but within
its commonAncestorContainer.

Same mistake is also present in describe.ts; asks for a better approach.

packages/dom/src/text-quote/match.ts

diff --git a/packages/dom/src/text-quote/match.ts b/packages/dom/src/text-quote/match.ts
index d5ded88..cc1de71 100644
--- a/packages/dom/src/text-quote/match.ts
+++ b/packages/dom/src/text-quote/match.ts
@@ -36,7 +36,16 @@
     const suffix = selector.suffix || '';
     const pattern = prefix + exact + suffix;
 
-    const iter = document.createNodeIterator(root, NodeFilter.SHOW_TEXT);
+    const iter = document.createNodeIterator(
+      root,
+      NodeFilter.SHOW_TEXT,
+      {
+        acceptNode: node =>
+          range.intersectsNode(node)
+            ? NodeFilter.FILTER_ACCEPT
+            : NodeFilter.FILTER_REJECT
+      },
+    );
 
     let fromIndex = 0;
     let referenceNodeIndex = 0;