IMPALA-9008: Serialize Maven invocations to deflake impala-minimal-hive-exec
Building impala-minimal-hive-exec was flaky (sometimes it failed
to download Guava 14.0.1), and my guess is that it is related to
downloading the same dependency in parallel with ext-data-source.
Similarly to the solution in IMPALA-7051, I try to fix it by
adding a fictional dependency (ext-data-source -> shaded-deps)
to serialize the build.
Full Maven dependency graph:
fe -> yarn-extras -> ext-data-source -> shaded-deps -> impala-parent
The ordering of yarn-extras, ext-data-source, and shaded-deps are
arbitrary.
Testing:
- I never reproduced the original flakiness, so I just hope
that it disappears with this change.
Change-Id: Ic951ad7313e5ad9add2a00e6a442c6e97f235967
Reviewed-on: http://gerrit.cloudera.org:8080/14372
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
diff --git a/ext-data-source/CMakeLists.txt b/ext-data-source/CMakeLists.txt
index 2cd2b20..46e437c 100644
--- a/ext-data-source/CMakeLists.txt
+++ b/ext-data-source/CMakeLists.txt
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
-add_custom_target(ext-data-source ALL DEPENDS gen-deps impala-parent
+# The dependency on shaded-deps is only added to avoid parallel downloads
+# of dependencies. For more details see IMPALA-7051, which was a similar issue.
+add_custom_target(ext-data-source ALL DEPENDS gen-deps impala-parent shaded-deps
COMMAND $ENV{IMPALA_HOME}/bin/mvn-quiet.sh -B install -DskipTests
)
