hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewStorageConfig.java - hudi - Git at Google

 /*
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
  * distributed with this work for additional information
  * regarding copyright ownership.  The ASF licenses this file
  * to you under the Apache License, Version 2.0 (the
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
  *      http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */

 package org.apache.hudi.common.table.view;

 import org.apache.hudi.common.config.DefaultHoodieConfig;
 import org.apache.hudi.common.util.ValidationUtils;

 import java.io.File;
 import java.io.FileReader;
 import java.io.IOException;
 import java.util.Properties;

 /**
  * File System View Storage Configurations.
  */
 public class FileSystemViewStorageConfig extends DefaultHoodieConfig {

   // Property Names
   public static final String FILESYSTEM_VIEW_STORAGE_TYPE = "hoodie.filesystem.view.type";
   public static final String FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE = "hoodie.filesystem.view.incr.timeline.sync.enable";
   public static final String FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE = "hoodie.filesystem.view.secondary.type";
   public static final String FILESYSTEM_VIEW_REMOTE_HOST = "hoodie.filesystem.view.remote.host";
   public static final String FILESYSTEM_VIEW_REMOTE_PORT = "hoodie.filesystem.view.remote.port";
   public static final String FILESYSTEM_VIEW_SPILLABLE_DIR = "hoodie.filesystem.view.spillable.dir";
   public static final String FILESYSTEM_VIEW_SPILLABLE_MEM = "hoodie.filesystem.view.spillable.mem";
   public static final String FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION =
       "hoodie.filesystem.view.spillable.compaction.mem.fraction";
   public static final String FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION =
       "hoodie.filesystem.view.spillable.bootstrap.base.file.mem.fraction";
   private static final String ROCKSDB_BASE_PATH_PROP = "hoodie.filesystem.view.rocksdb.base.path";
   public static final String FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS =
       "hoodie.filesystem.view.remote.timeout.secs";

   public static final FileSystemViewStorageType DEFAULT_VIEW_STORAGE_TYPE = FileSystemViewStorageType.MEMORY;
   public static final FileSystemViewStorageType DEFAULT_SECONDARY_VIEW_STORAGE_TYPE = FileSystemViewStorageType.MEMORY;
   public static final String DEFAULT_ROCKSDB_BASE_PATH = "/tmp/hoodie_timeline_rocksdb";

   public static final String DEFAULT_FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE = "false";
   public static final String DEFUALT_REMOTE_VIEW_SERVER_HOST = "localhost";
   public static final Integer DEFAULT_REMOTE_VIEW_SERVER_PORT = 26754;
   public static final Integer DEFAULT_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS = 5 * 60; // 5 min
   public static final String DEFAULT_VIEW_SPILLABLE_DIR = "/tmp/view_map/";
   private static final Double DEFAULT_MEM_FRACTION_FOR_PENDING_COMPACTION = 0.01;
   private static final Double DEFAULT_MEM_FRACTION_FOR_EXTERNAL_DATA_FILE = 0.05;
   private static final Long DEFAULT_MAX_MEMORY_FOR_VIEW = 100 * 1024 * 1024L; // 100 MB

   /**
    * Configs to control whether backup needs to be configured if clients were not able to reach
    * timeline service.
    */
   public static final String REMOTE_BACKUP_VIEW_HANDLER_ENABLE =
       "hoodie.filesystem.remote.backup.view.enable";
   // Need to be disabled only for tests.
   public static final String DEFAULT_REMOTE_BACKUP_VIEW_HANDLER_ENABLE = "true";

   public static FileSystemViewStorageConfig.Builder newBuilder() {
     return new Builder();
   }

   private FileSystemViewStorageConfig(Properties props) {
     super(props);
   }

   public FileSystemViewStorageType getStorageType() {
     return FileSystemViewStorageType.valueOf(props.getProperty(FILESYSTEM_VIEW_STORAGE_TYPE));
   }

   public boolean isIncrementalTimelineSyncEnabled() {
     return Boolean.parseBoolean(props.getProperty(FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE));
   }

   public String getRemoteViewServerHost() {
     return props.getProperty(FILESYSTEM_VIEW_REMOTE_HOST);
   }

   public Integer getRemoteViewServerPort() {
     return Integer.parseInt(props.getProperty(FILESYSTEM_VIEW_REMOTE_PORT));
   }

   public Integer getRemoteTimelineClientTimeoutSecs() {
     return Integer.parseInt(props.getProperty(FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS));
   }

   public long getMaxMemoryForFileGroupMap() {
     long totalMemory = Long.parseLong(props.getProperty(FILESYSTEM_VIEW_SPILLABLE_MEM));
     return totalMemory - getMaxMemoryForPendingCompaction() - getMaxMemoryForBootstrapBaseFile();
   }

   public long getMaxMemoryForPendingCompaction() {
     long totalMemory = Long.parseLong(props.getProperty(FILESYSTEM_VIEW_SPILLABLE_MEM));
     return new Double(totalMemory * Double.parseDouble(props.getProperty(FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION)))
         .longValue();
   }

   public long getMaxMemoryForBootstrapBaseFile() {
     long totalMemory = Long.parseLong(props.getProperty(FILESYSTEM_VIEW_SPILLABLE_MEM));
     long reservedForExternalDataFile =
         new Double(totalMemory * Double.parseDouble(props.getProperty(FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION)))
             .longValue();
     return reservedForExternalDataFile;
   }

   public String getBaseStoreDir() {
     return props.getProperty(FILESYSTEM_VIEW_SPILLABLE_DIR);
   }

   public FileSystemViewStorageType getSecondaryStorageType() {
     return FileSystemViewStorageType.valueOf(props.getProperty(FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE));
   }

   public boolean shouldEnableBackupForRemoteFileSystemView() {
     return Boolean.parseBoolean(props.getProperty(REMOTE_BACKUP_VIEW_HANDLER_ENABLE));
   }

   public String getRocksdbBasePath() {
     return props.getProperty(ROCKSDB_BASE_PATH_PROP);
   }

   /**
    * The builder used to build {@link FileSystemViewStorageConfig}.
    */
   public static class Builder {

     private final Properties props = new Properties();

     public Builder fromFile(File propertiesFile) throws IOException {
       try (FileReader reader = new FileReader(propertiesFile)) {
         props.load(reader);
         return this;
       }
     }

     public Builder fromProperties(Properties props) {
       this.props.putAll(props);
       return this;
     }

     public Builder withStorageType(FileSystemViewStorageType storageType) {
       props.setProperty(FILESYSTEM_VIEW_STORAGE_TYPE, storageType.name());
       return this;
     }

     public Builder withSecondaryStorageType(FileSystemViewStorageType storageType) {
       props.setProperty(FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE, storageType.name());
       return this;
     }

     public Builder withIncrementalTimelineSync(boolean enableIncrTimelineSync) {
       props.setProperty(FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE, Boolean.toString(enableIncrTimelineSync));
       return this;
     }

     public Builder withRemoteServerHost(String remoteServerHost) {
       props.setProperty(FILESYSTEM_VIEW_REMOTE_HOST, remoteServerHost);
       return this;
     }

     public Builder withRemoteServerPort(Integer remoteServerPort) {
       props.setProperty(FILESYSTEM_VIEW_REMOTE_PORT, remoteServerPort.toString());
       return this;
     }

     public Builder withMaxMemoryForView(Long maxMemoryForView) {
       props.setProperty(FILESYSTEM_VIEW_SPILLABLE_MEM, maxMemoryForView.toString());
       return this;
     }

     public Builder withRemoteTimelineClientTimeoutSecs(Long timelineClientTimeoutSecs) {
       props.setProperty(FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS, timelineClientTimeoutSecs.toString());
       return this;
     }

     public Builder withMemFractionForPendingCompaction(Double memFractionForPendingCompaction) {
       props.setProperty(FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION, memFractionForPendingCompaction.toString());
       return this;
     }

     public Builder withMemFractionForExternalDataFile(Double memFractionForExternalDataFile) {
       props.setProperty(FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION, memFractionForExternalDataFile.toString());
       return this;
     }

     public Builder withBaseStoreDir(String baseStorePath) {
       props.setProperty(FILESYSTEM_VIEW_SPILLABLE_DIR, baseStorePath);
       return this;
     }

     public Builder withRocksDBPath(String basePath) {
       props.setProperty(ROCKSDB_BASE_PATH_PROP, basePath);
       return this;
     }

     public Builder withEnableBackupForRemoteFileSystemView(boolean enable) {
       props.setProperty(REMOTE_BACKUP_VIEW_HANDLER_ENABLE, Boolean.toString(enable));
       return this;
     }

     public FileSystemViewStorageConfig build() {
       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_STORAGE_TYPE), FILESYSTEM_VIEW_STORAGE_TYPE,
           DEFAULT_VIEW_STORAGE_TYPE.name());
       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE),
           FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE, DEFAULT_FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE);
       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE),
           FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE, DEFAULT_SECONDARY_VIEW_STORAGE_TYPE.name());
       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_REMOTE_HOST), FILESYSTEM_VIEW_REMOTE_HOST,
           DEFUALT_REMOTE_VIEW_SERVER_HOST);
       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_REMOTE_PORT), FILESYSTEM_VIEW_REMOTE_PORT,
           DEFAULT_REMOTE_VIEW_SERVER_PORT.toString());

       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_SPILLABLE_DIR), FILESYSTEM_VIEW_SPILLABLE_DIR,
           DEFAULT_VIEW_SPILLABLE_DIR);
       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_SPILLABLE_MEM), FILESYSTEM_VIEW_SPILLABLE_MEM,
           DEFAULT_MAX_MEMORY_FOR_VIEW.toString());
       setDefaultOnCondition(props, !props.containsKey(FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS),
           FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS, DEFAULT_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS.toString());
       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION),
           FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION, DEFAULT_MEM_FRACTION_FOR_PENDING_COMPACTION.toString());
       setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION),
           FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION, DEFAULT_MEM_FRACTION_FOR_EXTERNAL_DATA_FILE.toString());

       setDefaultOnCondition(props, !props.containsKey(ROCKSDB_BASE_PATH_PROP), ROCKSDB_BASE_PATH_PROP,
           DEFAULT_ROCKSDB_BASE_PATH);

       setDefaultOnCondition(props, !props.containsKey(REMOTE_BACKUP_VIEW_HANDLER_ENABLE),
           REMOTE_BACKUP_VIEW_HANDLER_ENABLE, DEFAULT_REMOTE_BACKUP_VIEW_HANDLER_ENABLE);

       // Validations
       FileSystemViewStorageType.valueOf(props.getProperty(FILESYSTEM_VIEW_STORAGE_TYPE));
       FileSystemViewStorageType.valueOf(props.getProperty(FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE));
       ValidationUtils.checkArgument(Integer.parseInt(props.getProperty(FILESYSTEM_VIEW_REMOTE_PORT)) > 0);
       return new FileSystemViewStorageConfig(props);
     }
   }

 }
	/*
	* Licensed to the Apache Software Foundation (ASF) under one
	* or more contributor license agreements. See the NOTICE file
	* distributed with this work for additional information
	* regarding copyright ownership. The ASF licenses this file
	* to you under the Apache License, Version 2.0 (the
	* "License"); you may not use this file except in compliance
	* with the License. You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	package org.apache.hudi.common.table.view;

	import org.apache.hudi.common.config.DefaultHoodieConfig;
	import org.apache.hudi.common.util.ValidationUtils;

	import java.io.File;
	import java.io.FileReader;
	import java.io.IOException;
	import java.util.Properties;

	/**
	* File System View Storage Configurations.
	*/
	public class FileSystemViewStorageConfig extends DefaultHoodieConfig {

	// Property Names
	public static final String FILESYSTEM_VIEW_STORAGE_TYPE = "hoodie.filesystem.view.type";
	public static final String FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE = "hoodie.filesystem.view.incr.timeline.sync.enable";
	public static final String FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE = "hoodie.filesystem.view.secondary.type";
	public static final String FILESYSTEM_VIEW_REMOTE_HOST = "hoodie.filesystem.view.remote.host";
	public static final String FILESYSTEM_VIEW_REMOTE_PORT = "hoodie.filesystem.view.remote.port";
	public static final String FILESYSTEM_VIEW_SPILLABLE_DIR = "hoodie.filesystem.view.spillable.dir";
	public static final String FILESYSTEM_VIEW_SPILLABLE_MEM = "hoodie.filesystem.view.spillable.mem";
	public static final String FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION =
	"hoodie.filesystem.view.spillable.compaction.mem.fraction";
	public static final String FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION =
	"hoodie.filesystem.view.spillable.bootstrap.base.file.mem.fraction";
	private static final String ROCKSDB_BASE_PATH_PROP = "hoodie.filesystem.view.rocksdb.base.path";
	public static final String FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS =
	"hoodie.filesystem.view.remote.timeout.secs";

	public static final FileSystemViewStorageType DEFAULT_VIEW_STORAGE_TYPE = FileSystemViewStorageType.MEMORY;
	public static final FileSystemViewStorageType DEFAULT_SECONDARY_VIEW_STORAGE_TYPE = FileSystemViewStorageType.MEMORY;
	public static final String DEFAULT_ROCKSDB_BASE_PATH = "/tmp/hoodie_timeline_rocksdb";

	public static final String DEFAULT_FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE = "false";
	public static final String DEFUALT_REMOTE_VIEW_SERVER_HOST = "localhost";
	public static final Integer DEFAULT_REMOTE_VIEW_SERVER_PORT = 26754;
	public static final Integer DEFAULT_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS = 5 * 60; // 5 min
	public static final String DEFAULT_VIEW_SPILLABLE_DIR = "/tmp/view_map/";
	private static final Double DEFAULT_MEM_FRACTION_FOR_PENDING_COMPACTION = 0.01;
	private static final Double DEFAULT_MEM_FRACTION_FOR_EXTERNAL_DATA_FILE = 0.05;
	private static final Long DEFAULT_MAX_MEMORY_FOR_VIEW = 100 * 1024 * 1024L; // 100 MB

	/**
	* Configs to control whether backup needs to be configured if clients were not able to reach
	* timeline service.
	*/
	public static final String REMOTE_BACKUP_VIEW_HANDLER_ENABLE =
	"hoodie.filesystem.remote.backup.view.enable";
	// Need to be disabled only for tests.
	public static final String DEFAULT_REMOTE_BACKUP_VIEW_HANDLER_ENABLE = "true";

	public static FileSystemViewStorageConfig.Builder newBuilder() {
	return new Builder();
	}

	private FileSystemViewStorageConfig(Properties props) {
	super(props);
	}

	public FileSystemViewStorageType getStorageType() {
	return FileSystemViewStorageType.valueOf(props.getProperty(FILESYSTEM_VIEW_STORAGE_TYPE));
	}

	public boolean isIncrementalTimelineSyncEnabled() {
	return Boolean.parseBoolean(props.getProperty(FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE));
	}

	public String getRemoteViewServerHost() {
	return props.getProperty(FILESYSTEM_VIEW_REMOTE_HOST);
	}

	public Integer getRemoteViewServerPort() {
	return Integer.parseInt(props.getProperty(FILESYSTEM_VIEW_REMOTE_PORT));
	}

	public Integer getRemoteTimelineClientTimeoutSecs() {
	return Integer.parseInt(props.getProperty(FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS));
	}

	public long getMaxMemoryForFileGroupMap() {
	long totalMemory = Long.parseLong(props.getProperty(FILESYSTEM_VIEW_SPILLABLE_MEM));
	return totalMemory - getMaxMemoryForPendingCompaction() - getMaxMemoryForBootstrapBaseFile();
	}

	public long getMaxMemoryForPendingCompaction() {
	long totalMemory = Long.parseLong(props.getProperty(FILESYSTEM_VIEW_SPILLABLE_MEM));
	return new Double(totalMemory * Double.parseDouble(props.getProperty(FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION)))
	.longValue();
	}

	public long getMaxMemoryForBootstrapBaseFile() {
	long totalMemory = Long.parseLong(props.getProperty(FILESYSTEM_VIEW_SPILLABLE_MEM));
	long reservedForExternalDataFile =
	new Double(totalMemory * Double.parseDouble(props.getProperty(FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION)))
	.longValue();
	return reservedForExternalDataFile;
	}

	public String getBaseStoreDir() {
	return props.getProperty(FILESYSTEM_VIEW_SPILLABLE_DIR);
	}

	public FileSystemViewStorageType getSecondaryStorageType() {
	return FileSystemViewStorageType.valueOf(props.getProperty(FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE));
	}

	public boolean shouldEnableBackupForRemoteFileSystemView() {
	return Boolean.parseBoolean(props.getProperty(REMOTE_BACKUP_VIEW_HANDLER_ENABLE));
	}

	public String getRocksdbBasePath() {
	return props.getProperty(ROCKSDB_BASE_PATH_PROP);
	}

	/**
	* The builder used to build {@link FileSystemViewStorageConfig}.
	*/
	public static class Builder {

	private final Properties props = new Properties();

	public Builder fromFile(File propertiesFile) throws IOException {
	try (FileReader reader = new FileReader(propertiesFile)) {
	props.load(reader);
	return this;
	}
	}

	public Builder fromProperties(Properties props) {
	this.props.putAll(props);
	return this;
	}

	public Builder withStorageType(FileSystemViewStorageType storageType) {
	props.setProperty(FILESYSTEM_VIEW_STORAGE_TYPE, storageType.name());
	return this;
	}

	public Builder withSecondaryStorageType(FileSystemViewStorageType storageType) {
	props.setProperty(FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE, storageType.name());
	return this;
	}

	public Builder withIncrementalTimelineSync(boolean enableIncrTimelineSync) {
	props.setProperty(FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE, Boolean.toString(enableIncrTimelineSync));
	return this;
	}

	public Builder withRemoteServerHost(String remoteServerHost) {
	props.setProperty(FILESYSTEM_VIEW_REMOTE_HOST, remoteServerHost);
	return this;
	}

	public Builder withRemoteServerPort(Integer remoteServerPort) {
	props.setProperty(FILESYSTEM_VIEW_REMOTE_PORT, remoteServerPort.toString());
	return this;
	}

	public Builder withMaxMemoryForView(Long maxMemoryForView) {
	props.setProperty(FILESYSTEM_VIEW_SPILLABLE_MEM, maxMemoryForView.toString());
	return this;
	}

	public Builder withRemoteTimelineClientTimeoutSecs(Long timelineClientTimeoutSecs) {
	props.setProperty(FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS, timelineClientTimeoutSecs.toString());
	return this;
	}

	public Builder withMemFractionForPendingCompaction(Double memFractionForPendingCompaction) {
	props.setProperty(FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION, memFractionForPendingCompaction.toString());
	return this;
	}

	public Builder withMemFractionForExternalDataFile(Double memFractionForExternalDataFile) {
	props.setProperty(FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION, memFractionForExternalDataFile.toString());
	return this;
	}

	public Builder withBaseStoreDir(String baseStorePath) {
	props.setProperty(FILESYSTEM_VIEW_SPILLABLE_DIR, baseStorePath);
	return this;
	}

	public Builder withRocksDBPath(String basePath) {
	props.setProperty(ROCKSDB_BASE_PATH_PROP, basePath);
	return this;
	}

	public Builder withEnableBackupForRemoteFileSystemView(boolean enable) {
	props.setProperty(REMOTE_BACKUP_VIEW_HANDLER_ENABLE, Boolean.toString(enable));
	return this;
	}

	public FileSystemViewStorageConfig build() {
	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_STORAGE_TYPE), FILESYSTEM_VIEW_STORAGE_TYPE,
	DEFAULT_VIEW_STORAGE_TYPE.name());
	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE),
	FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE, DEFAULT_FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE);
	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE),
	FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE, DEFAULT_SECONDARY_VIEW_STORAGE_TYPE.name());
	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_REMOTE_HOST), FILESYSTEM_VIEW_REMOTE_HOST,
	DEFUALT_REMOTE_VIEW_SERVER_HOST);
	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_REMOTE_PORT), FILESYSTEM_VIEW_REMOTE_PORT,
	DEFAULT_REMOTE_VIEW_SERVER_PORT.toString());

	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_SPILLABLE_DIR), FILESYSTEM_VIEW_SPILLABLE_DIR,
	DEFAULT_VIEW_SPILLABLE_DIR);
	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_SPILLABLE_MEM), FILESYSTEM_VIEW_SPILLABLE_MEM,
	DEFAULT_MAX_MEMORY_FOR_VIEW.toString());
	setDefaultOnCondition(props, !props.containsKey(FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS),
	FILESTYSTEM_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS, DEFAULT_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS.toString());
	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION),
	FILESYSTEM_VIEW_PENDING_COMPACTION_MEM_FRACTION, DEFAULT_MEM_FRACTION_FOR_PENDING_COMPACTION.toString());
	setDefaultOnCondition(props, !props.containsKey(FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION),
	FILESYSTEM_VIEW_BOOTSTRAP_BASE_FILE_FRACTION, DEFAULT_MEM_FRACTION_FOR_EXTERNAL_DATA_FILE.toString());

	setDefaultOnCondition(props, !props.containsKey(ROCKSDB_BASE_PATH_PROP), ROCKSDB_BASE_PATH_PROP,
	DEFAULT_ROCKSDB_BASE_PATH);

	setDefaultOnCondition(props, !props.containsKey(REMOTE_BACKUP_VIEW_HANDLER_ENABLE),
	REMOTE_BACKUP_VIEW_HANDLER_ENABLE, DEFAULT_REMOTE_BACKUP_VIEW_HANDLER_ENABLE);

	// Validations
	FileSystemViewStorageType.valueOf(props.getProperty(FILESYSTEM_VIEW_STORAGE_TYPE));
	FileSystemViewStorageType.valueOf(props.getProperty(FILESYSTEM_SECONDARY_VIEW_STORAGE_TYPE));
	ValidationUtils.checkArgument(Integer.parseInt(props.getProperty(FILESYSTEM_VIEW_REMOTE_PORT)) > 0);
	return new FileSystemViewStorageConfig(props);
	}
	}

	}