Leave an emphatic TODO per Jeff's observations
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1754555 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/server/gen_test_char.c b/server/gen_test_char.c
index 84df3d4..c089448 100644
--- a/server/gen_test_char.c
+++ b/server/gen_test_char.c
@@ -120,19 +120,18 @@
/* Stop for any non-'token' character, including ctrls, obs-text,
* and "tspecials" (RFC2068) a.k.a. "separators" (RFC2616)
- * XXX: With luck, isascii behaves sensibly on EBCDIC platforms
- * and insists on chars that correspond to ASCII equivilants
+ * XXX: We need to build a specific table for EBCDIC values with
+ * ASCII equivilants here
*/
- if (!c || apr_iscntrl(c) || strchr(" \t()<>@,;:\\\"/[]?={}", c))
- || !apr_isascii(c)) {
- flags |= T_HTTP_TOKEN_STOP;
+ if (!c || apr_iscntrl(c) || strchr(" \t()<>@,;:\\\"/[]?={}", c)) {
}
/* Catch CTRLs other than VCHAR, HT and SP, and obs-text (RFC7230 3.2)
* This includes only the C0 plane, not C1 (which is obs-text itself.)
- * XXX: Need to confirm this behavior on EBCDIC architecture
+ * XXX: Need to constrain iscntrl to C0 equivilants in ASCII,
+ * even on EBCDIC architecture
*/
- if (!c || (apr_iscntrl(c) && c != '\t' && apr_isascii(c))) {
+ if (!c || (apr_iscntrl(c) && c != '\t')) {
flags |= T_HTTP_CTRLS;
}
