A user on IRC had APR_EPIPE in this path and lots of WARN spam
in logs. Check r->c->aborted to determine if an warning is worth
surfacing (although for a downstream filter error, is it ever?)
git-svn-id: https://svn.apache.org/repos/asf/httpd/mod_fcgid/trunk@1725557 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/CHANGES-FCGID b/CHANGES-FCGID
index be733e8..17d4a70 100644
--- a/CHANGES-FCGID
+++ b/CHANGES-FCGID
@@ -1,6 +1,10 @@
-*- coding: utf-8 -*-
Changes with mod_fcgid 2.3.10
+ *) Use an alternate, lower severity log message when a failure to
+ forward a response is due to the client connection being aborted.
+ [Eric Covener]
+
*) Windows: "graceful kill fail, sending SIGKILL" log message is now
debug level instead of warning. PR 54597. [Mario Brandt]
diff --git a/modules/fcgid/fcgid_bridge.c b/modules/fcgid/fcgid_bridge.c
index c8b45c2..180f582 100644
--- a/modules/fcgid/fcgid_bridge.c
+++ b/modules/fcgid/fcgid_bridge.c
@@ -403,11 +403,15 @@
/* Now pass any remaining response body data to output filters */
if ((rv = ap_pass_brigade(r->output_filters,
brigade_stdout)) != APR_SUCCESS) {
- if (!APR_STATUS_IS_ECONNABORTED(rv)) {
- ap_log_rerror(APLOG_MARK, APLOG_WARNING, rv, r,
- "mod_fcgid: ap_pass_brigade failed in "
- "handle_request_ipc function");
- }
+ if (r->connection->aborted) {
+ ap_log_rerror(APLOG_MARK, APLOG_TRACE1, rv, r,
+ "mod_fcgid: ap_pass_brigade failed "
+ "(client aborted connection)");
+ return OK;
+ }
+ ap_log_rerror(APLOG_MARK, APLOG_WARNING, rv, r,
+ "mod_fcgid: ap_pass_brigade failed in "
+ "handle_request_ipc function");
return HTTP_INTERNAL_SERVER_ERROR;
}
