commit 66f8ca1f09213c7108229cc546350ca2b4768774
author Gary Gregory <garydgregory@users.noreply.github.com> Fri Jul 10 08:57:24 2020 -0400
committer GitHub <noreply@github.com> Fri Jul 10 08:57:24 2020 -0400
tree 5010cc7a1071d681138d2acbf7b197bcee2e4f15
parent 986686535750a6a665a206ba0cc892d8fb24bbec

BasicExpiresHandler is annotated as immutable but is not. (#240)

httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java

diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java
index 1c01784..25d3385 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicExpiresHandler.java
@@ -46,11 +46,11 @@
 public class BasicExpiresHandler extends AbstractCookieAttributeHandler implements CommonCookieAttributeHandler {
 
     /** Valid date patterns */
-    private final String[] datepatterns;
+    private final String[] datePatterns;
 
-    public BasicExpiresHandler(final String[] datepatterns) {
-        Args.notNull(datepatterns, "Array of date patterns");
-        this.datepatterns = datepatterns;
+    public BasicExpiresHandler(final String[] datePatterns) {
+        Args.notNull(datePatterns, "Array of date patterns");
+        this.datePatterns = datePatterns.clone();
     }
 
     @Override
@@ -60,7 +60,7 @@
         if (value == null) {
             throw new MalformedCookieException("Missing value for 'expires' attribute");
         }
-        final Date expiry = DateUtils.parseDate(value, this.datepatterns);
+        final Date expiry = DateUtils.parseDate(value, this.datePatterns);
         if (expiry == null) {
             throw new MalformedCookieException("Invalid 'expires' attribute: "
                     + value);