Add special treatment for ClusterConfig
This diff allows callers of getChangeType to iterate over the result of getChangeType() by changing determinePropertyMapByType so that it just returns an empty map for ClusterConfig.
diff --git a/helix-core/src/main/java/org/apache/helix/controller/changedetector/ResourceChangeDetector.java b/helix-core/src/main/java/org/apache/helix/controller/changedetector/ResourceChangeDetector.java
index 611f4b2..a154af2 100644
--- a/helix-core/src/main/java/org/apache/helix/controller/changedetector/ResourceChangeDetector.java
+++ b/helix-core/src/main/java/org/apache/helix/controller/changedetector/ResourceChangeDetector.java
@@ -111,11 +111,14 @@
return snapshot.getResourceConfigMap();
case LIVE_INSTANCE:
return snapshot.getLiveInstances();
- case CONFIG:
+ case CLUSTER_CONFIG:
+ // In the case of ClusterConfig, we return an empty map
+ // This is to allow the caller to iterate on the change types without throwing an exception or
+ // leaving a warn log for ClusterConfig changes
return Collections.emptyMap();
default:
LOG.warn(
- "ResourceChangeDetector cannot compute the names of changes for the given ChangeType: {}",
+ "ResourceChangeDetector cannot determine propertyMap for the given ChangeType: {}. Returning an empty map.",
changeType);
return Collections.emptyMap();
}
