commit b8ed7685b5fc0efb162fe8c97cd56f995718d5af
author xyuanlu <xyuanlu@gmail.com> Wed Sep 08 14:05:03 2021 -0700
committer GitHub <noreply@github.com> Wed Sep 08 14:05:03 2021 -0700
tree 1dbbd3b4fa733f0f48da4127cc585e88f43537fe
parent 1174926e423b427d4fe31d0edfad0dd953e5ace0

Add input validation for getJobContext (#1864)

* add validation for getJobContext

helix-core/src/main/java/org/apache/helix/task/TaskUtil.java

diff --git a/helix-core/src/main/java/org/apache/helix/task/TaskUtil.java b/helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
index e2de939..fc9b3d4 100644
--- a/helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
+++ b/helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
@@ -20,6 +20,7 @@
  */
 
 import java.io.IOException;
+import java.security.InvalidParameterException;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -201,6 +202,9 @@
    */
   protected static JobContext getJobContext(HelixPropertyStore<ZNRecord> propertyStore,
       String jobResource) {
+    if (jobResource == null) {
+      throw new InvalidParameterException("Null job name is now allowed");
+    }
     ZNRecord r = propertyStore.get(
         Joiner.on("/").join(TaskConstants.REBALANCER_CONTEXT_ROOT, jobResource, CONTEXT_NODE), null,
         AccessOption.PERSISTENT);