commit 37e45bba685d389b1b2772d466422c4eb53c6d4c
author xyuanlu <xyuanlu@gmail.com> Mon Apr 04 10:14:03 2022 -0700
committer GitHub <noreply@github.com> Mon Apr 04 10:14:03 2022 -0700
tree d904e15629dc01289c58d712b53072c7e5929df9
parent 0703cefb4b066a38e2a0b83c9160f0744f4350f1

fix Broken Logic in perPartitionHealthCheck (#2012)

fix Broken Logic in perPartitionHealthCheck

helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java

diff --git a/helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java b/helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
index d35fdb4..7c63831 100644
--- a/helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
+++ b/helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
@@ -264,8 +264,8 @@
                 || globalPartitionHealthStatus.get(siblingInstance).isEmpty()) {
               unhealthyPartitions.computeIfAbsent(partition, list -> new ArrayList<>())
                   .add(HOST_NO_STATE_ERROR + siblingInstance);
-            } else if (globalPartitionHealthStatus.get(siblingInstance)
-                .getOrDefault(partition, false)) {
+            } else if (!(globalPartitionHealthStatus.get(siblingInstance)
+                .getOrDefault(partition, false))) {
               // We are checking sibling partition healthy status. So if partition health does not
               // exist or it is not healthy. We should mark this partition is unhealthy.
               unhealthyPartitions.computeIfAbsent(partition, list -> new ArrayList<>())