Google Git
Sign in
apache / hbase-site / edc9f41ac5957af2e574b6068b2bdf77baaf06cd / . / testdevapidocs / src-html / org / apache / hadoop / hbase / master / TestMasterBalancerNPE.html
blob: 16faa7fa7a883e32b8fe818a5f59a8535d1564b8 [file] [log] [blame]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html lang="en">
<head>
<title>Source code</title>
<link rel="stylesheet" type="text/css" href="../../../../../../stylesheet.css" title="Style">
</head>
<body>
<div class="sourceContainer">
<pre><span class="sourceLineNo">001</span>/*<a name="line.1"></a>
<span class="sourceLineNo">002</span> * Licensed to the Apache Software Foundation (ASF) under one<a name="line.2"></a>
<span class="sourceLineNo">003</span> * or more contributor license agreements. See the NOTICE file<a name="line.3"></a>
<span class="sourceLineNo">004</span> * distributed with this work for additional information<a name="line.4"></a>
<span class="sourceLineNo">005</span> * regarding copyright ownership. The ASF licenses this file<a name="line.5"></a>
<span class="sourceLineNo">006</span> * to you under the Apache License, Version 2.0 (the<a name="line.6"></a>
<span class="sourceLineNo">007</span> * "License"); you may not use this file except in compliance<a name="line.7"></a>
<span class="sourceLineNo">008</span> * with the License. You may obtain a copy of the License at<a name="line.8"></a>
<span class="sourceLineNo">009</span> *<a name="line.9"></a>
<span class="sourceLineNo">010</span> * http://www.apache.org/licenses/LICENSE-2.0<a name="line.10"></a>
<span class="sourceLineNo">011</span> *<a name="line.11"></a>
<span class="sourceLineNo">012</span> * Unless required by applicable law or agreed to in writing, software<a name="line.12"></a>
<span class="sourceLineNo">013</span> * distributed under the License is distributed on an "AS IS" BASIS,<a name="line.13"></a>
<span class="sourceLineNo">014</span> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.<a name="line.14"></a>
<span class="sourceLineNo">015</span> * See the License for the specific language governing permissions and<a name="line.15"></a>
<span class="sourceLineNo">016</span> * limitations under the License.<a name="line.16"></a>
<span class="sourceLineNo">017</span> */<a name="line.17"></a>
<span class="sourceLineNo">018</span>package org.apache.hadoop.hbase.master;<a name="line.18"></a>
<span class="sourceLineNo">019</span><a name="line.19"></a>
<span class="sourceLineNo">020</span>import static org.junit.Assert.assertTrue;<a name="line.20"></a>
<span class="sourceLineNo">021</span><a name="line.21"></a>
<span class="sourceLineNo">022</span>import java.io.IOException;<a name="line.22"></a>
<span class="sourceLineNo">023</span>import java.util.ArrayList;<a name="line.23"></a>
<span class="sourceLineNo">024</span>import java.util.Arrays;<a name="line.24"></a>
<span class="sourceLineNo">025</span>import java.util.List;<a name="line.25"></a>
<span class="sourceLineNo">026</span>import java.util.Map;<a name="line.26"></a>
<span class="sourceLineNo">027</span>import java.util.concurrent.CyclicBarrier;<a name="line.27"></a>
<span class="sourceLineNo">028</span>import java.util.concurrent.atomic.AtomicReference;<a name="line.28"></a>
<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.29"></a>
<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.HBaseTestingUtil;<a name="line.30"></a>
<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.ServerName;<a name="line.31"></a>
<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.TableName;<a name="line.32"></a>
<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.33"></a>
<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.master.assignment.AssignmentManager;<a name="line.34"></a>
<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer;<a name="line.35"></a>
<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.36"></a>
<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.37"></a>
<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.38"></a>
<span class="sourceLineNo">039</span>import org.junit.After;<a name="line.39"></a>
<span class="sourceLineNo">040</span>import org.junit.Before;<a name="line.40"></a>
<span class="sourceLineNo">041</span>import org.junit.ClassRule;<a name="line.41"></a>
<span class="sourceLineNo">042</span>import org.junit.Rule;<a name="line.42"></a>
<span class="sourceLineNo">043</span>import org.junit.Test;<a name="line.43"></a>
<span class="sourceLineNo">044</span>import org.junit.experimental.categories.Category;<a name="line.44"></a>
<span class="sourceLineNo">045</span>import org.junit.rules.TestName;<a name="line.45"></a>
<span class="sourceLineNo">046</span>import org.mockito.Mockito;<a name="line.46"></a>
<span class="sourceLineNo">047</span>import org.mockito.invocation.InvocationOnMock;<a name="line.47"></a>
<span class="sourceLineNo">048</span><a name="line.48"></a>
<span class="sourceLineNo">049</span>@Category({ MasterTests.class, MediumTests.class })<a name="line.49"></a>
<span class="sourceLineNo">050</span>public class TestMasterBalancerNPE {<a name="line.50"></a>
<span class="sourceLineNo">051</span><a name="line.51"></a>
<span class="sourceLineNo">052</span> @ClassRule<a name="line.52"></a>
<span class="sourceLineNo">053</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.53"></a>
<span class="sourceLineNo">054</span> HBaseClassTestRule.forClass(TestMasterBalancerNPE.class);<a name="line.54"></a>
<span class="sourceLineNo">055</span><a name="line.55"></a>
<span class="sourceLineNo">056</span> private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();<a name="line.56"></a>
<span class="sourceLineNo">057</span> private static final byte[] FAMILYNAME = Bytes.toBytes("fam");<a name="line.57"></a>
<span class="sourceLineNo">058</span> @Rule<a name="line.58"></a>
<span class="sourceLineNo">059</span> public TestName name = new TestName();<a name="line.59"></a>
<span class="sourceLineNo">060</span><a name="line.60"></a>
<span class="sourceLineNo">061</span> @Before<a name="line.61"></a>
<span class="sourceLineNo">062</span> public void setupConfiguration() {<a name="line.62"></a>
<span class="sourceLineNo">063</span> /**<a name="line.63"></a>
<span class="sourceLineNo">064</span> * Make {@link BalancerChore} not run,so does not disrupt the test.<a name="line.64"></a>
<span class="sourceLineNo">065</span> */<a name="line.65"></a>
<span class="sourceLineNo">066</span> HMaster.setDisableBalancerChoreForTest(true);<a name="line.66"></a>
<span class="sourceLineNo">067</span> }<a name="line.67"></a>
<span class="sourceLineNo">068</span><a name="line.68"></a>
<span class="sourceLineNo">069</span> @After<a name="line.69"></a>
<span class="sourceLineNo">070</span> public void shutdown() throws Exception {<a name="line.70"></a>
<span class="sourceLineNo">071</span> HMaster.setDisableBalancerChoreForTest(false);<a name="line.71"></a>
<span class="sourceLineNo">072</span> TEST_UTIL.shutdownMiniCluster();<a name="line.72"></a>
<span class="sourceLineNo">073</span> }<a name="line.73"></a>
<span class="sourceLineNo">074</span><a name="line.74"></a>
<span class="sourceLineNo">075</span> /**<a name="line.75"></a>
<span class="sourceLineNo">076</span> * This test is for HBASE-26712, to make the region is unassigned just before<a name="line.76"></a>
<span class="sourceLineNo">077</span> * {@link AssignmentManager#balance} is invoked on the region.<a name="line.77"></a>
<span class="sourceLineNo">078</span> */<a name="line.78"></a>
<span class="sourceLineNo">079</span> @Test<a name="line.79"></a>
<span class="sourceLineNo">080</span> public void testBalancerNPE() throws Exception {<a name="line.80"></a>
<span class="sourceLineNo">081</span> TEST_UTIL.startMiniCluster(2);<a name="line.81"></a>
<span class="sourceLineNo">082</span> TEST_UTIL.getAdmin().balancerSwitch(false, true);<a name="line.82"></a>
<span class="sourceLineNo">083</span> TableName tableName = createTable(name.getMethodName());<a name="line.83"></a>
<span class="sourceLineNo">084</span> final HMaster master = TEST_UTIL.getHBaseCluster().getMaster();<a name="line.84"></a>
<span class="sourceLineNo">085</span> List&lt;RegionInfo&gt; regionInfos = TEST_UTIL.getAdmin().getRegions(tableName);<a name="line.85"></a>
<span class="sourceLineNo">086</span> assertTrue(regionInfos.size() == 1);<a name="line.86"></a>
<span class="sourceLineNo">087</span> final ServerName serverName1 =<a name="line.87"></a>
<span class="sourceLineNo">088</span> TEST_UTIL.getMiniHBaseCluster().getRegionServer(0).getServerName();<a name="line.88"></a>
<span class="sourceLineNo">089</span> final ServerName serverName2 =<a name="line.89"></a>
<span class="sourceLineNo">090</span> TEST_UTIL.getMiniHBaseCluster().getRegionServer(1).getServerName();<a name="line.90"></a>
<span class="sourceLineNo">091</span><a name="line.91"></a>
<span class="sourceLineNo">092</span> final RegionInfo regionInfo = regionInfos.get(0);<a name="line.92"></a>
<span class="sourceLineNo">093</span><a name="line.93"></a>
<span class="sourceLineNo">094</span> RSGroupBasedLoadBalancer loadBalancer = master.getLoadBalancer();<a name="line.94"></a>
<span class="sourceLineNo">095</span> RSGroupBasedLoadBalancer spiedLoadBalancer = Mockito.spy(loadBalancer);<a name="line.95"></a>
<span class="sourceLineNo">096</span> final AtomicReference&lt;RegionPlan&gt; regionPlanRef = new AtomicReference&lt;RegionPlan&gt;();<a name="line.96"></a>
<span class="sourceLineNo">097</span><a name="line.97"></a>
<span class="sourceLineNo">098</span> /**<a name="line.98"></a>
<span class="sourceLineNo">099</span> * Mock {@link RSGroupBasedLoadBalancer#balanceCluster} to return the {@link RegionPlan} to move<a name="line.99"></a>
<span class="sourceLineNo">100</span> * the only region to the other RegionServer.<a name="line.100"></a>
<span class="sourceLineNo">101</span> */<a name="line.101"></a>
<span class="sourceLineNo">102</span> Mockito.doAnswer((InvocationOnMock invocation) -&gt; {<a name="line.102"></a>
<span class="sourceLineNo">103</span> @SuppressWarnings("unchecked")<a name="line.103"></a>
<span class="sourceLineNo">104</span> Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; tableNameToRegionServerNameToRegionInfos =<a name="line.104"></a>
<span class="sourceLineNo">105</span> (Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt;) invocation.getArgument(0);<a name="line.105"></a>
<span class="sourceLineNo">106</span> Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; regionServerNameToRegionInfos =<a name="line.106"></a>
<span class="sourceLineNo">107</span> tableNameToRegionServerNameToRegionInfos.get(tableName);<a name="line.107"></a>
<span class="sourceLineNo">108</span> assertTrue(regionServerNameToRegionInfos.size() == 2);<a name="line.108"></a>
<span class="sourceLineNo">109</span> List&lt;ServerName&gt; assignedRegionServerNames = new ArrayList&lt;ServerName&gt;();<a name="line.109"></a>
<span class="sourceLineNo">110</span> for (Map.Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt; entry : regionServerNameToRegionInfos<a name="line.110"></a>
<span class="sourceLineNo">111</span> .entrySet()) {<a name="line.111"></a>
<span class="sourceLineNo">112</span> if (entry.getValue().size() &gt; 0) {<a name="line.112"></a>
<span class="sourceLineNo">113</span> assignedRegionServerNames.add(entry.getKey());<a name="line.113"></a>
<span class="sourceLineNo">114</span> }<a name="line.114"></a>
<span class="sourceLineNo">115</span> }<a name="line.115"></a>
<span class="sourceLineNo">116</span> assertTrue(assignedRegionServerNames.size() == 1);<a name="line.116"></a>
<span class="sourceLineNo">117</span> ServerName assignedRegionServerName = assignedRegionServerNames.get(0);<a name="line.117"></a>
<span class="sourceLineNo">118</span> ServerName notAssignedRegionServerName =<a name="line.118"></a>
<span class="sourceLineNo">119</span> assignedRegionServerName.equals(serverName1) ? serverName2 : serverName1;<a name="line.119"></a>
<span class="sourceLineNo">120</span> RegionPlan regionPlan =<a name="line.120"></a>
<span class="sourceLineNo">121</span> new RegionPlan(regionInfo, assignedRegionServerName, notAssignedRegionServerName);<a name="line.121"></a>
<span class="sourceLineNo">122</span> regionPlanRef.set(regionPlan);<a name="line.122"></a>
<span class="sourceLineNo">123</span> return Arrays.asList(regionPlan);<a name="line.123"></a>
<span class="sourceLineNo">124</span> }).when(spiedLoadBalancer).balanceCluster(Mockito.anyMap());<a name="line.124"></a>
<span class="sourceLineNo">125</span><a name="line.125"></a>
<span class="sourceLineNo">126</span> AssignmentManager assignmentManager = master.getAssignmentManager();<a name="line.126"></a>
<span class="sourceLineNo">127</span> final AssignmentManager spiedAssignmentManager = Mockito.spy(assignmentManager);<a name="line.127"></a>
<span class="sourceLineNo">128</span> final CyclicBarrier cyclicBarrier = new CyclicBarrier(2);<a name="line.128"></a>
<span class="sourceLineNo">129</span><a name="line.129"></a>
<span class="sourceLineNo">130</span> /**<a name="line.130"></a>
<span class="sourceLineNo">131</span> * Override {@link AssignmentManager#balance} to invoke real {@link AssignmentManager#balance}<a name="line.131"></a>
<span class="sourceLineNo">132</span> * after the region is successfully unassigned.<a name="line.132"></a>
<span class="sourceLineNo">133</span> */<a name="line.133"></a>
<span class="sourceLineNo">134</span> Mockito.doAnswer((InvocationOnMock invocation) -&gt; {<a name="line.134"></a>
<span class="sourceLineNo">135</span> RegionPlan regionPlan = invocation.getArgument(0);<a name="line.135"></a>
<span class="sourceLineNo">136</span> RegionPlan referedRegionPlan = regionPlanRef.get();<a name="line.136"></a>
<span class="sourceLineNo">137</span> assertTrue(referedRegionPlan != null);<a name="line.137"></a>
<span class="sourceLineNo">138</span> if (referedRegionPlan.equals(regionPlan)) {<a name="line.138"></a>
<span class="sourceLineNo">139</span> /**<a name="line.139"></a>
<span class="sourceLineNo">140</span> * To make {@link AssignmentManager#unassign} could be invoked just before<a name="line.140"></a>
<span class="sourceLineNo">141</span> * {@link AssignmentManager#balance} is invoked.<a name="line.141"></a>
<span class="sourceLineNo">142</span> */<a name="line.142"></a>
<span class="sourceLineNo">143</span> cyclicBarrier.await();<a name="line.143"></a>
<span class="sourceLineNo">144</span> /**<a name="line.144"></a>
<span class="sourceLineNo">145</span> * After {@link AssignmentManager#unassign} is completed,we could invoke<a name="line.145"></a>
<span class="sourceLineNo">146</span> * {@link AssignmentManager#balance}.<a name="line.146"></a>
<span class="sourceLineNo">147</span> */<a name="line.147"></a>
<span class="sourceLineNo">148</span> cyclicBarrier.await();<a name="line.148"></a>
<span class="sourceLineNo">149</span> }<a name="line.149"></a>
<span class="sourceLineNo">150</span> /**<a name="line.150"></a>
<span class="sourceLineNo">151</span> * Before HBASE-26712,here may throw NPE.<a name="line.151"></a>
<span class="sourceLineNo">152</span> */<a name="line.152"></a>
<span class="sourceLineNo">153</span> return invocation.callRealMethod();<a name="line.153"></a>
<span class="sourceLineNo">154</span> }).when(spiedAssignmentManager).balance(Mockito.any());<a name="line.154"></a>
<span class="sourceLineNo">155</span><a name="line.155"></a>
<span class="sourceLineNo">156</span> try {<a name="line.156"></a>
<span class="sourceLineNo">157</span> final AtomicReference&lt;Throwable&gt; exceptionRef = new AtomicReference&lt;Throwable&gt;(null);<a name="line.157"></a>
<span class="sourceLineNo">158</span> Thread unassignThread = new Thread(() -&gt; {<a name="line.158"></a>
<span class="sourceLineNo">159</span> try {<a name="line.159"></a>
<span class="sourceLineNo">160</span> /**<a name="line.160"></a>
<span class="sourceLineNo">161</span> * To invoke {@link AssignmentManager#unassign} just before<a name="line.161"></a>
<span class="sourceLineNo">162</span> * {@link AssignmentManager#balance} is invoked.<a name="line.162"></a>
<span class="sourceLineNo">163</span> */<a name="line.163"></a>
<span class="sourceLineNo">164</span> cyclicBarrier.await();<a name="line.164"></a>
<span class="sourceLineNo">165</span> spiedAssignmentManager.unassign(regionInfo);<a name="line.165"></a>
<span class="sourceLineNo">166</span> assertTrue(spiedAssignmentManager.getRegionStates().getRegionAssignments().get(regionInfo)<a name="line.166"></a>
<span class="sourceLineNo">167</span> == null);<a name="line.167"></a>
<span class="sourceLineNo">168</span> /**<a name="line.168"></a>
<span class="sourceLineNo">169</span> * After {@link AssignmentManager#unassign} is completed,we could invoke<a name="line.169"></a>
<span class="sourceLineNo">170</span> * {@link AssignmentManager#balance}.<a name="line.170"></a>
<span class="sourceLineNo">171</span> */<a name="line.171"></a>
<span class="sourceLineNo">172</span> cyclicBarrier.await();<a name="line.172"></a>
<span class="sourceLineNo">173</span> } catch (Exception e) {<a name="line.173"></a>
<span class="sourceLineNo">174</span> exceptionRef.set(e);<a name="line.174"></a>
<span class="sourceLineNo">175</span> }<a name="line.175"></a>
<span class="sourceLineNo">176</span> });<a name="line.176"></a>
<span class="sourceLineNo">177</span> unassignThread.setName("UnassignThread");<a name="line.177"></a>
<span class="sourceLineNo">178</span> unassignThread.start();<a name="line.178"></a>
<span class="sourceLineNo">179</span><a name="line.179"></a>
<span class="sourceLineNo">180</span> master.setLoadBalancer(spiedLoadBalancer);<a name="line.180"></a>
<span class="sourceLineNo">181</span> master.setAssignmentManager(spiedAssignmentManager);<a name="line.181"></a>
<span class="sourceLineNo">182</span> /**<a name="line.182"></a>
<span class="sourceLineNo">183</span> * enable balance<a name="line.183"></a>
<span class="sourceLineNo">184</span> */<a name="line.184"></a>
<span class="sourceLineNo">185</span> TEST_UTIL.getAdmin().balancerSwitch(true, false);<a name="line.185"></a>
<span class="sourceLineNo">186</span> /**<a name="line.186"></a>
<span class="sourceLineNo">187</span> * Before HBASE-26712,here invokes {@link AssignmentManager#balance(RegionPlan)} which may<a name="line.187"></a>
<span class="sourceLineNo">188</span> * throw NPE.<a name="line.188"></a>
<span class="sourceLineNo">189</span> */<a name="line.189"></a>
<span class="sourceLineNo">190</span> master.balanceOrUpdateMetrics();<a name="line.190"></a>
<span class="sourceLineNo">191</span><a name="line.191"></a>
<span class="sourceLineNo">192</span> unassignThread.join();<a name="line.192"></a>
<span class="sourceLineNo">193</span> assertTrue(exceptionRef.get() == null);<a name="line.193"></a>
<span class="sourceLineNo">194</span> } finally {<a name="line.194"></a>
<span class="sourceLineNo">195</span> master.setLoadBalancer(loadBalancer);<a name="line.195"></a>
<span class="sourceLineNo">196</span> master.setAssignmentManager(assignmentManager);<a name="line.196"></a>
<span class="sourceLineNo">197</span> }<a name="line.197"></a>
<span class="sourceLineNo">198</span> }<a name="line.198"></a>
<span class="sourceLineNo">199</span><a name="line.199"></a>
<span class="sourceLineNo">200</span> private TableName createTable(String table) throws IOException {<a name="line.200"></a>
<span class="sourceLineNo">201</span> TableName tableName = TableName.valueOf(table);<a name="line.201"></a>
<span class="sourceLineNo">202</span> TEST_UTIL.createTable(tableName, FAMILYNAME);<a name="line.202"></a>
<span class="sourceLineNo">203</span> return tableName;<a name="line.203"></a>
<span class="sourceLineNo">204</span> }<a name="line.204"></a>
<span class="sourceLineNo">205</span><a name="line.205"></a>
<span class="sourceLineNo">206</span>}<a name="line.206"></a>
</pre>
</div>
</body>
</html>