blob: 62a498aad8807f31927090741469f1fb8b4bbe05 [file] [log] [blame]
<!DOCTYPE HTML>
<html lang="en">
<head>
<!-- Generated by javadoc (17) -->
<title>Source code</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="description" content="source: package: org.apache.hadoop.hbase.master, class: TestMasterBalancerNPE">
<meta name="generator" content="javadoc/SourceToHTMLConverter">
<link rel="stylesheet" type="text/css" href="../../../../../../stylesheet.css" title="Style">
</head>
<body class="source-page">
<main role="main">
<div class="source-container">
<pre><span class="source-line-no">001</span><span id="line-1">/*</span>
<span class="source-line-no">002</span><span id="line-2"> * Licensed to the Apache Software Foundation (ASF) under one</span>
<span class="source-line-no">003</span><span id="line-3"> * or more contributor license agreements. See the NOTICE file</span>
<span class="source-line-no">004</span><span id="line-4"> * distributed with this work for additional information</span>
<span class="source-line-no">005</span><span id="line-5"> * regarding copyright ownership. The ASF licenses this file</span>
<span class="source-line-no">006</span><span id="line-6"> * to you under the Apache License, Version 2.0 (the</span>
<span class="source-line-no">007</span><span id="line-7"> * "License"); you may not use this file except in compliance</span>
<span class="source-line-no">008</span><span id="line-8"> * with the License. You may obtain a copy of the License at</span>
<span class="source-line-no">009</span><span id="line-9"> *</span>
<span class="source-line-no">010</span><span id="line-10"> * http://www.apache.org/licenses/LICENSE-2.0</span>
<span class="source-line-no">011</span><span id="line-11"> *</span>
<span class="source-line-no">012</span><span id="line-12"> * Unless required by applicable law or agreed to in writing, software</span>
<span class="source-line-no">013</span><span id="line-13"> * distributed under the License is distributed on an "AS IS" BASIS,</span>
<span class="source-line-no">014</span><span id="line-14"> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.</span>
<span class="source-line-no">015</span><span id="line-15"> * See the License for the specific language governing permissions and</span>
<span class="source-line-no">016</span><span id="line-16"> * limitations under the License.</span>
<span class="source-line-no">017</span><span id="line-17"> */</span>
<span class="source-line-no">018</span><span id="line-18">package org.apache.hadoop.hbase.master;</span>
<span class="source-line-no">019</span><span id="line-19"></span>
<span class="source-line-no">020</span><span id="line-20">import static org.junit.Assert.assertTrue;</span>
<span class="source-line-no">021</span><span id="line-21"></span>
<span class="source-line-no">022</span><span id="line-22">import java.io.IOException;</span>
<span class="source-line-no">023</span><span id="line-23">import java.util.ArrayList;</span>
<span class="source-line-no">024</span><span id="line-24">import java.util.Arrays;</span>
<span class="source-line-no">025</span><span id="line-25">import java.util.List;</span>
<span class="source-line-no">026</span><span id="line-26">import java.util.Map;</span>
<span class="source-line-no">027</span><span id="line-27">import java.util.concurrent.CyclicBarrier;</span>
<span class="source-line-no">028</span><span id="line-28">import java.util.concurrent.atomic.AtomicReference;</span>
<span class="source-line-no">029</span><span id="line-29">import org.apache.hadoop.hbase.HBaseClassTestRule;</span>
<span class="source-line-no">030</span><span id="line-30">import org.apache.hadoop.hbase.HBaseTestingUtil;</span>
<span class="source-line-no">031</span><span id="line-31">import org.apache.hadoop.hbase.ServerName;</span>
<span class="source-line-no">032</span><span id="line-32">import org.apache.hadoop.hbase.TableName;</span>
<span class="source-line-no">033</span><span id="line-33">import org.apache.hadoop.hbase.client.RegionInfo;</span>
<span class="source-line-no">034</span><span id="line-34">import org.apache.hadoop.hbase.master.assignment.AssignmentManager;</span>
<span class="source-line-no">035</span><span id="line-35">import org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer;</span>
<span class="source-line-no">036</span><span id="line-36">import org.apache.hadoop.hbase.testclassification.MasterTests;</span>
<span class="source-line-no">037</span><span id="line-37">import org.apache.hadoop.hbase.testclassification.MediumTests;</span>
<span class="source-line-no">038</span><span id="line-38">import org.apache.hadoop.hbase.util.Bytes;</span>
<span class="source-line-no">039</span><span id="line-39">import org.junit.After;</span>
<span class="source-line-no">040</span><span id="line-40">import org.junit.Before;</span>
<span class="source-line-no">041</span><span id="line-41">import org.junit.ClassRule;</span>
<span class="source-line-no">042</span><span id="line-42">import org.junit.Rule;</span>
<span class="source-line-no">043</span><span id="line-43">import org.junit.Test;</span>
<span class="source-line-no">044</span><span id="line-44">import org.junit.experimental.categories.Category;</span>
<span class="source-line-no">045</span><span id="line-45">import org.junit.rules.TestName;</span>
<span class="source-line-no">046</span><span id="line-46">import org.mockito.Mockito;</span>
<span class="source-line-no">047</span><span id="line-47">import org.mockito.invocation.InvocationOnMock;</span>
<span class="source-line-no">048</span><span id="line-48"></span>
<span class="source-line-no">049</span><span id="line-49">@Category({ MasterTests.class, MediumTests.class })</span>
<span class="source-line-no">050</span><span id="line-50">public class TestMasterBalancerNPE {</span>
<span class="source-line-no">051</span><span id="line-51"></span>
<span class="source-line-no">052</span><span id="line-52"> @ClassRule</span>
<span class="source-line-no">053</span><span id="line-53"> public static final HBaseClassTestRule CLASS_RULE =</span>
<span class="source-line-no">054</span><span id="line-54"> HBaseClassTestRule.forClass(TestMasterBalancerNPE.class);</span>
<span class="source-line-no">055</span><span id="line-55"></span>
<span class="source-line-no">056</span><span id="line-56"> private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();</span>
<span class="source-line-no">057</span><span id="line-57"> private static final byte[] FAMILYNAME = Bytes.toBytes("fam");</span>
<span class="source-line-no">058</span><span id="line-58"> @Rule</span>
<span class="source-line-no">059</span><span id="line-59"> public TestName name = new TestName();</span>
<span class="source-line-no">060</span><span id="line-60"></span>
<span class="source-line-no">061</span><span id="line-61"> @Before</span>
<span class="source-line-no">062</span><span id="line-62"> public void setupConfiguration() {</span>
<span class="source-line-no">063</span><span id="line-63"> /**</span>
<span class="source-line-no">064</span><span id="line-64"> * Make {@link BalancerChore} not run,so does not disrupt the test.</span>
<span class="source-line-no">065</span><span id="line-65"> */</span>
<span class="source-line-no">066</span><span id="line-66"> HMaster.setDisableBalancerChoreForTest(true);</span>
<span class="source-line-no">067</span><span id="line-67"> }</span>
<span class="source-line-no">068</span><span id="line-68"></span>
<span class="source-line-no">069</span><span id="line-69"> @After</span>
<span class="source-line-no">070</span><span id="line-70"> public void shutdown() throws Exception {</span>
<span class="source-line-no">071</span><span id="line-71"> HMaster.setDisableBalancerChoreForTest(false);</span>
<span class="source-line-no">072</span><span id="line-72"> TEST_UTIL.shutdownMiniCluster();</span>
<span class="source-line-no">073</span><span id="line-73"> }</span>
<span class="source-line-no">074</span><span id="line-74"></span>
<span class="source-line-no">075</span><span id="line-75"> /**</span>
<span class="source-line-no">076</span><span id="line-76"> * This test is for HBASE-26712, to make the region is unassigned just before</span>
<span class="source-line-no">077</span><span id="line-77"> * {@link AssignmentManager#balance} is invoked on the region.</span>
<span class="source-line-no">078</span><span id="line-78"> */</span>
<span class="source-line-no">079</span><span id="line-79"> @Test</span>
<span class="source-line-no">080</span><span id="line-80"> public void testBalancerNPE() throws Exception {</span>
<span class="source-line-no">081</span><span id="line-81"> TEST_UTIL.startMiniCluster(2);</span>
<span class="source-line-no">082</span><span id="line-82"> TEST_UTIL.getAdmin().balancerSwitch(false, true);</span>
<span class="source-line-no">083</span><span id="line-83"> TableName tableName = createTable(name.getMethodName());</span>
<span class="source-line-no">084</span><span id="line-84"> final HMaster master = TEST_UTIL.getHBaseCluster().getMaster();</span>
<span class="source-line-no">085</span><span id="line-85"> List&lt;RegionInfo&gt; regionInfos = TEST_UTIL.getAdmin().getRegions(tableName);</span>
<span class="source-line-no">086</span><span id="line-86"> assertTrue(regionInfos.size() == 1);</span>
<span class="source-line-no">087</span><span id="line-87"> final ServerName serverName1 =</span>
<span class="source-line-no">088</span><span id="line-88"> TEST_UTIL.getMiniHBaseCluster().getRegionServer(0).getServerName();</span>
<span class="source-line-no">089</span><span id="line-89"> final ServerName serverName2 =</span>
<span class="source-line-no">090</span><span id="line-90"> TEST_UTIL.getMiniHBaseCluster().getRegionServer(1).getServerName();</span>
<span class="source-line-no">091</span><span id="line-91"></span>
<span class="source-line-no">092</span><span id="line-92"> final RegionInfo regionInfo = regionInfos.get(0);</span>
<span class="source-line-no">093</span><span id="line-93"></span>
<span class="source-line-no">094</span><span id="line-94"> RSGroupBasedLoadBalancer loadBalancer = master.getLoadBalancer();</span>
<span class="source-line-no">095</span><span id="line-95"> RSGroupBasedLoadBalancer spiedLoadBalancer = Mockito.spy(loadBalancer);</span>
<span class="source-line-no">096</span><span id="line-96"> final AtomicReference&lt;RegionPlan&gt; regionPlanRef = new AtomicReference&lt;RegionPlan&gt;();</span>
<span class="source-line-no">097</span><span id="line-97"></span>
<span class="source-line-no">098</span><span id="line-98"> /**</span>
<span class="source-line-no">099</span><span id="line-99"> * Mock {@link RSGroupBasedLoadBalancer#balanceCluster} to return the {@link RegionPlan} to move</span>
<span class="source-line-no">100</span><span id="line-100"> * the only region to the other RegionServer.</span>
<span class="source-line-no">101</span><span id="line-101"> */</span>
<span class="source-line-no">102</span><span id="line-102"> Mockito.doAnswer((InvocationOnMock invocation) -&gt; {</span>
<span class="source-line-no">103</span><span id="line-103"> @SuppressWarnings("unchecked")</span>
<span class="source-line-no">104</span><span id="line-104"> Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; tableNameToRegionServerNameToRegionInfos =</span>
<span class="source-line-no">105</span><span id="line-105"> (Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt;) invocation.getArgument(0);</span>
<span class="source-line-no">106</span><span id="line-106"> Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; regionServerNameToRegionInfos =</span>
<span class="source-line-no">107</span><span id="line-107"> tableNameToRegionServerNameToRegionInfos.get(tableName);</span>
<span class="source-line-no">108</span><span id="line-108"> assertTrue(regionServerNameToRegionInfos.size() == 2);</span>
<span class="source-line-no">109</span><span id="line-109"> List&lt;ServerName&gt; assignedRegionServerNames = new ArrayList&lt;ServerName&gt;();</span>
<span class="source-line-no">110</span><span id="line-110"> for (Map.Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt; entry : regionServerNameToRegionInfos</span>
<span class="source-line-no">111</span><span id="line-111"> .entrySet()) {</span>
<span class="source-line-no">112</span><span id="line-112"> if (entry.getValue().size() &gt; 0) {</span>
<span class="source-line-no">113</span><span id="line-113"> assignedRegionServerNames.add(entry.getKey());</span>
<span class="source-line-no">114</span><span id="line-114"> }</span>
<span class="source-line-no">115</span><span id="line-115"> }</span>
<span class="source-line-no">116</span><span id="line-116"> assertTrue(assignedRegionServerNames.size() == 1);</span>
<span class="source-line-no">117</span><span id="line-117"> ServerName assignedRegionServerName = assignedRegionServerNames.get(0);</span>
<span class="source-line-no">118</span><span id="line-118"> ServerName notAssignedRegionServerName =</span>
<span class="source-line-no">119</span><span id="line-119"> assignedRegionServerName.equals(serverName1) ? serverName2 : serverName1;</span>
<span class="source-line-no">120</span><span id="line-120"> RegionPlan regionPlan =</span>
<span class="source-line-no">121</span><span id="line-121"> new RegionPlan(regionInfo, assignedRegionServerName, notAssignedRegionServerName);</span>
<span class="source-line-no">122</span><span id="line-122"> regionPlanRef.set(regionPlan);</span>
<span class="source-line-no">123</span><span id="line-123"> return Arrays.asList(regionPlan);</span>
<span class="source-line-no">124</span><span id="line-124"> }).when(spiedLoadBalancer).balanceCluster(Mockito.anyMap());</span>
<span class="source-line-no">125</span><span id="line-125"></span>
<span class="source-line-no">126</span><span id="line-126"> AssignmentManager assignmentManager = master.getAssignmentManager();</span>
<span class="source-line-no">127</span><span id="line-127"> final AssignmentManager spiedAssignmentManager = Mockito.spy(assignmentManager);</span>
<span class="source-line-no">128</span><span id="line-128"> final CyclicBarrier cyclicBarrier = new CyclicBarrier(2);</span>
<span class="source-line-no">129</span><span id="line-129"></span>
<span class="source-line-no">130</span><span id="line-130"> /**</span>
<span class="source-line-no">131</span><span id="line-131"> * Override {@link AssignmentManager#balance} to invoke real {@link AssignmentManager#balance}</span>
<span class="source-line-no">132</span><span id="line-132"> * after the region is successfully unassigned.</span>
<span class="source-line-no">133</span><span id="line-133"> */</span>
<span class="source-line-no">134</span><span id="line-134"> Mockito.doAnswer((InvocationOnMock invocation) -&gt; {</span>
<span class="source-line-no">135</span><span id="line-135"> RegionPlan regionPlan = invocation.getArgument(0);</span>
<span class="source-line-no">136</span><span id="line-136"> RegionPlan referedRegionPlan = regionPlanRef.get();</span>
<span class="source-line-no">137</span><span id="line-137"> assertTrue(referedRegionPlan != null);</span>
<span class="source-line-no">138</span><span id="line-138"> if (referedRegionPlan.equals(regionPlan)) {</span>
<span class="source-line-no">139</span><span id="line-139"> /**</span>
<span class="source-line-no">140</span><span id="line-140"> * To make {@link AssignmentManager#unassign} could be invoked just before</span>
<span class="source-line-no">141</span><span id="line-141"> * {@link AssignmentManager#balance} is invoked.</span>
<span class="source-line-no">142</span><span id="line-142"> */</span>
<span class="source-line-no">143</span><span id="line-143"> cyclicBarrier.await();</span>
<span class="source-line-no">144</span><span id="line-144"> /**</span>
<span class="source-line-no">145</span><span id="line-145"> * After {@link AssignmentManager#unassign} is completed,we could invoke</span>
<span class="source-line-no">146</span><span id="line-146"> * {@link AssignmentManager#balance}.</span>
<span class="source-line-no">147</span><span id="line-147"> */</span>
<span class="source-line-no">148</span><span id="line-148"> cyclicBarrier.await();</span>
<span class="source-line-no">149</span><span id="line-149"> }</span>
<span class="source-line-no">150</span><span id="line-150"> /**</span>
<span class="source-line-no">151</span><span id="line-151"> * Before HBASE-26712,here may throw NPE.</span>
<span class="source-line-no">152</span><span id="line-152"> */</span>
<span class="source-line-no">153</span><span id="line-153"> return invocation.callRealMethod();</span>
<span class="source-line-no">154</span><span id="line-154"> }).when(spiedAssignmentManager).balance(Mockito.any());</span>
<span class="source-line-no">155</span><span id="line-155"></span>
<span class="source-line-no">156</span><span id="line-156"> try {</span>
<span class="source-line-no">157</span><span id="line-157"> final AtomicReference&lt;Throwable&gt; exceptionRef = new AtomicReference&lt;Throwable&gt;(null);</span>
<span class="source-line-no">158</span><span id="line-158"> Thread unassignThread = new Thread(() -&gt; {</span>
<span class="source-line-no">159</span><span id="line-159"> try {</span>
<span class="source-line-no">160</span><span id="line-160"> /**</span>
<span class="source-line-no">161</span><span id="line-161"> * To invoke {@link AssignmentManager#unassign} just before</span>
<span class="source-line-no">162</span><span id="line-162"> * {@link AssignmentManager#balance} is invoked.</span>
<span class="source-line-no">163</span><span id="line-163"> */</span>
<span class="source-line-no">164</span><span id="line-164"> cyclicBarrier.await();</span>
<span class="source-line-no">165</span><span id="line-165"> spiedAssignmentManager.unassign(regionInfo);</span>
<span class="source-line-no">166</span><span id="line-166"> assertTrue(spiedAssignmentManager.getRegionStates().getRegionAssignments().get(regionInfo)</span>
<span class="source-line-no">167</span><span id="line-167"> == null);</span>
<span class="source-line-no">168</span><span id="line-168"> /**</span>
<span class="source-line-no">169</span><span id="line-169"> * After {@link AssignmentManager#unassign} is completed,we could invoke</span>
<span class="source-line-no">170</span><span id="line-170"> * {@link AssignmentManager#balance}.</span>
<span class="source-line-no">171</span><span id="line-171"> */</span>
<span class="source-line-no">172</span><span id="line-172"> cyclicBarrier.await();</span>
<span class="source-line-no">173</span><span id="line-173"> } catch (Exception e) {</span>
<span class="source-line-no">174</span><span id="line-174"> exceptionRef.set(e);</span>
<span class="source-line-no">175</span><span id="line-175"> }</span>
<span class="source-line-no">176</span><span id="line-176"> });</span>
<span class="source-line-no">177</span><span id="line-177"> unassignThread.setName("UnassignThread");</span>
<span class="source-line-no">178</span><span id="line-178"> unassignThread.start();</span>
<span class="source-line-no">179</span><span id="line-179"></span>
<span class="source-line-no">180</span><span id="line-180"> master.setLoadBalancer(spiedLoadBalancer);</span>
<span class="source-line-no">181</span><span id="line-181"> master.setAssignmentManager(spiedAssignmentManager);</span>
<span class="source-line-no">182</span><span id="line-182"> /**</span>
<span class="source-line-no">183</span><span id="line-183"> * enable balance</span>
<span class="source-line-no">184</span><span id="line-184"> */</span>
<span class="source-line-no">185</span><span id="line-185"> TEST_UTIL.getAdmin().balancerSwitch(true, false);</span>
<span class="source-line-no">186</span><span id="line-186"> /**</span>
<span class="source-line-no">187</span><span id="line-187"> * Before HBASE-26712,here invokes {@link AssignmentManager#balance(RegionPlan)} which may</span>
<span class="source-line-no">188</span><span id="line-188"> * throw NPE.</span>
<span class="source-line-no">189</span><span id="line-189"> */</span>
<span class="source-line-no">190</span><span id="line-190"> master.balanceOrUpdateMetrics();</span>
<span class="source-line-no">191</span><span id="line-191"></span>
<span class="source-line-no">192</span><span id="line-192"> unassignThread.join();</span>
<span class="source-line-no">193</span><span id="line-193"> assertTrue(exceptionRef.get() == null);</span>
<span class="source-line-no">194</span><span id="line-194"> } finally {</span>
<span class="source-line-no">195</span><span id="line-195"> master.setLoadBalancer(loadBalancer);</span>
<span class="source-line-no">196</span><span id="line-196"> master.setAssignmentManager(assignmentManager);</span>
<span class="source-line-no">197</span><span id="line-197"> }</span>
<span class="source-line-no">198</span><span id="line-198"> }</span>
<span class="source-line-no">199</span><span id="line-199"></span>
<span class="source-line-no">200</span><span id="line-200"> private TableName createTable(String table) throws IOException {</span>
<span class="source-line-no">201</span><span id="line-201"> TableName tableName = TableName.valueOf(table);</span>
<span class="source-line-no">202</span><span id="line-202"> TEST_UTIL.createTable(tableName, FAMILYNAME);</span>
<span class="source-line-no">203</span><span id="line-203"> return tableName;</span>
<span class="source-line-no">204</span><span id="line-204"> }</span>
<span class="source-line-no">205</span><span id="line-205"></span>
<span class="source-line-no">206</span><span id="line-206">}</span>
</pre>
</div>
</main>
</body>
</html>