HBASE-25794: Fix checkstyle violations in hbase-table-reporter module (#85)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
diff --git a/hbase-table-reporter/src/main/java/org/apache/hbase/reporter/TableReporter.java b/hbase-table-reporter/src/main/java/org/apache/hbase/reporter/TableReporter.java
index d33d7b2..a7b3fd2 100644
--- a/hbase-table-reporter/src/main/java/org/apache/hbase/reporter/TableReporter.java
+++ b/hbase-table-reporter/src/main/java/org/apache/hbase/reporter/TableReporter.java
@@ -17,27 +17,6 @@
*/
package org.apache.hbase.reporter;
-import org.apache.commons.cli.Options;
-import org.apache.commons.cli.ParseException;
-import org.apache.commons.cli.Option;
-import org.apache.commons.cli.CommandLineParser;
-import org.apache.commons.cli.CommandLine;
-import org.apache.commons.cli.DefaultParser;
-import org.apache.datasketches.quantiles.DoublesSketch;
-import org.apache.datasketches.quantiles.DoublesUnion;
-import org.apache.datasketches.quantiles.UpdateDoublesSketch;
-import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.hbase.Cell;
-import org.apache.hadoop.hbase.ExtendedCell;
-import org.apache.hadoop.hbase.HBaseConfiguration;
-import org.apache.hadoop.hbase.HBaseIOException;
-import org.apache.hadoop.hbase.HRegionInfo;
-import org.apache.hadoop.hbase.KeyValue;
-import org.apache.hadoop.hbase.TableName;
-import org.apache.hadoop.hbase.client.*;
-import org.apache.hadoop.hbase.io.HeapSize;
-import org.apache.hadoop.hbase.util.Bytes;
-
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileWriter;
@@ -58,14 +37,44 @@
import java.util.stream.Collectors;
import java.util.stream.DoubleStream;
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.CommandLineParser;
+import org.apache.commons.cli.DefaultParser;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import org.apache.commons.cli.ParseException;
+import org.apache.datasketches.quantiles.DoublesSketch;
+import org.apache.datasketches.quantiles.DoublesUnion;
+import org.apache.datasketches.quantiles.UpdateDoublesSketch;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.ExtendedCell;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.KeyValue;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.io.HeapSize;
+import org.apache.hadoop.hbase.util.Bytes;
+
/**
* Run a scan against a table reporting on row size, column size and count.
*
* So can run against cdh5, uses loads of deprecated API and copies some Cell sizing methods local.
*/
-public class TableReporter {
+public final class TableReporter {
private static String GNUPLOT_DATA_SUFFIX = ".gnuplotdata";
+ private TableReporter(){
+ }
+
/**
* Quantile sketches. Has a print that dumps out sketches on stdout.
* To accumlate Sketches instances, see {@link AccumlatingSketch}
@@ -91,7 +100,8 @@
/**
* Bins that sort of make sense for the data we're seeing here. After some trial and error.
*/
- static double [] BINS = new double [] {1, 5, 10, 15, 20, 25, 100, 1024, 5120, 10240, 20480, 51200, 102400, 1048576};
+ static double [] BINS = new double [] {1, 5, 10, 15, 20, 25, 100, 1024, 5120,
+ 10240, 20480, 51200, 102400, 1048576};
/**
* Size of row.
@@ -123,14 +133,15 @@
}
private static void print(String label, final DoublesSketch sketch) {
- System.out.println(label + " quantiles " + Arrays.toString(sketch.getQuantiles(NORMALIZED_RANKS)));
+ System.out.println(label + " quantiles " +
+ Arrays.toString(sketch.getQuantiles(NORMALIZED_RANKS)));
double [] pmfs = sketch.getPMF(BINS);
// System.out.println(label + " pmfs " + Arrays.toString(pmfs));
System.out.println(label + " histo " +
(pmfs == null || pmfs.length == 0?
"null": Arrays.toString(Arrays.stream(pmfs).map(d -> d * sketch.getN()).toArray())));
- System.out.println(label + "stats N=" + sketch.getN() + ", min=" + sketch.getMinValue() + ", max=" +
- sketch.getMaxValue());
+ System.out.println(label + "stats N=" + sketch.getN() + ", min=" + sketch.getMinValue() +
+ ", max=" + sketch.getMaxValue());
}
}
@@ -171,7 +182,8 @@
* @return First <code>fraction</code> of Table's regions.
*/
private static List<RegionInfo> getRegions(Connection connection, TableName tableName,
- double fraction, String encodedRegionName) throws IOException {
+ double fraction, String encodedRegionName)
+ throws IOException {
try (Admin admin = connection.getAdmin()) {
// Use deprecated API because running against old hbase.
List<RegionInfo> regions = admin.getRegions(tableName);
@@ -244,7 +256,7 @@
private static void sketch(Configuration configuration, String tableNameAsStr, int limit,
double fraction, int threads, String isoNow, String encodedRegionName)
- throws IOException, InterruptedException, ExecutionException {
+ throws IOException, InterruptedException, ExecutionException {
TableName tableName = TableName.valueOf(tableNameAsStr);
AccumlatingSketch totalSketches = new AccumlatingSketch();
long startTime = System.currentTimeMillis();
@@ -272,12 +284,13 @@
}
});
try {
- List<SketchRegion> srs = regions.stream().map(ri -> new SketchRegion(connection, tableName, ri, limit)).
- collect(Collectors.toList());
+ List<SketchRegion> srs = regions.stream().
+ map(ri -> new SketchRegion(connection, tableName, ri, limit)).
+ collect(Collectors.toList());
List<Future<SketchRegion>> futures = new ArrayList<>(srs.size());
for (SketchRegion sr: srs) {
- // Do submit rather than inokeall; invokeall blocks until all done. This way I get control back
- // after all submitted.
+ // Do submit rather than inokeall; invokeall blocks until all done.
+ // This way I get control back after all submitted.
futures.add(es.submit(sr));
}
// Avoid java.util.ConcurrentModificationException
@@ -305,8 +318,9 @@
}
Sketches sketches = totalSketches.get();
String isoDuration = Duration.ofMillis(System.currentTimeMillis() - startTime).toString();
- sketches.print(Instant.now().toString() + " Totals for " + tableNameAsStr + " regions=" + count +
- ", limit=" + limit + ", fraction=" + fraction + ", took=" + isoDuration);
+ sketches.print(Instant.now().toString() + " Totals for " + tableNameAsStr +
+ " regions=" + count + ", limit=" + limit + ", fraction=" + fraction +
+ ", took=" + isoDuration);
// Dump out the gnuplot files. Saves time generating graphs.
dumpGnuplotDataFiles(isoNow, sketches, tableNameAsStr, count, isoDuration);
}
@@ -367,13 +381,14 @@
return "reporter." + isoNow + "." + tableName + "." + sketchName;
}
- private static String getFileFirstLine(String tableName, int regions, String isoDuration, UpdateDoublesSketch sketch) {
- return "# " + tableName + " regions=" + regions + ", duration=" + isoDuration + ", N=" + sketch.getN() +
- ", min=" + sketch.getMinValue() + ", max=" + sketch.getMaxValue();
+ private static String getFileFirstLine(String tableName, int regions,
+ String isoDuration, UpdateDoublesSketch sketch) {
+ return "# " + tableName + " regions=" + regions + ", duration=" + isoDuration + ", N=" +
+ sketch.getN() + ", min=" + sketch.getMinValue() + ", max=" + sketch.getMaxValue();
}
- private static void dumpPercentilesFile(String prefix, String firstLine, UpdateDoublesSketch sketch)
- throws IOException {
+ private static void dumpPercentilesFile(String prefix, String firstLine,
+ UpdateDoublesSketch sketch) throws IOException {
dumpFile(File.createTempFile(prefix + ".percentiles.", GNUPLOT_DATA_SUFFIX),
firstLine, sketch.getQuantiles(Sketches.NORMALIZED_RANKS));
}
@@ -398,17 +413,19 @@
System.out.println(Instant.now().toString() + " wrote " + file.toString());
}
- private static void dumpFiles(String prefix, String firstLine, UpdateDoublesSketch sketch) throws IOException {
+ private static void dumpFiles(String prefix, String firstLine, UpdateDoublesSketch sketch)
+ throws IOException {
dumpPercentilesFile(prefix, firstLine, sketch);
dumpHistogramFile(prefix, firstLine, sketch);
}
/**
- * Write four files, a histogram and percentiles, one each for each of the row size and column count sketches.
+ * Write four files, a histogram and percentiles,
+ * one each for each of the row size and column count sketches.
* Tie the four files with isoNow time.
*/
- private static void dumpGnuplotDataFiles(String isoNow, Sketches sketches, String tableName, int regions,
- String isoDuration) throws IOException {
+ private static void dumpGnuplotDataFiles(String isoNow, Sketches sketches, String tableName,
+ int regions, String isoDuration) throws IOException {
UpdateDoublesSketch sketch = sketches.columnCountSketch;
dumpFiles(getFileNamePrefix(isoNow, tableName, "columnCount"),
getFileFirstLine(tableName, regions, isoDuration, sketch), sketch);
@@ -434,15 +451,17 @@
System.out.println("OPTIONS:");
System.out.println(" -h,--help Output this help message");
System.out.println(" -l,--limit Scan row limit (per thread): default none");
- System.out.println(" -f,--fraction Fraction of table Regions to read; between 0 and 1: default 1.0 (all)");
- System.out.println(" -r,--region Scan this Region only; pass encoded name; 'fraction' is ignored.");
+ System.out.println(" -f,--fraction " +
+ "Fraction of table Regions to read; between 0 and 1: default 1.0 (all)");
+ System.out.println(" -r,--region " +
+ "Scan this Region only; pass encoded name; 'fraction' is ignored.");
System.out.println(" -t,--threads Concurrent thread count (thread per Region); default 1");
System.out.println(" -Dproperty=value Properties such as the zookeeper to connect to; e.g:");
System.out.println(" -Dhbase.zookeeper.quorum=ZK0.remote.cluster.example.org");
}
public static void main(String [] args)
- throws ParseException, IOException, ExecutionException, InterruptedException {
+ throws ParseException, IOException, ExecutionException, InterruptedException {
Options options = new Options();
Option help = Option.builder("h").longOpt("help").
desc("output this help message").build();
diff --git a/hbase-table-reporter/src/test/java/org/apache/hbase/reporter/TestTableReporter.java b/hbase-table-reporter/src/test/java/org/apache/hbase/reporter/TestTableReporter.java
index 16e46c8..34bf121 100644
--- a/hbase-table-reporter/src/test/java/org/apache/hbase/reporter/TestTableReporter.java
+++ b/hbase-table-reporter/src/test/java/org/apache/hbase/reporter/TestTableReporter.java
@@ -17,6 +17,11 @@
*/
package org.apache.hbase.reporter;
+import static org.apache.hadoop.hbase.shaded.junit.framework.TestCase.assertEquals;
+
+import java.util.ArrayList;
+import java.util.List;
+
import org.apache.hadoop.hbase.Cell;
import org.apache.hadoop.hbase.CellBuilderFactory;
import org.apache.hadoop.hbase.CellBuilderType;
@@ -24,11 +29,6 @@
import org.apache.hadoop.hbase.util.Bytes;
import org.junit.Test;
-import java.util.ArrayList;
-import java.util.List;
-
-import static org.apache.hadoop.hbase.shaded.junit.framework.TestCase.assertEquals;
-
public class TestTableReporter {
private static final byte [] CF = Bytes.toBytes("cf");
private static final byte [] Q = Bytes.toBytes("q");
@@ -56,7 +56,8 @@
final int columns = 3;
final int versions = 2;
for (int i = 0; i < rows; i++) {
- TableReporter.processRowResult(Result.create(makeCells(Bytes.toBytes(i), columns, versions)), sketches);
+ TableReporter.processRowResult(Result.create(makeCells(Bytes.toBytes(i),
+ columns, versions)), sketches);
}
sketches.print();
// Just check the column counts. Should be 2.
@@ -72,12 +73,14 @@
final int columns = 3;
final int versions = 2;
for (int i = 0; i < rows; i++) {
- TableReporter.processRowResult(Result.create(makeCells(Bytes.toBytes(i), columns, versions)), sketches);
+ TableReporter.processRowResult(Result.create(makeCells(Bytes.toBytes(i),
+ columns, versions)), sketches);
}
sketches.print();
TableReporter.Sketches sketches2 = new TableReporter.Sketches();
for (int i = 0; i < rows; i++) {
- TableReporter.processRowResult(Result.create(makeCells(Bytes.toBytes(i), columns, versions)), sketches2);
+ TableReporter.processRowResult(Result.create(makeCells(Bytes.toBytes(i),
+ columns, versions)), sketches2);
}
sketches2.print();
TableReporter.AccumlatingSketch accumlator = new TableReporter.AccumlatingSketch();
