| /** |
| * Licensed to the Apache Software Foundation (ASF) under one |
| * or more contributor license agreements. See the NOTICE file |
| * distributed with this work for additional information |
| * regarding copyright ownership. The ASF licenses this file |
| * to you under the Apache License, Version 2.0 (the |
| * "License"); you may not use this file except in compliance |
| * with the License. You may obtain a copy of the License at |
| * |
| * http://www.apache.org/licenses/LICENSE-2.0 |
| * |
| * Unless required by applicable law or agreed to in writing, software |
| * distributed under the License is distributed on an "AS IS" BASIS, |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| * See the License for the specific language governing permissions and |
| * limitations under the License. |
| */ |
| package org.apache.hadoop.hdfs; |
| |
| import junit.framework.TestCase; |
| import java.io.*; |
| import org.apache.hadoop.conf.Configuration; |
| import org.apache.hadoop.fs.FileSystem; |
| import org.apache.hadoop.fs.ParentNotDirectoryException; |
| import org.apache.hadoop.fs.Path; |
| import org.apache.hadoop.fs.permission.FsPermission; |
| |
| |
| /** |
| * This class tests that the DFS command mkdirs cannot create subdirectories |
| * from a file when passed an illegal path. HADOOP-281. |
| */ |
| public class TestDFSMkdirs extends TestCase { |
| |
| private void writeFile(FileSystem fileSys, Path name) throws IOException { |
| DataOutputStream stm = fileSys.create(name); |
| stm.writeBytes("wchien"); |
| stm.close(); |
| } |
| |
| /** |
| * Tests mkdirs can create a directory that does not exist and will |
| * not create a subdirectory off a file. |
| */ |
| public void testDFSMkdirs() throws IOException { |
| Configuration conf = new HdfsConfiguration(); |
| MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf).numDataNodes(2).build(); |
| FileSystem fileSys = cluster.getFileSystem(); |
| try { |
| // First create a new directory with mkdirs |
| Path myPath = new Path("/test/mkdirs"); |
| assertTrue(fileSys.mkdirs(myPath)); |
| assertTrue(fileSys.exists(myPath)); |
| assertTrue(fileSys.mkdirs(myPath)); |
| |
| // Second, create a file in that directory. |
| Path myFile = new Path("/test/mkdirs/myFile"); |
| writeFile(fileSys, myFile); |
| |
| // Third, use mkdir to create a subdirectory off of that file, |
| // and check that it fails. |
| Path myIllegalPath = new Path("/test/mkdirs/myFile/subdir"); |
| Boolean exist = true; |
| try { |
| fileSys.mkdirs(myIllegalPath); |
| } catch (IOException e) { |
| exist = false; |
| } |
| assertFalse(exist); |
| assertFalse(fileSys.exists(myIllegalPath)); |
| fileSys.delete(myFile, true); |
| |
| } finally { |
| fileSys.close(); |
| cluster.shutdown(); |
| } |
| } |
| |
| /** |
| * Tests mkdir will not create directory when parent is missing. |
| */ |
| public void testMkdir() throws IOException { |
| Configuration conf = new HdfsConfiguration(); |
| MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf).numDataNodes(2).build(); |
| DistributedFileSystem dfs = (DistributedFileSystem) cluster.getFileSystem(); |
| try { |
| // Create a dir in root dir, should succeed |
| assertTrue(dfs.mkdir(new Path("/mkdir-" + System.currentTimeMillis()), |
| FsPermission.getDefault())); |
| // Create a dir when parent dir exists as a file, should fail |
| IOException expectedException = null; |
| String filePath = "/mkdir-file-" + System.currentTimeMillis(); |
| writeFile(dfs, new Path(filePath)); |
| try { |
| dfs.mkdir(new Path(filePath + "/mkdir"), FsPermission.getDefault()); |
| } catch (IOException e) { |
| expectedException = e; |
| } |
| assertTrue("Create a directory when parent dir exists as file using" |
| + " mkdir() should throw ParentNotDirectoryException ", |
| expectedException != null |
| && expectedException instanceof ParentNotDirectoryException); |
| // Create a dir in a non-exist directory, should fail |
| expectedException = null; |
| try { |
| dfs.mkdir(new Path("/non-exist/mkdir-" + System.currentTimeMillis()), |
| FsPermission.getDefault()); |
| } catch (IOException e) { |
| expectedException = e; |
| } |
| assertTrue("Create a directory in a non-exist parent dir using" |
| + " mkdir() should throw FileNotFoundException ", |
| expectedException != null |
| && expectedException instanceof FileNotFoundException); |
| } finally { |
| dfs.close(); |
| cluster.shutdown(); |
| } |
| } |
| } |