commit 8668abf87e499bf6347fd624ae149341878537d4
author Gautham B A <gautham.bangalore@gmail.com> Wed Mar 31 02:05:45 2021 +0530
committer GitHub <noreply@github.com> Tue Mar 30 13:35:45 2021 -0700
tree 4edd37da37ee63ca89ee7a570adaf7ab6dbf253f
parent 50b1e1c0c4c9368c2419a33e38b67ba433b50206

HDFS-15927. Catch polymorphic type by reference (#2824)

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/hdfs_configuration.cc

diff --git a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/hdfs_configuration.cc b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/hdfs_configuration.cc
index 07e2edc..7b1496c 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/hdfs_configuration.cc
+++ b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/hdfs_configuration.cc
@@ -135,7 +135,7 @@
       URI uri;
       try {
         uri = URI::parse_from_string(PrependHdfsScheme(Get(dom_node_name)));
-      } catch (const uri_parse_error) {
+      } catch (const uri_parse_error&) {
         throw ha_parse_error("unable to find " + dom_node_name);
       }
 
@@ -148,7 +148,7 @@
       NamenodeInfo node(nameservice, *node_id, uri);
       namenodes.push_back(node);
     }
-  } catch (ha_parse_error e) {
+  } catch (const ha_parse_error& e) {
     LOG_ERROR(kRPC, << "HA cluster detected but failed because : " << e.what());
     namenodes.clear(); // Don't return inconsistent view
   }