HADOOP-9686. Easy access to final parameters in Configuration (Jason Lowe via jeagles)
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2.1.0-beta@1515987 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt
index 4a2798f..b1d3bef 100644
--- a/hadoop-common-project/hadoop-common/CHANGES.txt
+++ b/hadoop-common-project/hadoop-common/CHANGES.txt
@@ -1676,6 +1676,9 @@
IMPROVEMENTS
+ HADOOP-9686. Easy access to final parameters in Configuration (Jason Lowe
+ via jeagles)
+
OPTIMIZATIONS
BUG FIXES
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
index 9c8285a..84da26f 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
@@ -1903,6 +1903,15 @@
}
}
+ /**
+ * Get the set of parameters marked final.
+ *
+ * @return final parameter set.
+ */
+ public Set<String> getFinalParameters() {
+ return new HashSet<String>(finalParameters);
+ }
+
protected synchronized Properties getProps() {
if (properties == null) {
properties = new Properties();
diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
index 2cbb27f..0510e6b 100644
--- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
+++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
@@ -1136,7 +1136,23 @@
Class<?> clazz = config.getClassByNameOrNull("java.lang.Object");
assertNotNull(clazz);
}
-
+
+ public void testGetFinalParameters() throws Exception {
+ out=new BufferedWriter(new FileWriter(CONFIG));
+ startConfig();
+ declareProperty("my.var", "x", "x", true);
+ endConfig();
+ Path fileResource = new Path(CONFIG);
+ Configuration conf = new Configuration();
+ Set<String> finalParameters = conf.getFinalParameters();
+ assertFalse("my.var already exists", finalParameters.contains("my.var"));
+ conf.addResource(fileResource);
+ assertEquals("my.var is undefined", "x", conf.get("my.var"));
+ assertFalse("finalparams not copied", finalParameters.contains("my.var"));
+ finalParameters = conf.getFinalParameters();
+ assertTrue("my.var is not final", finalParameters.contains("my.var"));
+ }
+
public static void main(String[] argv) throws Exception {
junit.textui.TestRunner.main(new String[]{
TestConfiguration.class.getName()
