GUACAMOLE-1174: Correct logic detecting truncation of appended parameter.
The previous implementation passed `length - str_len` to `snprintf()`,
yet compared the return value to `length`. This is incorrect, as
`length` is not the buffer size provided to `snprintf()`.
diff --git a/src/protocols/kubernetes/url.c b/src/protocols/kubernetes/url.c
index 4bca015..ec0e880 100644
--- a/src/protocols/kubernetes/url.c
+++ b/src/protocols/kubernetes/url.c
@@ -123,10 +123,14 @@
char delimiter = '?';
if (qmark) delimiter = '&';
- /* Write the parameter to the buffer */
- int written;
- written = snprintf(buffer + str_len, length - str_len,
- "%c%s=%s", delimiter, param_name, escaped_param_value);
+ /* Advance to end of buffer, where the new parameter and delimiter need to
+ * be appended */
+ buffer += str_len;
+ length -= str_len;
+
+ /* Write the parameter and delimiter to the buffer */
+ int written = snprintf(buffer, length, "%c%s=%s", delimiter,
+ param_name, escaped_param_value);
/* The parameter was successfully added if it was written to the given
* buffer without truncation */
