commit 6d610ba519a289243d163b91f39793d8220dd342
author Daniel Sun <sunlan@apache.org> Sun Jul 12 14:55:29 2020 +0800
committer Daniel Sun <sunlan@apache.org> Sun Jul 12 14:55:29 2020 +0800
tree 2e18c9d9b975dbc7a68c829fbc01ea6e4c981764
parent 78091c3058b79ba6e674201b31cd9fb1e056f4ac

Trivial tweak: reduce method calls of `charAt`

src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java

diff --git a/src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java b/src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java
index 190462c..787009f 100644
--- a/src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java
+++ b/src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java
@@ -86,17 +86,17 @@
         if (nameLength > 2) {
             switch (name.charAt(0)) {
                 case 'g':
-                    if (nameLength > 3 && name.charAt(1) == 'e' && name.charAt(2) == 't' && mNode.getParameters().length == 0 && !mNode.getReturnType().equals(ClassHelper.VOID_TYPE)) {
+                    if (nameLength > 3 && mNode.getParameters().length == 0  && name.charAt(1) == 'e' && name.charAt(2) == 't' && !mNode.getReturnType().equals(ClassHelper.VOID_TYPE)) {
                         return decapitalize(name.substring(3));
                     }
                     break;
                 case 's':
-                    if (nameLength > 3 && name.charAt(1) == 'e' && name.charAt(2) == 't' && mNode.getParameters().length == 1 /*&& mNode.getReturnType().equals(ClassHelper.VOID_TYPE)*/) {
+                    if (nameLength > 3 && mNode.getParameters().length == 1 && name.charAt(1) == 'e' && name.charAt(2) == 't'  /*&& mNode.getReturnType().equals(ClassHelper.VOID_TYPE)*/) {
                         return decapitalize(name.substring(3));
                     }
                     break;
                 case 'i':
-                    if (name.charAt(1) == 's' && mNode.getParameters().length == 0 && (mNode.getReturnType().equals(ClassHelper.boolean_TYPE) /*|| mNode.getReturnType().equals(ClassHelper.Boolean_TYPE)*/)) {
+                    if (mNode.getParameters().length == 0 && name.charAt(1) == 's' && (mNode.getReturnType().equals(ClassHelper.boolean_TYPE) /*|| mNode.getReturnType().equals(ClassHelper.Boolean_TYPE)*/)) {
                         return decapitalize(name.substring(2));
                     }
                     break;