commit 6d2ead23fa859e073786fcc6186a6bf832d58d37
author Anthony Hsu <ahsu@linkedin.com> Fri Aug 03 12:09:24 2018 -0700
committer Hung Tran <hutran@linkedin.com> Tue Aug 07 15:35:32 2018 -0700
tree 73d89132c6f9cbe8f96eca974d483a796de497c8
parent de9f9d5654b81dc05e9c01aa1c540c8e30e174ef

[GOBBLIN-556] Gobblin AvroUtils reads and writes UTF rather than chars[]

Closes #2417 from erwa/gobblin-556-read-write-utf

gobblin-data-management/src/test/java/org/apache/gobblin/data/management/conversion/hive/avro/AvroSchemaManagerTest.java

diff --git a/gobblin-data-management/src/test/java/org/apache/gobblin/data/management/conversion/hive/avro/AvroSchemaManagerTest.java b/gobblin-data-management/src/test/java/org/apache/gobblin/data/management/conversion/hive/avro/AvroSchemaManagerTest.java
index eeba93e..fa2a296 100644
--- a/gobblin-data-management/src/test/java/org/apache/gobblin/data/management/conversion/hive/avro/AvroSchemaManagerTest.java
+++ b/gobblin-data-management/src/test/java/org/apache/gobblin/data/management/conversion/hive/avro/AvroSchemaManagerTest.java
@@ -61,23 +61,6 @@
     Assert.assertEquals(actualSchema.toString(), expectedSchema);
   }
 
-  @Test(expectedExceptions = SchemaParseException.class)
-  public void testExceptionWhenReadingSchemaUsingParser()
-      throws IOException, HiveException {
-    FileSystem fs = FileSystem.getLocal(new Configuration());
-
-    String jobId = "123";
-    State state = new State();
-    state.setProp(ConfigurationKeys.JOB_ID_KEY, jobId);
-
-    AvroSchemaManager asm = new AvroSchemaManager(fs, state);
-    Partition partition = getTestPartition(new Table("testDb", "testTable"));
-    Path schemaPath = asm.getSchemaUrl(partition);
-    // parse operation tries to read using UTF-8 encoding and fails
-    // because schema is written using modified UTF-8 encoding
-    new Schema.Parser().parse(fs.open(schemaPath));
-  }
-
   private Partition getTestPartition(Table table) throws HiveException {
     Partition partition = new Partition(table, ImmutableMap.of("partition_key", "1"), null);
     StorageDescriptor sd = new StorageDescriptor();

gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java

diff --git a/gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java b/gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java
index 7d7e497..52de135 100644
--- a/gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java
+++ b/gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java
@@ -381,7 +381,7 @@
     Preconditions.checkArgument(fs.exists(filePath), filePath + " does not exist");
 
     try (FSDataInputStream in = fs.open(filePath)) {
-      return new Schema.Parser().parse(in.readUTF());
+      return new Schema.Parser().parse(in);
     }
   }
 
@@ -399,7 +399,7 @@
     }
 
     try (DataOutputStream dos = fs.create(filePath)) {
-      dos.writeUTF(schema.toString());
+      dos.writeChars(schema.toString());
     }
     fs.setPermission(filePath, perm);
   }