commit 08e4e9acedf0aa157c79ff06feda364b443359e2
author John Hutchison <jhutchison@gmail.com> Thu Oct 22 10:45:17 2020 -0400
committer GitHub <noreply@github.com> Thu Oct 22 07:45:17 2020 -0700
tree fc0f5f6c1a8e4bef9c45b1566b9fa04074714b71
parent 99f51c37211e657ee3bd17b4fec3eeadf2537974

GEODE-8636: Remove hard-coded value from String in NettyRedisServer (#5621)

Authored-by: john Hutchison <hutchisonjo@vmware.com>

geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java

diff --git a/geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java b/geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
index adea25f..f93de64 100644
--- a/geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
+++ b/geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
@@ -98,12 +98,16 @@
     this.shutdownInvoker = shutdownInvoker;
     this.redisStats = redisStats;
     this.backgroundExecutor = backgroundExecutor;
+
     if (port < RANDOM_PORT_INDICATOR) {
-      throw new IllegalArgumentException("Redis port cannot be less than 0");
+      throw new IllegalArgumentException(
+          "Redis port cannot be less than " + RANDOM_PORT_INDICATOR);
     }
+
     selectorGroup = createEventLoopGroup("Selector", true, 1);
     workerGroup = createEventLoopGroup("Worker", true, 0);
     subscriberGroup = createEventLoopGroup("Subscriber", true, 0);
+
     try {
       this.bindAddress = getBindAddress(requestedAddress);
       serverChannel = createChannel(port);
@@ -116,15 +120,16 @@
   }
 
   private Channel createChannel(int port) {
-    ServerBootstrap serverBootstrap = new ServerBootstrap();
-
-    serverBootstrap.group(selectorGroup, workerGroup).channel(NioServerSocketChannel.class)
-        .childHandler(createChannelInitializer())
-        .option(ChannelOption.SO_REUSEADDR, true)
-        .option(ChannelOption.SO_RCVBUF, getBufferSize())
-        .childOption(ChannelOption.SO_KEEPALIVE, true)
-        .childOption(ChannelOption.CONNECT_TIMEOUT_MILLIS, CONNECT_TIMEOUT_MILLIS)
-        .childOption(ChannelOption.ALLOCATOR, PooledByteBufAllocator.DEFAULT);
+    ServerBootstrap serverBootstrap =
+        new ServerBootstrap()
+            .group(selectorGroup, workerGroup)
+            .channel(NioServerSocketChannel.class)
+            .childHandler(createChannelInitializer())
+            .option(ChannelOption.SO_REUSEADDR, true)
+            .option(ChannelOption.SO_RCVBUF, getBufferSize())
+            .childOption(ChannelOption.SO_KEEPALIVE, true)
+            .childOption(ChannelOption.CONNECT_TIMEOUT_MILLIS, CONNECT_TIMEOUT_MILLIS)
+            .childOption(ChannelOption.ALLOCATOR, PooledByteBufAllocator.DEFAULT);
 
     return createBoundChannel(serverBootstrap, port);
   }