commit 7dbcae083af718d02d9284c5a4a221badc34e226
author Mario Kevo <48509719+mkevo@users.noreply.github.com> Tue Apr 07 07:35:45 2020 +0200
committer GitHub <noreply@github.com> Tue Apr 07 07:35:45 2020 +0200
tree 3acc8ddf4fed11d1cea42ecd4f01751647fca8cd
parent 11a9bc20f30f4ecaf8c3a3e9e2aa2add003eaf03
parent 42fb6fb96c4d2bc951524b0eb6d3e09a70529e0a

Merge pull request #588 from Nordix/feature/GEODE-7930

GEODE-7930: Fix endpoint name truncation bug

cppcache/src/ThinClientPoolDM.cpp

diff --git a/cppcache/src/ThinClientPoolDM.cpp b/cppcache/src/ThinClientPoolDM.cpp
index 3503ea0..12bedbf 100644
--- a/cppcache/src/ThinClientPoolDM.cpp
+++ b/cppcache/src/ThinClientPoolDM.cpp
@@ -1966,11 +1966,8 @@
 }
 
 TcrEndpoint* ThinClientPoolDM::addEP(ServerLocation& serverLoc) {
-  std::string serverName = serverLoc.getServerName();
-  int port = serverLoc.getPort();
-  char endpointName[100];
-  std::snprintf(endpointName, 100, "%s:%d", serverName.c_str(), port);
-
+  const auto endpointName =
+      serverLoc.getServerName() + ":" + std::to_string(serverLoc.getPort());
   return addEP(endpointName);
 }
 
@@ -1982,7 +1979,7 @@
     LOGFINE("Created new endpoint %s for pool %s", endpointName.c_str(),
             m_poolName.c_str());
     ep = createEP(endpointName.c_str());
-    if (m_endpoints.emplace(endpointName, ep).second) {
+    if (!m_endpoints.emplace(endpointName, ep).second) {
       LOGERROR("Failed to add endpoint %s to pool %s", endpointName.c_str(),
                m_poolName.c_str());
     }