commit fffb64331a9aa78f07f53505467e08a86c6d1020
author Naburun Nag <nag@cs.wisc.edu> Tue Mar 03 14:05:09 2020 -0800
committer Naburun Nag <nag@cs.wisc.edu> Tue Mar 03 14:05:09 2020 -0800
tree 83726e1808d0d428becbeaaa89b01888e03621fe
parent f709b208ff2d005e8360eeb5adf521cf22c61446

Adding recommenders

src/main/java/org/apache/geode/kafka/sink/GeodeSinkConnectorConfig.java

diff --git a/src/main/java/org/apache/geode/kafka/sink/GeodeSinkConnectorConfig.java b/src/main/java/org/apache/geode/kafka/sink/GeodeSinkConnectorConfig.java
index 968004f..2ace395 100644
--- a/src/main/java/org/apache/geode/kafka/sink/GeodeSinkConnectorConfig.java
+++ b/src/main/java/org/apache/geode/kafka/sink/GeodeSinkConnectorConfig.java
@@ -30,6 +30,7 @@
 import org.apache.kafka.common.config.ConfigDef;
 
 import org.apache.geode.kafka.GeodeConnectorConfig;
+import org.apache.geode.kafka.utils.EnumRecommender;
 import org.apache.geode.kafka.utils.EnumValidator;
 import org.apache.geode.kafka.utils.GeodeSinkConfigurationConstants;
 
@@ -68,7 +69,8 @@
         SINK_GROUP,
         2,
         ConfigDef.Width.MEDIUM,
-        NULL_VALUES_BEHAVIOR_DISPLAY_NAME);
+        NULL_VALUES_BEHAVIOR_DISPLAY_NAME,
+        EnumRecommender.in(GeodeSinkConfigurationConstants.NullValueBehavior.values()));
     return configDef;
   }
 

src/main/java/org/apache/geode/kafka/utils/EnumRecommender.java

diff --git a/src/main/java/org/apache/geode/kafka/utils/EnumRecommender.java b/src/main/java/org/apache/geode/kafka/utils/EnumRecommender.java
new file mode 100644
index 0000000..857531a
--- /dev/null
+++ b/src/main/java/org/apache/geode/kafka/utils/EnumRecommender.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.kafka.utils;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.kafka.common.config.ConfigDef;
+
+public class EnumRecommender implements ConfigDef.Recommender {
+  private final List<String> valuesList;
+
+  public EnumRecommender(List<String> valuesList) {
+    this.valuesList = valuesList;
+  }
+
+  public static <T> EnumRecommender in(T[] enumerators) {
+    final List<String> valuesList = new ArrayList<>(enumerators.length);
+    for (T value : enumerators) {
+      valuesList.add(value.toString());
+    }
+    return new EnumRecommender(valuesList);
+  }
+
+  @Override
+  public List<Object> validValues(String s, Map<String, Object> map) {
+    return new ArrayList<>(valuesList);
+  }
+
+  @Override
+  public String toString() {
+    return valuesList.toString();
+  }
+
+  @Override
+  public boolean visible(String s, Map<String, Object> map) {
+    return true;
+  }
+}