commit 936a556979a4943b9a98eb6f00a2dc79d03624c0
author kamaci <furkankamaci@gmail.com> Fri Dec 22 19:53:16 2017 +0300
committer kamaci <furkankamaci@gmail.com> Fri Dec 22 23:24:06 2017 +0300
tree 9aef2caa8ee15bebacc5724e82bf930cef78bcb6
parent be1c1330708bd900c30428b6a5c0e133ba944a2a

Closed file system which is not eventually closed.

modules/command/src/main/java/org/apache/fluo/command/FluoGetJars.java

diff --git a/modules/command/src/main/java/org/apache/fluo/command/FluoGetJars.java b/modules/command/src/main/java/org/apache/fluo/command/FluoGetJars.java
index d4f8c7b..2ac32fe 100644
--- a/modules/command/src/main/java/org/apache/fluo/command/FluoGetJars.java
+++ b/modules/command/src/main/java/org/apache/fluo/command/FluoGetJars.java
@@ -65,12 +65,14 @@
 
     try {
       if (config.getObserverJarsUrl().startsWith("hdfs://")) {
-        FileSystem fs = FileSystem.get(new URI(config.getDfsRoot()), new Configuration());
-        File downloadPathFile = new File(opts.getDownloadPath());
-        if (downloadPathFile.exists()) {
-          FileUtils.deleteDirectory(downloadPathFile);
+        try (FileSystem fs = FileSystem.get(new URI(config.getDfsRoot()), new Configuration())) {
+          File downloadPathFile = new File(opts.getDownloadPath());
+          if (downloadPathFile.exists()) {
+            FileUtils.deleteDirectory(downloadPathFile);
+          }
+          fs.copyToLocalFile(new Path(config.getObserverJarsUrl()),
+              new Path(opts.getDownloadPath()));
         }
-        fs.copyToLocalFile(new Path(config.getObserverJarsUrl()), new Path(opts.getDownloadPath()));
       } else {
         log.error("Unsupported url prefix for {}={}", FluoConfiguration.OBSERVER_JARS_URL_PROP,
             config.getObserverJarsUrl());