commit e18d2731a637b6f6d7f984221e95f02fb68b4e20
author David Moravek <dmvk@apache.org> Mon Sep 06 11:39:24 2021 +0200
committer Robert Metzger <89049+rmetzger@users.noreply.github.com> Fri Sep 17 16:34:31 2021 +0200
tree 45ec5feffbce55cf27e869578b16704c54969a4e
parent 0bbc91a2a960cac7e9849eba7ff3e6d8085812be

[FLINK-24129][connectors-pulsar] Harden TopicRangeTest.rangeCreationHaveALimitedScope.

flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicRangeTest.java

diff --git a/flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicRangeTest.java b/flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicRangeTest.java
index 93b3621..f5665e7 100644
--- a/flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicRangeTest.java
+++ b/flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicRangeTest.java
@@ -20,11 +20,8 @@
 
 import org.apache.flink.util.InstantiationUtil;
 
-import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
 
-import java.util.Random;
-
 import static org.apache.flink.connector.pulsar.source.enumerator.topic.TopicRange.MAX_RANGE;
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -33,26 +30,30 @@
 /** Unit tests for {@link TopicRange}. */
 class TopicRangeTest {
 
-    private final Random random = new Random(System.currentTimeMillis());
-
-    @RepeatedTest(10)
-    @SuppressWarnings("java:S5778")
-    void rangeCreationHaveALimitedScope() {
-        assertThrows(
-                IllegalArgumentException.class,
-                () -> new TopicRange(-1, random.nextInt(MAX_RANGE)));
-        assertThrows(
-                IllegalArgumentException.class,
-                () -> new TopicRange(1, MAX_RANGE + random.nextInt(10000)));
-
-        assertDoesNotThrow(() -> new TopicRange(1, random.nextInt(MAX_RANGE)));
+    @Test
+    void topicRangeIsSerializable() throws Exception {
+        final TopicRange range = new TopicRange(1, 5);
+        final TopicRange cloneRange = InstantiationUtil.clone(range);
+        assertEquals(range, cloneRange);
     }
 
     @Test
-    void topicRangeIsSerializable() throws Exception {
-        TopicRange range = new TopicRange(10, random.nextInt(MAX_RANGE));
-        TopicRange cloneRange = InstantiationUtil.clone(range);
+    void negativeStart() {
+        assertThrows(IllegalArgumentException.class, () -> new TopicRange(-1, 1));
+    }
 
-        assertEquals(range, cloneRange);
+    @Test
+    void endBelowTheMaximum() {
+        assertDoesNotThrow(() -> new TopicRange(1, MAX_RANGE - 1));
+    }
+
+    @Test
+    void endOnTheMaximum() {
+        assertDoesNotThrow(() -> new TopicRange(1, MAX_RANGE));
+    }
+
+    @Test
+    void endAboveTheMaximum() {
+        assertThrows(IllegalArgumentException.class, () -> new TopicRange(1, MAX_RANGE + 1));
     }
 }