commit b216ed96be63fc2527b6437a6351260520859758
author Piotr Nowojski <piotr.nowojski@gmail.com> Fri Oct 08 10:48:31 2021 +0200
committer Piotr Nowojski <pnowojski@users.noreply.github.com> Mon Oct 11 19:49:27 2021 +0200
tree 87e0ec63f5fd977efa43ef19a6da108d1780f5ae
parent e052d925fb31faf2db08cdb33bc6bf4e105bfc1f

[hotfix] Add todos for state benchmarks

src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java

diff --git a/src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java b/src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java
index b53ad87..31199dc 100644
--- a/src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java
+++ b/src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java
@@ -45,9 +45,7 @@
 import static org.apache.flink.state.benchmark.StateBenchmarkConstants.setupKeyCount;
 import static org.apache.flink.state.benchmark.StateBenchmarkConstants.setupKeys;
 
-/**
- * Base implementation of the state benchmarks.
- */
+/** Base implementation of the state benchmarks. */
 public class StateBenchmarkBase extends BenchmarkBase {
     KeyedStateBackend<Long> keyedStateBackend;
 
@@ -61,6 +59,7 @@
         cleanUp(keyedStateBackend);
     }
 
+    // TODO: why AtomicInteger?
     static AtomicInteger keyIndex;
 
     private static int getCurrentIndex() {
@@ -81,7 +80,11 @@
             mapKey = mapKeys.get(currentIndex % mapKeyCount);
             mapValue = mapValues.get(currentIndex % mapKeyCount);
             value = randomValues.get(currentIndex % randomValueCount);
-            listValue = Collections.singletonList(randomValues.get(currentIndex % randomValueCount));
+            // TODO: singletonList is taking 25% of time in mapAdd benchmark... This shouldn't be
+            // initiated if benchmark is not using it and for the benchmarks that are using it,
+            // this should also be probably somehow avoided.
+            listValue =
+                    Collections.singletonList(randomValues.get(currentIndex % randomValueCount));
         }
 
         @TearDown(Level.Invocation)

src/main/java/org/apache/flink/state/benchmark/StateBenchmarkConstants.java

diff --git a/src/main/java/org/apache/flink/state/benchmark/StateBenchmarkConstants.java b/src/main/java/org/apache/flink/state/benchmark/StateBenchmarkConstants.java
index 6068e01..890ec7d 100644
--- a/src/main/java/org/apache/flink/state/benchmark/StateBenchmarkConstants.java
+++ b/src/main/java/org/apache/flink/state/benchmark/StateBenchmarkConstants.java
@@ -27,6 +27,7 @@
  * possible affect of using {@link Random#nextLong()}
  */
 class StateBenchmarkConstants {
+    // TODO: why all of those static fields? Those should be inside a context class
     static final int mapKeyCount = 10;
     static final int listValueCount = 100;
     static final int setupKeyCount = 500_000;