Google Git
Sign in
apache/flex-sdk/OK_commit_donation^!/.
commit
b68e18285862309dd5f2419d13a2e23e415a2c69
[log]
author
mamsellem <maurice.amsellem@systar.com>
Wed Oct 02 02:56:01 2013 +0200
committer
mamsellem <maurice.amsellem@systar.com>
Wed Oct 02 02:56:01 2013 +0200
tree
4198d07524ded8c76ff274d53584b6988d759632
parent
448266071533e134113d21c6e5296543753c150b [diff]
https://issues.apache.org/jira/browse/FLEX-33777 Dagrid for mobile
- refactoring:  more user friendly class names

diff --git a/frameworks/projects/experimental_mobile/manifest.xml b/frameworks/projects/experimental_mobile/manifest.xml
index 9cb9823..e4762f6 100644
--- a/frameworks/projects/experimental_mobile/manifest.xml
+++ b/frameworks/projects/experimental_mobile/manifest.xml

@@ -23,6 +23,6 @@
 <componentPackage>
     <component class="spark.components.MobileGrid"/>
     <component class="spark.components.supportClasses.MobileGridColumn"/>
-    <component class="spark.components.itemRenderers.ItemBitmapPartRenderer"/>
-    <component class="spark.components.itemRenderers.ItemTextPartRenderer"/>
+    <component class="spark.components.itemRenderers.MobileGridBitmapCellRenderer"/>
+    <component class="spark.components.itemRenderers.MobileGridTextCellRenderer"/>
 </componentPackage>

diff --git a/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IItemPartRendererBase.as b/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IMobileGridCellRenderer.as
similarity index 96%
rename from frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IItemPartRendererBase.as
rename to frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IMobileGridCellRenderer.as
index 37ca652..eb5ddc7 100644
--- a/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IItemPartRendererBase.as
+++ b/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IMobileGridCellRenderer.as

@@ -31,7 +31,7 @@
  *  @playerversion AIR 3.8
  *  @productversion Flex 4.11
  */
-public interface IItemPartRendererBase extends IDataRenderer
+public interface IMobileGridCellRenderer extends IDataRenderer
 {
     /** @private
      *  Object to be used for providing styles to the part renderer.

diff --git a/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IItemTextPartRenderer.as b/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IMobileGridTextCellRenderer.as
similarity index 95%
rename from frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IItemTextPartRenderer.as
rename to frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IMobileGridTextCellRenderer.as
index 90ca694..d26c312 100644
--- a/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IItemTextPartRenderer.as
+++ b/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/IMobileGridTextCellRenderer.as

@@ -25,7 +25,7 @@
  *  @productversion Flex 4.11
  */
 
-public interface IItemTextPartRenderer extends IItemPartRendererBase
+public interface IMobileGridTextCellRenderer extends IMobileGridCellRenderer
 {
     /* implement this property so that the renderer can receive the dataField from the renderer's MobileGridColumn*/
     function set labelField(value:String):void;

diff --git a/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/ItemBitmapPartRenderer.as b/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/MobileGridBitmapCellRenderer.as
similarity index 96%
rename from frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/ItemBitmapPartRenderer.as
rename to frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/MobileGridBitmapCellRenderer.as
index 29db838..1eed532 100644
--- a/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/ItemBitmapPartRenderer.as
+++ b/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/MobileGridBitmapCellRenderer.as

@@ -35,14 +35,14 @@
  *  @productversion Flex 4.11
  *
  *  */
-public class ItemBitmapPartRenderer extends BitmapImage implements IItemPartRendererBase
+public class MobileGridBitmapCellRenderer extends BitmapImage implements IMobileGridCellRenderer
 {
 
     private var _iconFunction:Function = null;
     private var _iconField:String = null;
     protected var _data:Object;
 
-    public function ItemBitmapPartRenderer()
+    public function MobileGridBitmapCellRenderer()
     {
         super();
         _fillMode = BitmapFillMode.REPEAT; // do not stretch

diff --git a/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/ItemTextPartRenderer.as b/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/MobileGridTextCellRenderer.as
similarity index 95%
rename from frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/ItemTextPartRenderer.as
rename to frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/MobileGridTextCellRenderer.as
index 2ad7118..139d9a3 100644
--- a/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/ItemTextPartRenderer.as
+++ b/frameworks/projects/experimental_mobile/src/spark/components/itemRenderers/MobileGridTextCellRenderer.as

@@ -37,14 +37,14 @@
  *  @productversion Flex 4.11
  *
  *  */
-public class ItemTextPartRenderer extends StyleableTextField implements IItemTextPartRenderer
+public class MobileGridTextCellRenderer extends StyleableTextField implements IMobileGridTextCellRenderer
 {
 
     private var _labelFunction:Function;
     private var _labelField:String;
     private var _data:Object;
 
-    public function ItemTextPartRenderer()
+    public function MobileGridTextCellRenderer()
     {
         super();
         editable = false;

diff --git a/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/ListMultiPartColumnLayout.as b/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/ListMultiPartColumnLayout.as
index 8cd7e27..1da5268 100644
--- a/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/ListMultiPartColumnLayout.as
+++ b/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/ListMultiPartColumnLayout.as

@@ -22,7 +22,7 @@
 import mx.core.ILayoutElement;
 import mx.core.mx_internal;
 
-import spark.components.itemRenderers.IItemPartRendererBase;
+import spark.components.itemRenderers.IMobileGridCellRenderer;
 import spark.core.IGraphicElement;
 import spark.utils.UIComponentUtils;
 
@@ -56,7 +56,7 @@
         return target.graphicElementPartRenderers;
     }
 
-    protected function get partRenderers():Vector.<IItemPartRendererBase>
+    protected function get partRenderers():Vector.<IMobileGridCellRenderer>
     {
         return target.partRenderers;
     }
@@ -82,7 +82,7 @@
         var cellHeight:Number = unscaledHeight - paddingTop - paddingBottom;
 
         var desc:MobileGridColumn;
-        var dpr:IItemPartRendererBase;
+        var dpr:IMobileGridCellRenderer;
         var curX:Number = cellPaddingLeft;
         var curY:Number = paddingTop;
         var colWidth:Number;

diff --git a/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/MobileGridColumn.as b/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/MobileGridColumn.as
index b7508f1..95d2d85 100644
--- a/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/MobileGridColumn.as
+++ b/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/MobileGridColumn.as

@@ -28,9 +28,9 @@
 import mx.utils.ObjectUtil;
 
 import spark.collections.SortField;
-import spark.components.itemRenderers.IItemPartRendererBase;
-import spark.components.itemRenderers.IItemTextPartRenderer;
-import spark.components.itemRenderers.ItemTextPartRenderer;
+import spark.components.itemRenderers.IMobileGridCellRenderer;
+import spark.components.itemRenderers.IMobileGridTextCellRenderer;
+import spark.components.itemRenderers.MobileGridTextCellRenderer;
 
 /**
  *  The MobileGridColumn class defines  a column to display in a MobileGrid control.
@@ -150,19 +150,19 @@
     private var _itemRenderer:IFactory;
 
     /**
-     *  The class factory for the IItemPartRendererBase  class used to
+     *  The class factory for the IMobileGridCellRenderer  class used to
      *  render individual grid cells.
      *
      *  <p>The default item renderer is the ItemTextPartRenderer class,
      *  which displays the data item as text, optimized for mobile.  </p>
      *  <p>You can use also ItemBitmapPartRenderer to display embedded bitmaps, in which case you need to define the iconField or iconFunction </p>
-     *  <p>You can also  create custom item renderers by deriving any subclass of UIComponent (eg. s:Button) and implementing IItemPartRendererBase.
+     *  <p>You can also  create custom item renderers by deriving any subclass of UIComponent (eg. s:Button) and implementing IMobileGridCellRenderer.
      *  for performance reasons  it's preferable that your renderer be written in ActionScript
      *
      *  @see #dataField
-     *  @see spark.components.itemRenderers.ItemTextPartRenderer
-     *  @see spark.components.itemRenderers.ItemBitmapPartRenderer
-     *  @see spark.components.itemRenderers.IItemPartRendererBase
+     *  @see spark.components.itemRenderers.MobileGridTextCellRenderer
+     *  @see spark.components.itemRenderers.MobileGridBitmapCellRenderer
+     *  @see spark.components.itemRenderers.IMobileGridCellRenderer
      *
      */
     public function get itemRenderer():IFactory
@@ -172,7 +172,7 @@
 
     public function set itemRenderer(value:IFactory):void
     {
-        _itemRenderer = value ? value : new ClassFactory(ItemTextPartRenderer);
+        _itemRenderer = value ? value : new ClassFactory(MobileGridTextCellRenderer);
     }
 
     private var _labelFunction:Function;
@@ -325,15 +325,15 @@
         return sortField;
     }
 
-    public function createPartRenderer():IItemPartRendererBase
+    public function createPartRenderer():IMobileGridCellRenderer
     {
-        var pr:IItemPartRendererBase = _itemRenderer.newInstance() as IItemPartRendererBase;
+        var pr:IMobileGridCellRenderer = _itemRenderer.newInstance() as IMobileGridCellRenderer;
         if (pr)
         {
             pr.cssStyleName = _styleName;
-            if (pr is IItemTextPartRenderer)
+            if (pr is IMobileGridTextCellRenderer)
             {
-                with (IItemTextPartRenderer(pr))
+                with (IMobileGridTextCellRenderer(pr))
                 {
                     labelField = _dataField;
                     labelFunction = _labelFunction;

diff --git a/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/MobileGridRowRenderer.as b/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/MobileGridRowRenderer.as
index c3a1446..832997d 100644
--- a/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/MobileGridRowRenderer.as
+++ b/frameworks/projects/experimental_mobile/src/spark/components/supportClasses/MobileGridRowRenderer.as

@@ -20,7 +20,7 @@
 {
 import flash.display.DisplayObject;
 
-import spark.components.itemRenderers.IItemPartRendererBase;
+import spark.components.itemRenderers.IMobileGridCellRenderer;
 import spark.core.DisplayObjectSharingMode;
 import spark.core.IGraphicElement;
 import spark.core.IGraphicElementContainer;
@@ -42,7 +42,7 @@
 public class MobileGridRowRenderer extends ItemRendererBase implements IGraphicElementContainer, ISharedDisplayObject
 {
     private var _columns:Vector.<MobileGridColumn>;
-    private var _partRenderers:Vector.<IItemPartRendererBase>;
+    private var _partRenderers:Vector.<IMobileGridCellRenderer>;
     private var _graphicElementPartRenderers:Vector.<IGraphicElement>;
     private var _partRenderersLayout:ListMultiPartColumnLayout;
 
@@ -63,7 +63,7 @@
     public function set columns(value:Vector.<MobileGridColumn>):void
     {
         _columns = value;
-        _partRenderers = new Vector.<IItemPartRendererBase>(_columns.length, true);
+        _partRenderers = new Vector.<IMobileGridCellRenderer>(_columns.length, true);
         _graphicElementPartRenderers = new Vector.<IGraphicElement>();
     }
 
@@ -72,7 +72,7 @@
         return _columns;
     }
 
-    public function get partRenderers():Vector.<IItemPartRendererBase>
+    public function get partRenderers():Vector.<IMobileGridCellRenderer>
     {
         return _partRenderers;
     }
@@ -86,7 +86,7 @@
     {
         super.createChildren();
         var desc:MobileGridColumn;
-        var pr:IItemPartRendererBase;
+        var pr:IMobileGridCellRenderer;
         var ge:IGraphicElement;
         for (var i:int = 0; i < _columns.length; i++)
         {
@@ -115,7 +115,7 @@
             else
             {
                 //TODO move to resource bundle
-                throw  new Error("MobileGridColumn item renderer must implement spark.components.itemRenderers.IItemPartRendererBase");
+                throw  new Error("MobileGridColumn item renderer must implement spark.components.itemRenderers.IMobileGridCellRenderer");
             }
         }
     }
@@ -136,7 +136,7 @@
 
     override protected function onDataChanged():void
     {
-        var dpr:IItemPartRendererBase;
+        var dpr:IMobileGridCellRenderer;
         for (var i:int = 0; i < _partRenderers.length; i++)
         {
             dpr = _partRenderers[i];