| commit | 13d587a95175b837c9ee4e4029257a6569d669b8 | [log] [tgz] |
|---|---|---|
| author | José Alberto Hernández <44206706+josehernandezfintecheandomx@users.noreply.github.com> | Wed Aug 10 12:28:16 2022 -0500 |
| committer | GitHub <noreply@github.com> | Wed Aug 10 12:28:16 2022 -0500 |
| tree | adc0cec3e2c8f8df7ed64b3a556880b5823631fa | |
| parent | eea635e90a470590292ebae952cf31e3df3a36e0 [diff] |
Allow disbursementDataArray empty instead of null (#2499) Co-authored-by: Jose Alberto Hernandez <alberto@MacBook-Pro.local>
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java index 9a01bf4..8909db4 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
@@ -1609,7 +1609,7 @@ final JsonArray disbursementDataArray = command.arrayOfParameterNamed(LoanApiConstants.disbursementDataParameterName); if (loanProduct.isDisallowExpectedDisbursements()) { - if (disbursementDataArray != null) { + if (!disbursementDataArray.isEmpty()) { final String errorMessage = "For this loan product, disbursement details are not allowed"; throw new MultiDisbursementDataNotAllowedException(LoanApiConstants.disbursementDataParameterName, errorMessage); }
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java index 029ca66..c92ff7b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
@@ -2883,7 +2883,7 @@ final JsonArray disbursementDataArray = command.arrayOfParameterNamed(LoanApiConstants.disbursementDataParameterName); if (isDisallowExpectedDisbursements) { - if (disbursementDataArray != null) { + if (!disbursementDataArray.isEmpty()) { final String errorMessage = "For this loan product, disbursement details are not allowed"; throw new MultiDisbursementDataNotAllowedException(LoanApiConstants.disbursementDataParameterName, errorMessage); }