commit ed8bca862329d0d4b446645bc2aafa0d5bcfddf9
author myrlen <myrle.krantz@kuelap.io> Mon Sep 04 18:36:01 2017 +0200
committer GitHub <noreply@github.com> Mon Sep 04 18:36:01 2017 +0200
tree 2604545c8e0250cc2224dd14bd52036cebf7e595
parent 80aeeb9dd018c048ef04bcc4cc17cc77ca13d895
parent 89c9c1f3eb72e8bce746fccbdcbbc0452c7640de

Merge pull request #8 from myrlen/develop

Don't submit empty journal entries.

service/src/main/java/io/mifos/portfolio/service/internal/util/AccountingAdapter.java

diff --git a/service/src/main/java/io/mifos/portfolio/service/internal/util/AccountingAdapter.java b/service/src/main/java/io/mifos/portfolio/service/internal/util/AccountingAdapter.java
index 4396b00..c95b51e 100644
--- a/service/src/main/java/io/mifos/portfolio/service/internal/util/AccountingAdapter.java
+++ b/service/src/main/java/io/mifos/portfolio/service/internal/util/AccountingAdapter.java
@@ -77,6 +77,14 @@
             .map(Optional::get)
             .collect(Collectors.toSet());
 
+    if (creditors.isEmpty() && !debtors.isEmpty() ||
+        debtors.isEmpty() && !creditors.isEmpty())
+      throw ServiceException.internalError("either only creditors or only debtors were provided.");
+
+    //noinspection ConstantConditions
+    if (creditors.isEmpty() && debtors.isEmpty())
+      return;
+
     final JournalEntry journalEntry = new JournalEntry();
     journalEntry.setCreditors(creditors);
     journalEntry.setDebtors(debtors);