Install the framework in CI so the TCK tests the local build The framework step ran clean verify, which does not install. The TCK is a separate Maven invocation, so it resolves org.apache.felix.framework from the repository rather than from the build that just ran, and org.apache.felix.framework 7.1.0-SNAPSHOT exists in apache.snapshots. Resolution therefore succeeded against the published snapshot and the TCK never exercised the code under test. That matters for this pull request in particular: the FilterImpl defects it fixes are exactly what the TCK reports, so a green TCK run proved nothing while the framework was being resolved from elsewhere. Running clean install makes the TCK test the framework this build produced. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
diff --git a/.github/workflows/maven-ci.yml b/.github/workflows/maven-ci.yml index c959968..9218fb9 100644 --- a/.github/workflows/maven-ci.yml +++ b/.github/workflows/maven-ci.yml
@@ -86,7 +86,11 @@ run: mvn -B -V -Dstyle.color=always --file webconsole/pom.xml clean install verify - name: Felix Framework if: steps.changes.outputs.framework == 'true' - run: mvn -B -V -Dstyle.color=always --file framework/pom.xml clean verify + # install, not verify: the TCK below is a separate Maven invocation and resolves + # the framework from the repository, so without installing it silently tests + # whatever org.apache.felix.framework is published rather than the build under + # test. + run: mvn -B -V -Dstyle.color=always --file framework/pom.xml clean install - name: OSGi-TCK Framework if: steps.changes.outputs.framework == 'true' run: mvn -B -V -Dstyle.color=always --file framework.tck/pom.xml clean verify