commit 0cadd0e916e838b007aa3c4e3e5c2bf1396a2153
author Rainer Döbele <doebele@apache.org> Tue Feb 22 10:42:37 2022 +0100
committer Rainer Döbele <doebele@apache.org> Tue Feb 22 10:42:37 2022 +0100
tree 9cec9663345b1d1c6ec07def811d6f76a032b9c7
parent 1fae785f4d18b18c45e06a25b448f50df0119d8a

MPIREDB-362 Bugfix: DBUtils checkStatementParamCount removed

empire-db/src/main/java/org/apache/empire/db/DBUtils.java

diff --git a/empire-db/src/main/java/org/apache/empire/db/DBUtils.java b/empire-db/src/main/java/org/apache/empire/db/DBUtils.java
index 849b101..fa89877 100644
--- a/empire-db/src/main/java/org/apache/empire/db/DBUtils.java
+++ b/empire-db/src/main/java/org/apache/empire/db/DBUtils.java
@@ -3,7 +3,6 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.SQLIntegrityConstraintViolationException;
-import java.text.MessageFormat;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
@@ -36,7 +35,6 @@
 import org.apache.empire.exceptions.InternalException;
 import org.apache.empire.exceptions.InvalidArgumentException;
 import org.apache.empire.exceptions.UnexpectedReturnValueException;
-import org.apache.empire.exceptions.UnspecifiedErrorException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -76,27 +74,6 @@
     {
         return context;
     }
-    
-    /**
-     * Param count checker
-     */
-    protected void checkStatementParamCount(String sqlCmd, Object[] sqlParams)
-    {
-        if (sqlCmd==null || sqlCmd.length()==0)
-            throw new InvalidArgumentException("sqlCmd", sqlCmd);
-        // count params
-        int paramCount = 0;
-        int pos = -1;
-        while ((pos=sqlCmd.indexOf('?', ++pos))>0)
-            paramCount++;
-        // check now
-        if (paramCount!=(sqlParams!=null ? sqlParams.length : 0))
-        {   // Wrong number of params
-            String msg = MessageFormat.format("Invalid number of parameters query: provided={0}, required={1}; query="+sqlCmd, paramCount, sqlParams.length);
-            log.error(msg);
-            throw new UnspecifiedErrorException(msg);
-        }
-    }
 
     /**
      * Executes an update, insert or delete SQL-Statement.<BR>
@@ -110,9 +87,7 @@
     public int executeSQL(String sqlCmd, Object[] sqlParams, DBMSHandler.DBSetGenKeys setGenKeys)
     {
         try 
-        {   // check
-            checkStatementParamCount(sqlCmd, sqlParams);
-            // Debug
+        {   // Debug
             if (log.isInfoEnabled())
                 log.info("Executing: " + sqlCmd);
             // execute SQL
@@ -152,9 +127,7 @@
     public ResultSet executeQuery(String sqlCmd, Object[] sqlParams, boolean scrollable)
     {
         try
-        {   // check
-            checkStatementParamCount(sqlCmd, sqlParams);
-            // Debug
+        {   // Debug
             if (log.isDebugEnabled())
                 log.debug("Executing: " + sqlCmd);
             // Execute the Statement