refactor parseInt => Number
diff --git a/packages/dubbo/src/dubbo-url.ts b/packages/dubbo/src/dubbo-url.ts
index 137b83e..044fdc5 100644
--- a/packages/dubbo/src/dubbo-url.ts
+++ b/packages/dubbo/src/dubbo-url.ts
@@ -53,7 +53,7 @@
}
get port() {
- return parseInt(this._url.port);
+ return Number(this._url.port);
}
get path() {
diff --git a/packages/dubbo/src/socket-worker.ts b/packages/dubbo/src/socket-worker.ts
index 7180fbb..38e27b9 100644
--- a/packages/dubbo/src/socket-worker.ts
+++ b/packages/dubbo/src/socket-worker.ts
@@ -78,14 +78,18 @@
static from(url: string) {
const [host, port] = url.split(':');
- return new SocketWorker(host, parseInt(port));
+ return new SocketWorker(host, Number(port));
}
private _initSocket() {
log(`SocketWorker#${this.pid} =connecting=> ${this.host}:${this.port}`);
this._socket = new net.Socket();
this._socket
- .connect(this.port, this.host, this._onConnected)
+ .connect(
+ this.port,
+ this.host,
+ this._onConnected,
+ )
.on('data', this._onData)
.on('error', this._onError)
.on('close', this._onClose);
diff --git a/perf/parseint-number.js b/perf/parseint-number.js
new file mode 100644
index 0000000..9aea932
--- /dev/null
+++ b/perf/parseint-number.js
@@ -0,0 +1,16 @@
+/**
+ * ❯ node parseint-number.js
+ * parseInt: 187.971ms
+ * number: 95.057ms
+ */
+console.time('parseInt');
+for (let i = 0; i < 1000000; i++) {
+ parseInt(i + '');
+}
+console.timeEnd('parseInt');
+
+console.time('number');
+for (let i = 0; i < 1000000; i++) {
+ Number(i + '');
+}
+console.timeEnd('number');
