DRILL-8495: HTTP Caching Not Saving Pages (#2912)
Co-authored-by: Charles Givre <charlesgivre@Charless-Mac-Studio.local>
diff --git a/contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java b/contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
index d0a78e3..3171e1c 100644
--- a/contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
+++ b/contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
@@ -1013,7 +1013,7 @@
/**
*
- * @param url
+ * @param url The input URL
* @return an input stream which the caller is responsible for closing.
*/
public static InputStream getRequestAndStreamResponse(String url) {
@@ -1029,9 +1029,9 @@
/**
*
- * @param url
+ * @param url The input URL
* @return response body which the caller is responsible for closing.
- * @throws IOException
+ * @throws IOException If anything goes wrong, throws an IOException
*/
public static ResponseBody makeSimpleGetRequest(String url) throws IOException {
Request.Builder requestBuilder = new Request.Builder()
@@ -1047,14 +1047,9 @@
@Override
public void close() {
- Cache cache;
try {
- cache = client.cache();
- if (cache != null) {
- cache.close();
- }
client.connectionPool().evictAll();
- } catch (IOException e) {
+ } catch (Exception e) {
logger.warn("Error closing cache. {}", e.getMessage());
}
}