ISSUE164: Move findbug settings files to distributedlog-build-tools
Descriptions of the changes in this PR:
Move findbug settings files to distributedlog-build-tools,
and a little change to bk-shade: add bk-common dependency and unshade netty.
Author: Arvin <arvindevel@gmail.com>
Reviewers: Sijie Guo <sijie@apache.org>
This closes #216 from ArvinDevel/issue164
diff --git a/distributedlog-build-tools/src/main/resources/distributedlog/findbugsExclude.xml b/distributedlog-build-tools/src/main/resources/distributedlog/findbugsExclude.xml
index 025fe64..7b2b80b 100644
--- a/distributedlog-build-tools/src/main/resources/distributedlog/findbugsExclude.xml
+++ b/distributedlog-build-tools/src/main/resources/distributedlog/findbugsExclude.xml
@@ -20,4 +20,162 @@
<!-- generated code, we can't be held responsible for findbugs in it //-->
<Class name="~org\.apache\.distributedlog\.tests\.generated.*" />
</Match>
+ <Match>
+ <!-- generated code, we can't be held responsible for findbugs in it //-->
+ <Class name="~org\.apache\.distributedlog\.thrift.*" />
+ </Match>
+ <!-- distributedlog-benchmark -->
+ <Match>
+ <!-- generated code, we can't be held responsible for findbugs in it //-->
+ <Class name="~org\.apache\.distributedlog\.benchmark\.thrift.*" />
+ </Match>
+ <!-- distributedlog-common -->
+ <Match>
+ <Class name="org.apache.distributedlog.common.concurrent.FutureUtils"/>
+ <Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.common.concurrent.FutureUtils$2"/>
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.common.concurrent.FutureUtils"/>
+ <Method name="Void" />
+ <Bug pattern="NM_METHOD_NAMING_CONVENTION" />
+ </Match>
+ <!-- distributedlog-core -->
+ <Match>
+ <!-- it is safe to store external bytes reference here. //-->
+ <Class name="org.apache.distributedlog.Entry$Builder" />
+ <Method name="setData" />
+ <Bug pattern="EI_EXPOSE_REP2" />
+ </Match>
+ <Match>
+ <!-- it is safe to store external bytes reference here. //-->
+ <Class name="org.apache.distributedlog.Entry" />
+ <Method name="getRawData" />
+ <Bug pattern="EI_EXPOSE_REP" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.BKAsyncLogReader" />
+ <Method name="run" />
+ <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.BKLogReadHandler$1" />
+ <Method name="onSuccess" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.BookKeeperClient$2" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.ReadUtils" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.ReadUtils$2" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.auditor.DLAuditor$2" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.auditor.DLAuditor$8" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.bk.SimpleLedgerAllocator$4" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.bk.SimpleLedgerAllocator$4$1" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.bk.SimpleLedgerAllocator$5" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.impl.acl.ZKAccessControl$4" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.impl.acl.ZKAccessControlManager$1" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.impl.acl.ZKAccessControlManager$1$1" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.impl.metadata.ZKLogStreamMetadataStore$1$1" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.lock.ZKSessionLock" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.lock.ZKSessionLock$12" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.lock.ZKSessionLock$13$1" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.util.Utils" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <Match>
+ <Class name="org.apache.distributedlog.util.Utils$6" />
+ <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
+ </Match>
+ <!-- distributedlog-protocol -->
+ <Match>
+ <!-- it is safe to store external bytes reference here. //-->
+ <Class name="org.apache.distributedlog.LogRecord" />
+ <Bug pattern="EI_EXPOSE_REP2" />
+ </Match>
+ <Match>
+ <!-- it is safe to store external bytes reference here. //-->
+ <Class name="org.apache.distributedlog.LogRecord" />
+ <Method name="getPayload" />
+ <Bug pattern="EI_EXPOSE_REP" />
+ </Match>
+ <!-- distributedlog-proxy-server -->
+ <Match>
+ <!-- generated code, we can't be held responsible for findbugs in it //-->
+ <Class name="~org\.apache\.distributedlog\.service\.placement\.thrift.*" />
+ </Match>
+ <Match>
+ <!-- it is safe to cast exception here. //-->
+ <Class name="org.apache.distributedlog.service.DistributedLogServiceImpl$Stream$2" />
+ <Method name="onFailure" />
+ <Bug pattern="BC_UNCONFIRMED_CAST" />
+ </Match>
+ <Match>
+ <!-- it is safe to cast exception here. //-->
+ <Class name="org.apache.distributedlog.service.stream.BulkWriteOp" />
+ <Method name="isDefiniteFailure" />
+ <Bug pattern="BC_IMPOSSIBLE_INSTANCEOF" />
+ </Match>
+ <!-- distributedlog-messaging -->
+ <Match>
+ <!-- generated code, we can't be held responsible for findbugs in it //-->
+ <Class name="~.*\.TransformedRecord" />
+ </Match>
+ <Match>
+ <!-- it is safe to store external bytes reference here. //-->
+ <Class name="org.apache.distributedlog.messaging.PartitionedMultiWriter" />
+ <Bug pattern="EI_EXPOSE_REP2" />
+ </Match>
+ <Match>
+ <!-- it is safe to store external bytes reference here. //-->
+ <Class name="org.apache.distributedlog.messaging.RRMultiWriter" />
+ <Bug pattern="EI_EXPOSE_REP2" />
+ </Match>
</FindBugsFilter>
diff --git a/distributedlog-common/pom.xml b/distributedlog-common/pom.xml
index a5ea020..19d3109 100644
--- a/distributedlog-common/pom.xml
+++ b/distributedlog-common/pom.xml
@@ -107,9 +107,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
- </configuration>
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
diff --git a/distributedlog-common/src/main/resources/findbugsExclude.xml b/distributedlog-common/src/main/resources/findbugsExclude.xml
deleted file mode 100644
index ce2c176..0000000
--- a/distributedlog-common/src/main/resources/findbugsExclude.xml
+++ /dev/null
@@ -1,32 +0,0 @@
-<!--
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
-//-->
-<FindBugsFilter>
- <Match>
- <Class name="org.apache.distributedlog.common.concurrent.FutureUtils"/>
- <Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.common.concurrent.FutureUtils$2"/>
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.common.concurrent.FutureUtils"/>
- <Method name="Void" />
- <Bug pattern="NM_METHOD_NAMING_CONVENTION" />
- </Match>
-</FindBugsFilter>
diff --git a/distributedlog-core-twitter/pom.xml b/distributedlog-core-twitter/pom.xml
index 5043e05..ddfd19d 100644
--- a/distributedlog-core-twitter/pom.xml
+++ b/distributedlog-core-twitter/pom.xml
@@ -105,9 +105,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
- </configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
diff --git a/distributedlog-core-twitter/src/main/resources/findbugsExclude.xml b/distributedlog-core-twitter/src/main/resources/findbugsExclude.xml
deleted file mode 100644
index 1afb903..0000000
--- a/distributedlog-core-twitter/src/main/resources/findbugsExclude.xml
+++ /dev/null
@@ -1,19 +0,0 @@
-<!--
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
-//-->
-<FindBugsFilter>
-</FindBugsFilter>
diff --git a/distributedlog-core/pom.xml b/distributedlog-core/pom.xml
index 90a3bb2..f010959 100644
--- a/distributedlog-core/pom.xml
+++ b/distributedlog-core/pom.xml
@@ -163,9 +163,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
- </configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
@@ -225,6 +222,7 @@
<include>net.jpountz.lz4:lz4</include>
<include>org.apache.bookkeeper.stats:bookkeeper-stats-api</include>
<include>org.apache.bookkeeper:bookkeeper-server</include>
+ <include>org.apache.bookkeeper:bookkeeper-common</include>
<include>org.apache.commons:commons-lang3</include>
<include>org.apache.distributedlog:distributedlog-common</include>
<include>org.apache.distributedlog:distributedlog-protocol</include>
@@ -297,10 +295,10 @@
<shadedPattern>dlshade.com.google</shadedPattern>
</relocation>
<!-- netty -->
- <relocation>
- <pattern>io.netty</pattern>
- <shadedPattern>dlshade.io.netty</shadedPattern>
- </relocation>
+ <!--<relocation>-->
+ <!--<pattern>io.netty</pattern>-->
+ <!--<shadedPattern>dlshade.io.netty</shadedPattern>-->
+ <!--</relocation>-->
<relocation>
<pattern>org.jboss.netty</pattern>
<shadedPattern>dlshade.org.jboss.netty</shadedPattern>
diff --git a/distributedlog-core/src/main/resources/findbugsExclude.xml b/distributedlog-core/src/main/resources/findbugsExclude.xml
deleted file mode 100644
index 40920db..0000000
--- a/distributedlog-core/src/main/resources/findbugsExclude.xml
+++ /dev/null
@@ -1,113 +0,0 @@
-<!--
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
-//-->
-<FindBugsFilter>
- <Match>
- <!-- generated code, we can't be held responsible for findbugs in it //-->
- <Class name="~org\.apache\.distributedlog\.thrift.*" />
- </Match>
- <Match>
- <!-- it is safe to store external bytes reference here. //-->
- <Class name="org.apache.distributedlog.Entry$Builder" />
- <Method name="setData" />
- <Bug pattern="EI_EXPOSE_REP2" />
- </Match>
- <Match>
- <!-- it is safe to store external bytes reference here. //-->
- <Class name="org.apache.distributedlog.Entry" />
- <Method name="getRawData" />
- <Bug pattern="EI_EXPOSE_REP" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.BKAsyncLogReader" />
- <Method name="run" />
- <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.BKLogReadHandler$1" />
- <Method name="onSuccess" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.BookKeeperClient$2" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.ReadUtils" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.ReadUtils$2" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.auditor.DLAuditor$2" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.auditor.DLAuditor$8" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.bk.SimpleLedgerAllocator$4" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.bk.SimpleLedgerAllocator$4$1" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.bk.SimpleLedgerAllocator$5" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.impl.acl.ZKAccessControl$4" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.impl.acl.ZKAccessControlManager$1" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.impl.acl.ZKAccessControlManager$1$1" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.impl.metadata.ZKLogStreamMetadataStore$1$1" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.lock.ZKSessionLock" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.lock.ZKSessionLock$12" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.lock.ZKSessionLock$13$1" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.util.Utils" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
- <Match>
- <Class name="org.apache.distributedlog.util.Utils$6" />
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- </Match>
-</FindBugsFilter>
diff --git a/distributedlog-protocol/pom.xml b/distributedlog-protocol/pom.xml
index 83dab62..bb355c6 100644
--- a/distributedlog-protocol/pom.xml
+++ b/distributedlog-protocol/pom.xml
@@ -77,9 +77,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
- </configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
diff --git a/distributedlog-protocol/src/main/resources/findbugsExclude.xml b/distributedlog-protocol/src/main/resources/findbugsExclude.xml
deleted file mode 100644
index 959e009..0000000
--- a/distributedlog-protocol/src/main/resources/findbugsExclude.xml
+++ /dev/null
@@ -1,30 +0,0 @@
-<!--
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
-//-->
-<FindBugsFilter>
- <Match>
- <!-- it is safe to store external bytes reference here. //-->
- <Class name="org.apache.distributedlog.LogRecord" />
- <Bug pattern="EI_EXPOSE_REP2" />
- </Match>
- <Match>
- <!-- it is safe to store external bytes reference here. //-->
- <Class name="org.apache.distributedlog.LogRecord" />
- <Method name="getPayload" />
- <Bug pattern="EI_EXPOSE_REP" />
- </Match>
-</FindBugsFilter>
diff --git a/distributedlog-proxy-client/pom.xml b/distributedlog-proxy-client/pom.xml
index 96aad98..244fc34 100644
--- a/distributedlog-proxy-client/pom.xml
+++ b/distributedlog-proxy-client/pom.xml
@@ -97,9 +97,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
- </configuration>
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
diff --git a/distributedlog-proxy-client/src/main/resources/findbugsExclude.xml b/distributedlog-proxy-client/src/main/resources/findbugsExclude.xml
deleted file mode 100644
index 05ee085..0000000
--- a/distributedlog-proxy-client/src/main/resources/findbugsExclude.xml
+++ /dev/null
@@ -1,23 +0,0 @@
-<!--
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
-//-->
-<FindBugsFilter>
- <Match>
- <!-- generated code, we can't be held responsible for findbugs in it //-->
- <Class name="~org\.apache\.distributedlog\.thrift.*" />
- </Match>
-</FindBugsFilter>
diff --git a/distributedlog-proxy-protocol/pom.xml b/distributedlog-proxy-protocol/pom.xml
index f2bbe0b..92ae0fd 100644
--- a/distributedlog-proxy-protocol/pom.xml
+++ b/distributedlog-proxy-protocol/pom.xml
@@ -88,9 +88,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
- </configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
diff --git a/distributedlog-proxy-protocol/src/main/resources/findbugsExclude.xml b/distributedlog-proxy-protocol/src/main/resources/findbugsExclude.xml
deleted file mode 100644
index 05ee085..0000000
--- a/distributedlog-proxy-protocol/src/main/resources/findbugsExclude.xml
+++ /dev/null
@@ -1,23 +0,0 @@
-<!--
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
-//-->
-<FindBugsFilter>
- <Match>
- <!-- generated code, we can't be held responsible for findbugs in it //-->
- <Class name="~org\.apache\.distributedlog\.thrift.*" />
- </Match>
-</FindBugsFilter>
diff --git a/distributedlog-proxy-server/pom.xml b/distributedlog-proxy-server/pom.xml
index 6637e88..35a199b 100644
--- a/distributedlog-proxy-server/pom.xml
+++ b/distributedlog-proxy-server/pom.xml
@@ -203,9 +203,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
- </configuration>
</plugin>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
diff --git a/distributedlog-tutorials/distributedlog-messaging/pom.xml b/distributedlog-tutorials/distributedlog-messaging/pom.xml
index 14ac7b6..0d39cc0 100644
--- a/distributedlog-tutorials/distributedlog-messaging/pom.xml
+++ b/distributedlog-tutorials/distributedlog-messaging/pom.xml
@@ -100,9 +100,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>
- </configuration>
</plugin>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
diff --git a/distributedlog-tutorials/distributedlog-messaging/src/main/resources/findbugsExclude.xml b/distributedlog-tutorials/distributedlog-messaging/src/main/resources/findbugsExclude.xml
deleted file mode 100644
index 4b86949..0000000
--- a/distributedlog-tutorials/distributedlog-messaging/src/main/resources/findbugsExclude.xml
+++ /dev/null
@@ -1,33 +0,0 @@
-<!--
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
-//-->
-<FindBugsFilter>
- <Match>
- <!-- generated code, we can't be held responsible for findbugs in it //-->
- <Class name="~.*\.TransformedRecord" />
- </Match>
- <Match>
- <!-- it is safe to store external bytes reference here. //-->
- <Class name="org.apache.distributedlog.messaging.PartitionedMultiWriter" />
- <Bug pattern="EI_EXPOSE_REP2" />
- </Match>
- <Match>
- <!-- it is safe to store external bytes reference here. //-->
- <Class name="org.apache.distributedlog.messaging.RRMultiWriter" />
- <Bug pattern="EI_EXPOSE_REP2" />
- </Match>
-</FindBugsFilter>
