commit 6cac8f96bc1bb509d6d8c2944a7a82efd31c97ef
author Lee Rhodes <leerho@users.noreply.github.com> Thu Mar 02 11:19:49 2023 -0800
committer Lee Rhodes <leerho@users.noreply.github.com> Thu Mar 02 11:19:49 2023 -0800
tree ef093d6f1ccb8514db1c67eba666f098a58eb94b
parent 171b83d6735424bff49de2f433c5eadc723bd1c1

Restored logging in AllocateDirect and AllocateDirectWritableMap.

datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirect.java

diff --git a/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirect.java b/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirect.java
index 2edf359..b2b1992 100644
--- a/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirect.java
+++ b/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirect.java
@@ -21,13 +21,18 @@
 
 import static org.apache.datasketches.memory.internal.UnsafeUtil.unsafe;
 
+import java.util.logging.Logger;
+
 /**
  * Provides access to direct (native) memory.
  *
+ * @author Roman Leventov
  * @author Lee Rhodes
  */
 @SuppressWarnings("restriction")
 final class AllocateDirect {
+  static final Logger LOG = Logger.getLogger(AllocateDirect.class.getCanonicalName());
+
   private final Deallocator deallocator;
   private final long nativeBaseOffset;
   private final MemoryCleaner cleaner;
@@ -107,7 +112,7 @@
       if (valid.change()) {
         if (calledFromCleaner) {
           // Warn about non-deterministic resource cleanup.
-          //LOG.warning("A direct resource was not closed explicitly");
+          LOG.warning("A direct resource was not closed explicitly");
         }
         unsafe.freeMemory(nativeAddress);
         return true;

datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirectWritableMap.java

diff --git a/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirectWritableMap.java b/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirectWritableMap.java
index 0dd39a9..41fb014 100644
--- a/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirectWritableMap.java
+++ b/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/AllocateDirectWritableMap.java
@@ -29,6 +29,7 @@
 import java.lang.reflect.Method;
 import java.nio.MappedByteBuffer;
 import java.nio.channels.FileChannel;
+import java.util.logging.Logger;
 
 import sun.nio.ch.FileChannelImpl;
 
@@ -44,11 +45,13 @@
  * <a href="http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/f940e7a48b72/src/solaris/native/java/nio/MappedByteBuffer.c">
  * MappedByteBuffer.c</a></p>
  *
+ * @author Roman Leventov
  * @author Lee Rhodes
  * @author Praveenkumar Venkatesan
  */
 @SuppressWarnings("restriction")
 class AllocateDirectWritableMap {
+  static final Logger LOG = Logger.getLogger(AllocateDirectWritableMap.class.getCanonicalName());
 
   private static final int MAP_RO = 0;
   private static final int MAP_RW = 1;
@@ -282,7 +285,7 @@
       if (valid.change()) {
         if (calledFromCleaner) {
           // Warn about non-deterministic resource cleanup.
-          //LOG.warning("A WritableMapHandleImpl was not closed manually");
+          LOG.warning("A direct mapped resource was not closed explicitly");
         }
         unmap();
         return true;