Changed POM and added log4j2.xml config to eliminate compiler warnings.
Removed unused "resource" warning in EstimateSketchUDFTest.
Added SuppressWarnings("deprecation") to two methods. Turns out that the
actual problem is within Hive itself.
diff --git a/pom.xml b/pom.xml
index 83b7584..19f91fa 100644
--- a/pom.xml
+++ b/pom.xml
@@ -172,12 +172,33 @@
<artifactId>hive-exec</artifactId>
<version>${hive-exec.version}</version>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-slf4j-impl</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
<version>${hadoop-common.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </exclusion>
+ </exclusions>
<scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <version>1.7.27</version>
</dependency>
<!-- END: UNIQUE FOR THIS JAVA COMPONENT -->
diff --git a/src/main/java/org/apache/datasketches/hive/frequencies/GetFrequentItemsFromStringsSketchUDTF.java b/src/main/java/org/apache/datasketches/hive/frequencies/GetFrequentItemsFromStringsSketchUDTF.java
index 1247112..25a4021 100644
--- a/src/main/java/org/apache/datasketches/hive/frequencies/GetFrequentItemsFromStringsSketchUDTF.java
+++ b/src/main/java/org/apache/datasketches/hive/frequencies/GetFrequentItemsFromStringsSketchUDTF.java
@@ -47,9 +47,10 @@
PrimitiveObjectInspector inputObjectInspector;
PrimitiveObjectInspector errorTypeObjectInspector;
+ @SuppressWarnings("deprecation")
@Override
public StructObjectInspector initialize(final ObjectInspector[] inspectors) throws UDFArgumentException {
- if ((inspectors.length != 1) && (inspectors.length != 2)) {
+ if (inspectors.length != 1 && inspectors.length != 2) {
throw new UDFArgumentException("One or two arguments expected");
}
@@ -89,7 +90,7 @@
@Override
public void process(final Object[] data) throws HiveException {
- if ((data == null) || (data[0] == null)) { return; }
+ if (data == null || data[0] == null) { return; }
final BytesWritable serializedSketch =
(BytesWritable) inputObjectInspector.getPrimitiveWritableObject(data[0]);
final ItemsSketch<String> sketch = ItemsSketch.getInstance(
diff --git a/src/main/java/org/apache/datasketches/hive/tuple/ArrayOfDoublesSketchToValuesUDTF.java b/src/main/java/org/apache/datasketches/hive/tuple/ArrayOfDoublesSketchToValuesUDTF.java
index dabd1fc..ee9bda3 100644
--- a/src/main/java/org/apache/datasketches/hive/tuple/ArrayOfDoublesSketchToValuesUDTF.java
+++ b/src/main/java/org/apache/datasketches/hive/tuple/ArrayOfDoublesSketchToValuesUDTF.java
@@ -43,6 +43,7 @@
PrimitiveObjectInspector inputObjectInspector;
+ @SuppressWarnings("deprecation")
@Override
public StructObjectInspector initialize(final ObjectInspector[] inspectors) throws UDFArgumentException {
if (inspectors.length != 1) {
@@ -70,7 +71,7 @@
@Override
public void process(final Object[] data) throws HiveException {
- if ((data == null) || (data[0] == null)) { return; }
+ if (data == null || data[0] == null) { return; }
final BytesWritable serializedSketch =
(BytesWritable) inputObjectInspector.getPrimitiveWritableObject(data[0]);
final ArrayOfDoublesSketch sketch = ArrayOfDoublesSketches.wrapSketch(
diff --git a/src/test/java/org/apache/datasketches/hive/theta/EstimateSketchUDFTest.java b/src/test/java/org/apache/datasketches/hive/theta/EstimateSketchUDFTest.java
index 895e18a..f337a60 100644
--- a/src/test/java/org/apache/datasketches/hive/theta/EstimateSketchUDFTest.java
+++ b/src/test/java/org/apache/datasketches/hive/theta/EstimateSketchUDFTest.java
@@ -27,7 +27,7 @@
import org.apache.hadoop.io.BytesWritable;
import org.testng.annotations.Test;
-@SuppressWarnings({"javadoc","resource"})
+@SuppressWarnings({"javadoc"})
public class EstimateSketchUDFTest {
@Test
diff --git a/src/test/resources/log4j2.xml b/src/test/resources/log4j2.xml
new file mode 100644
index 0000000..e446eec
--- /dev/null
+++ b/src/test/resources/log4j2.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Configuration status="WARN">
+ <Appenders>
+ <Console name="Console" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/>
+ </Console>
+ </Appenders>
+ <Loggers>
+ <Root level="DEBUG">
+ <AppenderRef ref="Console"/>
+ </Root>
+ </Loggers>
+</Configuration>
\ No newline at end of file
