commit 3f1f5790f5425a4bec5e7911dab61ccbf17a41d0
author AlexanderSaydakov <AlexanderSaydakov@users.noreply.github.com> Wed Jul 22 15:53:27 2020 -0700
committer AlexanderSaydakov <AlexanderSaydakov@users.noreply.github.com> Wed Jul 22 15:53:27 2020 -0700
tree 13870ccfae274403f750fed6783cc4253984328a
parent 862da304111cd91fdf206202d25834e499b3e1b9

no need to check for zero, rearranged order

tuple/include/tuple_sketch_impl.hpp

diff --git a/tuple/include/tuple_sketch_impl.hpp b/tuple/include/tuple_sketch_impl.hpp
index 7178e50..f0c5b50 100644
--- a/tuple/include/tuple_sketch_impl.hpp
+++ b/tuple/include/tuple_sketch_impl.hpp
@@ -70,9 +70,7 @@
   if (detail) {
     os << "### Retained entries" << std::endl;
     for (const auto& it: *this) {
-      if (it.first != 0) {
-        os << it.first << ": " << it.second << std::endl;
-      }
+      os << it.first << ": " << it.second << std::endl;
     }
     os << "### End retained entries" << std::endl;
   }
@@ -129,13 +127,6 @@
 
 template<typename S, typename U, typename P, typename A>
 template<typename UU>
-void update_tuple_sketch<S, U, P, A>::update(const std::string& key, UU&& value) {
-  if (key.empty()) return;
-  update(key.c_str(), key.length(), std::forward<UU>(value));
-}
-
-template<typename S, typename U, typename P, typename A>
-template<typename UU>
 void update_tuple_sketch<S, U, P, A>::update(uint64_t key, UU&& value) {
   update(&key, sizeof(key), std::forward<UU>(value));
 }
@@ -178,6 +169,19 @@
 
 template<typename S, typename U, typename P, typename A>
 template<typename UU>
+void update_tuple_sketch<S, U, P, A>::update(int8_t key, UU&& value) {
+  update(static_cast<int64_t>(key), std::forward<UU>(value));
+}
+
+template<typename S, typename U, typename P, typename A>
+template<typename UU>
+void update_tuple_sketch<S, U, P, A>::update(const std::string& key, UU&& value) {
+  if (key.empty()) return;
+  update(key.c_str(), key.length(), std::forward<UU>(value));
+}
+
+template<typename S, typename U, typename P, typename A>
+template<typename UU>
 void update_tuple_sketch<S, U, P, A>::update(double key, UU&& value) {
   update(canonical_double(key), std::forward<UU>(value));
 }
@@ -190,12 +194,6 @@
 
 template<typename S, typename U, typename P, typename A>
 template<typename UU>
-void update_tuple_sketch<S, U, P, A>::update(int8_t key, UU&& value) {
-  update(static_cast<int64_t>(key), std::forward<UU>(value));
-}
-
-template<typename S, typename U, typename P, typename A>
-template<typename UU>
 void update_tuple_sketch<S, U, P, A>::update(const void* key, size_t length, UU&& value) {
   const uint64_t hash = map_.hash_and_screen(key, length);
   if (hash == 0) return;